From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E18243C60 for ; Thu, 7 Mar 2024 02:36:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8930742EF7; Thu, 7 Mar 2024 02:36:10 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id AD15742E64 for ; Thu, 7 Mar 2024 02:36:07 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-412f988b601so3435275e9.0 for ; Wed, 06 Mar 2024 17:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775367; x=1710380167; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2XjfYakFnTo2VdVGbAzqoYPQ7A8JiK4I9/AKEBjWLNs=; b=OAfJi1kJ6WKBfHT4/7pPvNU0knoIGwRISdfuhayCLUaP3MCCaysa3CI6q+bkBIJG7Z CuYr7yvVmzKNwW55BAtSdsOawL1neDmhu088KkE0hFrzhSnBXJi/ukhouLQPRjIPgEAb BpgXbcRbFVHcjFpt4Yo7kqFMIDsZTGF7M2mwFMvmjalyIgCrNSZrAfN20ZpbAaS947le Bbkz2ZmwvKyzDjY9c3hv2DDAUVldMa2W/Jp90qYBZfOCMrWbyCAadF0Zi7FwnnNr9onW K9KZpEVX+ELFeSU1vMdi2WoxnwzMnsKSe1e6AVbyaQ5jfKOrCt7Ej67K1wqxcHLKAmtO gCPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775367; x=1710380167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2XjfYakFnTo2VdVGbAzqoYPQ7A8JiK4I9/AKEBjWLNs=; b=KnacqaYUjktrAgQJGX37cmIzPLh3E14VX4p3l+qeSqgvz38EEzsvDyzC5hiIgUYJQD ZFLrMAl8RbGIZeX2TTRz9QmAo3Jzak2Zxf3iQoXDwUt5H3BLsxM7lZz6n/1rRTR+M69r jI6G0manej7WUG8VaKPuqsPWqgKTsPImz7+wpSsXuCsbRjwthiKbQTd2h5/6Mdq6ki9G l1LfPVTlWw51hC6hpMnRP7xkXWzVW9a9os6wLgNXMAVRBiK2Y16DwTq1tAG5FB48GpDu Y2bYXUhf6wDt/7OZYqCQMwVaQ/nA8ZH04vQDfVwr7JRbYNJoFdYPiQRlTAVuzv3yFZN3 7cpA== X-Forwarded-Encrypted: i=1; AJvYcCXs+uu3K2TczFXGOClx+I9rKZTiZj4q354rPkEFI0ootfNdZy6XbXIAzSghxbG/z3BhFmIwREnpuh1bP9laeTU= X-Gm-Message-State: AOJu0YyjMj/yoB1KaZVgYSvng77IFBcK8SgblbsVmd5i61/MKLXfVGuG E44YKy6UCcJ4i5g6UxeVtDs/TRrKE8bsPn/kghK0mPQNdR5I/qd2W5XnJfPW7mo= X-Google-Smtp-Source: AGHT+IFIRDGCzUkXT9OZAEPIQOLzqX+NlrM099H6/JRJOx8eiuuaLlB3pL6RYmHm5m5jVgvVYGUkYg== X-Received: by 2002:a05:600c:3b02:b0:412:f195:9cae with SMTP id m2-20020a05600c3b0200b00412f1959caemr3073287wms.8.1709775367337; Wed, 06 Mar 2024 17:36:07 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id p42-20020a05600c1daa00b00412e6de503csm891740wms.25.2024.03.06.17.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:36:06 -0800 (PST) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: Jie Hai , dpdk stable Subject: patch 'net/hns3: remove QinQ insert support for VF' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:31:25 +0000 Message-Id: <20240307013159.1735343-68-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/1822aa59aff6c2b7b3ad69cc50a543fe928a0ef4 Thanks. Luca Boccassi --- >From 1822aa59aff6c2b7b3ad69cc50a543fe928a0ef4 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 28 Dec 2023 20:14:28 +0800 Subject: [PATCH] net/hns3: remove QinQ insert support for VF [ upstream commit f6e79b8d3968150736499bc225762b62fbf1b768 ] In the HIP08 platform, the PF driver will notify VF driver to update the PVID state [1], and VF will declare support QinQ insert when PVID is disabled. In the later platform (e.g. HIP09), the hardware has been improved, so the PF driver will NOT notify VF driver to update the PVID state. However, the later platform still have constraint: PVID and QinQ insert cannot be enabled at the same time, otherwise, the hardware discards packets and reports an error interrupt. Plus, as far as we known, VF driver's users don't use the QinQ insert. Therefore, we declare that the VF driver don't support QinQ insert. [1] commit b4e4d7ac9f09 ("net/hns3: support setting VF PVID by PF driver") Signed-off-by: Chengwen Feng Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index 5d9df03733..119c930b1a 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c @@ -84,7 +84,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE | RTE_ETH_TX_OFFLOAD_VLAN_INSERT); - if (!hw->port_base_vlan_cfg.state) + if (!hns->is_vf && !hw->port_base_vlan_cfg.state) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_QINQ_INSERT; if (hns3_dev_get_support(hw, OUTER_UDP_CKSUM)) -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:40.624910859 +0000 +++ 0068-net-hns3-remove-QinQ-insert-support-for-VF.patch 2024-03-07 01:05:34.882941799 +0000 @@ -1 +1 @@ -From f6e79b8d3968150736499bc225762b62fbf1b768 Mon Sep 17 00:00:00 2001 +From 1822aa59aff6c2b7b3ad69cc50a543fe928a0ef4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f6e79b8d3968150736499bc225762b62fbf1b768 ] + @@ -23,2 +24,0 @@ -Cc: stable@dpdk.org - @@ -32 +32 @@ -index 8f224aa00c..28c26b049c 100644 +index 5d9df03733..119c930b1a 100644 @@ -35 +35 @@ -@@ -85,7 +85,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) +@@ -84,7 +84,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)