From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13E1043CE7 for ; Mon, 18 Mar 2024 16:40:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EF0640289; Mon, 18 Mar 2024 16:40:05 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id E626F4027F for ; Mon, 18 Mar 2024 16:40:03 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-414006a0115so33606705e9.3 for ; Mon, 18 Mar 2024 08:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710776403; x=1711381203; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YLD47xCj2o7KCfA9pibCRUsgBjb+X/NR1TQdDdFtDeE=; b=jYf3ArLTD3EuMSMeKuTT8avS/36lrRA6wN+1SwHOMB/sb/J1PFIkJhdBcUO6IYFyp6 ecBAYOmVy8O/abhKZso1U10JaWuSQXjMg+ZHWNDiPpaZUzblw21ru2kyZ8EFQYtsuJoy WjrwguF53GZyy0vw8UAXsOLr9DPbMGGuDFdhGBLLhsmiwVzhwfJTDcOSz8JQv1Gg8T9S RH5S+EWwFCVTLuUGAWYz2w7JZO7/b3zn/ATgj2XBMkVvhAi8LMAgQsOlSRyc/0TiWwQI 5G9Vd7sEfwNyExz7t6JojfQw4RdEhEnA79rSpir8LMRI6TJqO6NUDg5CkMjd+bg16E4+ iruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710776403; x=1711381203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YLD47xCj2o7KCfA9pibCRUsgBjb+X/NR1TQdDdFtDeE=; b=kWZVl7sWaW8orAc29Vdj8oBelzLZG800i8KNcknhVZxt42g/t/geL9t/54Qj5C8cap Offf7VhV3DGTPTiYKuBvLi0Kd2LoVcEct5qpX7dMHy/56yxFmQwVffFFzUL9VbKM+Vly 72cljxsGAUFOIBzkj3gVLwXqZRa6Z5bRm1sJODlewcnxtwP1SVqDuQX67lD2ZWZdN00J FsKqQRHuPeBuMo08tPwnP5s8VL7P3ldjtA3J2HQUnAz7dB7T+02fDoBTkDhW/G2AfqpY nsma85SdKGgyTXR9kPQ6+qROLjrnTjNdGddTqsjRxfQpwHpLCYYL76PLhLFLiAGinl7g meYA== X-Forwarded-Encrypted: i=1; AJvYcCUBueqovomCmDTxxZTvWPa7UOs0xLoQ9cLzVNj0rKryZfBNte4H84YHUay1k5OJ3qNnzkvx/yZxbQJvlrJq0Xk= X-Gm-Message-State: AOJu0YyLzAAueGEeHyCgL2StD4ax3ZhPEGrWtuA8QjtlEC6XOI0/6lQT TjCUjj0avhHWPWwoFgxNOJuw7cRCRPr9dKW4SgT5BhQsJ/L5t3m6Lr93sEYvirI= X-Google-Smtp-Source: AGHT+IFfj7poZYWUZ8n2ZAMPRWBhCtrPYD+95AGjjDrmQUWGNNNPSR4YAaHeofhXkdj1ilOQJlpFHg== X-Received: by 2002:a05:600c:19cd:b0:413:1688:2679 with SMTP id u13-20020a05600c19cd00b0041316882679mr7468344wmq.41.1710776403512; Mon, 18 Mar 2024 08:40:03 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id fs27-20020a05600c3f9b00b00413e63bb140sm18284957wmb.41.2024.03.18.08.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:40:02 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix --stats-period option check' has been queued to stable release 22.11.5 Date: Mon, 18 Mar 2024 15:39:01 +0000 Message-Id: <20240318153919.3407921-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240318153919.3407921-1-luca.boccassi@gmail.com> References: <20240314000957.2810803-61-luca.boccassi@gmail.com> <20240318153919.3407921-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d6cee7ffc08fbb7aaf4df759dba3d1411a9a729a Thanks. Luca Boccassi --- >From d6cee7ffc08fbb7aaf4df759dba3d1411a9a729a Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 14 Mar 2024 10:17:02 +0100 Subject: [PATCH] app/testpmd: fix --stats-period option check [ upstream commit 2ae06c579ea4e1cd234c5b14bef2957ee154ec74 ] Rather than silently ignore an invalid value, raise an error for stats-period user input. Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- app/test-pmd/parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index cddcdef045..92fa786492 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -763,7 +763,7 @@ launch_args_parse(int argc, char** argv) n = strtoul(optarg, &end, 10); if ((optarg[0] == '\0') || (end == NULL) || (*end != '\0')) - break; + rte_exit(EXIT_FAILURE, "Invalid stats-period value\n"); stats_period = n; break; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-18 12:58:39.721013119 +0000 +++ 0011-app-testpmd-fix-stats-period-option-check.patch 2024-03-18 12:58:39.115344777 +0000 @@ -1 +1 @@ -From 2ae06c579ea4e1cd234c5b14bef2957ee154ec74 Mon Sep 17 00:00:00 2001 +From d6cee7ffc08fbb7aaf4df759dba3d1411a9a729a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2ae06c579ea4e1cd234c5b14bef2957ee154ec74 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 11b0cce577..d715750bb8 100644 +index cddcdef045..92fa786492 100644 @@ -22 +23 @@ -@@ -776,7 +776,7 @@ launch_args_parse(int argc, char** argv) +@@ -763,7 +763,7 @@ launch_args_parse(int argc, char** argv)