From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4569043CE7 for ; Mon, 18 Mar 2024 16:40:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D24240689; Mon, 18 Mar 2024 16:40:06 +0100 (CET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id 3290740689 for ; Mon, 18 Mar 2024 16:40:05 +0100 (CET) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-41413f7b2dfso4877575e9.2 for ; Mon, 18 Mar 2024 08:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710776405; x=1711381205; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2rT9YCka/zFimHiuxJYJR6o/Se9VSPC+3mRm+pRy7dU=; b=ZgbciIcMIPNUZIQX4Uul0nrff90/r1Ej4lVAToVzm1EblLbdFOHb2NYBMbZSz/dDqA LckRQBF+9uGRVZ4Y+jCl11eZbSqiBRPXoBVddrYXxiAC/asMh1/KWgifKrf6xOK2vG2v 7lyXtFlaD8bih2bPygfktGMkoCnaHp2gH39C9JxGHb+PPbAPa48njWUgqc07UI4Ffs/G dTF5ApolAyKYUJITW0kGxqmKjZwfG8v5pBZKRp7APr4R2Wc77YSiDwkbeEegxSWuDHjB 2/QFT2CsuDDqg1VV+Jb6ay3XvtGcx6b/KX6ss3iKyQvfkM1ZNgBfff6O+HcdiIhMaFVX UsmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710776405; x=1711381205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2rT9YCka/zFimHiuxJYJR6o/Se9VSPC+3mRm+pRy7dU=; b=a1MJ69x32lgbrH8pBo6mMobLF1y3hs8B5IPG4J8GILahKvH0A3oi41NGwMFcQCX2wD GD7pQu+LrM0A+BJ+e2vAGgiYXmAirxZEeEIK1CcnRR9SUFtLPavvuTW2z+71WXwJmd+x mXnveaDy6fvM0TosyHIBR4+0e2M9gnwvpnYf53kxmKxXuXk53NrOprFthpuCqxZVTnaa YKTKnoC2s4TR20z1WD+blCfDJ3hQluK3tzNpaMk7lxgt5u+QtjB9/XEs20t0qCZEFbk2 lWi5/4nFSbIgViAYdxLXS3E4Y7NjDIZwioVV5eTYvXD2Cfv3wO3FZhn3WgG9HOx7khG2 iyIA== X-Forwarded-Encrypted: i=1; AJvYcCXyOItb3gBOuBtR6LTufdVRPzDapuI9hUZiF8wqeNqlRjXaA4ZXnK/OJ64vlOkgQ0zhcQqWeVd8g5RtRsamO3U= X-Gm-Message-State: AOJu0YwFxSSQ9uDGdNCVkbxKRrpQU0LK1Jl4gJcoKjeFdPySziw+ppKx WMiixSI8dk/Ot9NsKArGsLhBxBavX2uHxyKwRL0mllonZfDdF3gjj/jSHJjRj1w= X-Google-Smtp-Source: AGHT+IEuJc1j1vhKjF3yqVeFC+0EkmYOefoLg2ACO87TyDFtBv4Tlot8tZUD9I2dEhMIcc3bdnLUhg== X-Received: by 2002:a05:600c:a02:b0:414:8d7:8292 with SMTP id z2-20020a05600c0a0200b0041408d78292mr4940770wmp.0.1710776404855; Mon, 18 Mar 2024 08:40:04 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id p10-20020a05600c1d8a00b004145cecb7bcsm1193856wms.45.2024.03.18.08.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:40:04 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix burst option parsing' has been queued to stable release 22.11.5 Date: Mon, 18 Mar 2024 15:39:02 +0000 Message-Id: <20240318153919.3407921-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240318153919.3407921-1-luca.boccassi@gmail.com> References: <20240314000957.2810803-61-luca.boccassi@gmail.com> <20240318153919.3407921-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/2eb0560cb0cc8d49aad3e28491c62d23d92a5f6c Thanks. Luca Boccassi --- >From 2eb0560cb0cc8d49aad3e28491c62d23d92a5f6c Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 14 Mar 2024 10:17:03 +0100 Subject: [PATCH] app/testpmd: fix burst option parsing [ upstream commit 6fa896ae804a7dbd7fb766643f733dbad12bba43 ] rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but for the theoretical case when it would fail, raise an error rather than skip subsequent options. Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- app/test-pmd/parameters.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 92fa786492..be4d0ecec5 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -1115,7 +1115,9 @@ launch_args_parse(int argc, char** argv) 0, &dev_info); if (ret != 0) - return; + rte_exit(EXIT_FAILURE, "Failed to get driver " + "recommended burst size, please provide a " + "value between 1 and %d\n", MAX_PKT_BURST); rec_nb_pkts = dev_info .default_rxportconf.burst_size; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-18 12:58:39.760621662 +0000 +++ 0012-app-testpmd-fix-burst-option-parsing.patch 2024-03-18 12:58:39.115344777 +0000 @@ -1 +1 @@ -From 6fa896ae804a7dbd7fb766643f733dbad12bba43 Mon Sep 17 00:00:00 2001 +From 2eb0560cb0cc8d49aad3e28491c62d23d92a5f6c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6fa896ae804a7dbd7fb766643f733dbad12bba43 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index d715750bb8..3414a0d38c 100644 +index 92fa786492..be4d0ecec5 100644 @@ -23 +24 @@ -@@ -1128,7 +1128,9 @@ launch_args_parse(int argc, char** argv) +@@ -1115,7 +1115,9 @@ launch_args_parse(int argc, char** argv)