From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87ADC43CE7 for ; Mon, 18 Mar 2024 16:39:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E91D402B8; Mon, 18 Mar 2024 16:39:37 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id E6F4D4027F for ; Mon, 18 Mar 2024 16:39:34 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4140eb3aeb9so9399955e9.3 for ; Mon, 18 Mar 2024 08:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710776374; x=1711381174; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IpxssnuUgReawwmVpNf7FEAncc71HTrapZ4Pyb2p0a4=; b=hW/WwOG0IebadC+OEtfNsGbg+ydD1dFG++B5lX1do6pjf/jmLvDOZAarYj/P4vts9z eCq3iSY4dyy0BVQXgWEk/yM4akYJZsmhQWmN9KaUyvbJIgYPb7x0iBVrRR/J1JPF4xti DHO+DY3U+EP+F+7DFKZO8nFu0ZohCrPFlWZ72eADqgJsarQSWC7zHQ9yUbUXakSOfkhG TBp1s0PPFM7v0b2YTEtzgw+wpgmX7fenDwx9VM21VYHmMhcXfKC65R5HLyfhTgvo8nG5 MoB6vG4Alu0Eyoel45NgeUT2g4lZG6GQ6CSDhMK9qW/QXdBBZ+PGCiaa3PrnEQ15BMrJ 6vBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710776374; x=1711381174; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IpxssnuUgReawwmVpNf7FEAncc71HTrapZ4Pyb2p0a4=; b=gZb6uWUArTIWNjHPLBDhJB6lBAC+1IQGDm/Kn2IVvfRetvYzTk7Rd51AMQYv7SJsIT cSFdBgWJv8pHJ3XpfDz83VfFPmI+uCS7v+suQNVZGr8EVM2iMhdITJGLIse6rIY62oUT BdcgK/fQOpcfdBgVQ8CEoYxLoO0s+XCu3V7nl9AC8xrAE5ZXUyju5DTI9dd8WNcy9MTc 7Az3ceD+Yefzqs5a66Lsm50vchVtconOm/oFlhOBFb+472a04dVCfhFCeuTTf99lV7Wk QL5aIujNidQldPHWp8tUSl+KAaExSZLPK9r5TC/vAGyQaWUL1bd+b9NAr4PxzjK0+hOk ok2Q== X-Gm-Message-State: AOJu0YwYQYk4TFaFZbY3MDGGgUY6gg32wSOchFS5vZ8eid68JirF+XlA XMDL2o1MRtwRyj3Wij4BXtzlDVdRU9m+Ksb4OOP6DXDiZFp1Tsx0m1QAxfl6kO4= X-Google-Smtp-Source: AGHT+IFWuo7PcL/2oBmdHO/WewDAgNinZUbED97RP1qcmW6xfYTdPviuC7s6SeefPGUfmzuSFWXQFw== X-Received: by 2002:a5d:6a04:0:b0:33e:79d3:2cb with SMTP id m4-20020a5d6a04000000b0033e79d302cbmr7937162wru.38.1710776374580; Mon, 18 Mar 2024 08:39:34 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id k3-20020adff5c3000000b0033e7eba040dsm10172283wrp.97.2024.03.18.08.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:39:34 -0700 (PDT) From: luca.boccassi@gmail.com To: Jie Hai Cc: dpdk stable Subject: patch 'net/hns3: enable PFC for all user priorities' has been queued to stable release 22.11.5 Date: Mon, 18 Mar 2024 15:38:54 +0000 Message-Id: <20240318153919.3407921-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240318153919.3407921-1-luca.boccassi@gmail.com> References: <20240314000957.2810803-61-luca.boccassi@gmail.com> <20240318153919.3407921-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fc5f4ef40f77639862f54264600bf872175c417b Thanks. Luca Boccassi --- >From fc5f4ef40f77639862f54264600bf872175c417b Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Wed, 6 Mar 2024 17:20:47 +0800 Subject: [PATCH] net/hns3: enable PFC for all user priorities [ upstream commit aae6989df36c105b917cf69975c075dfde2e6b84 ] When user set TC number to 4 and enable PFC and ETS by dev_configure, driver only enable user priority 0-3. The packet with user priority 4-7 cannot trigger PFC frame. Fix by enabling PFC for all user priorities. By the way, the nb_tcs from user can never be 0 because of the ahead check in driver. So remove this redundant code. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_dcb.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3/hns3_dcb.c index 2831d3dc62..915e4eb768 100644 --- a/drivers/net/hns3/hns3_dcb.c +++ b/drivers/net/hns3/hns3_dcb.c @@ -1499,7 +1499,6 @@ hns3_dcb_info_update(struct hns3_adapter *hns, uint8_t num_tc) static int hns3_dcb_hw_configure(struct hns3_adapter *hns) { - struct rte_eth_dcb_rx_conf *dcb_rx_conf; struct hns3_pf *pf = &hns->pf; struct hns3_hw *hw = &hns->hw; enum hns3_fc_status fc_status = hw->current_fc_status; @@ -1519,12 +1518,8 @@ hns3_dcb_hw_configure(struct hns3_adapter *hns) } if (hw->data->dev_conf.dcb_capability_en & RTE_ETH_DCB_PFC_SUPPORT) { - dcb_rx_conf = &hw->data->dev_conf.rx_adv_conf.dcb_rx_conf; - if (dcb_rx_conf->nb_tcs == 0) - hw->dcb_info.pfc_en = 1; /* tc0 only */ - else - hw->dcb_info.pfc_en = - RTE_LEN2MASK((uint8_t)dcb_rx_conf->nb_tcs, uint8_t); + hw->dcb_info.pfc_en = + RTE_LEN2MASK((uint8_t)HNS3_MAX_USER_PRIO, uint8_t); hw->dcb_info.hw_pfc_map = hns3_dcb_undrop_tc_map(hw, hw->dcb_info.pfc_en); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-18 12:58:39.437505569 +0000 +++ 0004-net-hns3-enable-PFC-for-all-user-priorities.patch 2024-03-18 12:58:39.091344117 +0000 @@ -1 +1 @@ -From aae6989df36c105b917cf69975c075dfde2e6b84 Mon Sep 17 00:00:00 2001 +From fc5f4ef40f77639862f54264600bf872175c417b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit aae6989df36c105b917cf69975c075dfde2e6b84 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org