From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99CC043CE7 for ; Mon, 18 Mar 2024 16:39:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91F1140289; Mon, 18 Mar 2024 16:39:53 +0100 (CET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 6F93940698 for ; Mon, 18 Mar 2024 16:39:51 +0100 (CET) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-41409fd8b6eso19058615e9.2 for ; Mon, 18 Mar 2024 08:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710776391; x=1711381191; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G4n9ghKOGobAqpK38tUPNahXVWjF2DnUGKmezSk5zDE=; b=IC+QsQmexpTpagUHlLP7Oo+tnFQ1/CduD7IKLSYsGN7iNvYVu2QRJ1vc5xt9aIhLbD JHNivNVXWRGXVOZpAMQGnx4ukJTW9bCusJaHCEaJ0OLPS1wkSq7Tcuhav82ekTLBSmPJ scsaCt49JJBUQE4eN5k2efLczvQ2DWcI/MWmfDGVICfZtk1wm96ROXUlofUxaHz7j4ee 7fr7cIBoJVtCgtnf+UPg5nVvPLaVmpH+zgBsQI0BgmTtlruNBOW6Js8K9dnX4+U25kn6 LFgZGD6AfzrImxH3p82geEaX1LfuBasZjNrZtz2JhqTMADPZdWfcwNiYShHtll6NyrOl k1nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710776391; x=1711381191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G4n9ghKOGobAqpK38tUPNahXVWjF2DnUGKmezSk5zDE=; b=sV4YonutG4lyyVXWoWCQb4ZJCbBscTG0R7wsyuTvnKs38vGexI7L5ydYLjA7DAjunj JHj4apnCbIePX6K5QewSDx8X83aH9te/f82VZ6fVjGCUbSV6TbLBo2Hf+lrv1QUv/cBL eO6zHmoG2fEnk8Z+qMQJfdIkclaOlV7G3KpmY+z60O3iVjq6cUPVIthIdLrhoHUOlXsD 0yz4AOz7oZM8d+Vsu04q2UWOJOYHcp1cHynrlcenAQJxSL8eWkTwOEgORDS0O+5snztW FGK8FHr50xwDw9u2qFHAz/vRpigo3sKtXvuVyq0Xat/U9WbZPd/KphiVA4O/ZAcwCS6V tn7w== X-Forwarded-Encrypted: i=1; AJvYcCVGgH2vZ0Om2u8Zd1d7cXvKIoGgFXm3OLRIVzg16+zfmCAPxX9mKdKqKDMpRQhVS7fCgF5dohFAYCpY7XcGqac= X-Gm-Message-State: AOJu0YxeAICyWDzKcXt70+YpsbLL0+FN2ktkSiVTDFkrtbp1OSwy/6sS +Mee95zpE3zSII09oyEgXBzTd/V+qk9nDeq75JWjTASL3CATZsdNjmRC7EGIeKc= X-Google-Smtp-Source: AGHT+IFEqMNnVQS95wVGT8Dra6A0SatTbrXbXZFRfxGIdCPcT7cdoW4RtIZxMdvg/EWrZVNAUjIcJw== X-Received: by 2002:a05:600c:3b25:b0:413:286c:4fc0 with SMTP id m37-20020a05600c3b2500b00413286c4fc0mr6150266wms.34.1710776391024; Mon, 18 Mar 2024 08:39:51 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id r11-20020a05600c35cb00b00414038162e1sm10615506wmq.23.2024.03.18.08.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:39:50 -0700 (PDT) From: luca.boccassi@gmail.com To: Shai Brandes Cc: Amit Bernstein , dpdk stable Subject: patch 'net/ena/base: restructure interrupt handling' has been queued to stable release 22.11.5 Date: Mon, 18 Mar 2024 15:38:59 +0000 Message-Id: <20240318153919.3407921-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240318153919.3407921-1-luca.boccassi@gmail.com> References: <20240314000957.2810803-61-luca.boccassi@gmail.com> <20240318153919.3407921-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/c5251ed8a6f8bdd4e31ce19c5dc0a2f5588bcc41 Thanks. Luca Boccassi --- >From c5251ed8a6f8bdd4e31ce19c5dc0a2f5588bcc41 Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 12 Mar 2024 20:07:00 +0200 Subject: [PATCH] net/ena/base: restructure interrupt handling [ upstream commit 553653ccc18c1ed9fb0406e1b0130e945d5ab30f ] When invoking an admin command, in interrupt mode, if the interrupt is received after timeout and also after the calling function finished running, the response will be written into a memory that is no longer valid. Fixes: 99ecfbf845b3 ("ena: import communication layer") Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/base/ena_com.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index 4bd85f29f5..98035f3cd4 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -173,6 +173,7 @@ static int ena_com_admin_init_aenq(struct ena_com_dev *ena_dev, static void comp_ctxt_release(struct ena_com_admin_queue *queue, struct ena_comp_ctx *comp_ctx) { + comp_ctx->user_cqe = NULL; comp_ctx->occupied = false; ATOMIC32_DEC(&queue->outstanding_cmds); } @@ -466,6 +467,9 @@ static void ena_com_handle_single_admin_completion(struct ena_com_admin_queue *a return; } + if (!comp_ctx->occupied) + return; + comp_ctx->status = ENA_CMD_COMPLETED; comp_ctx->comp_status = cqe->acq_common_descriptor.status; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-18 12:58:39.641249262 +0000 +++ 0009-net-ena-base-restructure-interrupt-handling.patch 2024-03-18 12:58:39.111344667 +0000 @@ -1 +1 @@ -From 553653ccc18c1ed9fb0406e1b0130e945d5ab30f Mon Sep 17 00:00:00 2001 +From c5251ed8a6f8bdd4e31ce19c5dc0a2f5588bcc41 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 553653ccc18c1ed9fb0406e1b0130e945d5ab30f ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index fb3ad27d0a..a0c88b1a0e 100644 +index 4bd85f29f5..98035f3cd4 100644 @@ -24 +25 @@ -@@ -181,6 +181,7 @@ static int ena_com_admin_init_aenq(struct ena_com_dev *ena_dev, +@@ -173,6 +173,7 @@ static int ena_com_admin_init_aenq(struct ena_com_dev *ena_dev, @@ -32 +33 @@ -@@ -474,6 +475,9 @@ static void ena_com_handle_single_admin_completion(struct ena_com_admin_queue *a +@@ -466,6 +467,9 @@ static void ena_com_handle_single_admin_completion(struct ena_com_admin_queue *a