From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A3A843DF8 for ; Thu, 4 Apr 2024 11:52:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 004AC4067E; Thu, 4 Apr 2024 11:52:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CCD9B402E9 for ; Thu, 4 Apr 2024 11:52:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712224359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0ONGOqAQa9goQZK2gBtqLzRmONygseN7nOpc0dODTM=; b=hvBb6p4Tvs/FDhTcCWjlXB8v92R1MIorxBb/Mqby60zKLj5fZ/g95hB28j07iJjUiSxglF XFHvNrEmg3J4/Y6LB+WuIah+rl2/uuUj9KsYXuzvbfVaFhguCmlJDeusqiyJDBQhpomijc Kq95woyzoQ1gCNXWE3HyR2Qq01+070o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-igCSJLB_PaWsNhRXg9Nskw-1; Thu, 04 Apr 2024 05:52:36 -0400 X-MC-Unique: igCSJLB_PaWsNhRXg9Nskw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D63F1863070; Thu, 4 Apr 2024 09:52:35 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EF433C85; Thu, 4 Apr 2024 09:52:35 +0000 (UTC) From: Kevin Traynor To: Bing Zhao Cc: Suanming Mou , dpdk stable Subject: patch 'net/mlx5: fix drop action release timing' has been queued to stable release 21.11.7 Date: Thu, 4 Apr 2024 10:51:41 +0100 Message-ID: <20240404095155.155427-11-ktraynor@redhat.com> In-Reply-To: <20240404095155.155427-1-ktraynor@redhat.com> References: <20240404095155.155427-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/61aa88de549503b234bb05ceab42fe3b698b1f69 Thanks. Kevin --- >From 61aa88de549503b234bb05ceab42fe3b698b1f69 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Fri, 8 Mar 2024 05:22:37 +0200 Subject: [PATCH] net/mlx5: fix drop action release timing [ upstream commit 22a3761b782b7c46ca428209b15b4f7382a40a62 ] When creating the drop action Devx object, the global counter set is also used as in the regular or hairpin queue creation. The drop action should be destroyed before the global counter set release procedure. Or else, the counter set object is still referenced and cannot be released successfully. This would cause the counter set resources to be exhausted after starting and stopping the ports repeatedly. Fixes: 65b3cd0dc39b ("net/mlx5: create global drop action") Signed-off-by: Bing Zhao Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 9fc34f05e2..b339ccce84 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1606,10 +1606,10 @@ mlx5_dev_close(struct rte_eth_dev *dev) } mlx5_proc_priv_uninit(dev); + if (priv->drop_queue.hrxq) + mlx5_drop_action_destroy(dev); if (priv->q_counters) { mlx5_devx_cmd_destroy(priv->q_counters); priv->q_counters = NULL; } - if (priv->drop_queue.hrxq) - mlx5_drop_action_destroy(dev); if (priv->mreg_cp_tbl) mlx5_hlist_destroy(priv->mreg_cp_tbl); -- 2.44.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-04 10:49:34.297375830 +0100 +++ 0011-net-mlx5-fix-drop-action-release-timing.patch 2024-04-04 10:49:33.739457709 +0100 @@ -1 +1 @@ -From 22a3761b782b7c46ca428209b15b4f7382a40a62 Mon Sep 17 00:00:00 2001 +From 61aa88de549503b234bb05ceab42fe3b698b1f69 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 22a3761b782b7c46ca428209b15b4f7382a40a62 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 8b54843a43..d1a63822a5 100644 +index 9fc34f05e2..b339ccce84 100644 @@ -28 +29 @@ -@@ -2383,10 +2383,10 @@ mlx5_dev_close(struct rte_eth_dev *dev) +@@ -1606,10 +1606,10 @@ mlx5_dev_close(struct rte_eth_dev *dev)