From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1870243E57 for ; Sat, 13 Apr 2024 14:51:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12ABA40685; Sat, 13 Apr 2024 14:51:20 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2051.outbound.protection.outlook.com [40.107.243.51]) by mails.dpdk.org (Postfix) with ESMTP id 1DC15400D6 for ; Sat, 13 Apr 2024 14:51:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ej/9vKk91KJgcR5OfCetK5F1GEmj5zEq74fPOUm+PIyaWE46la71ER+LKiVDgkGuRXlfXgfEUiOPQakEmMYNrwC6EIooRWfV2l6pgwujx6oiXwoxMeisWUjgE88IbbSfxDp5mP/HmvwgQOLd5bg3pfhjAHYJL3GkqHjKnUFi4MqXKrSKdUzFn+of74PxBGZRuCdw9LnOqwX22PwH36U4+pxp7gUUaGNrJf0BRd/hZL8pmbW0GuT5zfZGc6urLXixJit1n9BViu+gAl8lODYNWVtJD22qJe5yxundiw6EunTRyyBmCPU+rwtZyek3qmw4kZiG4i1BOzYYcpAmoIxB4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZYU1yGRiwtOoeA399zR06K8v1g5hdgQsSDK/SkVVSvU=; b=BX1vwyrPOVLdse/SQqJbaLDDMaa/Azh0N1GxJi2h7c8N4Av8fD46tUlghCUEdE4Ehy++W4aonR65igDx63OaXqE7hVais4ZirNBxOnAMH9bvBNeOd5tOGELaGvq7lRfHsBXQMI+1VQNk4KoNc68rSznYhYzBPXVLVOFLqIbOmc6mFRZWEXbaLCsF0xGIqtk11VIK98d+R9SU0HYkssA+ZljdWfaizsxV7tdL+zlySE6Unq7a1mA5jIJc83RJzJ5CgV5Mzecvowy+KfPoeyjcyHQH27/qc384NN1DMPGnpyBpHKd9MdcX4SECMWEbSUWXQairaP9Ovlcg8Hgot+u86A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYU1yGRiwtOoeA399zR06K8v1g5hdgQsSDK/SkVVSvU=; b=L3H9l+FC05AWiO/npT6lwUghcCzhUCbAtolpVlqKA0cW2L6ndn89R0LuCrsaSajOfjmtV9B25KCic84Y9NIWnKlEPmr/k7a+3AL1qFQevQjcZ3dDoFWNkajR/HtNK40JPhMFxLX3xdcd/XxqsY315ObSW9OpKj7j7Mgf5+4x/dEcp9pcGhBmhECJHag3JI1tJRyh6xdp7bL+XDdrMlLlHhlGzmJooJe18gzN1zrDoWLouAo8mKdH2O030334ADwyyRerSZpzXb9UVDM2dd2El3j3QHsV06vwi7W2sCB/nfFMNmFxaQ+AXo4VeJp7DkFTo+kM4TjnPT3sIx59/l8wWA== Received: from MN2PR19CA0033.namprd19.prod.outlook.com (2603:10b6:208:178::46) by CH3PR12MB8510.namprd12.prod.outlook.com (2603:10b6:610:15b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.43; Sat, 13 Apr 2024 12:51:14 +0000 Received: from BL6PEPF00020E61.namprd04.prod.outlook.com (2603:10b6:208:178:cafe::ec) by MN2PR19CA0033.outlook.office365.com (2603:10b6:208:178::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.30 via Frontend Transport; Sat, 13 Apr 2024 12:51:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF00020E61.mail.protection.outlook.com (10.167.249.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:51:13 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:51:02 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:51:01 -0700 From: Xueming Li To: Suanming Mou CC: Anoob Joseph , dpdk stable Subject: patch 'app/crypto-perf: add missing op resubmission' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:48:10 +0800 Message-ID: <20240413125005.725659-10-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E61:EE_|CH3PR12MB8510:EE_ X-MS-Office365-Filtering-Correlation-Id: 7dae2513-df03-4776-857b-08dc5bb866df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OXKcwgjesClhxgnNIxIjGVQ+VfArhQG6vqB8uHHgAacQbqUukRzIVtAcTMt0AG0kxuJ6oV+sTUe9Qw07k91ig3byMCnSIM+KOCIjmYkwdqer6SEzLQapiYFDIBn7mEm15xaLlpKA70KbabHmSbNU338imyfTD2J28+ssw4xGp/VtXVu2swZsBpY5vEDwGFiJAmcao424qW0xDrv6QMOhwXfybG2HZHLzaMDOy6xGrI4XONvfdPE7aaXcDOi6VtMxOP70ZWVQOZrqbUbdBtZWwWs4vK8M0RTtj/KjstNCLm66lrUyqAeWP3pM0t2K38sJ+u7X4Yu2Ma+A1bN4FH2TjZFqKc9IuLKAalJHA7BZHUXdW53lgTxjQQ4Fn88xBh9wC/EnKSVSsi+Wsdn1PsrTDjqHMscjPsOW56g8hzVAfz0OS2iNgxgwvU9/zuXK4CWZh0Y4jzLFGuIDRn7Qnl9UjQb+Kp4EfYzqeOusydESpe/VICkhnh4ngLvI6foJ+PJZp5bQVT/A/5DwXSzWTFOQI3ldItf2MOG20Tdfo4ZmrTDqDwbqG2cPjHf8KuNS/w5h9Lro5Yw6SQ7tjM4RIshgIOM5eKBJO49aNiAFOU1iIr3STqyGj+Fpvj8/Y/DOoSFrSYThXhLn7wCflt3O3v15lnmnW9jbYOSerFxm40B/0iORxBr7cD35NIprYTpRCBil6zOHyoDboPcCIyWLzhwfHHsIx3F3fD53PycIyTp7X8+KoBV43kNMpixCI4Ko5MLZ X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:51:13.5615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7dae2513-df03-4776-857b-08dc5bb866df X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E61.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8510 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=14c38e2db1ea3f8d09969caec97facbb93600526 Thanks. Xueming Li --- >From 14c38e2db1ea3f8d09969caec97facbb93600526 Mon Sep 17 00:00:00 2001 From: Suanming Mou Date: Mon, 15 Jan 2024 16:08:30 +0800 Subject: [PATCH] app/crypto-perf: add missing op resubmission Cc: Xueming Li [ upstream commit 74d7c028ecf478f18cf9623210bab459d5992d7a ] Currently, after enqueue_burst, there may be ops_unused ops left for next round enqueue. And in next round preparation, only ops_needed ops will be added. But if in the final round the left ops is less than ops_needed, there will be invalid ops between the new needed ops and previous unused ops. The previous unused ops should be moved front after the needed ops. In the commit[1], an resubmission fix was added to throughput test, and the fix was missed for verify. This commit adds the missed resubmission fix for verify. [1] commit 44e2980b70d1 ("app/crypto-perf: fix crypto operation resubmission") Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Suanming Mou Acked-by: Anoob Joseph --- app/test-crypto-perf/cperf_test_verify.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 2b0d3f142b..10172a53a0 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -275,7 +275,6 @@ cperf_verify_test_runner(void *test_ctx) ops_needed, ctx->sess, ctx->options, ctx->test_vector, iv_offset, &imix_idx, NULL); - /* Populate the mbuf with the test vector, for verification */ for (i = 0; i < ops_needed; i++) cperf_mbuf_set(ops[i]->sym->m_src, @@ -293,6 +292,17 @@ cperf_verify_test_runner(void *test_ctx) } #endif /* CPERF_LINEARIZATION_ENABLE */ + /** + * When ops_needed is smaller than ops_enqd, the + * unused ops need to be moved to the front for + * next round use. + */ + if (unlikely(ops_enqd > ops_needed)) { + size_t nb_b_to_mov = ops_unused * sizeof(struct rte_crypto_op *); + + memmove(&ops[ops_needed], &ops[ops_enqd], nb_b_to_mov); + } + /* Enqueue burst of ops on crypto device */ ops_enqd = rte_cryptodev_enqueue_burst(ctx->dev_id, ctx->qp_id, ops, burst_size); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:05.479948002 +0800 +++ 0010-app-crypto-perf-add-missing-op-resubmission.patch 2024-04-13 20:43:04.907754049 +0800 @@ -1 +1 @@ -From 74d7c028ecf478f18cf9623210bab459d5992d7a Mon Sep 17 00:00:00 2001 +From 14c38e2db1ea3f8d09969caec97facbb93600526 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 74d7c028ecf478f18cf9623210bab459d5992d7a ] @@ -23 +25,0 @@ -Cc: stable@dpdk.org