From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE52B43E57 for ; Sat, 13 Apr 2024 15:00:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4C4340EAB; Sat, 13 Apr 2024 15:00:46 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2059.outbound.protection.outlook.com [40.107.93.59]) by mails.dpdk.org (Postfix) with ESMTP id 48D64400D6 for ; Sat, 13 Apr 2024 15:00:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dmiltU4UAUXmNIeh44HS8+fq3LyCplK5bUviRXOZxygpOVTXmTVQMXXOdUTuBpyLinAyzwMhyjuANI9Mi3vHUgZlurxXei87qY0SYdfH8B9t+52CUkASnhsHFmjxn9HMM3gAjksbklaz9TOsbS06CZUL4Eft5EkfX9x2670U+U0JRkpMx+BkYm2YALRMyOfq4rllB21oSsNwPbUp0x/qsfmGbpTVakfagFeDuNbfMEG4Jx0ZSChuDxWzUPBnGQvwVoc1Qt9UhRPE4vtukS8wk9srMqdB7rmrQFN5vfgVtKYwLe9D0c3eAGQH4CGyNfQ0PyxeeHfQdN9uNBTDHOafBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=geHn80UzxARpfh+xKroblZLerPuD/rgEGPXQx9eOfC8=; b=ES8lgLY+qXAwA5t72dxNMbbiVHoa7gGAG7DC+MN3D7wUf5N+roh4jzaQnLE48kmMHEMsTwc88bz9juCzl/+EGNUvETcsWEPWceS/QvcBS/OZiJfumZgXTkiKedLAXHcotFm9rXo/c/YGkTu+m8J+83XKSOZrXQdESGxoKeJgwUefQT/nJKOzLVwPK3nXO3XIMcP5/dwGGOknydWKWKBlxe7A9SKhS9fanA2kk3QvE0EDa7oNTfXw/lBi/RP8iFG5aStmm22XAgIAo9kfBe8puDoVCq8gW+aXi7bwdDuGuFkd2WC+b0I4Fse9yUQE80KISfAoDB588xbpzOnMAX16Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=geHn80UzxARpfh+xKroblZLerPuD/rgEGPXQx9eOfC8=; b=kwiBF4mWIdfqTH9lJE4+5YRu0d2ZibqHOU7X+qknoMMvh1bptwk1alTNR8bpCN7sCSLQz7ttK2fUWl3K2ekVjM73aKTNA9POTB2/MGQkvk4xfd7/pSTYuQTjhxK52NncOdbIVuNppjPbRuEvElmNxEAmbv0PCM+ShFLu+CpWOqzEMNGJ5pa9SBGGtJeeaIj5cDKRlxaxNycP7zXl3wwRzrPOJmy3SqoerHkFVv9E0Hxm2yh0IgWy1iJgjGpv4Nm45hQe1jVpknJzSPfF2In2hViZ1F1DKo+8dtFQSzhWZe2RriTQFfHblPBRtk7USxdA9iJ0q3Lb+q+hujPfetM8Kg== Received: from MW4PR04CA0161.namprd04.prod.outlook.com (2603:10b6:303:85::16) by IA0PR12MB8648.namprd12.prod.outlook.com (2603:10b6:208:486::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.56; Sat, 13 Apr 2024 13:00:42 +0000 Received: from MWH0EPF000989E6.namprd02.prod.outlook.com (2603:10b6:303:85:cafe::51) by MW4PR04CA0161.outlook.office365.com (2603:10b6:303:85::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.27 via Frontend Transport; Sat, 13 Apr 2024 13:00:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MWH0EPF000989E6.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 13:00:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 06:00:21 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 06:00:19 -0700 From: Xueming Li To: Chaoyong He CC: Long Wu , Peng Zhang , "dpdk stable" Subject: patch 'net/nfp: fix uninitialized variable' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:49:52 +0800 Message-ID: <20240413125005.725659-112-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E6:EE_|IA0PR12MB8648:EE_ X-MS-Office365-Filtering-Correlation-Id: cc869b2e-74a3-4c87-4be0-08dc5bb9b96d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4S75mQ6vVbPI3nC673Ptc66mh7Sc8M0RmDxoE9OxNlb94xN/pk7m4JK+Haeslfvt4R/tDi0a2TqErMaq659Zwbv03aYa76FXx2tSUh1peRkXkMbYJ63qB6iDRmkQrIJHIyLqgwpkxo/PG251YhIpwjqrum11F3biN0SctcPVZxo4Hu3B28OFH/l6HEOIi6/5Ugk6yi61Lzr7+Xnx6MCW5pdh/JrU3X2S3iMyUEuXgekO+dPhqQhesgqej59SQdfkdxm9T2YqrPPBVMcf3z59/+2aJjPJthEJxOsiAJinM+oh7SQsQ8XtWDRu9tF64W9wqzRdz10hXoZCgoCFHnyPF33nhneqUwcY2D0jcJUjF14kG8a7fM5Z/OpSBHlQfXtv4TCpZN0NAsNaByattlmRFQuRHOinsBINttOQAsdpZaH3ShGbXCYgLKT2z6oYD0YNDdg3WN+iVXbVR6SpHVPPmfJWQ7aSnWWXmUxQ8e6Iy1GqC+7mwzDewtEULsR+VbxiNmS2Vx0qwiKJOh2V4psPFqVO+6fDBAKFQEIH4UWS1X6s51z3F92m1qM5roO1fAGobjDc1kx2kuEF/E0P5ex+ynOw84D1cDdHKSh4sBE+SWudWU6QEpUS2tTMLlGYwG26lmieduUdpu+/KhRGjT61DOPO3rYVLmli7ASgFTZAUh08t3j5SkV2UpRjyWidF8nPWkkrTVb0LR5tLzArUmqycoN7dnlSR9iAsg+OTiRYdd6oDxAaRoYnsMq58PoCbxxv X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 13:00:41.7011 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc869b2e-74a3-4c87-4be0-08dc5bb9b96d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8648 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=4aa1a6420482dccab127369b01d51d1825fdd71d Thanks. Xueming Li --- >From 4aa1a6420482dccab127369b01d51d1825fdd71d Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 19 Mar 2024 16:55:07 +0800 Subject: [PATCH] net/nfp: fix uninitialized variable Cc: Xueming Li [ upstream commit 77cb47144932a52c34f1825d90a8804c2538817b ] CI found in the logic of 'nfp_aesgcm_iv_update()', the variable 'cfg_iv' may be used uninitialized in some case. Coverity issue: 415808 Fixes: 7e13f2dc603e ("net/nfp: fix IPsec data endianness") Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index aebdbb2f48..b10cda570b 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -523,7 +523,7 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg, char *iv_b; char *iv_str; const rte_be32_t *iv_value; - uint8_t cfg_iv[NFP_ESP_IV_LENGTH]; + uint8_t cfg_iv[NFP_ESP_IV_LENGTH] = {}; iv_str = strdup(iv_string); if (iv_str == NULL) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:08.445391928 +0800 +++ 0112-net-nfp-fix-uninitialized-variable.patch 2024-04-13 20:43:05.137753749 +0800 @@ -1 +1 @@ -From 77cb47144932a52c34f1825d90a8804c2538817b Mon Sep 17 00:00:00 2001 +From 4aa1a6420482dccab127369b01d51d1825fdd71d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 77cb47144932a52c34f1825d90a8804c2538817b ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 205d1d594c..647bc2bb6d 100644 +index aebdbb2f48..b10cda570b 100644 @@ -24 +26 @@ -@@ -526,7 +526,7 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg, +@@ -523,7 +523,7 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg,