From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC9D743E57 for ; Sat, 13 Apr 2024 14:56:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D743640DDD; Sat, 13 Apr 2024 14:56:05 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2087.outbound.protection.outlook.com [40.107.92.87]) by mails.dpdk.org (Postfix) with ESMTP id 72F35400D6 for ; Sat, 13 Apr 2024 14:56:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dALJ5eZUCjDJix6COMwNGIOkWKnixQwjQEjltb4RKR1lvyMmfdOITngD90qfSwxYE8mKjAb4dMIacYB2TT4vuRVmLLmbDDTQmRnXgATZa2LDxQpq6lkvCZSERTigWcDNk4C5nsG+kUWdQWVBnu1DYN8oLLvII8qVtMKoARfyikKWYHm42+MhapUAimM5cvoInI1zRvSdOdW2Czr6O/Aur3AGHFHVLo8piVcA1GBunv9RRYiNWdH2uhAing3oLg5Kptu9v9EMPatv+9SaLyOUZXL7E1h9pFsMo8aw/auSJFQAWrValLwNofPPxO8VSgrCZ2VFayJsKJznJLQGQ4vNig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sjn/FcjlDM/F5gj5NtxleLe4xd5NNfe/gCcEj1YTcls=; b=mYrNt4FfHGJemQ1fwTZH0D/iypnDefODqxQ99HY5FhIm6ocCaWjYKXDVvtuzYONZ+sELklQcHXnBDhfHt8AppzHYeC+bUwFLCSqAKOPEdHvxN5Y/+BN0h11ySp0JrBZx/BNNNHRIj325laAwZ7qGFIYMAaL3h6payHkPisXO9AaKTAaIzzxd69AXVj2kT9/sjxuu6T/XpX2lepIiXYmWLUKB3QDY/3I6FS3B5FMzB0QG6iwmyC2TXi7D8HpthdjPn5BgDUihjFqMhHTl1z5Rn7T/7DFUXy4nb+MSwFdbrakMF7DXsgemjzcq65C6unAnJcTjhqPXqr9e+vO6jmg4IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjn/FcjlDM/F5gj5NtxleLe4xd5NNfe/gCcEj1YTcls=; b=uoexcLGNAXAfnR6HtjuyRQHlPBNfoaCHxZgYjSjypZp2ogsT7Swp9YfplkhUB33z/sTkEEILrRA035UU46ZOYGe78jwUMejmaC9zBE5j9eMSGLntJJ4fWMHd0okmVrZoSL1SeTRRkh9BLTaeEoM5vrAk1KcQdY9+UQH6RM/BJaA5CfXH+iQW7zZ5zzT+UvRrM8j/QSBiNz7mbAoOtKTJ8IIjkjwlABaVbWX+eEYAgYzeKF+GRDydHXxponPfaE8hLKTeC8XEKtGprdY2O3yiWBXfboWxOiL1n8uF3o14clPOdPx3F8y5t6xBV9SCtDcCmpudA9G1B7r8wupQ7e8vbA== Received: from DM6PR10CA0032.namprd10.prod.outlook.com (2603:10b6:5:60::45) by LV3PR12MB9268.namprd12.prod.outlook.com (2603:10b6:408:216::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Sat, 13 Apr 2024 12:56:02 +0000 Received: from DS3PEPF0000C37F.namprd04.prod.outlook.com (2603:10b6:5:60:cafe::a5) by DM6PR10CA0032.outlook.office365.com (2603:10b6:5:60::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.30 via Frontend Transport; Sat, 13 Apr 2024 12:56:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF0000C37F.mail.protection.outlook.com (10.167.23.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:56:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:55:47 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:55:45 -0700 From: Xueming Li To: Bing Zhao CC: Ori Kam , dpdk stable Subject: patch 'net/mlx5: remove device status check in flow creation' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:49:02 +0800 Message-ID: <20240413125005.725659-62-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37F:EE_|LV3PR12MB9268:EE_ X-MS-Office365-Filtering-Correlation-Id: a3175438-4460-4b5d-c34e-08dc5bb91298 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uPyiG9iIXcjaXtPQAsrgGUGuvwTsJZcmN+8DXji2RLIItHy/ssF7MzARuOL1UuQwmLCKMtNKxmDxEu2CSG//0VgA7DAsYJYK7DQ4nYCvTONV0jFPz4x5M65xHCBU8Sn+nps2xtIvWLRCojhl0aNQWqEn1jy2VyePpK8VDzYxoREIQo0zb/ycx+8OqMJ5JhPq/7QnP1b1hFHgKFBanYNJ89AkYVUJj9UFrsuUuxPC7FoA+IoKxW8xbNUqyY++F05jz8+YRQoSZ2Mc68z0Pi37Yti8AZTvJoeiAZMWUAHMO36f0X3O4DNXUTwQq4+Lo8esv7pGyvcLrI8krGpoJ+A3RQw9bwl4MqD+FhoA39I/16Tn57yhDGCGpnNMplc9HK5mjTW4k82vLvtkJuRRvcrSmu1rp9JifZqOwc9UCItltQsZRqRIiAOHmccnxgDtEPZmXNwBqzBRhTHIYUrguDeZReQqIqNEIiWa2FiZQtFWkUmFX2NppfnO+x3/AMqyyjLT43bN8cUcmu6GGZt8uKBmOPqX6qrohjwam9Nt+fOUq9FFgaFDAZ1HkCpgba3PXvgRyPKd22B7GVAEZuU1UcfzTbAOnmFPh7AbhCf9+eEz2+cXDgeTTYJcppH5cfc4E1mxAZ/gNMwF01mkmVIOWZ5FcTKunD/SxyQcbhl0XuoEB2cpb2yfjEc9/YQgb92oDJ3QP6JVk40ydgWpa5z/3X6HHMYdXc634hYjoF1IRSDge8crvOdrRlbirz/ey6k6G7+a X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:56:01.7284 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3175438-4460-4b5d-c34e-08dc5bb91298 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9268 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=272feb8eb990b5ef05604e0359d39dc5650f449c Thanks. Xueming Li --- >From 272feb8eb990b5ef05604e0359d39dc5650f449c Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Thu, 29 Feb 2024 12:51:56 +0100 Subject: [PATCH] net/mlx5: remove device status check in flow creation Cc: Xueming Li [ upstream commit 4095ce34095e33ae9e8b19150b9280ff8737a590 ] The flow rule can be inserted even before the device started. The only exception is for a queue or RSS action. For the other interfaces of template API, the start status is not checked. The checking would cause some cache miss or eviction since the flag locates on some other cache line. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Signed-off-by: Bing Zhao Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 7e4ead1875..6aaf3aee2a 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -3322,10 +3322,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, uint32_t res_idx = 0; int ret; - if (unlikely((!dev->data->dev_started))) { - rte_errno = EINVAL; - goto error; - } job = flow_hw_job_get(priv, queue); if (!job) { rte_errno = ENOMEM; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:06.968868057 +0800 +++ 0062-net-mlx5-remove-device-status-check-in-flow-creation.patch 2024-04-13 20:43:05.017753905 +0800 @@ -1 +1 @@ -From 4095ce34095e33ae9e8b19150b9280ff8737a590 Mon Sep 17 00:00:00 2001 +From 272feb8eb990b5ef05604e0359d39dc5650f449c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 4095ce34095e33ae9e8b19150b9280ff8737a590 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -19,2 +21,2 @@ - drivers/net/mlx5/mlx5_flow_hw.c | 5 ----- - 1 file changed, 5 deletions(-) + drivers/net/mlx5/mlx5_flow_hw.c | 4 ---- + 1 file changed, 4 deletions(-) @@ -23 +25 @@ -index 6f43e88864..8ca866059d 100644 +index 7e4ead1875..6aaf3aee2a 100644 @@ -26 +28 @@ -@@ -3526,11 +3526,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, +@@ -3322,10 +3322,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, @@ -31,3 +33,2 @@ -- rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, -- "Port must be started before enqueueing flow operations"); -- return NULL; +- rte_errno = EINVAL; +- goto error; @@ -35,3 +36,3 @@ - flow = mlx5_ipool_malloc(table->flow, &flow_idx); - if (!flow) - goto error; + job = flow_hw_job_get(priv, queue); + if (!job) { + rte_errno = ENOMEM;