From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BA1243E57 for ; Sat, 13 Apr 2024 14:56:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9685440294; Sat, 13 Apr 2024 14:56:32 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2046.outbound.protection.outlook.com [40.107.237.46]) by mails.dpdk.org (Postfix) with ESMTP id 61F26400D6 for ; Sat, 13 Apr 2024 14:56:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iwk4kvMb/8+u3tIWzXTZzECHljMcao6XaMgyEVMGPxwJHxyEA7OIYI0ZgYzPGnpqRUoFLgrj7//RPtYw84kUQacwCaWjCwPV1mKD0g6/1+aXdYOzJzrYj8IKP8mxd/Yd+g0qgVOPJzUtdELyPUiej7vzcCBDcVo41QbkngzW0y/ZXmX04qEUKEwmppt/hsmjX3XunfbjYuKj4Y+8mA5fDOMJoUeA3rgHgcTyXSg+wtBPM6JGLdjmvPEIqpOd0Gr6aE8YOMDaZFELeWuFVwl556dIbAem4hLZ1p4loVwQGTYvX36/GWlFPxSkBdV0LsLCbcL+d9O4c1VWuSK9hqa3/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hnUFRmSkzuNP14LUyiyz9qU3xzjKKJ2ExhrzE7aADds=; b=Ia8tFIIGYRlp+Pr6i7ryk/vnU7eMBVGfxBjLwOnRMnXRpguH2cEflVo1C2KsK9rOkzuOLMB8b5/wxQSnLQ8LRgE9opSPSCM3nRnA+3O3bsnfQmTvXwV0WkI3/h3EH69hmgQDDnvYRwyQb+AP+QTgg0vAOiK6/IBnlbbTsL4RNtf7hAS2+Yczyl7k0jAKAj4fbNUrt5JvxTMIWD4ZFNHLKllsbn6CSQjTt8bnH958/ld5NmecNZFCLhDaIpWlL0YxEgTxYtnKwwakE9CkkuuMnx3iOqtkPK2zQF1CWz/J70JXUqdUERbXj/Wg84ac3oKZKUuX+fWrMGt8VvKWk6npzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hnUFRmSkzuNP14LUyiyz9qU3xzjKKJ2ExhrzE7aADds=; b=N4NXI+OTDD7Nt7RbIxUbeG9WfVwBPvfJo12NckDWRQKUAr4vSJlwRIts60AdHDWM/t86LvPOxqdq3Q97gwnF43wAEa664ArErC3HMtXii1PnTXFgVFrj6Let+/1wExk8cZv1yxQMsLYZronlDhGB8jhEs/tnJziAAcDh4h/X+CuIdCFUJIIclBa/uIksP5IbkUVk+zzKFlSDLcXR7dwC6lKtcWqkrrtyIPreg2fWSwFnWCJaHs8P/S8ySoXr7eGBjCaOXscpCyc7BHJbLnONesBI1z9iVIgc0f9B6XzQ8et3vnTARA25DH7+a5hFFhYfA9J8djISamVod9+/J2tGsg== Received: from DM6PR11CA0019.namprd11.prod.outlook.com (2603:10b6:5:190::32) by IA0PR12MB8205.namprd12.prod.outlook.com (2603:10b6:208:400::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Sat, 13 Apr 2024 12:56:26 +0000 Received: from DS3PEPF0000C37A.namprd04.prod.outlook.com (2603:10b6:5:190:cafe::91) by DM6PR11CA0019.outlook.office365.com (2603:10b6:5:190::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.30 via Frontend Transport; Sat, 13 Apr 2024 12:56:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF0000C37A.mail.protection.outlook.com (10.167.23.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:56:26 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:56:16 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:56:14 -0700 From: Xueming Li To: Bruce Richardson CC: Akhil Goyal , Ciara Power , Tyler Retzlaff , dpdk stable Subject: patch 'test: do not count skipped tests as executed' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:49:08 +0800 Message-ID: <20240413125005.725659-68-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37A:EE_|IA0PR12MB8205:EE_ X-MS-Office365-Filtering-Correlation-Id: c37e3fe0-825e-4fe2-b2f5-08dc5bb92141 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p4EzyOTgpFDsUvtBJk1RcvUiJuRQC0RZ15HaDkciDekbmU/jI6Tbl49TTskpPlPTXRzKnVj5pDRutPXLzN+49bQtDW+xGfgKQvt1l09lUTMBr0O8QK8Cvp/Nu/TdheBTYPg8LFoxpacH4eM3EAnPiJAXFginb60hezS+R3R35RaErinJCSsg9YcvCZ679N3BgPJHI7rcUdewHsh7LfEmwPgcwn+rcpxX9G9daCxzDxG1k5EoMA1l8mqpaWfPVSE4yaW/VcZRBNzjFKWn8nMRVDsz3HZzRU5Etve9v8x8iJBH7uvHR6d+AC3xOEhdUmcHNu6VD0C0MdKcdYpiGbsThD9QAaO4cT0Nt781Mh9pn6E79Gk3yftF4IRF4e8P09ytq3PQJp0iC2CvG3kzhwzJM+HK/N24uF+nVXQEmUxhFcqLRsh6XnrsRWdVrIB9VcUEiCIi6Oa3FQR3UdKQhCASRK6jiG/7CViOPqsx/Co8ANfkcmY0AH2Q/C2GgGBd+ZhOEdXARKO05T3dhufDErtjHGEnqaYOr2kyS96w59tFNV5Q1QJDMMru4HDYLSm4IT1Q3DYgMM8iBoj1BY4WLWTDlQ9n7m+WUD1eVtxby026Jz38gSAZUc/QqvvvcGG3PUfs8gbjxS55XslNwbCPQZUf+aCgP39vsoWeZR/Ik8JbwZXrbgd2vYyF164It6G6EiPJH+opRom0PhkBzuKOqfROrY9tghM2UaqIGZ6c3dVTJdDxdOHYOzpyJQLn8k7ntV2/ X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(82310400014)(1800799015)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:56:26.2767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c37e3fe0-825e-4fe2-b2f5-08dc5bb92141 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8205 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=e8dccbca30cec3504b043b3e4da6951c0f9f8168 Thanks. Xueming Li --- >From e8dccbca30cec3504b043b3e4da6951c0f9f8168 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 13 Nov 2023 15:05:33 +0000 Subject: [PATCH] test: do not count skipped tests as executed Cc: Xueming Li [ upstream commit a620df6df6d61660661afade09760b2dfba4eb42 ] The logic around skipped tests is a little confusing in the unit test runner. * Any explicitly disabled tests are counted as skipped but not executed. * Any tests that return TEST_SKIPPED are counted as both skipped and executed, using the same statistics counters. This makes the stats very strange and hard to correlate, since the totals don't add up. One would expect that SKIPPED + EXECUTED + UNSUPPORTED == TOTAL, and that PASSED + FAILED == EXECUTED. To achieve this, mark any tests returning TEST_SKIPPED, or ENOTSUP as not having executed. Signed-off-by: Bruce Richardson Acked-by: Akhil Goyal Acked-by: Ciara Power Acked-by: Tyler Retzlaff --- app/test/test.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/test/test.c b/app/test/test.c index bfa9ea52e3..7b882a59de 100644 --- a/app/test/test.c +++ b/app/test/test.c @@ -375,11 +375,13 @@ unit_test_suite_runner(struct unit_test_suite *suite) if (test_success == TEST_SUCCESS) suite->succeeded++; - else if (test_success == TEST_SKIPPED) + else if (test_success == TEST_SKIPPED) { suite->skipped++; - else if (test_success == -ENOTSUP) + suite->executed--; + } else if (test_success == -ENOTSUP) { suite->unsupported++; - else + suite->executed--; + } else suite->failed++; } else if (test_success == -ENOTSUP) { suite->unsupported++; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:07.128290849 +0800 +++ 0068-test-do-not-count-skipped-tests-as-executed.patch 2024-04-13 20:43:05.017753905 +0800 @@ -1 +1 @@ -From a620df6df6d61660661afade09760b2dfba4eb42 Mon Sep 17 00:00:00 2001 +From e8dccbca30cec3504b043b3e4da6951c0f9f8168 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a620df6df6d61660661afade09760b2dfba4eb42 ] @@ -20,2 +22,0 @@ -Cc: stable@dpdk.org - @@ -31 +32 @@ -index 8b25615913..680351f6a3 100644 +index bfa9ea52e3..7b882a59de 100644 @@ -34 +35 @@ -@@ -369,11 +369,13 @@ unit_test_suite_runner(struct unit_test_suite *suite) +@@ -375,11 +375,13 @@ unit_test_suite_runner(struct unit_test_suite *suite)