From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C960B43E57 for ; Sat, 13 Apr 2024 14:58:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9645402CB; Sat, 13 Apr 2024 14:58:08 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2042.outbound.protection.outlook.com [40.107.236.42]) by mails.dpdk.org (Postfix) with ESMTP id 0C936400D6 for ; Sat, 13 Apr 2024 14:58:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c3xM8URezxhxSNeQ0Gq7Su99MA87v6lSGyqSJdedQJpFFj+UaS3Ol9K4W9kzEjU5yo5buAZfxNAwgffw2PrW7xua0RTU0RBSVz9817A6rx3x5SvlRitg2u97le42rrGd0G0WNdXJMjUXnlfdbrtBjnja/EdvlNWuhAjbETqgGiySRIhRgyFOOYXyeugvtP2j/g0+dgMAQvYOfgxFaDrYV03FLtSI0JpUnJlRJ7PBTX67zvNCmztTFvypkoQFOzIWkNOe81AG/p8LxQIGtBsVd7BNXJyWcX6WTbPXlb/OoyzETSuq89FE7KVzgcxfz3RWjO2sbb2NWNPkDXdQ6bZnpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HGzDpLRw4PoyxuH6fMkThRaE+MzF/7uoNvH9cVwe0SU=; b=bR4W9ay6uxzp8RwcRU/OUg2zpeI2COPFMWUAZfr7bOtbiwBL6bT+LFSCboj48nxiqhgadIH5+22x0mbifjSmNSVhitTOSMZR6xiR8K6GUDTSGRsMFuzweBaTwut6jxL/6vqMy/Rc02ku122aef+kuKmskhgybLiEgdqr1osniBOdcYGacJDVtZJZzstzJy84KuyLMz5QWw4cJBOBsPyserTHl5nIMGxuSB3vRpM2+U2Kh5QBlHP0lRtscjuYfJoA9sgpvo1H4ftlSogoj+LalsHML9Kqz5NtFyY8woCkn3dKNezVJMvLvx2K/nH+rZI9fG9SccmyNW7KWP08X+g6iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HGzDpLRw4PoyxuH6fMkThRaE+MzF/7uoNvH9cVwe0SU=; b=PwugTMwYP/Trq38dlMtqqJx+Yo/v92TNxze6sZhtuYQWWWzbtbsWKhrk88QvwFjWURKD1lD6CJ+9CMDu2twKkeg+D9V2hmVvvO0GabcXFvFm64xPhIVN9rvSoPvRaisUTbiKdf76zNQGL5+6agoHQV3lcEOW/up1BCEYX91fpBWvnpsOSIWtaYOJWXQZCpUa44DKGmpITVjcBiCq1t5XPSFFKr8Wiyxt4TDASUTrt58ECYD+7q8YhZrHKg+GsMTT6CN+C28LimxMODASSxibAZHRWnLgmv5J5pjEpCy7a0I958Ydxgn4766OLxGwOXQyFv2pKNOxGEl8OK08VZLIVA== Received: from CH2PR07CA0039.namprd07.prod.outlook.com (2603:10b6:610:5b::13) by DM4PR12MB8500.namprd12.prod.outlook.com (2603:10b6:8:190::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 13 Apr 2024 12:58:03 +0000 Received: from DS3PEPF0000C37B.namprd04.prod.outlook.com (2603:10b6:610:5b:cafe::65) by CH2PR07CA0039.outlook.office365.com (2603:10b6:610:5b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Sat, 13 Apr 2024 12:58:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF0000C37B.mail.protection.outlook.com (10.167.23.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:58:03 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:58:00 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:57:59 -0700 From: Xueming Li To: Chaoyong He CC: Long Wu , Peng Zhang , "dpdk stable" Subject: patch 'net/nfp: fix switch domain free check' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:49:26 +0800 Message-ID: <20240413125005.725659-86-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37B:EE_|DM4PR12MB8500:EE_ X-MS-Office365-Filtering-Correlation-Id: cb8ae9dd-90f7-40e7-8a40-08dc5bb95aec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AkdeAiW2kZ4mAL5zMJgQwgr7W9rTHJDAUaSKdxOJghmR6JqddV6xUEJusj9Jwx6S/2BPnB/obQ+l/cvd8K/h8Rvfo+8w3xTnoQSQB3usoWEGo/8E/g9iIyCWaQjNe1/V6Jw5YkDRZx7kU6HWHOgBhR5iumw+Q3NiBrHcUIKCMbaLWlIl9ufamKd9jIOfLc0rziLyxT18GxInOiiwixYRDqXWqIGpxdeHRCogunqtkRTZAXs+P2cBiS8R5rC8UTuGdnTa+5SpfpjGSVpmjaK4FR7RmNUsGlBXLNMz/MqXKxbMFUnJDZiRiFITL26TF9vtDG4+8YfyBDDej3EPBJb3GsGpxchq8lUarCabaagd7U5P838zpWwRNteWnoz4fsR4UXRAqEtfvA4gw1I6gCcah94ilEBZ24KjEqEnYlK/IFVMKhA0/OW2Hq7fh65oLiYDa0wLqY8h4qeznDsvhKKk6HwPaRKL98n/0DuIupEM6T2DTqv0Nk5rBwPPJR0JA5VQyLQBcPFXUxmoXsSr1lovkopePRHS+hMrzJRK0SGSCSka4b5U38z9CFZUaRjZlHvlgMrnL/p3u/cMz9jgaqrGuQthfdoVju7zTR0ZHJcsD8bQBEaIgJJEfa+t+yFzEtmapbGMuLI6FrV4tj64hU2tIzsKAYwAUKGbvOiONear3Dm4vtYmOEa16qP/rg6j1upp5jkIxDElvKmOjnAliGmafwop5okYMCw9ae+ADRnK/rw7Kj8DXoIPh8aAUrzQ46Pn X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:58:03.0890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb8ae9dd-90f7-40e7-8a40-08dc5bb95aec X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8500 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=dd48153b15f1b6113ed16f14061e891b556404ea Thanks. Xueming Li --- >From dd48153b15f1b6113ed16f14061e891b556404ea Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Thu, 14 Mar 2024 15:40:17 +0800 Subject: [PATCH] net/nfp: fix switch domain free check Cc: Xueming Li [ upstream commit 5b1b9f9c11bedb672cdf01c834d6c341d50a0f1e ] CI found calling 'rte_eth_switch_domain_free()' without checking return value. Coverity issue: 414936 Fixes: 20eaa8e2ebae ("net/nfp: free switch domain ID on close") Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c index 326d36c3a9..ecf7a1e576 100644 --- a/drivers/net/nfp/flower/nfp_flower.c +++ b/drivers/net/nfp/flower/nfp_flower.c @@ -814,7 +814,8 @@ nfp_uninit_app_fw_flower(struct nfp_pf_dev *pf_dev) rte_free(app_fw_flower->pf_hw); nfp_mtr_priv_uninit(pf_dev); nfp_flow_priv_uninit(pf_dev); - rte_eth_switch_domain_free(app_fw_flower->switch_domain_id); + if (rte_eth_switch_domain_free(app_fw_flower->switch_domain_id) != 0) + PMD_DRV_LOG(WARNING, "Failed to free switch domain for device"); rte_free(app_fw_flower); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:07.640225280 +0800 +++ 0086-net-nfp-fix-switch-domain-free-check.patch 2024-04-13 20:43:05.037753879 +0800 @@ -1 +1 @@ -From 5b1b9f9c11bedb672cdf01c834d6c341d50a0f1e Mon Sep 17 00:00:00 2001 +From dd48153b15f1b6113ed16f14061e891b556404ea Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 5b1b9f9c11bedb672cdf01c834d6c341d50a0f1e ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 97219ff379..303f6bd3f6 100644 +index 326d36c3a9..ecf7a1e576 100644 @@ -24 +26 @@ -@@ -793,7 +793,8 @@ nfp_uninit_app_fw_flower(struct nfp_pf_dev *pf_dev) +@@ -814,7 +814,8 @@ nfp_uninit_app_fw_flower(struct nfp_pf_dev *pf_dev)