From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71F0C43E57 for ; Sat, 13 Apr 2024 14:58:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C45B40E5A; Sat, 13 Apr 2024 14:58:23 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79]) by mails.dpdk.org (Postfix) with ESMTP id 0C728402CB for ; Sat, 13 Apr 2024 14:58:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZagW12jv8GDM7afUSJcNrDvfTl1T6Dvnj28vdzlR44+fK8orjsUrcu103EvuUvhEoxNRn5uUsn8zAzLRYZ9fcWroL/1EIFfeM1Jw5mPrbvHry7h/X1oG/qvuu7reM7rUM0/mthJ+Q8x6Aj1WcX6dZ+yzZcXr2IHSVdDVUZ4OTcYc2BOuXe4sa/CgNpVzON3QP1NGy81hrDEqp9VJuNJ9X53YRUE1anhVX7ntFU75NiPVHbg5FY/Lg4DqZadrIsqUoC5JfVKXWCVK0G4XjmgYGM+x0Dyiaf6Tw/7xCqNzn3rOzTDw8Il+XoYe6SfNXGZjZIf2cYLnVqDyOfV8/pnZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3LoEGmAlA++PJ720Go2ATcyjotXONgvjmNjg8tzzqgM=; b=M7TiDnJmY5ArrvCLPGg6jh86bkwXCFRs9hXpwCu9HVUaZBd9YNo7FMQW7jF6eVrps4xhrt9cQuvp3skHbp+O2339H9oJL5Yg+aHvOH5B5mVN1Eg4rL+GQ7CQFB471Z8o6LwR5q3U/8s0kaBw9GKEubXcidL7EJRQxTg32E/UzYxG7vVqeP18Chv6WWYf0E5FrnVoTpU8hogb+kaKkM1U9xqM9Xu8nRHN0gbmM2esj4S9O2VFQlPU03ItZjuymVnF4gtPIYh8y54f61FktfFrhyCbO7EpyyAwTqKVKWKwj3tw2lqKhmrTJ7XxuxGo6TDD9fLarkEhVJj0o9lCun4rKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3LoEGmAlA++PJ720Go2ATcyjotXONgvjmNjg8tzzqgM=; b=oWsasXCXq4QvTVAYOg1QGl2Wh8r13cJuWMMFwskM35EL6fsYHjMSNtLgEOvk3bY7AC7ceHS4/Ub6v8QwZ3KrpH4rHfyuJfETBy9y53rXp0H5h4Jxg7pp94X/cUOKOW0e3c3EMWWJjLiS10/DTkoSB2qlkcFTRYWJ/GhO05rzA86uEUb7/ygp3k+kLsNG5K+RfzYbsw6evFygI+xB/bG/xSSDm9EoSUNswgdVQlEnRcWbfldbLpcmgbZ2QbZOQ1o1rdwNq0Cipo9yWnZD3HXNXZtU4gojBfQBTbGCiiQEiHcZGdYSw2p7Ig1xEBFJ61NdSCXcJ6vSSSLIP7pdSTGDXg== Received: from MW4P222CA0014.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::19) by MN0PR12MB5740.namprd12.prod.outlook.com (2603:10b6:208:373::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 13 Apr 2024 12:58:17 +0000 Received: from MWH0EPF000A6735.namprd04.prod.outlook.com (2603:10b6:303:114:cafe::ee) by MW4P222CA0014.outlook.office365.com (2603:10b6:303:114::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31 via Frontend Transport; Sat, 13 Apr 2024 12:58:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MWH0EPF000A6735.mail.protection.outlook.com (10.167.249.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 12:58:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 05:58:08 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 05:58:06 -0700 From: Xueming Li To: David Marchand CC: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix error message for invalid option' has been queued to stable release 23.11.1 Date: Sat, 13 Apr 2024 20:49:30 +0800 Message-ID: <20240413125005.725659-90-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240413125005.725659-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> <20240413125005.725659-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6735:EE_|MN0PR12MB5740:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cd70369-3653-471b-9a75-08dc5bb962fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vVFdv30Pymym0dLzmP0QsDyrIqmdPeI61dvfL47Ksi9QJN/WIhUMyp0xexf0EuE3SelbOJ0gjozq1l/DRhAsD2rAHCDP3MODsPWIoRAR70VY2zc16sgoLAQgijx894BrCcNMbuViOLQvPVzoXLFWVVTlMTx8MViRlkXhThj5ea4tewwdStD2BmdIaTIjRm88aJHfrRJDGiM4hr0NHX7tA0/jALm+EDC6da46SlAfjeiLPtfAh071cT7AJXNuo9S/WDbITFAC3L3JaC8d46n6TsnjxjErHpX/Nks7hWpYVy/xuervGxFaHN7n/ks0Ktz2aW9kKAqF3Q92thaC0Z1b3k8kCWA3sqU0HSGzkoMOtq2j6ziDXy2apDJn31tp+nYpPd4Dm5u6O3R/g17qJBEohqnjYKSxgk866OQ03OlN4I1uwU8ZyjUCG4/kH1u9US0U8dXXyB19jg3TBiLdSoDnhN8lvqiNzhLQ6rB1YaLXiq9QdhpQ9wI2OMJIYv1vMjn3np27S9dGhjFttQ33vBzllcoBaPntorhKt7lebCCN3QWFmdr4yo9gVv6JI2TDHnK+JNAkdRB6HdFDcgRJFunO9pb6qb2aO3FqrbyOcoAYu/yI74nwx50ol2HmaPdRWfAfrl6bQHI0vnyTbIB/RMfbMw7Jv+pv3PhUSUY3Xg6eF+NR1N4axCRvF2Ggfr4oMjMKGzb+LuZqxrmoQu9xjU6c+QP+4lFaGHvv4nesETaPl57ZMZNBZ50pAi73gvUvNQKF X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(82310400014)(36860700004)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 12:58:16.6498 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd70369-3653-471b-9a75-08dc5bb962fa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6735.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5740 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/15/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=97089aa02e6cc724601cae527ff8ddb3ca0479e3 Thanks. Xueming Li --- >From 97089aa02e6cc724601cae527ff8ddb3ca0479e3 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 14 Mar 2024 10:17:04 +0100 Subject: [PATCH] app/testpmd: fix error message for invalid option Cc: Xueming Li [ upstream commit c25382fa81533429d5968b47b356c79153b76212 ] """ The variable optind is the index of the next element to be processed in argv. The system initializes this value to 1. The caller can reset it to 1 to restart scanning of the same argv, or when scanning a new argument vector. """ Hence, if an invalid option is passed through testpmd cmdline, getopt returns '?' and increments optind to the next index in argv for a subsequent call. The message should log the previous index. Fixes: 8fad2e5ab2c5 ("app/testpmd: report invalid command line parameter") Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- app/test-pmd/parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 3414a0d38c..a4c09e2a2b 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -1497,7 +1497,7 @@ launch_args_parse(int argc, char** argv) break; default: usage(argv[0]); - fprintf(stderr, "Invalid option: %s\n", argv[optind]); + fprintf(stderr, "Invalid option: %s\n", argv[optind - 1]); rte_exit(EXIT_FAILURE, "Command line is incomplete or incorrect\n"); break; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-04-13 20:43:07.759182325 +0800 +++ 0090-app-testpmd-fix-error-message-for-invalid-option.patch 2024-04-13 20:43:05.047753866 +0800 @@ -1 +1 @@ -From c25382fa81533429d5968b47b356c79153b76212 Mon Sep 17 00:00:00 2001 +From 97089aa02e6cc724601cae527ff8ddb3ca0479e3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c25382fa81533429d5968b47b356c79153b76212 ] @@ -19 +21,0 @@ -Cc: stable@dpdk.org