From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Ferruh Yigit" <ferruh.yigit@amd.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org, stable@dpdk.org,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe
Date: Fri, 26 Apr 2024 08:13:34 -0700 [thread overview]
Message-ID: <20240426081334.1a24577d@hermes.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F3F7@smartserver.smartshare.dk>
On Fri, 26 Apr 2024 14:20:01 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> > From: Ferruh Yigit [mailto:ferruh.yigit@amd.com]
> > Sent: Thursday, 25 April 2024 18.53
> >
> > Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread
> > safe has performance impact on datapath.
> >
> > Instead document APIs as not thread safe and add condition for reliable
> > stats reset functionality, forwarding should be stopped.
>
> I'm not sure stopping forwarding suffices.
> NIC hardware counters will keep progressing unless RX and TX is stopped at NIC level.
>
> I don't have any suggestions for a better wording, though. :-(
>
> Anyway, better with the patch than without...
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
The safest option would be:
rte_eth_dev_stop
rte_eth_stats_reset
rte_eth_dev_start
next prev parent reply other threads:[~2024-04-26 15:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 16:53 Ferruh Yigit
2024-04-26 12:20 ` Morten Brørup
2024-04-26 15:13 ` Stephen Hemminger [this message]
2024-04-26 15:17 ` Morten Brørup
2024-04-26 22:57 ` Stephen Hemminger
2024-04-28 15:52 ` Mattias Rönnblom
2024-04-29 6:20 ` Morten Brørup
2024-04-29 15:33 ` Stephen Hemminger
2024-04-28 15:48 ` Mattias Rönnblom
2024-04-29 7:57 ` Morten Brørup
2024-04-29 9:30 ` Mattias Rönnblom
2024-04-26 21:33 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426081334.1a24577d@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).