* [PATCH v2 1/5] baseband/acc: fix memory barrier
[not found] <20240502204548.236729-1-hernan.vargas@intel.com>
@ 2024-05-02 20:45 ` Hernan Vargas
2024-06-07 12:45 ` Maxime Coquelin
0 siblings, 1 reply; 2+ messages in thread
From: Hernan Vargas @ 2024-05-02 20:45 UTC (permalink / raw)
To: dev, gakhil, trix, maxime.coquelin
Cc: nicolas.chautru, qi.z.zhang, Hernan Vargas, stable
Moving memory barrier so that dequeue thread can be in sync with enqueue
thread.
Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")
Cc: stable@dpdk.org
Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
---
drivers/baseband/acc/acc_common.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
index fddeb0737b8b..e249f37e38fe 100644
--- a/drivers/baseband/acc/acc_common.h
+++ b/drivers/baseband/acc/acc_common.h
@@ -1112,6 +1112,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
req_elem_addr,
(void *)q->mmio_reg_enqueue);
+ q->aq_enqueued++;
+ q->sw_ring_head += enq_batch_size;
+
rte_wmb();
/* Start time measurement for enqueue function offload. */
@@ -1122,8 +1125,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
queue_stats->acc_offload_cycles += rte_rdtsc_precise() - start_time;
- q->aq_enqueued++;
- q->sw_ring_head += enq_batch_size;
n -= enq_batch_size;
} while (n);
--
2.37.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/5] baseband/acc: fix memory barrier
2024-05-02 20:45 ` [PATCH v2 1/5] baseband/acc: fix memory barrier Hernan Vargas
@ 2024-06-07 12:45 ` Maxime Coquelin
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Coquelin @ 2024-06-07 12:45 UTC (permalink / raw)
To: Hernan Vargas, dev, gakhil, trix; +Cc: nicolas.chautru, qi.z.zhang, stable
On 5/2/24 22:45, Hernan Vargas wrote:
> Moving memory barrier so that dequeue thread can be in sync with enqueue
> thread.
>
> Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> drivers/baseband/acc/acc_common.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
> index fddeb0737b8b..e249f37e38fe 100644
> --- a/drivers/baseband/acc/acc_common.h
> +++ b/drivers/baseband/acc/acc_common.h
> @@ -1112,6 +1112,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
> req_elem_addr,
> (void *)q->mmio_reg_enqueue);
>
> + q->aq_enqueued++;
> + q->sw_ring_head += enq_batch_size;
> +
> rte_wmb();
>
> /* Start time measurement for enqueue function offload. */
> @@ -1122,8 +1125,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
>
> queue_stats->acc_offload_cycles += rte_rdtsc_precise() - start_time;
>
> - q->aq_enqueued++;
> - q->sw_ring_head += enq_batch_size;
> n -= enq_batch_size;
>
> } while (n);
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-07 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240502204548.236729-1-hernan.vargas@intel.com>
2024-05-02 20:45 ` [PATCH v2 1/5] baseband/acc: fix memory barrier Hernan Vargas
2024-06-07 12:45 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).