From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDD1344153 for ; Tue, 4 Jun 2024 14:12:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF2F14369F; Tue, 4 Jun 2024 14:12:34 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2085.outbound.protection.outlook.com [40.107.94.85]) by mails.dpdk.org (Postfix) with ESMTP id C69FF4369A; Tue, 4 Jun 2024 14:12:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWwm1zvQvohGZpJs++D6vR52NwYUyH+g4Pk32qbk1IhlqpBWj2XMOVETZlrn/Y3aXQeIQ6cRlsM8ZBlc8uBoKn/azLYx7NPHilcoLSWmnmgUW/H0dnfWYgdE+jaalPBPJSkjLf87tegzKTv3zFv7jaqp4vi3b+dnP7C5dnCucZUr1udJ8zyPAkLUfar6jrxY4MkKtAJGhoTR8wx3NwgWAQat0pht0IPr8vy0OW0BO3WAWl7yXzpst4CV5gJtA+5sDQvHoUWdZNbznQYDDo0fJ9jNDgWuMDyC1gqTNXyL7JEz5Pdd+OZdWDxJ0d3eXrbN55MzLmH2B6eM4DLDPkY8Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PY8QyesctAhwlggO1gJhtB/qcz7kGm9DqLhU0Cc4u+I=; b=dhXiR1XztXYMNo1kvwyHD1WaYrd2vyA3AKwGtpGvr563tn9CuEFjLVwaBryY2oVmR/iKOPnKBxbkqCTM7hODSQq9Sf/DvPtnDdYQyPk8Z+fJmegT5zQs9HMnIZFmmPDdJnmjBum0NzGiLKs8qx1vZjFQNA0OvGNoHBEfjIW9RbVmrq5nwkuh4plMl0dj4n+5sGMiqBS8oo3cQBtf6m5cd4yP/nfL1tgLjUrjybFGq7bppzbn55VlxZeGNsgPKFX6jtEmgvYavNYvzYc5spdlIH+gqxf+SMFtJxPCMOpYx2mz27O7Up+2Ma+ckBgqkaJFCjjoc78uzddxWMavK4BtWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PY8QyesctAhwlggO1gJhtB/qcz7kGm9DqLhU0Cc4u+I=; b=beD3sM+QTsMmJwF98/frH76P59Q3RCXKHJnp5VOx9urzWFK/aV9MoZzliy3qu03E8RWBsW8DO0psLW6ARwvf+6qVa/EE5PbzXkh6ANDFH0GAC9MJuW35T0Rv4agQ3unWI9XfMT66tz+WZTJ+HPXGLUsubLP0aKYDl2m6LcjE7WM= Received: from BL1PR13CA0308.namprd13.prod.outlook.com (2603:10b6:208:2c1::13) by BY5PR12MB4114.namprd12.prod.outlook.com (2603:10b6:a03:20c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.27; Tue, 4 Jun 2024 12:12:31 +0000 Received: from BN3PEPF0000B36F.namprd21.prod.outlook.com (2603:10b6:208:2c1:cafe::b6) by BL1PR13CA0308.outlook.office365.com (2603:10b6:208:2c1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7656.15 via Frontend Transport; Tue, 4 Jun 2024 12:12:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN3PEPF0000B36F.mail.protection.outlook.com (10.167.243.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.0 via Frontend Transport; Tue, 4 Jun 2024 12:12:31 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 4 Jun 2024 07:12:28 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande , , Selwin Sebastian Subject: [PATCH v3 04/25] net/axgbe: update DMA coherency values Date: Tue, 4 Jun 2024 17:41:36 +0530 Message-ID: <20240604121157.3052-4-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604121157.3052-1-venkatkumar.ande@amd.com> References: <20240507124305.2318-1-VenkatKumar.Ande@amd.com> <20240604121157.3052-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36F:EE_|BY5PR12MB4114:EE_ X-MS-Office365-Filtering-Correlation-Id: 86bca966-bde3-471b-ef92-08dc848f9be6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?58zOxaMCzzmBpoLFsm5+ZRmBvLVQlIX6p8D0CRALW0badlNFrUYUGwopXsiu?= =?us-ascii?Q?wn2pJFl/5ydmyQpv6FHqVqz6ZsvInut89Qwcw7iN4LLPivXoWR5UjDG/a8KP?= =?us-ascii?Q?Fe0N74aFCHbJv/OQot0MnYTh2pclbFJ05VAi8TPFsohjDnbIGnqH0iAuXApk?= =?us-ascii?Q?nZ7fK21BGwcnXgSCW469rVwk1heMxNbIQ55DgZDqEzGzX4yY7iduKSbeAr7v?= =?us-ascii?Q?BeFL+baiEokkPVDWP7r2I2vkcHKJMHiX0cLzD3NedK9rqCoA43o2wFFH6aUy?= =?us-ascii?Q?l6/rRsaSCkQhDqcVory8lNfADEdt6JNf2dSoCUN+Y0APpaTtNrXJ1/nsmu+O?= =?us-ascii?Q?0320+ont6G6MGlJdk5IIqqfNV/cySYa8ItVgd1FBxQ0KaSGo3tudA1RzxI3c?= =?us-ascii?Q?xAhXsnPB0yYt69hg9Zf/G+qKMFMwmFRH4VRkZyuOjvOAu+HkWgxn7ePHbZMr?= =?us-ascii?Q?y1Qhig7DdpLMej8rFpm58sE98x6W7BqJC7RbM+uS44PwDWAxGRCFfomCFntg?= =?us-ascii?Q?hhhCDR8w/CC88pot7FO2VroLWafqoh7i2NnpB6iqepF2wRsXSzKRasZu1yOQ?= =?us-ascii?Q?d2OTZ3lWZyhACql8aUmqDOqAzw1BuLtitRvmc0mhRsCRdRo2FDhVZIe8UHbZ?= =?us-ascii?Q?/Q8bvaR1J8CDEL7bY64xg4t0ALt4m6NtkHsDiKB2vbWt3zfbA7szr+jopKk1?= =?us-ascii?Q?yU8q0TcKeJ5vQ04/iH5y47a9NwMjmvS2SWYjuIJFRcVG7l2ekIKgUEXKCNA+?= =?us-ascii?Q?29bgKQTrMbbHiro9ciitXpGL7cUV3Zx782EkypCvSnCk//ZOMCWZCsCFF0gg?= =?us-ascii?Q?+TzoSJiLNP2Vl8cYug3EtkBhna9rzVBoFmT6a2786XNTno509hwkCpzNtzpp?= =?us-ascii?Q?FXG81VfEBptr286/LbP4lnEm+G35NhhQ8E4yjhrA5T0lc+L6gWM3yayYfDUH?= =?us-ascii?Q?QGmlb1YMd3t+X0hDIaamSB9kNXP04WXBTWbR7wPOo59qM7aGE30gk9Tqxio2?= =?us-ascii?Q?QZyM8h86g8FnkWJ+QPt26yl96isoVw8J1xqAf5ct8PxcWQFF1sdVKz6yWvTm?= =?us-ascii?Q?3PDfbJ/wK9+gSSNPuX6ywJ4hB3faxarzZeYmh7zk3xBO+PbwzO/FC4aNtZGX?= =?us-ascii?Q?8ABL1qW20+IvpyNVPpZSeF738xSw4WkIUfAeOkwW+k+D3qTP0CrARBRu7YY+?= =?us-ascii?Q?0abuF2QC0TjrhIZsfsEc8cP4bvBT5Em2xsk59fazRwT9Eyi22O6Kp58we7Mu?= =?us-ascii?Q?w3qzV/ii13CU0CHAzv96+FO0Fpe9dsYEdmMHC+EI22JflQuQ531CingbVcYu?= =?us-ascii?Q?NWY1eZ/HNjbJkqK4/cCzDJEFrJdI3aTMIJ0W9Ua31+JFlGFMFNB0YD+RfPdR?= =?us-ascii?Q?fjMdQRvlIIQxW5Z2YCWpJFn1SyCm?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 12:12:31.0093 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86bca966-bde3-471b-ef92-08dc848f9be6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36F.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4114 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Venkat Kumar Ande Based on the IOMMU configuration, the current cache control settings can result in possible coherency issues. The hardware team has recommended new settings for the PCI device path to eliminate the issue. Without the fix the user will get incorrect data in TSO functionality Fixes: 7c4158a5b592 ("net/axgbe: add DMA programming and start/stop") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_dev.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c index 3389954aa6..9b0073eea6 100644 --- a/drivers/net/axgbe/axgbe_dev.c +++ b/drivers/net/axgbe/axgbe_dev.c @@ -647,23 +647,21 @@ static void axgbe_config_dma_cache(struct axgbe_port *pdata) unsigned int arcache, awcache, arwcache; arcache = 0; - AXGMAC_SET_BITS(arcache, DMA_AXIARCR, DRC, 0x3); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, DRC, 0xf); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, TEC, 0xf); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, THC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIARCR, arcache); awcache = 0; - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, DWC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPD, 0x1); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHD, 0x1); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDD, 0x1); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, DWC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIAWCR, awcache); arwcache = 0; - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWD, 0x1); - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWC, 0x3); - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, RDRC, 0x3); + AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWC, 0xf); + AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, RDRC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIAWRCR, arwcache); } -- 2.34.1