From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E7F344153 for ; Tue, 4 Jun 2024 14:12:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C43A436B4; Tue, 4 Jun 2024 14:12:42 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45]) by mails.dpdk.org (Postfix) with ESMTP id DC435436B4; Tue, 4 Jun 2024 14:12:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DIGcpetT0/jNdakNm0iZLCA9++2Fa7vU966fZHg/PauTuFlG2jCouZfsI95fQCeVTnj59ZdGz2t8surp0LgyA4CeeRp0htHMkcuNTI7HXhU4fW7osr6qSBsOLNjv2MMitCJvuG2K32N6BW3xBvptBFAdeysKjqrzipcdo/28bwNFK0l3DSHGVOjCED0qe4OLtSZBpS5bLQqNACIHeJDx71nMKcpT99SH9ar6Kbu/Fgn7CmeW4pJndLWuD4SIKaPtRi1n6wn8zObq9e/71qYg9YtJUpa/dTwkRc1PMgsdQWnrlFxzx4tJ4KfswBdv3PgMoC0O0obE4gR8vGuqxU1GEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HSbSQUoLb1v8P+u8gtkjnQG6YFlUttjlR+ebH54V4mQ=; b=UzS7u/E/eF2W534qFlxRYScyXOn2908Yk4qCs7bHz1N0Qfsq95MtYMKhqZM+vdYoxFk9Pl+vATB2od5CY/2BgWkvC8duEdqFb4ooACIlEGbyvPONAijV6dZYEfj/yizTDnJdAyyUxSncRFc+yesYjffzjPCY9bib9u3RpX83n5oi9judfKLM7u6MRI8psFnJPl7RLxkYZ/FDNVbWLo/VcTuBZD0SsB3UFzdmOSnLeYylb0RyaGiwp9y2AlWH8JQbvokSO+yd8jhzUNIMyace9z3AAVJ1+8O9DXxJF4KF3Wn65yGEsM/fbLddDBPMqKlKLQPizfY8A6D5ygMwocNVpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSbSQUoLb1v8P+u8gtkjnQG6YFlUttjlR+ebH54V4mQ=; b=FqQ8tysu8E7MbVe5UaxVKFJA4JFcEHYAX+1w4sHKjPb+vwILSUaa9GN6aQziQKtxYWVlYmBEpM67g8n6X1+o2b1EfoBU0SvIz1boS3x3SyJGdkNx9xZqCWQYAhspQdzqAjiBa4wEpYJttUIlBAIkxG5zE5ZV1HVsBQkrzHSeL7A= Received: from MN2PR01CA0049.prod.exchangelabs.com (2603:10b6:208:23f::18) by CY8PR12MB8339.namprd12.prod.outlook.com (2603:10b6:930:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.27; Tue, 4 Jun 2024 12:12:37 +0000 Received: from BN3PEPF0000B36D.namprd21.prod.outlook.com (2603:10b6:208:23f:cafe::41) by MN2PR01CA0049.outlook.office365.com (2603:10b6:208:23f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31 via Frontend Transport; Tue, 4 Jun 2024 12:12:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN3PEPF0000B36D.mail.protection.outlook.com (10.167.243.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.0 via Frontend Transport; Tue, 4 Jun 2024 12:12:37 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 4 Jun 2024 07:12:35 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande , , Selwin Sebastian Subject: [PATCH v3 06/25] net/axgbe: yellow carp devices do not need rrc Date: Tue, 4 Jun 2024 17:41:38 +0530 Message-ID: <20240604121157.3052-6-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604121157.3052-1-venkatkumar.ande@amd.com> References: <20240507124305.2318-1-VenkatKumar.Ande@amd.com> <20240604121157.3052-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36D:EE_|CY8PR12MB8339:EE_ X-MS-Office365-Filtering-Correlation-Id: cb3658f2-43b0-4fdb-471f-08dc848f9f81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|82310400017|36860700004|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?k5W1uo6kNVmAfRJVOMAgOdS3vUEjUia4MtfNVmad/VqV0y4+afuRctfm0Kgu?= =?us-ascii?Q?umwc+wZ3ogu3uUqFxjX0RH6CwNbR2tnb/qcX3rGmlW4cDme2DOMpbJba972q?= =?us-ascii?Q?G57lnIPJ/kXF3+0S+SvDn88+Ds+3tHZIykna1ILeNNPbr674NYxSSZk8SOFc?= =?us-ascii?Q?Tg9k3Z8NyXdQvyVT3qHGRoU3am0Ys+rC6EzDBZRgaqqBsITyJUiByscEKKMb?= =?us-ascii?Q?n+sMwfkVpt/W8ENT1C4L9ZJ9wgfn6jPvFxbCbBsv6+I7it4paUMLrHdUv8tZ?= =?us-ascii?Q?jg6Lr5DJKZOdWQHWLkBmm9fCkqpn7X/j9VCwoA5GJj5+Tvz3kRKOuVNDXb03?= =?us-ascii?Q?rCj0x/k4EzgtuhfwMekAdpW3xtkBhdWcvrU8gJJu4oohDdpd1AKEEY+tojqQ?= =?us-ascii?Q?EfAhHfDZNbo9o21YaD9KJNdxsg5F+4SNWaJX3j9+hqB0U74hkhn+pJcMye8E?= =?us-ascii?Q?XlKvP7ySbtk6rLby3v4m9S2qalIjaZ9CdURyLW4OfM9AwwElVgeChuGba3+N?= =?us-ascii?Q?u1pW8M1oZ3Vcum9wX6pZ7OnUKgS6g/rs9abVGBvZn/7ZgZhXPs4/sR/xrzPZ?= =?us-ascii?Q?wVFJV5D1k6N2KVarsVjFHd1A63NdtbzQNUFBcd/jqAPHBKcJBruIVWIZRreg?= =?us-ascii?Q?ydkcoHkID6kPKih3w/5JzuIjASckP4bijG13e3OCpEPoZAsOouDZ/q9K3qqi?= =?us-ascii?Q?TfsYSreCkVqIoCVlecLi5awpn/Ez3UPtLVbkbshh9LtWBa19iKO/8WbhaEaR?= =?us-ascii?Q?7igmzC3HxzglHTjeisD77HEIN1qP4bGKvcta/zMbUfLVe5GAfOvWoexKrtF3?= =?us-ascii?Q?6L2rgQUtAJMgKgoaVXlN+5xEJ1rfQCpd+7eVep8u4QuOW19D9EARdhAvkLCZ?= =?us-ascii?Q?0/K+la4+1wB6COUFTaFzUdn2I9K6M6ID0cIo0HSADxYybX88GfQNXjKj4nGR?= =?us-ascii?Q?fbfoQw9H3bQaiSzSvnpZiKcZ1Hj+ak5+e1fIu5eqnZzzqEkXcZBCEMRvaPYX?= =?us-ascii?Q?Ipx8mbvgKTtMGZCU9fCb/5xeLKTCEysgmD5xwRBoNFvmiQRyUhYRaEV6j0cZ?= =?us-ascii?Q?N1VQ80Dn2s9KqLWowrP6jKT/aFAMJqRb3tir+OIlayiTeqe+AeJ92EC+kM97?= =?us-ascii?Q?+TF35lRg3yeIRVOlSf3vDNFxs6D8Kx1Po4h6lZpvKWrYgbMX7PGaJ2tWUAJQ?= =?us-ascii?Q?chRP2meJ+hedYwlfAk8pyRvTK+i0WxHh80ZCgVPCqYVf1FKtoLCctCa3bXoh?= =?us-ascii?Q?PM6BEoVT8RbAQqWI9sGF9Oba5Y21v4ngsk8CBsKfhHZod5hJyZ4nc5+8FPbw?= =?us-ascii?Q?EvtbwtPM7HrNpAi76icbHNUmvagUeuLdGv0oP0/8TTHWJgn3W3ug5jBFY+C8?= =?us-ascii?Q?UkYPo15SO/nn1Ks7oA7lEK/uN0kw1eksvJWubZBD5fZyCD5ZzA=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(82310400017)(36860700004)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 12:12:37.0538 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb3658f2-43b0-4fdb-471f-08dc848f9f81 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36D.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8339 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Venkat Kumar Ande Link stability issues are noticed on Yellow carp platforms when Receiver Reset Cycle is issued. Since the CDR workaround is disabled on these platforms, the Receiver Reset Cycle is not needed. So, avoid issuing rrc on Yellow carp platforms. Without the fix the user will not get the link UP. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ drivers/net/axgbe/axgbe_ethdev.h | 1 + drivers/net/axgbe/axgbe_phy_impl.c | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index e5d8f7db02..86c2ec64e0 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -208,6 +208,7 @@ static struct axgbe_version_data axgbe_v2a = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static struct axgbe_version_data axgbe_v2b = { @@ -220,6 +221,7 @@ static struct axgbe_version_data axgbe_v2b = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static const struct rte_eth_desc_lim rx_desc_lim = { @@ -2269,6 +2271,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) /* Yellow Carp devices do not need cdr workaround */ pdata->vdata->an_cdr_workaround = 0; + + /* Yellow Carp devices do not need rrc */ + pdata->vdata->enable_rrc = 0; } else { unknown_cpu = 1; } diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h index df5d63c493..f122dfd516 100644 --- a/drivers/net/axgbe/axgbe_ethdev.h +++ b/drivers/net/axgbe/axgbe_ethdev.h @@ -463,6 +463,7 @@ struct axgbe_version_data { unsigned int ecc_support; unsigned int i2c_support; unsigned int an_cdr_workaround; + unsigned int enable_rrc; }; struct axgbe_mmc_stats { diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index ee9dcbe3da..f51830f800 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1708,7 +1708,7 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart) } /* No link, attempt a receiver reset cycle */ - if (phy_data->rrc_count++) { + if (pdata->vdata->enable_rrc && phy_data->rrc_count++) { phy_data->rrc_count = 0; axgbe_phy_rrc(pdata); } -- 2.34.1