From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6775645482 for ; Mon, 17 Jun 2024 16:39:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6158F40674; Mon, 17 Jun 2024 16:39:47 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 845514028B for ; Mon, 17 Jun 2024 16:39:46 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f480624d10so36759325ad.1 for ; Mon, 17 Jun 2024 07:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718635186; x=1719239986; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wbRwG4aPcsXXfo+1C40lRheKOpNTeruJ3jKx/Mz3+rE=; b=N7WXE3zJt2jSRH1MMEFpkST5JhMQlCV8eepcfjwm764Ds0KYTPVuPO5y/gcGOVx2A4 jTzt5xo+NfQFGN9bRlGTaCjPPbdnvkrIY9yeFDLi9DPaX3E90rT/WttAzl3qrOrKtKvc Soasy869xJ0M56WoRuP/kKWwD7KtHhhiF23jdI9tNFYjUQkAsU2fhqqh301PfR9cUf2T ds/xF4l5PdmEHq+nrkA/gUW+UqukX5Q3GimCYOIxsDP0Z9TDbwsQkJQJxlwJBZCTHX8y SpDTJIcMLrrGcprWppr1MGUYHbDLoGJSzudU9OWkqpgzWXhEHEdEdwm95v+5SXi9FI9f P99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718635186; x=1719239986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wbRwG4aPcsXXfo+1C40lRheKOpNTeruJ3jKx/Mz3+rE=; b=UwGCY8KTCuvJQqEo5Xtb3b2GHTVMcQFZVhat8FAW1hGUERD1thXZVd0GsrXqKrN7Eu w6kVp5XmO7GRuQYpdif6/HX03tyI183O7UAEsFfdhvgOBb8skzbanTrHBVnFKZw5ZtrU qLhkUnvYx7AzaUfA6frzU9kpi2xULxuypThK0T0S8rJZZQ26AdcStToc9DSFFaTSZtuI /7z+PSaPOovpVuRkq8Qua6UM0xrRO1ykYpFc1o+2Nw/8CA06719rJY1ZQJWxAFcdhCW6 4buBTIHr0twUxyn3JgiTt2SKjalU4qEgogiB9RLNgH2CJaV0f2rbaHzlL6LVCn92uCV/ 1iNw== X-Forwarded-Encrypted: i=1; AJvYcCWgIydk8wcPIr4x6TcPhwufldcNMrm3cXqELkyXFhbDgAW6N7udIgr4wdaTVSuJLDhmFoejPDOdwMlSaKqMPLo= X-Gm-Message-State: AOJu0Yy9ZX1QQw9GWC6OOKc5a65ilhTA/bNGj7F5jTbWNi3wdsvPfcRG ghGHjds+twitBsrcxxhVgs+rwBpMzKAteDeixkyTcMC1hOmNZDxiI2AAS5vlthg= X-Google-Smtp-Source: AGHT+IHZCt6CkPDBlGcpeJ6HmyLXevZPglycO44c30XVqUZVQ+ziAVroiYEyj3/smIbtqSDyGhh/dA== X-Received: by 2002:a17:902:cecd:b0:1f7:9fb:9d0c with SMTP id d9443c01a7336-1f8629fcc1bmr124599125ad.56.1718635185686; Mon, 17 Jun 2024 07:39:45 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f1ad05sm79792595ad.242.2024.06.17.07.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 07:39:45 -0700 (PDT) Date: Mon, 17 Jun 2024 07:39:43 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: David Marchand , , , Ciara Power , Chengwen Feng , Shaowei Sun <1819846787@qq.com> Subject: Re: [PATCH] telemetry: lower log level on socket error Message-ID: <20240617073943.16cc7f66@hermes.local> In-Reply-To: References: <20240606122654.2889214-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, 17 Jun 2024 15:28:17 +0100 Bruce Richardson wrote: > On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote: > > When starting two DPDK programs using the same DPDK prefix (like for > > example OVS and testpmd, both running as primary processes in > > --in-memory mode), the first DPDK process of the two spews some error > > log when the second starts: > > > > TELEMETRY: Socket write base info to client failed > > > > This is because telemetry init involves trying to connect on existing > > sockets to check if it can take over an existing socket file. > > > > On the other hand, this error log provides no helpful information. > > Lower this log to debug level. > > > > Fixes: e14bb5f10509 ("telemetry: fix connected clients count") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Acked-by: Bruce Richardson > > Would it be also worthwhile having the probing process wait a small amount > of time or check for an input string before closing the socket? That should > avoid the error message being necessary at all for the case described. If telemetry used abstract socket path instead this would not be a problem. Using regular paths leads to races and problems with restart. And all the stat and runtime check logic could go away.