patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] telemetry: lower log level on socket error
@ 2024-06-06 12:26 David Marchand
  2024-06-06 13:26 ` Christian Ehrhardt
  2024-06-17 14:28 ` Bruce Richardson
  0 siblings, 2 replies; 8+ messages in thread
From: David Marchand @ 2024-06-06 12:26 UTC (permalink / raw)
  To: dev; +Cc: stable, Ciara Power, Chengwen Feng, Bruce Richardson, Shaowei Sun

When starting two DPDK programs using the same DPDK prefix (like for
example OVS and testpmd, both running as primary processes in
--in-memory mode), the first DPDK process of the two spews some error
log when the second starts:

TELEMETRY: Socket write base info to client failed

This is because telemetry init involves trying to connect on existing
sockets to check if it can take over an existing socket file.

On the other hand, this error log provides no helpful information.
Lower this log to debug level.

Fixes: e14bb5f10509 ("telemetry: fix connected clients count")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/telemetry/telemetry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 1663bd8c68..509fae76ec 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -382,7 +382,7 @@ client_handler(void *sock_id)
 			"{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}",
 			telemetry_version, getpid(), MAX_OUTPUT_LEN);
 	if (write(s, info_str, strlen(info_str)) < 0) {
-		TMTY_LOG_LINE(ERR, "Socket write base info to client failed");
+		TMTY_LOG_LINE(DEBUG, "Socket write base info to client failed");
 		goto exit;
 	}
 
-- 
2.44.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-06-19 15:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-06 12:26 [PATCH] telemetry: lower log level on socket error David Marchand
2024-06-06 13:26 ` Christian Ehrhardt
2024-06-19 14:37   ` Thomas Monjalon
2024-06-17 14:28 ` Bruce Richardson
2024-06-17 14:39   ` Stephen Hemminger
2024-06-17 14:52     ` Bruce Richardson
2024-06-17 15:13       ` Stephen Hemminger
2024-06-19 15:44   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).