From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40AE345492 for ; Wed, 19 Jun 2024 11:58:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24F93427E2; Wed, 19 Jun 2024 11:58:54 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2092.outbound.protection.outlook.com [40.107.236.92]) by mails.dpdk.org (Postfix) with ESMTP id 1D091427C3; Wed, 19 Jun 2024 11:58:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cki6mCP+8nGL6h1xmcTHg/EhhqhKEuFBL1T/o+csKriOlrczfG2j8iD9nt8dxWON5T0mHYlZiI+f1XrqhVrBT2pA3U1Kd8I74LfceSFAz+8Q+C9WxJJuAaCsJJHOhaxehHOPYJaazTefZoy3zqibGth8Y0kBsmOovVtUPL92RKI88oj4HRF3Vuiipy32dlcUjKRjfuv6pwS6/z9vkgjToE1GbKNiEJkW7EOsAatfovrR4r00mkN/di7sXmUCVcRX+c0Mkn35+qfqsBkHUbm8ViEKuNz20ZPbX/zHHurhr0GP5lZeGiGkoQV7cMNNgzLRc1IPH9Hg8XrhgxiZ0QHWAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XJdW3k8T3Nn8Zj/ihwa0YNXFmT3fHj0bA3CmO/DiNh0=; b=IShEIe9Y1Huxo5LWF7zusovzbR8CHEW3acJsCdBpKPXKt3k9C9z+t0IIKYb84KJz2GFYVmZD9SUb+pk7GyCnizbMsFI4Ml5zVCUyZHixqPBx5VSzSj0XdvXX2pT4ZL42P/q+hcaGB+C4WIDZo0yC+9FHgxXnl5Owv7hfDTO0tFH7dr+ql7N920+onebsJQHtrlZDoXiR+ViOt+QbMgVno7Jx/cOdJC3DVje8TREzCcvOK8VxtO1QJAvnbwO9iTOBlkML4BXclApbxzMBhjU1ZrulCK4WZ6X+oVES97WXezlElaInE0TP/8XD2dVHPJQU1SS2DtgVupLb+z4vE2RrLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XJdW3k8T3Nn8Zj/ihwa0YNXFmT3fHj0bA3CmO/DiNh0=; b=c4swlY8QrtU+db7+4mKPSr/oTF689KZzfO+zeuRHzKWPS7wRVcoqKbspBzo5Qf59BDoJsUiThCcSBGQdDoQOE0snEt3+YgC1OUM8HSzp/2CDkXon8cx+T9JWv6FHWlBJ9Qm6BEAtd0vJsRceopIw3Dbh4OktPhnSWs0r4oUzMQQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5782.namprd13.prod.outlook.com (2603:10b6:303:171::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.20; Wed, 19 Jun 2024 09:58:52 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%4]) with mapi id 15.20.7677.030; Wed, 19 Jun 2024 09:58:51 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , chaoyong.he@corigine.com, stable@dpdk.org, Long Wu Subject: [PATCH 02/23] net/nfp: disable ctrl VNIC queues Date: Wed, 19 Jun 2024 17:58:09 +0800 Message-Id: <20240619095830.3479757-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240619095830.3479757-1-chaoyong.he@corigine.com> References: <20240619095830.3479757-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR13CA0057.namprd13.prod.outlook.com (2603:10b6:a03:2c2::32) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5782:EE_ X-MS-Office365-Filtering-Correlation-Id: 89583353-55c0-40c8-c4a1-08dc90466c2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230037|366013|52116011|376011|1800799021|38350700011; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/DnyMkYNQWLZcxthxepNOgLDSb1BVJ5xiM7GG23Jw5CYuzQKV9DPcAEsjzwn?= =?us-ascii?Q?8UKy+oUNCfZ8ekxjX7FcGSN0YbhhaHmmfgSbFlQOJcBMhZ9hVym323+AEdH9?= =?us-ascii?Q?rWQikAEAn854KlmbAsePlHxcOYP4t3EFig/eO2W8wgW56WH7jFqKeRbjvFi9?= =?us-ascii?Q?W3h47Baiq7WULMVpdBjd7BjkQQcDcLYyNwE1P5T0HQTHmx54OmJn5scffdm2?= =?us-ascii?Q?j5CwepDEoZDFIJbd3km4qO8BKV5rLTkPy2AslhkQnStKB/aUBSlcY9ICZ+MJ?= =?us-ascii?Q?0bi/SilQqzT0Iy8Ku9bDrjaAiuLN9VoygVb3x3mC9rJIt8kMctKZzCXJ3wf+?= =?us-ascii?Q?U506eoE86T3wAX/8yeLGG33j3D8YeJCf/jyefE6iNC0kVJPyMwd7MWmAbl0F?= =?us-ascii?Q?3MQtwPZh3Cw9MBgxDZZw/E+8v86zTMk5GnU/pRdHpK67ZzJE38Tq+O6g9U4A?= =?us-ascii?Q?nQXDSX5USWXNCuoKcY3gMcJBKeQ0mxVb80EQ4io9ijHLRRBwL/f7XcGcdk0K?= =?us-ascii?Q?Nek1ZQS8aC4ynUty2Sx5jWHFffvZCGyOIIVpKJ2+roT4t4eSJUrlbFiTG2Ea?= =?us-ascii?Q?KPTuiPsW5R4vIT5SiBjrSgGTkOr1WslB0diVkULLpt/4fPorzsZWmXjjXzb0?= =?us-ascii?Q?qVJwI0R8TxeffFvr3A6rUSEr3uCqmzGwmWloyN3nTRPGoSlhzO3tRoj2/Kub?= =?us-ascii?Q?UcKgFAa2E1yoGwo9Ly/9vOlhsLyBnsiNmnXe+IyonEfEMIFr7XN5qfWS7x45?= =?us-ascii?Q?IuTb1ju1sweXU3d99f+W3QpyXC/50T445zOax+2NN+ZTGbmyAuGeN1XL5gU1?= =?us-ascii?Q?jN1Bo0QXpXNf27VZyRSasyUhc+nn43XSAUvXm5ihx8tG0lXEPc+XoGYOxMyg?= =?us-ascii?Q?ZH84oOxL533ywST9VIGlBTofqGSGV1ZynczxD7jhpc46x1mIX/Mjx1+hMU5x?= =?us-ascii?Q?eyPrUAovC/6TI47MjVUUOuyWW8r5wxOWfCeqIlJyWynKhbd5mwPn7uIv7Imq?= =?us-ascii?Q?FwNwZYdn3h9XeCWJfAzLfckVYyI1Vu9duC3z3iUOyvBB1nO62bI6aK82jVsu?= =?us-ascii?Q?uXUVbfgSR1Qo8IHMjFJ9Ji0/X2VnHO09grEInS/RlY6PBGLDnbKOfC77B2NZ?= =?us-ascii?Q?msC6kMejPIhydBLCqE2G9ct0xRVopK8n0lDt3W0L1C2NNNPgw6KCSoXjSDkK?= =?us-ascii?Q?Bk6ZqTyvzhdgb1uWw3bPsLGhR6W3UiwGTGSvIyhvZzgvWLbluKYU2LqL3uVy?= =?us-ascii?Q?+J8+1glS+ahrxdQb+nfWoaqi8z0P5CG4xU+SkmW+ivZb7YluubrOtJ0zEGdo?= =?us-ascii?Q?o8TAbc9HZ4S/gxKCtmzW2skrYWtA+6XYKKqwWUOawvIVAqKMMB5LSnAqyBqD?= =?us-ascii?Q?GrGQhbE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(52116011)(376011)(1800799021)(38350700011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EvvfdYQnv379Vn/2o2TnGqum/IKtMoUEPA4pXq5XdGas9b3RkzU5FPQLCBxp?= =?us-ascii?Q?TKMG1D+c4bRUzHPcAHvVMNBdLJ7JvJhTcvOXpChaAFNGqS42a15vtimUGeMO?= =?us-ascii?Q?d0QZWE1A/efJgCsSnNQi58sB/oIhyjmdYsBPOSpSAaBjct4VvIrBN7Khg9PZ?= =?us-ascii?Q?D4GhDdvvyrtSFmd+LgXyHGJXKhMXgyuoSmn+j5g5MvF+G+OSE0yGKamKPWYM?= =?us-ascii?Q?l/zi/vSBNFpfypqFIEu73/P1AtnEewpkFRnz/Yc7B5vMM+PhHWcBPlJ4976f?= =?us-ascii?Q?4fs+jYQI6+ypBdQpId/dNtHjRYzTIxcpblsG2wTgMYXN1Vxv9azJw0cv26By?= =?us-ascii?Q?JPr2xiq3+NXzLa+ilzk7Jw8eOEhFnEqwEOHPUAg/h5WK31SxMNT/5ZqYakCb?= =?us-ascii?Q?2eRnsbms3xwagFrYlMjbg+2XLwkrH8Ep0TX5189+0ydNVC9Ae/bJEpj9bqQw?= =?us-ascii?Q?ylkT75ZadEp3m99Zy8tfXYOtxSLVMuMIcf00SJeUk/vCLzEC5WR/GIokfmKD?= =?us-ascii?Q?jyyCf3dvwmwZcfoLmVlkE/RmiYi/qsNGyWaplqqcCZQJrdHVEdJZyPWhMR6f?= =?us-ascii?Q?Iszas0O2f78Fbxaa37n4roceiGEcV8FFj+rufMSpVjTgQh2IcFxS6EpNu3jl?= =?us-ascii?Q?RP+7YyoCmK3R9+nQ7YiFn1lGNthxuG4Ntq0TItsQIdmwpkFcx9LJgxJ9uQF/?= =?us-ascii?Q?qRgiWxqCC48vz5FaYduRHWBDOXPHQsiObjC0b7TvxuD7JPnsOIMohQm+DCzQ?= =?us-ascii?Q?k+ChXK6U5ytggnfFqi2ahNQDcCNlPmY6xXFvT+MsUsIC1uAj56cwX8eWTHG8?= =?us-ascii?Q?SuPBeAR/ZZLKtTPNsongzj1OyhBwRS0L2pMAkC4L8WoEr0A+MNtysaokIMOU?= =?us-ascii?Q?/V22EGpnNEA8v3KGh6eTk3DSZQeV1TPOYAqHxcwOKqlfPz/7gf7WYqCqNCRm?= =?us-ascii?Q?WdMyH29CuChSFWWHZ27VZyT2SWQObne6Nl91wP4sAm2gmZ253zbIqYsgSF1v?= =?us-ascii?Q?CYa1MCKZGQAReFdhRbmf8fE5zRjm43wh09OdwU5pnuL7vOZWjQ40TWX2phHi?= =?us-ascii?Q?njqbWmHfnDez+PU2TKBrw8yjjgEFj2frh0ONVD9el01mvG8/iySljbeLArpU?= =?us-ascii?Q?FCXBC3q5W/y2J7RXLfJKjiPcABbdV9DXgBjGRb/XDoFLTYtwPzgnfl1UPz8K?= =?us-ascii?Q?PtT/PwYTAyrMYsTfpC7sGA156lih3H/vJ2jEQeg5cQCuIoY4al+PD/MiWDAW?= =?us-ascii?Q?sHkqZFQFDedboijjbki8m/cvbM1+Ipzwbl3C195bsw65e/fqjvCJHDvsa1OE?= =?us-ascii?Q?A2dG5g5KB9Qno0Nw+QiGQvY9L+Xs6M1iOlj1+qwYJ+2l5s1sj3ddAmDRjAwo?= =?us-ascii?Q?7ZwUXOjn43+DkcbFAEFuxUwJHuwObrhX+ot/1GICk3IkRlv6Ufu185Qjkiko?= =?us-ascii?Q?yzWTf630ZJWRIYjFKhmPNv1gdWlK5ewa/yfUAz5Dayyku2N4EELXGTulNUv+?= =?us-ascii?Q?iiu0J8IsQNSZKynNLm5rBN85HmmJcRrpJmePuDoyRhO7f+7lUCPpO5AZxdx3?= =?us-ascii?Q?S++VEf8bUVLiXspdQ+2cpxt3A43HiaMQ2ZL7keSR00G6i1oSSYQhCEAM4iCi?= =?us-ascii?Q?YQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89583353-55c0-40c8-c4a1-08dc90466c2c X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2024 09:58:51.9272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WP5dvHCwZpoy9ErSFq/t6InGgoooYzS2ZiD1EstkxsNJHA5DiC3gxskt2bLnpCqlq/qL5ZKxNQuEXZO2aYdP3S3aKEppcCT/KAcTh3S3Soc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5782 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Peng Zhang The logic forgot to disable the ctrl VNIC queues when representor port close, and this will cause DPDK application restart fail if not force reload the flower firmware. Fix this by adding the missing logic to disable the ctrl VNIC queues. Fixes: 945441ebdb9c ("net/nfp: add flower ctrl VNIC") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/flower/nfp_flower.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c index 0edebd574a..5caaf9d745 100644 --- a/drivers/net/nfp/flower/nfp_flower.c +++ b/drivers/net/nfp/flower/nfp_flower.c @@ -533,6 +533,8 @@ nfp_flower_cleanup_ctrl_vnic(struct nfp_app_fw_flower *app_fw_flower, pci_name = strchr(hw_priv->pf_dev->pci_dev->name, ':') + 1; + nfp_net_disable_queues(eth_dev); + snprintf(ctrl_txring_name, sizeof(ctrl_txring_name), "%s_cttx_ring", pci_name); for (i = 0; i < hw->max_tx_queues; i++) { txq = eth_dev->data->tx_queues[i]; -- 2.39.1