From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BB8E454E9 for ; Tue, 25 Jun 2024 02:00:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2322F40EDD; Tue, 25 Jun 2024 02:00:44 +0200 (CEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 755E4400EF for ; Tue, 25 Jun 2024 02:00:42 +0200 (CEST) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-424798859dfso41601415e9.0 for ; Mon, 24 Jun 2024 17:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273642; x=1719878442; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QP7fjeb8OcJmhx2zfRPwAKYG9GfhbRawRbihQdpOOmA=; b=UIetwiDI8O8zU8+7FOptlwVAkP56MNZWgkK/PTk6kLG3Zv+JTCQqtaJhH76HVo7GQi e52nIh4e+itP+a6CM1YzRvFihcjfYSUiLg8JSxPkmR6taVoptD2P2oYZ95amMwcac/CN mTOHhdSNoF0VOxbEY+1IPq5QZ9lRaXbv+8xlQCF2Nj1b+C7lA9GrsbqMNy78EAFQbGs+ V1P4dpSrWNbEJkCZ09uVDPu/FapvL0Tqnbx7oGdpcNd1RRyPZgLiL7BLlYQeGVRhQBNn F2oYLCbL70JOL87Dx7SsFxMSpJ6qvlCmGM9UcozLNeEdiBly/ZRXFIEcObuAgwyzCguT IZeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273642; x=1719878442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QP7fjeb8OcJmhx2zfRPwAKYG9GfhbRawRbihQdpOOmA=; b=ewTBOuhO+R7JFVlwM3ywjM6iqHsWVkKZVNNHMZMt0qEmte9GgaT8CY9buo7+14Ega5 P0pEjDh5M2lkNnZhc+3KUu3ctLJY5BLN5GZdezblyOWXJiZlWP/p80E4dtqTyF+usaDI SJB71ajVGg8ybCpw5o0zFC6xdnn3EhF8/AluF3JWm09vVEieYZQ2U+9W20u0EBK6HLsO 1wKsgnXC0lU1tPSbmGISeSmbTtknwHxiIeCvP9502n6Q2dz5mcXLbNmY8eq8FOv6mVl4 Fml2WyUnHqcZK/6m+Ju8l5AC5XK//jsK3zM4XKjsiV/bsQjP60rR5k5v5kDGz0ihzGMe 5eDQ== X-Forwarded-Encrypted: i=1; AJvYcCU4FEhKsRxkn1lDgEuaIu6Ph+Q5vXf93ZrHzVoBRNIcaq6o4uBLoE2zhFPq9zwhDyYOahcSzLo44jVNr6Wk/WA= X-Gm-Message-State: AOJu0YxrGgc17rnBETCSBAlwkzbPRuVKqwyL+Kt3T9gvplzue4EJ26VW rNNgXhjl8yWfMv5MzPpsS7h2/XVQIFh2VTXtJfmXO7dvgJIcXA7kvZpYhA== X-Google-Smtp-Source: AGHT+IEXJkHuYuVEvVnv+cWxkb07itYHLJnmqkGIZGi5KLGxsy5hqNpUvk3Nkjj7TeJ/f5R6prc2xw== X-Received: by 2002:adf:e990:0:b0:35f:1bc3:50b0 with SMTP id ffacd0b85a97d-366e9652995mr3784220f8f.63.1719273641592; Mon, 24 Jun 2024 17:00:41 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424817a8d8esm153582635e9.12.2024.06.24.17.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:00:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Venkat Kumar Ande Cc: Selwin Sebastian , dpdk stable Subject: patch 'net/axgbe: disable RRC for yellow carp devices' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:58:13 +0100 Message-Id: <20240624235907.885628-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a1e4f462f35e4015d7f2de421d96fbd39ff42632 Thanks. Luca Boccassi --- >From a1e4f462f35e4015d7f2de421d96fbd39ff42632 Mon Sep 17 00:00:00 2001 From: Venkat Kumar Ande Date: Tue, 4 Jun 2024 17:41:38 +0530 Subject: [PATCH] net/axgbe: disable RRC for yellow carp devices [ upstream commit e82b0fe097da02eab8be924a28a0a4ca96bc3c69 ] Link stability issues are noticed on Yellow carp platforms when Receiver Reset Cycle is issued. Since the CDR workaround is disabled on these platforms, the Receiver Reset Cycle is not needed. So, avoid issuing rrc on Yellow carp platforms. Without the fix the user will not get the link UP. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ drivers/net/axgbe/axgbe_ethdev.h | 1 + drivers/net/axgbe/axgbe_phy_impl.c | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 30440e9e1d..2156b1d17a 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -205,6 +205,7 @@ static struct axgbe_version_data axgbe_v2a = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static struct axgbe_version_data axgbe_v2b = { @@ -217,6 +218,7 @@ static struct axgbe_version_data axgbe_v2b = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static const struct rte_eth_desc_lim rx_desc_lim = { @@ -2224,6 +2226,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) /* Yellow Carp devices do not need cdr workaround */ pdata->vdata->an_cdr_workaround = 0; + + /* Yellow Carp devices do not need rrc */ + pdata->vdata->enable_rrc = 0; } else { unknown_cpu = 1; } diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h index 7f19321d88..ae57aeaa00 100644 --- a/drivers/net/axgbe/axgbe_ethdev.h +++ b/drivers/net/axgbe/axgbe_ethdev.h @@ -463,6 +463,7 @@ struct axgbe_version_data { unsigned int ecc_support; unsigned int i2c_support; unsigned int an_cdr_workaround; + unsigned int enable_rrc; }; struct axgbe_mmc_stats { diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 8f8845a1c5..46ee5f0617 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1708,7 +1708,7 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart) } /* No link, attempt a receiver reset cycle */ - if (phy_data->rrc_count++) { + if (pdata->vdata->enable_rrc && phy_data->rrc_count++) { phy_data->rrc_count = 0; axgbe_phy_rrc(pdata); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:15.281453298 +0100 +++ 0027-net-axgbe-disable-RRC-for-yellow-carp-devices.patch 2024-06-25 00:22:13.117184263 +0100 @@ -1 +1 @@ -From e82b0fe097da02eab8be924a28a0a4ca96bc3c69 Mon Sep 17 00:00:00 2001 +From a1e4f462f35e4015d7f2de421d96fbd39ff42632 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e82b0fe097da02eab8be924a28a0a4ca96bc3c69 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index e5d8f7db02..86c2ec64e0 100644 +index 30440e9e1d..2156b1d17a 100644 @@ -29 +30 @@ -@@ -208,6 +208,7 @@ static struct axgbe_version_data axgbe_v2a = { +@@ -205,6 +205,7 @@ static struct axgbe_version_data axgbe_v2a = { @@ -37 +38 @@ -@@ -220,6 +221,7 @@ static struct axgbe_version_data axgbe_v2b = { +@@ -217,6 +218,7 @@ static struct axgbe_version_data axgbe_v2b = { @@ -45 +46 @@ -@@ -2269,6 +2271,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) +@@ -2224,6 +2226,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) @@ -56 +57 @@ -index df5d63c493..f122dfd516 100644 +index 7f19321d88..ae57aeaa00 100644 @@ -68 +69 @@ -index ee9dcbe3da..f51830f800 100644 +index 8f8845a1c5..46ee5f0617 100644