From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79DAC454E9 for ; Tue, 25 Jun 2024 02:01:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 756EC41141; Tue, 25 Jun 2024 02:01:47 +0200 (CEST) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id D075D40EDD for ; Tue, 25 Jun 2024 02:01:45 +0200 (CEST) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42122ac2f38so28951265e9.1 for ; Mon, 24 Jun 2024 17:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719273705; x=1719878505; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4cKZSl6xRRlILF0+aqaxGbjfQS6rGgcVDXRznEJ/MJQ=; b=a5UsDp/NXFiBnfNUbcXdZt50nE1KQScKS3QbGTkSR1fQdrXVoCW4HXocy6dwuf7Kw/ jVa0a10sn68KbFJmMBytovOtR63v1HQ7Touy3UzBWLPOE5PfDHo/yYcASsRzLXur7iOz ONRUN4cvg/L0pVs9EcTWVwpI49Ivwwi7SOAUxsH2SrsO3Hg9mKTs79MUtnmZwxNAwMT2 n7N4TToq/B5n6smDDZmrZyXxQpsrSloBexEeUZ8wxlzg+kPnlNAl9YJfdkNE7ALr8ZkZ +qPA1ysAdly667/nzdN8tbAEJ5VosktVoE/1amDkrCe9r/SXYOQUSbHPI3x4qoZO1/uw YWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719273705; x=1719878505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4cKZSl6xRRlILF0+aqaxGbjfQS6rGgcVDXRznEJ/MJQ=; b=IxJsFlnS5LZG2n532Y4VQmYm8NWbyvMSVgSECeupVSrOwSbr/8EqD4gNeAkuC1DKOz FjXEHGPFIplhcjkbxNasaYvU2YrjmHT7SZOWdPD9Z3AG5hU50Z3mFL59ZmRaz6jEFePG g9sN1n8fBdIMMjIup3JjzSKIdU10gHLLG8XcnvTvzVhbFXTT21Fap5aAFhCKud51Kiob +rHVWD0P0ZqlHtNQ2+6661umh6db6MpbafmPeWqdn0Gd0NLGEjP9Cobvy4xY5yXUuipc 0yrnWeR+nLgbtGdpA8pbKzPSWYPawlyPWxQ61BNmdcjGlsd6C9nwpnqL7O9Y4R9fILEI xRvg== X-Forwarded-Encrypted: i=1; AJvYcCVKPzFbVyQdf5BnGm9gmseu6PKiFo3ZdEurYESo7bAywsQ+RP9hoJrBAx1W4BoPvfmYzPq+OFJGwDB2xFMmt+w= X-Gm-Message-State: AOJu0YwNrWdt4/DvtMrGL8mVjp0l/TL62QVBKw67Kta6sm4XeKN4KDqd Y8gzZ7cCT5rhLk+EpAc+nzfDL8LQuz/xUZeX0UgkfpKCll7u2gL8iKuffQ== X-Google-Smtp-Source: AGHT+IGRqBnap/yKRksDHMrGEGXfJO7Pf/340lc5lXFiioBesAbcimhjBCynX2EgwcdGprrFCk+v9w== X-Received: by 2002:a05:600c:450f:b0:424:89ea:a6ac with SMTP id 5b1f17b1804b1-42489eaa776mr59300015e9.5.1719273705499; Mon, 24 Jun 2024 17:01:45 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366383f6769sm11480580f8f.5.2024.06.24.17.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 17:01:45 -0700 (PDT) From: luca.boccassi@gmail.com To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc: fix memory barrier' has been queued to stable release 22.11.6 Date: Tue, 25 Jun 2024 00:58:33 +0100 Message-Id: <20240624235907.885628-47-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240624235907.885628-1-luca.boccassi@gmail.com> References: <20240624235907.885628-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d47135efe7ed109c90c806899b4a6c7f022388b4 Thanks. Luca Boccassi --- >From d47135efe7ed109c90c806899b4a6c7f022388b4 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 2 May 2024 13:45:44 -0700 Subject: [PATCH] baseband/acc: fix memory barrier [ upstream commit 0a200a3a29017f6b01a481776a571a75e03a32ce ] Moving memory barrier so that dequeue thread can be in sync with enqueue thread. Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h index 9336d3fbcf..7ea3cc9a02 100644 --- a/drivers/baseband/acc/acc_common.h +++ b/drivers/baseband/acc/acc_common.h @@ -964,6 +964,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, req_elem_addr, (void *)q->mmio_reg_enqueue); + q->aq_enqueued++; + q->sw_ring_head += enq_batch_size; + rte_wmb(); #ifdef RTE_BBDEV_OFFLOAD_COST @@ -978,8 +981,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, rte_rdtsc_precise() - start_time; #endif - q->aq_enqueued++; - q->sw_ring_head += enq_batch_size; n -= enq_batch_size; } while (n); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-06-25 00:22:16.331479882 +0100 +++ 0047-baseband-acc-fix-memory-barrier.patch 2024-06-25 00:22:13.177185486 +0100 @@ -1 +1 @@ -From 0a200a3a29017f6b01a481776a571a75e03a32ce Mon Sep 17 00:00:00 2001 +From d47135efe7ed109c90c806899b4a6c7f022388b4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0a200a3a29017f6b01a481776a571a75e03a32ce ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index fddeb0737b..e249f37e38 100644 +index 9336d3fbcf..7ea3cc9a02 100644 @@ -22 +23 @@ -@@ -1112,6 +1112,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, +@@ -964,6 +964,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, @@ -31,4 +32,4 @@ - /* Start time measurement for enqueue function offload. */ -@@ -1122,8 +1125,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, - - queue_stats->acc_offload_cycles += rte_rdtsc_precise() - start_time; + #ifdef RTE_BBDEV_OFFLOAD_COST +@@ -978,8 +981,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, + rte_rdtsc_precise() - start_time; + #endif