From: Soumyadeep Hore <soumyadeep.hore@intel.com>
To: bruce.richardson@intel.com, aman.deep.singh@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [PATCH v3 2/2] net/cpfl: fix +ve error codes for received ctlq messages
Date: Fri, 5 Jul 2024 08:30:32 +0000 [thread overview]
Message-ID: <20240705083032.2756071-3-soumyadeep.hore@intel.com> (raw)
In-Reply-To: <20240705083032.2756071-1-soumyadeep.hore@intel.com>
Previously error codes were only -ve for
cpfl_receive_ctlq_msg() but now there are +ve error codes.
Hence code changes are made accordingly.
Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying")
Cc: stable@dpdk.org
Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
---
drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
index 39a281fa61..b9e825ef57 100644
--- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c
+++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
@@ -95,7 +95,7 @@ cpfl_fxp_create(struct rte_eth_dev *dev,
ret = cpfl_rule_process(itf, ad->ctlqp[cpq_id], ad->ctlqp[cpq_id + 1],
rim->rules, rim->rule_num, true);
- if (ret < 0) {
+ if (ret != 0) {
rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
"cpfl filter create flow fail");
rte_free(rim);
--
2.43.0
next prev parent reply other threads:[~2024-07-05 9:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240704051835.2630052-1-soumyadeep.hore@intel.com>
[not found] ` <20240705050831.2639342-1-soumyadeep.hore@intel.com>
2024-07-05 5:08 ` [PATCH v2 1/2] net/cpfl: fix check for opcodes of " Soumyadeep Hore
2024-07-05 5:08 ` [PATCH v2 2/2] net/cpfl: fix +ve error codes for " Soumyadeep Hore
[not found] ` <20240705083032.2756071-1-soumyadeep.hore@intel.com>
2024-07-05 8:30 ` [PATCH v3 1/2] net/cpfl: fix check for opcodes of " Soumyadeep Hore
2024-07-05 9:49 ` Bruce Richardson
2024-07-05 8:30 ` Soumyadeep Hore [this message]
[not found] ` <20240705130515.3090598-1-soumyadeep.hore@intel.com>
2024-07-05 13:05 ` [PATCH v4 " Soumyadeep Hore
2024-07-05 14:21 ` Bruce Richardson
2024-07-05 13:05 ` [PATCH v4 2/2] net/cpfl: fix +ve error codes for " Soumyadeep Hore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705083032.2756071-3-soumyadeep.hore@intel.com \
--to=soumyadeep.hore@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).