From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EED045610 for ; Fri, 12 Jul 2024 12:47:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5990E42EA9; Fri, 12 Jul 2024 12:47:27 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2047.outbound.protection.outlook.com [40.107.100.47]) by mails.dpdk.org (Postfix) with ESMTP id F0F6C402E5 for ; Fri, 12 Jul 2024 12:47:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vMfuV2A7a3UvSKU8fyVJvirxMBzhU1o4I6zg7IcrE2CsRNVeDAJucHgFXT1M8IkTAHudRa5s5ymvpMkYcQP94GQCvAPMxl/1blHYnQgko3NnAI4UV/BoulQJpmHGHZlpMLNOqlM4ry2G4gMZWbwvPChW9aEUE7Iq81jHiT23VQSppAVQmdySSOM84ICidvUVVxnS9CAXlDEYYqdRHeAXFVbONxgef9RG8whJUKBFSx3A+rgWpUhf3D5suJKALmngLeEY+vu1ag/lFRKayNDcY1Dv0JPoC6m5zr7r7HVVJPKL2q0NAA6aO+yzfS2SCvBg5vvYrVLqG55Dh54BKbB5Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yGSxv/8Lgb5fvGYAfa/are1Z5HIKVbdpqWO0PM4LmFQ=; b=GSoM8UfG7WRkYiySfgmlRhb6BaSbVcv1cAVnEpunkk9Lp/m/gKJwGwH6SNQCMZevxVJw5Z2O2e5EuuPh3AjSMZUXN0ML42XRHfc3MtryWwiQJ8kwxVhUQ/BtceON1lr32z/VemjjIKpwRxS0ltcJkW3wbdpRN7J6EVADAc6SgaCebJgXbcuRo6/ZFaNqp20BI4Dk41c8ak5UBJ2IR5cR3k7vFca61I2M4YRgpDI6ZzNMbQr7prHTcQuiYYdbXNrOEHDMW2EJ5DMLpP0UOeNQCt9vgvJVAtCgNiP2BraqzIZt0ZlRFcyknx3mengoEpupbRdplkPodaK+p1KTft1ICA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yGSxv/8Lgb5fvGYAfa/are1Z5HIKVbdpqWO0PM4LmFQ=; b=chF9GqrHg1pmeWxCiyZKzfs1sUpIlpTG5bhfRQLsUkJp6iin0BexPE4ggX1RmbTNYKpYqLIUzPx2AW4iCwwSn7qKzCSyD6yZoQ8W/x3QBGdDUUlGkiElyE1pSRdiBafftGX0KeVqEvTgpiXhAnmCiwx1C388VFoGKbLCuJg5Qjjcd+C78TfTr/biV38HhTFUHjDDlNpbvG0Qcv06xJ+KumAZC9a9vsCecq1yfeH4ppM61WH+eF1eerjKqe54RHr6E2nLNPsSIlASWhEe4U3ZqtY65nl9m7lXFRwCZrOHyLSJzQQietMbguHoiNkREQyk5tud6AVBb+gIa5ZLMcKWhA== Received: from DS7PR05CA0056.namprd05.prod.outlook.com (2603:10b6:8:2f::17) by MW6PR12MB8898.namprd12.prod.outlook.com (2603:10b6:303:246::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Fri, 12 Jul 2024 10:47:21 +0000 Received: from DS1PEPF0001709D.namprd05.prod.outlook.com (2603:10b6:8:2f:cafe::1a) by DS7PR05CA0056.outlook.office365.com (2603:10b6:8:2f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:47:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709D.mail.protection.outlook.com (10.167.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 10:47:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:47:11 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:47:09 -0700 From: Xueming Li To: Jie Hai CC: dpdk stable Subject: patch 'net/hns3: disable SCTP verification tag for RSS hash input' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:01 +0800 Message-ID: <20240712104528.308638-16-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709D:EE_|MW6PR12MB8898:EE_ X-MS-Office365-Filtering-Correlation-Id: fbf6e52b-fd5c-4878-9501-08dca2600194 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8PYJAOSCklf8YDfr/pbe4rvlZ2AZfqfQQZpp3yKnip2V6hy5a014rjgZW1Gn?= =?us-ascii?Q?Q0whTqK4KJPS/BCYk0yUpN1KcZ0Z1IpOjlWbTl3Yt1aP/WwyT4SBzBMrVwAZ?= =?us-ascii?Q?ukaICmr63zfhQcjCStflyXqN0kZdb6EjfO+u7yfsvf3eawMCdxU3hmwyOhdN?= =?us-ascii?Q?W3YcFi8a8mSyEib8G2nSjGh1vLEGqHJjKcevljq38F1WpRp7m3ZgPJQYchAQ?= =?us-ascii?Q?wRi4arcY3p6JhDAGChqS/HHXy4sp3bz8xiUSq6LXpxsf8qevm3YuP4Bh6bbb?= =?us-ascii?Q?ntIPXiNyGVyq9HMPDA1GHPSgAconFWLNcWWV7Qe/Ms9mWuYSJQ7JM46g50dF?= =?us-ascii?Q?L9bPgbc2J0TchVXxOqTMvkc/z8II01QzLjKja1Y0vD72427d4q+Kt+iUlNxo?= =?us-ascii?Q?nAo8qs0jw38ofuEAd8j9GF6DHvhGPhZQCnBnI+k7pXVpK3u6vt/S23BqiU4j?= =?us-ascii?Q?021epZ+ACbj4jsBOzXH6Gn+dnjQ6wac2voUr2VPOc9jL/FBF1rfm9/MbaOrI?= =?us-ascii?Q?lHy2XaFVnkEhE/9tzWZqSkTj54Nk4UPLy5aGiDbiX930hVf38ahtO8mIp0sR?= =?us-ascii?Q?U8uGYDBXIScwEWMFPvEHiDNGFwQneQiuIc4AGwbcwjzKqToeJIEGOfxorJq+?= =?us-ascii?Q?JisCoSjxkjkvmbw1/gRb856eOKqBWBbwCUCIfKFjq2Xz3LDNYna1LXSNkbAr?= =?us-ascii?Q?JpnWNv2UwVrr8FEZ6kofs17KhacQlH1qq/KqnSXDWt12jzSRxVffRAZwY3ry?= =?us-ascii?Q?oEQToMDk7mySBKD2jtaD5B4rrhrpKOLbe/KZ5g2F2+4/Ob+0cU7c/Dd9mzO3?= =?us-ascii?Q?OdBx3bc+xj4t1poSA0j4YrlUiJZAuJUIIorJ3GaEwb9hHPXUk/j1U//PWJ6g?= =?us-ascii?Q?YYW9r2HatnWdhvXP86RVUb1/qhuOfyAubmI8snobFZzN9A3StFbFzSvzMJV2?= =?us-ascii?Q?/TraamfLMScpVlE0Lmw0Ct0J0Me8Tt7iXSvK5enm5AoWpqiIy2THExOi0nKS?= =?us-ascii?Q?/aOG4PZsN7dSUOq+SUDj0cQI2E4GuFO5d0Y/qwKtyoxgYdJg/ad8lQX5nfgA?= =?us-ascii?Q?cy5K0UMukd8JcrqOhiDvu92XJ0xqN3DNPRG757JG1/s7hNpcjjKzAW1YdKGw?= =?us-ascii?Q?Ri/AVQ+MzNyWPjdaLNvIOqCg80/c740qGuXmWh4S90qzPblRNu2++Z6k0w0h?= =?us-ascii?Q?rhVdX6/IGYTeFajaWjvhyeOF/dl9C6EMDcElmlgwo7wuUan8v7zHYL1HNaYp?= =?us-ascii?Q?3e+rERR00j97rgjBcsQv1vG1lkDf5nJbe+ycCZa1pzHjnlSZTdbievrcDLei?= =?us-ascii?Q?yDlDr+nzBqugz7ir8k6fnnfIy0CveoVEm9ByqLX6d9yo4eE5DvhJ+Aj/PcIy?= =?us-ascii?Q?IXUTLXYnPnHMBsJjYTfQO6W4jpCtfqEqKPH4J4Wh0m4NzFwWR82Gtsibn5Jh?= =?us-ascii?Q?0SPWoOQBB59VSckBzGafkbLPRBhjLkh5?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:47:20.5123 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbf6e52b-fd5c-4878-9501-08dca2600194 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8898 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=94cdd81ce0bf3175e02bceb5e996f1bc3e7f31f7 Thanks. Xueming Li --- >From 94cdd81ce0bf3175e02bceb5e996f1bc3e7f31f7 Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Wed, 3 Apr 2024 18:16:23 +0800 Subject: [PATCH] net/hns3: disable SCTP verification tag for RSS hash input Cc: Xueming Li [ upstream commit bb1f4717636f5b7d27f4f2fe30469b69d8910bd0 ] When the symmetric RSS algorithm is used, the same packet is expected to be hashed to the same queue in the upstream and downstream directions. The problem is that it could map the packets in the same SCTP connection to different NIC RX queues depending on the direction of packets. This is because the verification Tag is used as the RSS hash input for the SCTP packets, and the value depends on the peer end of the SCTP connection and could not be symmetrically used in the hardware-implemented RSS algorithm. In addition, the ethdev framework doesn't support setting SCTP V-tag as the RSS hash input. So disable it for all RSS hash algorithms. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rss.c | 6 ++---- drivers/net/hns3/hns3_rss.h | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index 15feb26043..3eae4caf52 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -153,8 +153,7 @@ static const struct { BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_S) | BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D) | BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_S) | - BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D) | - BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER), + BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D), HNS3_RSS_TUPLE_IPV4_SCTP_M }, /* IPV6-FRAG */ @@ -274,8 +273,7 @@ static const struct { BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_S) | BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D) | BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_D) | - BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S) | - BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER), + BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S), HNS3_RSS_TUPLE_IPV6_SCTP_M }, }; diff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h index 9d182a8025..0755760b45 100644 --- a/drivers/net/hns3/hns3_rss.h +++ b/drivers/net/hns3/hns3_rss.h @@ -49,7 +49,6 @@ enum hns3_tuple_field { HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_S, HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D, HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_S, - HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER, /* IPV4 ENABLE FIELD */ HNS3_RSS_FIELD_IPV4_EN_NONFRAG_IP_D = 24, @@ -74,7 +73,6 @@ enum hns3_tuple_field { HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S, HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D, HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_S, - HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER, /* IPV6 ENABLE FIELD */ HNS3_RSS_FIELD_IPV6_NONFRAG_IP_D = 56, @@ -96,12 +94,12 @@ enum hns3_tuple_field { #define HNS3_RSS_TUPLE_IPV4_TCP_M GENMASK(3, 0) #define HNS3_RSS_TUPLE_IPV4_UDP_M GENMASK(11, 8) -#define HNS3_RSS_TUPLE_IPV4_SCTP_M GENMASK(20, 16) +#define HNS3_RSS_TUPLE_IPV4_SCTP_M GENMASK(19, 16) #define HNS3_RSS_TUPLE_IPV4_NONF_M GENMASK(25, 24) #define HNS3_RSS_TUPLE_IPV4_FLAG_M GENMASK(27, 26) #define HNS3_RSS_TUPLE_IPV6_TCP_M GENMASK(35, 32) #define HNS3_RSS_TUPLE_IPV6_UDP_M GENMASK(43, 40) -#define HNS3_RSS_TUPLE_IPV6_SCTP_M GENMASK(52, 48) +#define HNS3_RSS_TUPLE_IPV6_SCTP_M GENMASK(51, 48) #define HNS3_RSS_TUPLE_IPV6_NONF_M GENMASK(57, 56) #define HNS3_RSS_TUPLE_IPV6_FLAG_M GENMASK(59, 58) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:14.978124522 +0800 +++ 0015-net-hns3-disable-SCTP-verification-tag-for-RSS-hash-.patch 2024-07-12 18:40:13.936594247 +0800 @@ -1 +1 @@ -From bb1f4717636f5b7d27f4f2fe30469b69d8910bd0 Mon Sep 17 00:00:00 2001 +From 94cdd81ce0bf3175e02bceb5e996f1bc3e7f31f7 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit bb1f4717636f5b7d27f4f2fe30469b69d8910bd0 ] @@ -20,2 +22,0 @@ - -Cc: stable@dpdk.org