From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81CC145610 for ; Fri, 12 Jul 2024 12:47:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B98D402E5; Fri, 12 Jul 2024 12:47:30 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2086.outbound.protection.outlook.com [40.107.95.86]) by mails.dpdk.org (Postfix) with ESMTP id 4BEB640261 for ; Fri, 12 Jul 2024 12:47:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u4BbI4wqHJTuD5ERBtQSQccrATEV2wQTQInbcbV6PavOMXO6Ud4Llc10xCkCl1vwPZXA/VhXppVXsJX42VlX6gtQDHuCL1am9gNFzvpKRPQyNsYbIhzrn/zT+JKdAwTtd5JW9fP88Q2Xc7POU2ZlIKXAGa3fCr2VXZDGTyqxUm/acbM7uH/Y2mE6oYaFnVpYKLzXlFHOcCVgxqfEtNlo9voHtUX2wTWqdsq7hIiqRdOnVh15uujgD+SIQbxHxmXN3uRmqS0LH2woxx1SG54EM0XLICCDnb3oxUURN83JjDw6GaPcY1ZKzJ55vO1ZszP5/GPIfPXqdz2YsoUPSPQ7vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NqkDV4izCGYCmHEOg7xMKao0b/2/0cYRmD7c6sDf71Q=; b=hQaXKiPQfLffVddPfgqUEZuZSUvKzdE8NQMHsyY2FK+OpEaezC+Xmi7zQAGnLazLH2EF4QSMl5INFLWNa7iKI29x9z78BzCzaiiKydyG8ogkOulAVsGlqMDjK8YUGeLQwlIMgnLLQ/X8FH/QLF42RyQcTTESTUoZDzTgwv7gdc9w3lyUUMyu9wnkMFHdRt7SNQCIGZIOII9tzG7uVCQ8Vsc5J0Z8tppwVVvtzI2wwa52U6P15ASU7KbOPfMPLv2ir1i6aZiScP2QSzd9FoA6VJ3fSC/JkYnp9iq70msR6uC6JO0fKq3/AaDQ5fQU8LbrEqEjeS40ryC7cH+TCL0Scg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NqkDV4izCGYCmHEOg7xMKao0b/2/0cYRmD7c6sDf71Q=; b=qhzGhp3TZu4BBnpg0SZM9zoKeFgawixJCGY2JTfoAjppfOYcgA1pfaC6sDvM+59bPK7VLC3PGSJvaAdHtyg6nFILwMDrckLmmqDu2VBLzkmUSCS6CAbfXBeiljCAJHyc8VAq9wqfq3GBUT9x9Pn3Z3a37RQ+YKrARhHCm9eUZXmxTokSRJE4xbUbXbBa8KaQSGjUj0qEMJyWMctR0jqptlI/USCtFzYQ3GlobqPFyhDe4ts3dCfpUQXglf8l6l9gTeNnQv6PkNFjy6gQ8oGyc5JwMLo75kF7OW4d/FQGJF72IpF7Lo8nvaO45mI95NiDGcaI5Myb2quCws776pY7HQ== Received: from MW4P222CA0023.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::28) by DS0PR12MB8295.namprd12.prod.outlook.com (2603:10b6:8:f6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23; Fri, 12 Jul 2024 10:47:26 +0000 Received: from SJ1PEPF000023D3.namprd21.prod.outlook.com (2603:10b6:303:114:cafe::27) by MW4P222CA0023.outlook.office365.com (2603:10b6:303:114::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:47:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023D3.mail.protection.outlook.com (10.167.244.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Fri, 12 Jul 2024 10:47:26 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:47:21 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:47:19 -0700 From: Xueming Li To: Ronak Doshi CC: Ferruh Yigit , dpdk stable Subject: patch 'net/vmxnet3: add missing register command' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:05 +0800 Message-ID: <20240712104528.308638-20-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D3:EE_|DS0PR12MB8295:EE_ X-MS-Office365-Filtering-Correlation-Id: 70f6303d-d29e-4192-d00e-08dca26004d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VARS0xxFeVft/MTWmxX6R9mDJZaxLYPJhA44ARbIg1dJO7F9gJfLP7SylDEZ?= =?us-ascii?Q?7rARD8Rx4aTy/aPPek6JdOF2gFrsQreEJr+yiNud8guVP/y3rRooKovjP2Kf?= =?us-ascii?Q?cUpVX7QO1ovdBMbMxASn8LY/aQkzJQ5SI29OCTYZbIc9cJ5czLALvwuMunhH?= =?us-ascii?Q?Wxz3swarxK8xwJZsWKgB7x/Z6wzDmG8gSdgR/oHmplkuz8QHfLi1P/Ut9q74?= =?us-ascii?Q?mNE7yeo9XyA0b2dN1quCv3zP81mY9d/DfJL9gzhgV2ThWZRTUNqFjerODNU1?= =?us-ascii?Q?jzxFu3MKP3KviOiiJ6AaFraxMJ0hPLR1g9YcmgNCjneZ+H0ojrqjmsGu2uqu?= =?us-ascii?Q?oxWOt9jvOZDZ0WEj6bP53cklJqbj6DU2TwpDcMRHE2yXInogeHqPkx6F32Ec?= =?us-ascii?Q?zaV1MEACIR2dpqSCoe52yffiQSQli418dBy/RDX6L0kdnPeQjrjCGGIWHP5q?= =?us-ascii?Q?8lmGPDe9YWJ/uVKgOGROqqgaol/oI40ojF3PZYsQXsluOgpohFVzuuXBkajQ?= =?us-ascii?Q?jxvLX8shfpN54wO9qR65xhkOaVu9cIHlfCo1ufk3qCA3qcJe0CLCNtZGNdCZ?= =?us-ascii?Q?OZC36olDZqHe3C/RANnEVre7DEq9QWTGnomFxph3J+PENen3bruNDMV6cqPZ?= =?us-ascii?Q?iGyOHz4fyJ7tUmliUEkSJlZk+a23UhGp2KZrk7/iinHvltU90jSBU18CdGTa?= =?us-ascii?Q?Lqb4k6Ly1WXN2TvBMoeqzqEStVcAMofEv50GoAuNh0LAdYM2/gs4BHwqlT4m?= =?us-ascii?Q?AjBm6TTl2MmADm4Iks5GA+76bphKxDmZ90hNAiSUmr8SP7dpkWpP8CZdJ/T3?= =?us-ascii?Q?DnDDctobDg8R+n3y9Rpse600UNkdoK6N43VIzWGUiZTnkgMB586ZzhVHC2sa?= =?us-ascii?Q?kvvB9eUNQqZ2kQI4T14K7y5eZ2IMoTIGxycN5MhU76g2oH6PRImJhyCqvavB?= =?us-ascii?Q?Hqth9asqEBN2tkWDZB3G9tWL4Iu24TPFwcCE5B6DHvdRslkABzK8vyfal2Qh?= =?us-ascii?Q?qEWp3w1/qUpSWetI2lUKUY2+3m35qilNLsVEpyQgospvf3HVa2wJqVHueEcg?= =?us-ascii?Q?c5qsKOAPAzA6M89z7b0a2LWhmXBO+DxQQyyUq9tVRnQTt3wgMsnG1p/3jNzF?= =?us-ascii?Q?ax995UFpbTLnUYXFJusEoJI0JsGx2NKHuLO6L7hOtsQ5we2uaiZ12EnFoWjG?= =?us-ascii?Q?t7UgXl1tEW5sz9d7uBrKBIWkV2097cR5BLvF7mVF5ri3yY3Pp3y++D4TIYeW?= =?us-ascii?Q?gGi/xAmcvRBoYZEfYlqtZa2GYilYLi7DEK1GHC3kXmyK3200BQIkO+f+CcBk?= =?us-ascii?Q?eHF7lBBabY7euiKw4rwyscjaUfYFdYJtVKuVDNTc2vEECUjcTMAXGQm593wT?= =?us-ascii?Q?vGJU720aoq4TrSBYe04NKexzhtWSAbsUqHtHF6ALB+KOZfLrd/3TUZ2CkDBF?= =?us-ascii?Q?AEgqNlmP42yPptpYnW7karqBGJYn88Cs?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:47:26.1136 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70f6303d-d29e-4192-d00e-08dca26004d5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D3.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8295 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=57d6e27ef584849a3759a26b9b9c891437ebdbda Thanks. Xueming Li --- >From 57d6e27ef584849a3759a26b9b9c891437ebdbda Mon Sep 17 00:00:00 2001 From: Ronak Doshi Date: Mon, 22 Apr 2024 11:10:50 -0700 Subject: [PATCH] net/vmxnet3: add missing register command Cc: Xueming Li [ upstream commit 5296276e4b86db7d3a77ac5788d15fbc8406d501 ] vmxnet3 uses capability registers to advertise the supported capabilities of UPT device. It uses DCR0_REG command register for this purpose. However, the register command enum misses one command which technically is not used by dpdk vmxnet3 driver yet. This can cause issue for commands added later. For example, DCR0_REG and MAX_CAPABILITIES register commands when issued will lead to incorrect command being executed in the hypervisor. The return values can be unexpected and can result in some capabilities being disabled and affect vnics requesting Uniform Passthroguh (UPT) mode. This patch fixes this issue by adding a reserved command in its place. Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers") Signed-off-by: Ronak Doshi Acked-by: Ferruh Yigit --- .mailmap | 2 +- drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index c6bf385a59..db6bc47117 100644 --- a/.mailmap +++ b/.mailmap @@ -1216,7 +1216,7 @@ Roman Kapl Roman Korynkevych Roman Storozhenko Roman Zhukov -Ronak Doshi +Ronak Doshi Ron Beider Ronghua Zhang RongQiang Xie diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h index 24c235876e..a6bb281d8d 100644 --- a/drivers/net/vmxnet3/base/vmxnet3_defs.h +++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h @@ -126,6 +126,7 @@ typedef enum { VMXNET3_CMD_RESERVED7, VMXNET3_CMD_RESERVED8, VMXNET3_CMD_GET_MAX_QUEUES_CONF, + VMXNET3_CMD_RESERVED11, VMXNET3_CMD_GET_MAX_CAPABILITIES, VMXNET3_CMD_GET_DCR0_REG, } Vmxnet3_Cmd; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:15.167873900 +0800 +++ 0019-net-vmxnet3-add-missing-register-command.patch 2024-07-12 18:40:13.966594244 +0800 @@ -1 +1 @@ -From 5296276e4b86db7d3a77ac5788d15fbc8406d501 Mon Sep 17 00:00:00 2001 +From 57d6e27ef584849a3759a26b9b9c891437ebdbda Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 5296276e4b86db7d3a77ac5788d15fbc8406d501 ] @@ -22 +24,0 @@ -Cc: stable@dpdk.org @@ -32 +34 @@ -index de326949c4..cb8d65bf0e 100644 +index c6bf385a59..db6bc47117 100644 @@ -35 +37 @@ -@@ -1229,7 +1229,7 @@ Roman Kapl +@@ -1216,7 +1216,7 @@ Roman Kapl