From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BDDB45610 for ; Fri, 12 Jul 2024 12:48:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31AF3402E5; Fri, 12 Jul 2024 12:48:32 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2072.outbound.protection.outlook.com [40.107.236.72]) by mails.dpdk.org (Postfix) with ESMTP id 04026402E5 for ; Fri, 12 Jul 2024 12:48:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sh32n+XeyiSAeTUYEBux12teobUOWwvOL8f1w3ut0gYQxMJamHT7HP79T/KbS4ZCoKMV3QgePsN3gFAe6ixZ+AcImnPxkARLT9Fbzx7Ee3ZrnHY2DZ9uu8vGeZFWg2nPP7+Lh3p4FKqvDjveRXKRWE2c7KPXF79ZZgaspqOS0jlWydJ4WQ48kWMBeAjXdWxjx2K2IdW0Vqw4oXQrBW/KkTs41xrCyZRLHUXrNcDbBZXH2dVaDumwzMwTz+ImW//Wvl2IYNOmyXzwBui8ZjZNN88C3+SfhYus4MYSTrIj2ZgLEheO9EJCVyu2JUSaQW8oXbuGl2jIVV1PJTMoMNfKQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zLeIsdbrhX0nQ64CZkRUGM3j9jGfVhlVH0Gr/QZFgSM=; b=X5l6p7qwR6JzSqMlXvh1UJZqVG17E3f9zGiv5FXdYwn7xh+2N0Kz8gWwdn3tH+Rq1ndOcI3epQLX67RjPA+gL0Vozhac0z47VYjT9r44/W1U7qziUQ5EqvJVaZJN2YcCTSNHbP4cx82MQJNoUKY+gCVrtbcY7w6F9crbkLukcWuLhxOMr/uuIGERcMZfp822cA4xxjcPjbCBfVvasYU7Fdk4y25qPSH407j3jRUP5EshUOYZNwH+mtqxHIMnUDfp0AORecVz7JUchtHmRdxMIZBmeMFRaNnfqqHYOq3lNTjn0ZD7XIsV3LZA8XvA+YDIvrBgHJfjiskdUlMylDQ1Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zLeIsdbrhX0nQ64CZkRUGM3j9jGfVhlVH0Gr/QZFgSM=; b=dKTy6yt290/aCUpylk6NO4XW7wplMeeAceRLfTIjueJCG6qKrCMBTbrqcFwehIvXyiHuf/sdybzxcyacueBKmATA85YNVgpZ7VK92ghdU319xndtk0Q5ez0UovFBj151qA8FAom1megqJOOx+55rqpffW6lpGNFDZ4QvurMui/5KCBXIGd9ohGfDYYYHAwis7TQP8fkarld7oQucRnkpVo8nUvLPhnGxu9CRhU6nXXkr/B5q5eclvVkrR87++Md/f9e9sKV6PhJY80k/0WFRwSLuDzt66UVaAz1TOt7ElUs1wZ2oQTQsfbEQPWMVlntHtx7Szicfb+eTSuTw9TU6SA== Received: from DM6PR07CA0075.namprd07.prod.outlook.com (2603:10b6:5:337::8) by PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Fri, 12 Jul 2024 10:48:25 +0000 Received: from DS1PEPF00017096.namprd05.prod.outlook.com (2603:10b6:5:337:cafe::8c) by DM6PR07CA0075.outlook.office365.com (2603:10b6:5:337::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:48:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF00017096.mail.protection.outlook.com (10.167.18.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 10:48:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:13 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:11 -0700 From: Xueming Li To: Ciara Loftus CC: Stephen Hemminger , dpdk stable Subject: patch 'net/af_xdp: remove unused local statistic' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:11 +0800 Message-ID: <20240712104528.308638-26-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017096:EE_|PH7PR12MB6466:EE_ X-MS-Office365-Filtering-Correlation-Id: fc7f7185-e1ce-4060-864b-08dca2602833 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dgWlkgjlJ9DpPABsbX2mhgOZ7jDHGp+VZbGTvJH2RrmOMNWKoeH5NutFzd5D?= =?us-ascii?Q?Xbh7Yl1KntilGRFjsym2+STLQ6iq6+X4FjFo+UgfDRZgcUJ3awofac3c5wYw?= =?us-ascii?Q?nnBhPj9eVVXujhseF/SdWVYyhQm6grPauU7op6kA0RiyHU4ybt4GfCfPc7N+?= =?us-ascii?Q?c6GPXvO+wL4xl+DYJrT85BeKHHhJVu28gz1ph82AJieZK5NchyG8VvcD70i2?= =?us-ascii?Q?fdbeQW4SUWj7I4NFyqQqAT4xEBeqK4mPjABZh4ZjwjMl7AyQ6WIpFkemndCC?= =?us-ascii?Q?IrpzO6GfRgpca/wbATXYK19/TnVv41KpTzCRBncIs83NRJmmlOQnhoruDGWO?= =?us-ascii?Q?nULtxPDTDq3fvuWz1av7sGSJQuPZGyWzARizuU2gKtr0O3qjeJufGxoP1vsx?= =?us-ascii?Q?zIbLQsGn8i2ak9fnxzrpAqJDTepiPphOkSP7K5Ju23sivPOMWA/Yqvfp8XJ0?= =?us-ascii?Q?PqDhNWxDMSyU8I6OFLJcr1p8lxeQK4kZ6+Q4H07QnZ6jlRivCQmvkP/WEhTT?= =?us-ascii?Q?vdiPYT7tYU4+fdfhzVPVx+aidnfiDuSAtqsf0lBwuSvcIuJr4VWbGFZ8f4r+?= =?us-ascii?Q?tP4sNlgbb7aY646mrPyGIQFI4K9DvZjYgN5hwH9zJiAOQmZkjONqcomqepK1?= =?us-ascii?Q?fEC3AfThjDtxIIts5EayJbs2AoucvC+mPbyv3OI6q9YSSducj43JYEYvQJWn?= =?us-ascii?Q?xj6ksUlXkSFJlCvTZoAytgVJeRpJ2dVHybAq29cKt1tuO9KJGFnMGKB15+9G?= =?us-ascii?Q?XBxTixvlpWkcRQB9EZqxtM4DldDuwlif+Bd1qEaMLeKOTYU5UCINhjqwUH97?= =?us-ascii?Q?mwB44qB/7Xfe9rYr5WuMC0nxcKbErLhTI7o9Dn4ThO7R3Z7OXO9uPYb4YH1k?= =?us-ascii?Q?1tZjYckFYPJiC1bCFvxs2t7f/9ipxpYqFRd3gg1XecK2Z64vghxtBZO7UCQJ?= =?us-ascii?Q?CkdR7MHIZ3iyCvm5smclGvM0n3IVHr2UY4IfuUgARLe2TA6X7qsRt1OL+6Jf?= =?us-ascii?Q?ylmFhi25ZvAjOj6/ZBpfesJKyP0E0s8jq8QytizlHW4vdL4rHGKR1phKZ1PK?= =?us-ascii?Q?PwfWnediE0UQ1ik2SFziHaPNno/0FNzGikXc0CMYZzrUITJpwDH+D542hLH5?= =?us-ascii?Q?1wmJZJ4KCvhc40Q1BD7ITPZDlL3LLwFuJkypb0F3u5023nfuP84gLE1+cB90?= =?us-ascii?Q?7q30io+vDBJZA7/gJgBRlSXrLUA2JZapR5MkxXOlPf8qBBGf7MrT6YWaFzWH?= =?us-ascii?Q?WZQtW0U2Hnwj6Ml0zvRq8tfCiMOyz+Xc0V04VyIl/K3Rg98xi4Jd6ekhh7Zl?= =?us-ascii?Q?ggjM0O3neR/IiR6yTJX7bLcpMenc5BRbH9F1gLCi8gAVksg0jJbUl9W8QpXk?= =?us-ascii?Q?jOJrz6ZHLY3Uor3e6ej76FiIPM6qtU/aeH9Ad9e0/mZH9+RvDc66US4ixVyp?= =?us-ascii?Q?ekyHI7qvNWqs9foI51dIGbjPLZ1aGS3o?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:48:25.3074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc7f7185-e1ce-4060-864b-08dca2602833 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017096.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6466 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=a8b99ca72bb63a2a32a524c290cd3e224dddc4b9 Thanks. Xueming Li --- >From a8b99ca72bb63a2a32a524c290cd3e224dddc4b9 Mon Sep 17 00:00:00 2001 From: Ciara Loftus Date: Tue, 14 May 2024 08:41:55 +0000 Subject: [PATCH] net/af_xdp: remove unused local statistic Cc: Xueming Li [ upstream commit abdabad636a54660f4a260e1e9dc573900582bd4 ] The rx_dropped statistic is never incremented so its existence is pointless. Remove it. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus Acked-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 57759e2301..74f750dbb3 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -124,7 +124,6 @@ struct xsk_umem_info { struct rx_stats { uint64_t rx_pkts; uint64_t rx_bytes; - uint64_t rx_dropped; uint64_t imissed_offset; }; @@ -880,7 +879,6 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->ipackets += stats->q_ipackets[i]; stats->ibytes += stats->q_ibytes[i]; - stats->imissed += rxq->stats.rx_dropped; stats->oerrors += txq->stats.tx_dropped; fd = process_private->rxq_xsk_fds[i]; ret = fd >= 0 ? getsockopt(fd, SOL_XDP, XDP_STATISTICS, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:15.403713471 +0800 +++ 0025-net-af_xdp-remove-unused-local-statistic.patch 2024-07-12 18:40:13.986594241 +0800 @@ -1 +1 @@ -From abdabad636a54660f4a260e1e9dc573900582bd4 Mon Sep 17 00:00:00 2001 +From a8b99ca72bb63a2a32a524c290cd3e224dddc4b9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit abdabad636a54660f4a260e1e9dc573900582bd4 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 25e67851f6..4b282adb03 100644 +index 57759e2301..74f750dbb3 100644 @@ -23 +25 @@ -@@ -125,7 +125,6 @@ struct xsk_umem_info { +@@ -124,7 +124,6 @@ struct xsk_umem_info { @@ -31 +33 @@ -@@ -884,7 +883,6 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) +@@ -880,7 +879,6 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)