From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92C9B45610 for ; Fri, 12 Jul 2024 12:48:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C67C402E5; Fri, 12 Jul 2024 12:48:39 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2074.outbound.protection.outlook.com [40.107.220.74]) by mails.dpdk.org (Postfix) with ESMTP id 686BB40261 for ; Fri, 12 Jul 2024 12:48:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nig1qlvay2NndyL2q0zCmcrvyEvLEOVjNz1bUKKh3HhDgIwIqpC+EEPT50H8XKCPVJvrUnWer+3n2hhkJF+twGs9jqg3pZAp/9R/3OWE3N+j1U8a232gBzW4umqidBfXW0PekP7hGkV5jOnr9HfAWr5YdvoUFNfXcKh/3DnklCNCTMtMgb1r0DpnRQ3X1GgqDUcYTJrjYEoXsAG4TVEowVOz9IrUfFLegVNm+e+i7+BANRnJWJiD0XKaijt5AKcjCwa4URNxZUkZQQqcPy5PrybjfdVfV0OVnjD6x704EfLWe2YqKDktsW0FOe6VZHupmK69CFncPLx0DHZIxaJFFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iTlUtxoYGEODSa4wN5NPC2WF2Ag/VgZxFecPj5E6a74=; b=UWCJZJ/JnHHDaeclV+ydtAoS02k6i4GNM7e9qbpIWkzcJbYch11mEv/qM4Kwux3n/Do50gmarzOzihqhfEK5yczAehdb0kP6j7gXm5fz5/yv0e5B0oRgQhSCylMBAcSijkxJJ9krRjNx02QO1LGG1TsIFXChEMCXGovOSMFec8730l2RGApymfnmU4sZnxX4VthIcLPsa+1sunDyd8OYZOfzEjNfS1HROsM8514zYsaqn1VLICQrMmg+T4474v/+vuBBxknckE6D2HKHGcTQ31WErw/Wlb6mqRlSyOI2zeFg85ClymH9m6lLzgIUtaFIAL7+8ysJ7tPtj4pfJuo/Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iTlUtxoYGEODSa4wN5NPC2WF2Ag/VgZxFecPj5E6a74=; b=gtzqTvdWnjp3Ro6OZ4aYUrIM5q6qmrtAm/0EMwq1Y9K4oxR87vj7xI3vZiNCMqkdgtz8Oh1oAy313Ta7zN5f+8fvQc2B9y/adQSiwNpldOok9Ck7OZC0Du4EZy23tHx9vxhkTwoajZ1i56dEtDZNsw9Kt2G3hOvrtbSM68XRs+838Je5mPZnzJtrZX9aFMtcrVmKTsQU2CvBoo84ydZ9GhbbVB/3cZMHFLYjnMN6aBxH8GpJyM5blwRQpmMKd7AHBKP0A0YszEe6FttxG/FOQKpPL7XHoAOwXkYDN+xxMzbG6I6HGVZ+j8Gq1z7E8CHPMOCS1UErNd0ZOSgngfN94Q== Received: from DS7PR05CA0035.namprd05.prod.outlook.com (2603:10b6:8:2f::18) by IA0PR12MB7554.namprd12.prod.outlook.com (2603:10b6:208:43e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.38; Fri, 12 Jul 2024 10:48:33 +0000 Received: from DS1PEPF0001709D.namprd05.prod.outlook.com (2603:10b6:8:2f:cafe::28) by DS7PR05CA0035.outlook.office365.com (2603:10b6:8:2f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.8 via Frontend Transport; Fri, 12 Jul 2024 10:48:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709D.mail.protection.outlook.com (10.167.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 10:48:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:20 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:18 -0700 From: Xueming Li To: Stephen Hemminger CC: Ferruh Yigit , dpdk stable Subject: patch 'net/tap: fix file descriptor check in isolated flow' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:14 +0800 Message-ID: <20240712104528.308638-29-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709D:EE_|IA0PR12MB7554:EE_ X-MS-Office365-Filtering-Correlation-Id: b666e18e-5c04-4ce1-e089-08dca2602ca9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9M4hyrIWQsgj79JVJBsUY+tBtL1c2WRZGA75GvMz6jaf6TbFUPSvcZYD+od4?= =?us-ascii?Q?RrVLsCASRkq7H8N1dt2gkuHdm+6pX30D54Hj5/gPxPbfG9fRmP8dVLkGyORF?= =?us-ascii?Q?lbya6TjhJ0yPJnXE5aPYA/80UUGju6BMhUW7GDjamel1eB2ggu8G6bhxTay5?= =?us-ascii?Q?OUBQhbDJeGelnjpiWUzqm9VkiN8/1+vJnbM1aM+3Jy6ezv3XY+a2QCfGxAHb?= =?us-ascii?Q?BTP1/AorsSdSZ4mEdpf3zX7U6NsaR9tywLGLqLLQhYDhXed3NNgJGjkyKPs4?= =?us-ascii?Q?XfWJh/SJWY8ZcppERHYethdF2ZrBtx3QUsMa+bV8SyHBy91gkUYDdoXBNvMy?= =?us-ascii?Q?l9MPZtSZnZ1SSON876uliOm/ZnK2koKY0CvpNhHATSpxgGPG4FrOP9YTb6je?= =?us-ascii?Q?z7tOQVyUI2rA9OBHs+/mKEZycUscMAPLTxGioD4tODmHrE8tmX8jCk6ykisj?= =?us-ascii?Q?6oQ87V3y/PLake7yOWqa5ZGW37NYUx9knrMiRLbMEgKPRsd7nuDn2GFwVhBv?= =?us-ascii?Q?sWB/Ri2/OQpPNCDUVuIRGU8GHkalsPbfYQSZCuBXOugyzaPbcYssZBpfb61j?= =?us-ascii?Q?5MsGd4ptK4z1dqf+4MwQ80YyxJONoOYLTq/u523+QK9VIen4Y7d+rUAwAVBK?= =?us-ascii?Q?OCMeocYhTgp/s6lGQmoos1xEbxS2lDh+1CA+NT7hhBu7zzySW1V267nEwMKm?= =?us-ascii?Q?0ImwezMFhrILbDii/VSn01ECrG/3hsTWVjC3AhJdPhtHaNt1AToz5HXK2akP?= =?us-ascii?Q?hORQ3eCFp/jVn0Veqo+FUS/GbacEXhjpoZCNSXm72LCY5t4+GSjP2BjsclLS?= =?us-ascii?Q?iwhGJ1GldCaa07gHMNcEEHYLkzXRIDPEyvk7H6W8vjcbaZhPUR1Uv+/ypTLs?= =?us-ascii?Q?ZZOUL1Bd/lTxmj8zV6lveea8XE+6gGJvfCvScbCPrHgmksFzfl5H/YyI4+lx?= =?us-ascii?Q?KNAQQlq5ytRKieRmnvLvep20s0IpRe4IBGnGxAOsOlxSZwWbmTtfaE3L7miP?= =?us-ascii?Q?UOhdChBwCsFjD+j86icnorz39e+vSz6dMrb0EznnZIOwzo/MrPbx57rcS7Eb?= =?us-ascii?Q?xjAzTOBNoJPiKGJQA+8H7MlGRnk5V1+n6WUYzPSxmhVMy/9zixTUO22zBV3I?= =?us-ascii?Q?26WU8L35XFEDhIQXB9e8IJsIksnd7C8dI1nhE2nl6O9Ar8CaX0o0Kfv05JMM?= =?us-ascii?Q?JbpSKlkiNja9u5NQl7rJCta1QWkYiPgIzIaEkUHK2zW14yi1CUKwAMV/Wom7?= =?us-ascii?Q?Ng1DsXiv2vBBGe5YwdmjvkTPO5VqvggsObSfWNUvhKrEIzTZqPWWQyGR3wdV?= =?us-ascii?Q?7uteS2/GvLtW/bSlIMaJlU4+62MgpenYIF88Bl4ls/Ip0n6Nrug4GSl6lPBq?= =?us-ascii?Q?2X61hBiaBDIuGWT72AnNgBXEvlYsmFV2+G/s1QgjGFtRliUtyfAGvDoVNgey?= =?us-ascii?Q?7gKQ2sU05jMbDCikI4O1TmCtl26xKe5Z?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:48:32.7939 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b666e18e-5c04-4ce1-e089-08dca2602ca9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7554 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=92d455764ca76de41a9d148838c6eb2eb1bd6579 Thanks. Xueming Li --- >From 92d455764ca76de41a9d148838c6eb2eb1bd6579 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 21 May 2024 13:12:46 -0700 Subject: [PATCH] net/tap: fix file descriptor check in isolated flow Cc: Xueming Li [ upstream commit e9e6089a41c275f3dcd7491f4df903a284653bb9 ] The check for receive queue FD in flow_isolate is incorrect. If queue has not been setup then FD will be -1 not 0. Fixes: f503d2694825 ("net/tap: support flow API isolated mode") Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/tap_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index fa50fe45d7..79cd6a12ca 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1595,7 +1595,7 @@ tap_flow_isolate(struct rte_eth_dev *dev, * If netdevice is there, setup appropriate flow rules immediately. * Otherwise it will be set when bringing up the netdevice (tun_alloc). */ - if (!process_private->rxq_fds[0]) + if (process_private->rxq_fds[0] == -1) return 0; if (set) { struct rte_flow *remote_flow; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:15.500910360 +0800 +++ 0028-net-tap-fix-file-descriptor-check-in-isolated-flow.patch 2024-07-12 18:40:13.986594241 +0800 @@ -1 +1 @@ -From e9e6089a41c275f3dcd7491f4df903a284653bb9 Mon Sep 17 00:00:00 2001 +From 92d455764ca76de41a9d148838c6eb2eb1bd6579 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e9e6089a41c275f3dcd7491f4df903a284653bb9 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org