From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E986845610 for ; Fri, 12 Jul 2024 12:48:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0780402E5; Fri, 12 Jul 2024 12:48:59 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2083.outbound.protection.outlook.com [40.107.236.83]) by mails.dpdk.org (Postfix) with ESMTP id DF8C940261 for ; Fri, 12 Jul 2024 12:48:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GRfh5QJ2SWn9i9YQnYm2xej3uihw+rCHGYXFUvjXxrLZCh6jXhCxPCcGp7M/KIzyIIWJeeS+4+vYMvtH8AHWeO+LxQuDIyZCFnp0o3O+xDXzvySc0Lj1t35ifnpQYM8qNltdlBIr40W9rBgdhm3aaDbF4K/4rCPIoaFQlgeeMWlb5aKCpz42ZG/F6GcNYKy09wyekqiTYwOZAs6bnXv1m93RSLPEXjOvdyo+srC91vea1CRSaf1JZrTNQAVF+aHZPOiKrIOn4WqnJIEvbNLicGR778cwSbs/uZDO/hoBwuNcffRCCo+HNVjSFesyPMKQ+sunzSjpgSeFJ2NPE8KhRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNFOLW1i3RZECpzBGV/uPTPIKXK6c0+6AXwh+gkw3Y0=; b=Tm77csSGiJdH1cEDXpAJuoSK/2yEYzDt7lXOGDAxTyYBa6dpTa9ripe8GX/br0o+QBKD8rafdtehsao92GRlCwWwphM32L4dP/5R3yDVQ1SibfOLmsF/r6dzqD/F0XYLzHo7VeMgfcy8CNjNuMpl/BK73T9Qo/NfmBsU3YTnePTnxIk46n6cL/qboA/yw/917VZv/O87kg9owWa3xMtM9+QYbPJzSs2LmiKXc4/QagYsAMeHJ7R928/ngs6zTYzvqH+89NWQSMlyctnFG5Ubx9vzOtyNhELHhbbTNJnOCbaY4iPkIaDZKUPcH7nHeh5K+f/chY1qauuezdkOdNjrzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rNFOLW1i3RZECpzBGV/uPTPIKXK6c0+6AXwh+gkw3Y0=; b=oL4x35LUysrh383mufPqjUo8EdBCi/wuQ2vNG6QFg/pRNARYzbFI+gfyOceuCNgNej+d136PBzIKCDQAV7tUoKELoI2F50rgo940O3ZDIjoEvHLeC5rSxng47F5rhBt6x0DE6uc9UCXJcyDxLmW63V4boh8/JTxFSrkiAmiTNDP+g5NN5Wz0G0OWh1BH2mEmBlwB6deWg4KWyYYs8C3V7cBV2Eove+6inPoeJ3ibJ3OpWe6s3A2XygErzV4EuLASFKZqQOo8KnbX0ruu24USHR7lizb8Avbw2eZC9wZXs0oHrO1pQBTfZjkvUU6WqNWs4mTZMMoU6zA8Ned+TwMqCw== Received: from DS7PR05CA0046.namprd05.prod.outlook.com (2603:10b6:8:2f::14) by SJ2PR12MB8979.namprd12.prod.outlook.com (2603:10b6:a03:548::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Fri, 12 Jul 2024 10:48:55 +0000 Received: from DS1PEPF0001709D.namprd05.prod.outlook.com (2603:10b6:8:2f:cafe::7e) by DS7PR05CA0046.outlook.office365.com (2603:10b6:8:2f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:48:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709D.mail.protection.outlook.com (10.167.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 10:48:54 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:43 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:41 -0700 From: Xueming Li To: Venkat Kumar Ande CC: Selwin Sebastian , dpdk stable Subject: patch 'net/axgbe: reset link when link never comes back' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:16 +0800 Message-ID: <20240712104528.308638-31-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709D:EE_|SJ2PR12MB8979:EE_ X-MS-Office365-Filtering-Correlation-Id: 62c75f62-e220-4662-bf3c-08dca26039d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Frtcl9nL4h8ePJ7fF1vYC1b8kzygC34UgJJM+68cJmujZM/SkA9ljA5kZOtl?= =?us-ascii?Q?//rmeSRVup+9qsNFI8ueXo6xtWcmeiWkO2NMK8rDUd+aGvMxBCE7//g+1Dbf?= =?us-ascii?Q?NjH7KF3bruK89cbyNBx/gYXnhHMbS6uZQH8z4gQ10zhPMJZv2PFX6Di20ylU?= =?us-ascii?Q?pZU7fcFDGbsTbRA//+jk6lcTiT9a2I7mcMugomrTaST12Y+JI2qVtkFYdzgR?= =?us-ascii?Q?mVcnTPjLc+O2DfpjP/SU6wIX8Spyh4ja0s53DpjSQyIhAhTuYXhtKhqzHV9G?= =?us-ascii?Q?ByKQYeJd0kiQerr0K38FoWxRQqjekBwXFKVSet60n+TPY8AwVDXOEvTx3+7D?= =?us-ascii?Q?v2BGu7CqMSKYtkXOnL4L5mLHh379PUas67VD9ISeUEAubQ7NQr3g2QgvIKbD?= =?us-ascii?Q?UXcSaLxYi6PzceJfqEsf0DcMxYmDKNtb9q5VntwruEU41o3TS+M155tiSGHS?= =?us-ascii?Q?nbJIHaQKuO6XgCJ1bvWCr2ER27ly8KpTyBd2E8TJ79R+2PDWo7WjIfcItmpw?= =?us-ascii?Q?H7UnEm+ItpJD5cYofXb/TWTJPqcR+eLz0Y7oxzmpRxYcaptoU0EGDg7NvdhB?= =?us-ascii?Q?AVrQvlyOmnYSQVfRykZVdU5rTJqaAXHduaE4BJoCiRkd9A0bNYwY4lOTvRmB?= =?us-ascii?Q?xFw/L5pzneErH9WNdlwgn9+sUVPlw7Wg9M0Jeor+qjRTCMLxmAURDOb+aMpB?= =?us-ascii?Q?8FzruM+P7eByAbz+SOETNVOFomhrAzcasMsB9D2fox/iwAYDemfYayGs3A1A?= =?us-ascii?Q?xjk+sWGGyHgydZZK2U/7KiALk6CNTC5aNG5EQeSmLG/Rzt0gCYMr8XJR0fqz?= =?us-ascii?Q?CJwrXF78dsmYVXOXQRcMMoKIxnEGR1zQj86A2YEoE8y14HFkxaa/v0pq84OR?= =?us-ascii?Q?7V52rWp62t8SHyzlRXqLs8gJeDFqSnSiw2sVYCWo3ICLxfR5qkeJ7pbRqdlY?= =?us-ascii?Q?t1J9Z+ydE113uNjWhGMLwQ9/lqoYUiGuqmjg4JOJ3cQm5RD0upeeI84Khb6Q?= =?us-ascii?Q?x+Vg6cjNopY1v9WxXlCu8+OUuD78A6mhvlX4ub9FG+Ho4eP2JrRjlbZLCW07?= =?us-ascii?Q?etwWjJgSdeDni35ypv/J/lP1FB3irEIHI0vd2SDjmXc32UvxJvowjNhIxzD1?= =?us-ascii?Q?/Oc3kxpPEI4ehh1nq/0YqRU2KVGMFyniUHJPki/KjBafmaB6PstzSQtf39zY?= =?us-ascii?Q?m3+HLv7/6q8rmYPaZnmOoLEUjuSYWdkc3OLHwRblKO40a+XloV/QqITLVyyF?= =?us-ascii?Q?ApS0+4FtxcgsI7P605BAtaC00FYnVaFmskamVQhq1lJhgx3oDj4E6X7PwmS8?= =?us-ascii?Q?8sKUaHYRGOP8KQ4v36OV1dzYk6GjEsoIYc/pgDiaudh0og0ph7p9SMN6Y+qD?= =?us-ascii?Q?6LTF58b4oc99YjRdzAvet3dVUpqr4MDpgkKn2OmGKIQjxTRMdceGQlcg2UKA?= =?us-ascii?Q?rUbYRQ4H4jgwl7vTQXfQ7BDX8PZuNwEM?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:48:54.8721 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62c75f62-e220-4662-bf3c-08dca26039d2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8979 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=1392a3469283f3e2dc6753d4d02761f1979a5047 Thanks. Xueming Li --- >From 1392a3469283f3e2dc6753d4d02761f1979a5047 Mon Sep 17 00:00:00 2001 From: Venkat Kumar Ande Date: Tue, 4 Jun 2024 17:41:34 +0530 Subject: [PATCH] net/axgbe: reset link when link never comes back Cc: Xueming Li [ upstream commit edf463256dd35803aaa11b0da704a0542ad20071 ] Normally, auto negotiation and reconnect should be automatically done by the hardware. But there seems to be an issue where auto negotiation has to be restarted manually. This happens because of link training and so even though still connected to the partner the link never "comes back". This needs an auto-negotiation restart. Without the fix the user will not see the link up status Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_mdio.c | 2 +- drivers/net/axgbe/axgbe_phy_impl.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_mdio.c b/drivers/net/axgbe/axgbe_mdio.c index 913ceada0d..b03bc471cb 100644 --- a/drivers/net/axgbe/axgbe_mdio.c +++ b/drivers/net/axgbe/axgbe_mdio.c @@ -1051,7 +1051,7 @@ static void axgbe_phy_status(struct axgbe_port *pdata) &an_restart); if (an_restart) { axgbe_phy_config_aneg(pdata); - return; + goto adjust_link; } if (pdata->phy.link) { diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index d97fbbfddd..87795c63c9 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1697,6 +1697,13 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart) if (reg & MDIO_STAT1_LSTATUS) return 1; + if (pdata->phy.autoneg == AUTONEG_ENABLE && + phy_data->port_mode == AXGBE_PORT_MODE_BACKPLANE) { + if (rte_bit_relaxed_get32(AXGBE_LINK_INIT, &pdata->dev_state)) { + *an_restart = 1; + } + } + /* No link, attempt a receiver reset cycle */ if (phy_data->rrc_count++) { phy_data->rrc_count = 0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:15.573039251 +0800 +++ 0030-net-axgbe-reset-link-when-link-never-comes-back.patch 2024-07-12 18:40:13.996594240 +0800 @@ -1 +1 @@ -From edf463256dd35803aaa11b0da704a0542ad20071 Mon Sep 17 00:00:00 2001 +From 1392a3469283f3e2dc6753d4d02761f1979a5047 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit edf463256dd35803aaa11b0da704a0542ad20071 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -38 +40 @@ -index 44ff28517c..54fe9faae0 100644 +index d97fbbfddd..87795c63c9 100644