From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27A2145610 for ; Fri, 12 Jul 2024 12:49:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C5CF40B9D; Fri, 12 Jul 2024 12:49:06 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2056.outbound.protection.outlook.com [40.107.243.56]) by mails.dpdk.org (Postfix) with ESMTP id F19E440261 for ; Fri, 12 Jul 2024 12:49:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J2GH/v2epchbVSsjn/OW1xLs9abrGTrO+AF0j/Z5W8Ja5V1xdO2J2yZdNZ5Py6ySPG1kGTn+EzQw0re786/S20Gb3Yygu28rW/IIHru7lLo7vJu2ifViY44cB5Y/8PTOXg2dv269QOr3QxGJNaOEuV2JQ9v/2PQEpiIJioqvnC45Kc907RapNUxbwqfb5z00/lbwtd7xFRfKD5NGrDF9675kyzogGlc39TvFvT/ozB1yDeZGsZDRwLxLDO8KJg3F+OnAIClNPK6hqNeOMfBRDLT6IeL3sDNO6I7rquWzh17MIDC1BOR0/QmvPR/xvVdjLz0jFwJwAJ1IP/8DlQ3/ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X13k7tBK6nJmzj0XrWgNnB7nueu6kR8iejowBeg3z08=; b=dKdcFmOpoeo8sptL0w2g/e0bPZLqN1y1fxwDa2V2OGZ6+9YSwkyUjNBhNeDogLOLOyboMJAnuDdOYIr72azmf839Jvwr6nYENUkXmXkAten369U215KWTF/cZfteEzqa9gX7Gza/7q8dMMWcKqC1WTHJTdaV0Z5JQZeJggLS5YAl7QYLura2f6dM/21foVGJ6a4aJ6cL309FB1o0B9AoLNPwB6369ZOB5ZrK1BAQOrZFFFUL1k15XgIE3G94f8rf59gAxnZbu9CNSkpUM0JxDDj7KCXXwjs/PfPYvU7aJc7p8OdYrAq8WThyovyMP5tVHFhkhvEyWjmszvr9+RIrGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X13k7tBK6nJmzj0XrWgNnB7nueu6kR8iejowBeg3z08=; b=RMhAWidnSiDAMDqPQT/etislkxqYpKNg3Bh5rjVXiafgWjs3BCooas9UZFjqRDDogO2BiG1bzy0SsfiBB1K6MUBpMx/2iZvb7zm3fjLh+ArSf2DqhRzr/KX85HktFX5MN0aIEmEL3ZvMb4KW0WeLgqHpcRc0YDrmHQPhLjY+StGof7iaI58eFpiLWemm5RVdJYnqaOaW3Ek1mF7NPdouCMdI8zStbDZb6sVmcxffRgrh4HskoImEeRibQ6OPD3JTWlb/Vc3fHSfzB+LHNA0cMvW89q0onyLlDh8+FXkmPUl96nG5LcbfggTVeJTgpaJ6K6spjeaW3w44iH6GLaXVHQ== Received: from DS7PR05CA0041.namprd05.prod.outlook.com (2603:10b6:8:2f::8) by DM4PR12MB6400.namprd12.prod.outlook.com (2603:10b6:8:b9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23; Fri, 12 Jul 2024 10:49:00 +0000 Received: from DS1PEPF0001709D.namprd05.prod.outlook.com (2603:10b6:8:2f:cafe::49) by DS7PR05CA0041.outlook.office365.com (2603:10b6:8:2f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:49:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709D.mail.protection.outlook.com (10.167.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 10:48:59 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:49 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:47 -0700 From: Xueming Li To: Venkat Kumar Ande CC: Selwin Sebastian , dpdk stable Subject: patch 'net/axgbe: disable interrupts during device removal' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:19 +0800 Message-ID: <20240712104528.308638-34-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709D:EE_|DM4PR12MB6400:EE_ X-MS-Office365-Filtering-Correlation-Id: ed41bb1f-389c-47e1-9c8c-08dca2603cd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FSLbpnV4o5TU3aNCLaVn8woWvCOdhxiPCKBgpR+mt07UDDM6PhWXd8x/cS+G?= =?us-ascii?Q?usX3YBKmQ35a/ajhcCHwx4PdnKXNwHq/ksSgO7acm8tHlDhGHgr6nLpsdGDH?= =?us-ascii?Q?3fEFiMlQX0lhjzYW7lfNjgvIJJNudKnz5g6tHEWcDYGtxbL5+xXJenwpO3tb?= =?us-ascii?Q?DSsHrH2DgvhVAo4igvdeaS5NOvoyLtFc5gFJ+ygT1TmDXDMAJR0zTRDjk2sB?= =?us-ascii?Q?YpZG7qmT+BKk86u+QSAdePb4mxvIDux9IO6AhQXrLCel2T7vG1LccM83+T18?= =?us-ascii?Q?Dt6fc2bR1Lo10Ym0ktsqyHj873PFRV+XroL4WSRtiq3CjXOcXCvB/yU+wkmM?= =?us-ascii?Q?NmAn6AR+lVTHR5vsJTe/9D4GbOZdp0+iwPmPJe85Ed1np8KIyZjLpP+4Qnbq?= =?us-ascii?Q?Piy0ipkLpPoB3fOKG4gB7FFXtsg4JA6rnRM8zSsnuzDuKkJRzw/c2J9ouHfK?= =?us-ascii?Q?BOUZA8vjDyH8SKwI3wnYoMGqz/LigTPGckbDLSvmpmF9aO+jJ1odaol8udzC?= =?us-ascii?Q?+dwyVHCPQSzrgEw+QnSlSmNkU39jL5bbybvctaO7GSc5AzPtqB837dYTkfUe?= =?us-ascii?Q?xtOPSIv1odS6pfC9JQeYCre5RhfgztQauGnEZRRZ6vkgf8v5H0z7+suLx3MK?= =?us-ascii?Q?52KiOr4d3Ch6xJrpnY5sCDF8STIK+VyIHhKLkBNAT1ujHIaQfvuCaOCA0wvP?= =?us-ascii?Q?VarnjRP5FItAV0eCHXigZW/q85ze2WwY5yPDtEfKsi+avvfeuAq/7bBu94Uq?= =?us-ascii?Q?aD0MDREWuj+aenQYc28jockolAAVAFpw5mwlCUumOcLRTjodZCM32BFes8hm?= =?us-ascii?Q?eQmvy5243WezSG8B7mTudfPpjqeTm74QvRxak7/1DRWcEF4I85OgxgQ+ptVw?= =?us-ascii?Q?faapxvUu+qqveq0jk+Xc36jaVmaEipGayaMqymr9r0XWYBk76X/QpjpQ/6nd?= =?us-ascii?Q?dli3F93uC1CwHmWjTnA5u0tRUDgBnmRH2l8Hs0UpRtrW2p2tlkhKaxFIOL0d?= =?us-ascii?Q?jJ0IFojnWc//WSOxaP3PnRNX2xmT7stNNxjCtR9CTmJob7U8W0J0zoXhlIKr?= =?us-ascii?Q?N7XGkpOWKcKkRfn9cJj2eGDDXViyJItZHy86KIHdgifsDRNuQlmInrn8VBh3?= =?us-ascii?Q?2jEZ77qB3VPUoSsGrP57T5MdjKssCDl7XJxsbUnv3Dqgkp6KEv9LLNRDUr4s?= =?us-ascii?Q?TcXhGo745AqOQZi0fgXsduSZGSo3L5759duynNy/SHaI+iRCsl5/wsF6yUAJ?= =?us-ascii?Q?uAwACcxMPapwH4Wn9XxLYuUdMPYWC8MWRu+YFsmTYT7ejKYl+Wq9jnf0YJGE?= =?us-ascii?Q?Yep0RByRdS2slg+gs39Qg729Dv7IiaydaxRnXqFOuG9eU38atwUMBiDaKXW4?= =?us-ascii?Q?u3OT596s3UTLJnPWKiBsbFvKiosXMnAu5mSI6Og4ezdGgmlQKcPUzdqaCFNx?= =?us-ascii?Q?bxV+ekynF0LxgT9uVpwRQlBtv0wqWJqB?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:48:59.9659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed41bb1f-389c-47e1-9c8c-08dca2603cd9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6400 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=b4a353a5e8abbe4b04c177821526a9ee58ebe3b4 Thanks. Xueming Li --- >From b4a353a5e8abbe4b04c177821526a9ee58ebe3b4 Mon Sep 17 00:00:00 2001 From: Venkat Kumar Ande Date: Tue, 4 Jun 2024 17:41:37 +0530 Subject: [PATCH] net/axgbe: disable interrupts during device removal Cc: Xueming Li [ upstream commit 7b7288b08760204139085174ba00a2863dfdbbec ] Hardware interrupts are enabled during the init, however, they are not disabled during close. Disable all hardware interrupts during close operation to avoid any issues. Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index f174d46143..4a37d92699 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -2404,12 +2404,14 @@ static int axgbe_dev_close(struct rte_eth_dev *eth_dev) { struct rte_pci_device *pci_dev; + struct axgbe_port *pdata; PMD_INIT_FUNC_TRACE(); if (rte_eal_process_type() != RTE_PROC_PRIMARY) return 0; + pdata = eth_dev->data->dev_private; pci_dev = RTE_DEV_TO_PCI(eth_dev->device); axgbe_dev_clear_queues(eth_dev); @@ -2419,6 +2421,9 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) axgbe_dev_interrupt_handler, (void *)eth_dev); + /* Disable all interrupts in the hardware */ + XP_IOWRITE(pdata, XP_INT_EN, 0x0); + return 0; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:15.706903735 +0800 +++ 0033-net-axgbe-disable-interrupts-during-device-removal.patch 2024-07-12 18:40:13.996594240 +0800 @@ -1 +1 @@ -From 7b7288b08760204139085174ba00a2863dfdbbec Mon Sep 17 00:00:00 2001 +From b4a353a5e8abbe4b04c177821526a9ee58ebe3b4 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 7b7288b08760204139085174ba00a2863dfdbbec ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index dd681f15a0..e5d8f7db02 100644 +index f174d46143..4a37d92699 100644 @@ -25 +27 @@ -@@ -2411,12 +2411,14 @@ static int +@@ -2404,12 +2404,14 @@ static int @@ -40 +42 @@ -@@ -2426,6 +2428,9 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) +@@ -2419,6 +2421,9 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev)