From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF12145610 for ; Fri, 12 Jul 2024 12:49:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E89A3402E5; Fri, 12 Jul 2024 12:49:10 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2075.outbound.protection.outlook.com [40.107.212.75]) by mails.dpdk.org (Postfix) with ESMTP id 24D2F40261 for ; Fri, 12 Jul 2024 12:49:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LgNYlcyYfkky7Io25OrlMUroJniMI7LqoA7d8v1Zn/yOj44hTED9HKbkLzS24r2Mz/EPzCNraHm3aIwLXWRy3j0ridjQj4YaUOr47BlDG6FNeo0rtguswlBZ/GMvSjkN7S8Kk72L7Dz3FeHS79KWsWMZ/H7Ci0V30XcGff2phswrY8D1akeXcdtyMRUusdVxUDXP7M0t4BrPLJs1xlnOjRGPwsYoDMpizV+lBscxPKeFg4IODxETT60puavv4gIkJLk9//GL75oiVCQpEAO4iNNAcweXcfi0mMwG7kcd3EgLcFNMwBVJh1613qtKAiUrtEfY92+5V0CNzQ9WxD1HSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9kXFTNVbQPa3KMX2HhBGEeo5oB+tuuH2jBvKocdyp/8=; b=WrEPi8RzOL47iJZl4pKODS6mzSkWQW9PIGZKQhsCbDE5GVr8zjTjY6gOLStx2r2VEa8YE8gGLorDv1NaiXcOjq8C4mAVzy+AW0j6B4oDXVYhqKJO4eRfuNcLLzttwPlSqsw+epjkp/p1QrxJAMgti8oEx/A0e8UlPYLT4Rd/NWdZhrrtdfJVmVbfAJkq+eG7gqEt9grI7pRjuC+aW1pNuSV9xpl83vZUK48SWXGh7UNF32QtCynTZmgqn+yRi89+jpUZUu7kWbxz53JgrG+ytHU7ifBtKLMWHkZT+DQVQYRn9QVFsdS6wHxe0mJkprFKQfz24a7nKZJW8NqODSpjQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9kXFTNVbQPa3KMX2HhBGEeo5oB+tuuH2jBvKocdyp/8=; b=bcVjvNCseWNS+993DAyQq/N/jhTGvM9UCG7QVnzUlp0CkZIADRrTQcCKzYM4Ia/dmFcPXme4rwwaKpw4TLQe9EuBqj70mJEgsBu0hwJKPAlXSyU53eigNYBq17tCy46INJ2PFRYN+zOCiFdxX6hE+MtIS6nL4/d3Jxj+Z24eA5gnnzF7e81GZrcfra0F7xLJmHrsQw9x7BHWpDSaJIGl1haskvCwCOlBgEqep1N3YjTeKmruWV67y8D76arzBocVqUU21gwklsfy2QG5UY0QPPD1ATBhK/kEpjbB2THmWai6TDbX+/0pRFj0C8ZMebpmbwJqAT9W84qXLGLeGU4XtQ== Received: from BYAPR02CA0014.namprd02.prod.outlook.com (2603:10b6:a02:ee::27) by DS0PR12MB7947.namprd12.prod.outlook.com (2603:10b6:8:150::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.30; Fri, 12 Jul 2024 10:49:06 +0000 Received: from SJ1PEPF000023D5.namprd21.prod.outlook.com (2603:10b6:a02:ee:cafe::85) by BYAPR02CA0014.outlook.office365.com (2603:10b6:a02:ee::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22 via Frontend Transport; Fri, 12 Jul 2024 10:49:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023D5.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Fri, 12 Jul 2024 10:49:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:51 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:48:49 -0700 From: Xueming Li To: Venkat Kumar Ande CC: Selwin Sebastian , dpdk stable Subject: patch 'net/axgbe: disable RRC for yellow carp devices' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:20 +0800 Message-ID: <20240712104528.308638-35-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D5:EE_|DS0PR12MB7947:EE_ X-MS-Office365-Filtering-Correlation-Id: ed42c3e2-2749-4845-bbf5-08dca260404d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1zSylTWOXnxpz6afXiqDQm8CoHCjKKIujfh61pgqUMMwJt5G1XOCtsOQwCxg?= =?us-ascii?Q?JYggac8EOBtjYwwY2pLvCJ4sLKUg2p8rmDkUCoSazDpe2dceFhdIbXDph2PH?= =?us-ascii?Q?yv5DJjiR0s36YG7re9EQsX/D6LTWlO/L9CC9H6HeOB0j3QK42TwPAxhATQkM?= =?us-ascii?Q?puettfnPQUzr6nYuwNt8626QcT97h7ccV82f1hvx0FbL96sKTJ+InNLfKNSZ?= =?us-ascii?Q?u441DdRMLZ4AzKiZW1T7ArH9SSfvalsP9lH5d3xtm7FtX0mB55t5JSkM1yoW?= =?us-ascii?Q?LNCSUs7dUxucfZB6ErWdDtsnkRYNr6GLR/2q0zBVJAJPCGn2bjnJNRtM/hiM?= =?us-ascii?Q?7k9n9vOtc6nYXkiPBBOFSw3vXpOVRrxd6ldH9Myqrs2zCepnVWsQSpcIw1FU?= =?us-ascii?Q?dFn7MwoCUr0ffmWgerM2O251/7MXi4wKvDQkTSlgeewPg7PKLmYLz4TTfEik?= =?us-ascii?Q?xmTZPzSGNtN3C+i6F8yO+29LRxnj3XntF7l62zmT2xN495X+XTWriHX7skIA?= =?us-ascii?Q?fC2ZltJ7WuwmKzBKSrkscX4IZXXeCs/TOZxhVcMuqkDpHcaodMGTQdkVdybx?= =?us-ascii?Q?2g/T2xopXrBfyfFRGpBFQipFRRFr+d9iu0VHHCman9ZD9W4ozVW1ffaIc/mB?= =?us-ascii?Q?egaO4g6n/nhrjpIybrkF9m2iQAGU+z+1k8d3dslCcRTOu+vVS7hU8BGTs1sC?= =?us-ascii?Q?bSrf1irJs24McKGRfEadPS1Ny0O/JYv43mcXJPBU/eUHZBKEvosc+l3SFJac?= =?us-ascii?Q?R71oeYnDLy0D45Ew2peEJYc9ehH6FSgQEGaOXgwNdU0t2wsnNm8KtsxKCy7q?= =?us-ascii?Q?MjG4AjvP4WO5dNIcKNjKnW0U5UysBwmGquaXFoLVHX53EDkOgaOYcOs6zUuM?= =?us-ascii?Q?kUdf7f07zoPVk9t8i+tURPeqYwDy43iMs/T3rQvzkMfzIh4E6E1SfPuSiynV?= =?us-ascii?Q?TLyW6G9s4aoWHZiCrEjfFz6Va8TcUR5vR2V5AYl4dHMosi91OMJQkOpBlqj2?= =?us-ascii?Q?Gb1WoIkZFtMMbtyhgQxc+5hm0MjU/DfEB2Mkc79m592vmYf/a92hlG5278ec?= =?us-ascii?Q?QLg0js9/6/zj49gTL+kcUCM4sUIYvJ2tz4ZFWFmTVaDMaNtaiIuM2BFe0X13?= =?us-ascii?Q?TfqDNofAtAjen2S8loysoVaJNpmwGVaXm/gaQn4mJFtvDgTTODxSlMbNHRB/?= =?us-ascii?Q?bFu6gzPlp5i3dJvpVIJ8Z4hIHjorFT2RoZIybrhju+nYnyxDkYi6vzd7xtCm?= =?us-ascii?Q?6s+ORUCUJaXWmiFiyZ8yBV8FGb+tQueWV21s/xg/mVjPA6zN/ZLe5o1xW6jN?= =?us-ascii?Q?1Ejh0J+toHqcco8ejt4bz+AUKEJ7fQs/rb9HPjguf4kNNWKvLmhO5x/rYOZw?= =?us-ascii?Q?IpLvXUwi7xXxljeWxLzMeZLm6xeDk9u2nKk4uTj0xNnLnHWdx6XK7cF+l8qJ?= =?us-ascii?Q?H2yh+Uk80TmL0wO5fsPHS9DmZvInQl8Z?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:49:05.8851 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed42c3e2-2749-4845-bbf5-08dca260404d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D5.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7947 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=a3de80c9a145f97e86a3206e2864962f58ec22c1 Thanks. Xueming Li --- >From a3de80c9a145f97e86a3206e2864962f58ec22c1 Mon Sep 17 00:00:00 2001 From: Venkat Kumar Ande Date: Tue, 4 Jun 2024 17:41:38 +0530 Subject: [PATCH] net/axgbe: disable RRC for yellow carp devices Cc: Xueming Li [ upstream commit e82b0fe097da02eab8be924a28a0a4ca96bc3c69 ] Link stability issues are noticed on Yellow carp platforms when Receiver Reset Cycle is issued. Since the CDR workaround is disabled on these platforms, the Receiver Reset Cycle is not needed. So, avoid issuing rrc on Yellow carp platforms. Without the fix the user will not get the link UP. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ drivers/net/axgbe/axgbe_ethdev.h | 1 + drivers/net/axgbe/axgbe_phy_impl.c | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 4a37d92699..6ce87f83f4 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -207,6 +207,7 @@ static struct axgbe_version_data axgbe_v2a = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static struct axgbe_version_data axgbe_v2b = { @@ -219,6 +220,7 @@ static struct axgbe_version_data axgbe_v2b = { .ecc_support = 1, .i2c_support = 1, .an_cdr_workaround = 1, + .enable_rrc = 1, }; static const struct rte_eth_desc_lim rx_desc_lim = { @@ -2267,6 +2269,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) /* Yellow Carp devices do not need cdr workaround */ pdata->vdata->an_cdr_workaround = 0; + + /* Yellow Carp devices do not need rrc */ + pdata->vdata->enable_rrc = 0; } else { unknown_cpu = 1; } diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h index 7f19321d88..ae57aeaa00 100644 --- a/drivers/net/axgbe/axgbe_ethdev.h +++ b/drivers/net/axgbe/axgbe_ethdev.h @@ -463,6 +463,7 @@ struct axgbe_version_data { unsigned int ecc_support; unsigned int i2c_support; unsigned int an_cdr_workaround; + unsigned int enable_rrc; }; struct axgbe_mmc_stats { diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 8f8845a1c5..46ee5f0617 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1708,7 +1708,7 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart) } /* No link, attempt a receiver reset cycle */ - if (phy_data->rrc_count++) { + if (pdata->vdata->enable_rrc && phy_data->rrc_count++) { phy_data->rrc_count = 0; axgbe_phy_rrc(pdata); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:15.739296931 +0800 +++ 0034-net-axgbe-disable-RRC-for-yellow-carp-devices.patch 2024-07-12 18:40:14.006594239 +0800 @@ -1 +1 @@ -From e82b0fe097da02eab8be924a28a0a4ca96bc3c69 Mon Sep 17 00:00:00 2001 +From a3de80c9a145f97e86a3206e2864962f58ec22c1 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e82b0fe097da02eab8be924a28a0a4ca96bc3c69 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index e5d8f7db02..86c2ec64e0 100644 +index 4a37d92699..6ce87f83f4 100644 @@ -29 +31 @@ -@@ -208,6 +208,7 @@ static struct axgbe_version_data axgbe_v2a = { +@@ -207,6 +207,7 @@ static struct axgbe_version_data axgbe_v2a = { @@ -37 +39 @@ -@@ -220,6 +221,7 @@ static struct axgbe_version_data axgbe_v2b = { +@@ -219,6 +220,7 @@ static struct axgbe_version_data axgbe_v2b = { @@ -45 +47 @@ -@@ -2269,6 +2271,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) +@@ -2267,6 +2269,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) @@ -56 +58 @@ -index df5d63c493..f122dfd516 100644 +index 7f19321d88..ae57aeaa00 100644 @@ -68 +70 @@ -index ee9dcbe3da..f51830f800 100644 +index 8f8845a1c5..46ee5f0617 100644