From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 998F545610 for ; Fri, 12 Jul 2024 12:49:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91A81402E5; Fri, 12 Jul 2024 12:49:33 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2074.outbound.protection.outlook.com [40.107.100.74]) by mails.dpdk.org (Postfix) with ESMTP id ACF9840261 for ; Fri, 12 Jul 2024 12:49:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sps2MRdmI9GIIvPfLU7iomUStLt9huvOIE/sowmTxxLus6BlWeLkxMU3RmwnXH7MNmeILWiR3PMzvP/IXabZqSdk/8GzwtXc/aAPDpTHP5FebpsDNUsB4ICUVg50csPdkcBFsy8IbSSscfztOc4HFztJA4xhyudCkAYP0ukPvgtIBRWziYnD5GysNEgtZ6oLJ4SS6d3eDSVJkBI4JoUyLt25/M53H83LGaXCmd0KuqVNOlv3jdechpKeMkqYnexcpH6T3wuyIKuu+wmr+G55fdKCb+3iUqZPQt1OY+63x8jzJyAGA0vsqtECXlJjRjwk7AD0KnORXqcKEHaLV6VaZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zY0cOMHY6a3RycRa+FRLzJAq/WB88BpYfv9XJ4ieWnQ=; b=nw6+6/K+ucN55oj3HeuNu5fMYniAGC6SjyVv6+tR1Dg7TrCbnjFZR0sJ1hMQOmCYt3HJlOipHMZnNtDU2zIYd3tV/YcwPOave/ABwNQ9QnD2kHCYe0003JEf0k2NFF3VLSQwkFVkmZqFr6Me7TI1XhepN6AjbpuL9IGzyn+4qZeM0Al2X3zrVsmcFCDpdBeKiVwXCRPXb5SYr3t7RWJl1HpeKrrYmZTyTFHDEKH6rOnW/+67sG/avyiaDFdP065J0LFyqt4FYZsRd3lIig5Ywk6kAtYJ0LclREh+gc8F+b6wB1oNJ0rXNUpitEmpdA5z+qYO8ySRLEzyybMy3YRI7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zY0cOMHY6a3RycRa+FRLzJAq/WB88BpYfv9XJ4ieWnQ=; b=QoCIh0nfO5Rx1qcFq6zINBAtZswvH3eLhnJ/YP5nXKdtSwpdwW0QE5xoBhuEe0oEjnuO41hutVibSvD6ToGAbKH4ss6jnHWrz7FqlxC6lQnxkpwuuXDYojbvzkzolOSSD30uFsMmuAAUOzZ9LKi5rRI4EkeQvPJsvr5pTFtmM1SaJCRcFzq9/Dc6gCkVTCBrTk4oyqLmjCsqWC1scHXBMNN/9L4mzAukTrwZ3vm3k+oVNQdYjrU/vJZC/xOtisecQUYqpiwBkjp4lC2ze5l26FiGGyNkEG4o0uVBoeX7Y9UDwb1CT2ZWxEWwtNXli99OJGjeivULKz9WBUOsx3/zRg== Received: from BYAPR06CA0056.namprd06.prod.outlook.com (2603:10b6:a03:14b::33) by LV3PR12MB9267.namprd12.prod.outlook.com (2603:10b6:408:211::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23; Fri, 12 Jul 2024 10:49:27 +0000 Received: from SJ1PEPF000023DA.namprd21.prod.outlook.com (2603:10b6:a03:14b:cafe::e3) by BYAPR06CA0056.outlook.office365.com (2603:10b6:a03:14b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22 via Frontend Transport; Fri, 12 Jul 2024 10:49:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023DA.mail.protection.outlook.com (10.167.244.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Fri, 12 Jul 2024 10:49:26 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:49:18 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:49:16 -0700 From: Xueming Li To: Venkat Kumar Ande CC: Selwin Sebastian , dpdk stable Subject: patch 'net/axgbe: check only minimum speed for cables' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:24 +0800 Message-ID: <20240712104528.308638-39-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023DA:EE_|LV3PR12MB9267:EE_ X-MS-Office365-Filtering-Correlation-Id: 0424c5c1-ce4c-4eec-9582-08dca2604ca9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FiCPbQZ6Hwe7jcuezSQ0dMPYRLD/qz1eOdR3UTZsXkhVjSbUtW5PXoQtZA1K?= =?us-ascii?Q?ncOMDmYU+9dJzO33cKxxpTd4i3KNh0TRF2r/WlUW92nDRLthRuJUd71gWdd+?= =?us-ascii?Q?Ngv1BJMhPiR4qNtY9JXSdEK83Y9RZ1aQ7g+m24qXvvP0yYGFQevOe/tTrdZK?= =?us-ascii?Q?JS9QP6ZHOc4VPqa3OM+LJatlB+7d6t3nj67w4nG+OOOE1CLlXgJssaDbgYYY?= =?us-ascii?Q?d0guwRQBAwBLK+xgK1Wy7ZEj78Q2zE8J/O2QI5sPZlKU0mN46w45V7MjFM1g?= =?us-ascii?Q?o1TK2h674muF7cn13TVfKNtEbwPFL0UCZVo5BQ8ewspjDx6kKOHpfTqTOZQG?= =?us-ascii?Q?GzXBwrpOavTH6UALNATZM2kjpFUXF7A0TiPqE/ZUGbRYJ7FMJ1h76dm/HbvU?= =?us-ascii?Q?z68ZZ7xAO0icYGKSHtgtmbTbmodQBrgY+WdA3PLhqsYuplPaArwANij4x6Rn?= =?us-ascii?Q?eBC1aG4eKoAsd9Nv9NkOkqEd8diW0F+GN6y3CxyiIH3wdE5hbW9MJGK816cX?= =?us-ascii?Q?OxeJxzGyP/qAxK4a2gAhGoR6/VPIlvKpslPnMvvHa/nXYqs2pY1CeeCVZRe0?= =?us-ascii?Q?duYKqLxSS62YJxvuihqLXvmUaIhz9qS76M5pBpnmkuA0mBmM6Z+1dGFy0sUG?= =?us-ascii?Q?Y+3x5r1Ff5DdYMjo3WigZFuI1ZcpLHUajefbSJUipAuu6qmQHuTg9Nq+3Asv?= =?us-ascii?Q?0NQcT+jr/wTo/F0RNw7B1UZwLVQcvQtKQxYePL3Hu+TKfJAmQgnhm5GAarBt?= =?us-ascii?Q?zmAjHFDp879ROzI91jNshOBY2tOIVHL1pPaU5Bh3UQyLiG6k+2kpIWpeR3i6?= =?us-ascii?Q?zhHoUunVDgfzgFco65QPc4j0IFH3bGnA01QariSPeu4YIoiiTKk2BP1/pju0?= =?us-ascii?Q?OKviWEwtmNjKbT6friAnSQXXepLan5+MwavOKzhgOSOpqSteXQuqjOFfomHM?= =?us-ascii?Q?EBdzROwt4EOTv2WY9yUZgCq29j+iQN0KgusffR6fqm/0UrQewfvSUOhMnzuv?= =?us-ascii?Q?hANBvA5eaq5iIgcCgI4MxzBD/8NlIb6nDCBFn/910dfnmbIy7zGBrm5p1V8R?= =?us-ascii?Q?rL/69vZDgu1gAl/hKaPP4hd/tGY21LWjWH77Jz1erccjT0SMx5QdYr4IQGZN?= =?us-ascii?Q?IKkHRPZvrJJ6SHQMwxz09Zy85mLpPim/i3WaBMUEdWPFxaL7VcQ1XLyp/V6h?= =?us-ascii?Q?uJJqOPLjDC4Nx1flyXHpERcMtVe9Hi/bvB6ctnUYRA7kG1wnX9hCm6GbSqvd?= =?us-ascii?Q?QeQmAlpSnyMcNhkyIZhyUOY9N8AuG0Y1sU1J+5GLSqgczySpGEBCaz/TS916?= =?us-ascii?Q?TZ2QdU0Iy5C20s4ZhvVIJBmAqp9pTnh1TlFRCE8xpyT3cLq9MeQhI8hqw8SN?= =?us-ascii?Q?D0maUQn0yQsE4f7NY3NT7zT7vqYLDt9OD3etTkPkIdZDskLdwEetFTSs9MdL?= =?us-ascii?Q?Y0G4dEJ2XJUDnY4sKJEcfU50IuPpmSXr?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:49:26.5885 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0424c5c1-ce4c-4eec-9582-08dca2604ca9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023DA.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9267 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=3a6efdb072a54859906df25ff4dbaae4a353a609 Thanks. Xueming Li --- >From 3a6efdb072a54859906df25ff4dbaae4a353a609 Mon Sep 17 00:00:00 2001 From: Venkat Kumar Ande Date: Tue, 4 Jun 2024 17:41:42 +0530 Subject: [PATCH] net/axgbe: check only minimum speed for cables Cc: Xueming Li [ upstream commit b5587a39dc94ee0bd055b515cc8c060923ed69b9 ] There are cables that exist that can support speeds in excess of 10GbE. The driver, however, restricts the EEPROM advertised nominal bitrate to a specific range, which can prevent usage of cables that can support, for example, up to 25GbE. Rather than checking that an active or passive cable supports a specific range, only check for a minimum supported speed. Fixes: a5c7273771e8 ("net/axgbe: add phy programming APIs") Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 85b01bfa10..12908d4e6f 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -117,9 +117,7 @@ enum axgbe_sfp_speed { #define AXGBE_SFP_BASE_BR 12 #define AXGBE_SFP_BASE_BR_1GBE_MIN 0x0a -#define AXGBE_SFP_BASE_BR_1GBE_MAX 0x0d #define AXGBE_SFP_BASE_BR_10GBE_MIN 0x64 -#define AXGBE_SFP_BASE_BR_10GBE_MAX 0x68 #define AXGBE_SFP_BASE_CU_CABLE_LEN 18 @@ -536,25 +534,22 @@ static void axgbe_phy_sfp_phy_settings(struct axgbe_port *pdata) static bool axgbe_phy_sfp_bit_rate(struct axgbe_sfp_eeprom *sfp_eeprom, enum axgbe_sfp_speed sfp_speed) { - u8 *sfp_base, min, max; + u8 *sfp_base, min; sfp_base = sfp_eeprom->base; switch (sfp_speed) { case AXGBE_SFP_SPEED_1000: min = AXGBE_SFP_BASE_BR_1GBE_MIN; - max = AXGBE_SFP_BASE_BR_1GBE_MAX; break; case AXGBE_SFP_SPEED_10000: min = AXGBE_SFP_BASE_BR_10GBE_MIN; - max = AXGBE_SFP_BASE_BR_10GBE_MAX; break; default: return false; } - return ((sfp_base[AXGBE_SFP_BASE_BR] >= min) && - (sfp_base[AXGBE_SFP_BASE_BR] <= max)); + return sfp_base[AXGBE_SFP_BASE_BR] >= min; } static void axgbe_phy_sfp_external_phy(struct axgbe_port *pdata) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:15.889545813 +0800 +++ 0038-net-axgbe-check-only-minimum-speed-for-cables.patch 2024-07-12 18:40:14.016594238 +0800 @@ -1 +1 @@ -From b5587a39dc94ee0bd055b515cc8c060923ed69b9 Mon Sep 17 00:00:00 2001 +From 3a6efdb072a54859906df25ff4dbaae4a353a609 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b5587a39dc94ee0bd055b515cc8c060923ed69b9 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index d9585a7404..b6a2a084aa 100644 +index 85b01bfa10..12908d4e6f 100644