From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 851AD45610 for ; Fri, 12 Jul 2024 12:50:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EF22402E5; Fri, 12 Jul 2024 12:50:06 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2073.outbound.protection.outlook.com [40.107.244.73]) by mails.dpdk.org (Postfix) with ESMTP id 6C39B40261 for ; Fri, 12 Jul 2024 12:50:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nDvgQFx+A86QCoQwf/vIsq3L7KJ7yZdShQegWyJ0+rAhHDA9iicQoGwaRAaKLYGivSm8w6aAlxO2eWfjJumq2oPytOeAfeiesMexp9E2glk9PVAg9nH+GzQIbvq8l/KsQW91UE1QD+aNGO1A9X9eyeJIDGOve1HqtSdOsjILUIgQO375OEmPyqkfMkfcQ26cpS3qTyZIyRhTMmsEHgQlDfDMOH+utIeZyei6//IK9RGr/tUwznpz0jaemsRKE1OB7pVv1ik5bDjY5KhJtUhjMn1XVPMk6y9HnMJ/JPYfIXr2N2aOzs2mMD/9ftL7/ewCRqGqLNW326ZRPLRiwH74eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kmp9Rghg9nfPMARhq7cYB8aEDglgedUby36Q5z4D1EE=; b=a+QbICkG3MldH61CKT9ql8qOBLAihSnnpkKoe7GtIKnzUIS9mgrf4PU1GEtxWD/+jbihhyzpt6l08OoSrKnyzDBsok6axRT3LUnSL1ZTZ3kQvFbVdt3NFyyR/rIo/jvv+w7V129Y35/wNRg2eBkis8eKfr4CTx2YeTSu5z3PjPXuwmPdBZaiBo48chTBiDF/+/qhP0XPdaYj8jhvfI/R4DRXPo/bhEAXxDM+0Jh2QR72u/6q4V+Z5tXuNsqGBiSK26a0wEgIpsZPJXkTAUv3csWXmtjCwRR4csRfFJ7r9p0B9qR1eXguuKrszW2TIMECtJnkCI4IkopVxYgx5JDCmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kmp9Rghg9nfPMARhq7cYB8aEDglgedUby36Q5z4D1EE=; b=cIBPwjhNshGp03RlI8IQTJXUKlVoYSPVeWZb6Pzw9ZcerZ4dOH7rgSQ3LCIFNIzTMkNwxJtX1ONAQVS2/yRlxlS9cyIH899WhDTPf2Q+zU0Lj3aI/5sl+BQOQuSze+fnMK+iOWTLucQT0qq2ilpwlMGlqb75Y+HodlBJN+SG0UUjk+dJ4h5SBrbliGZVeMA41AN1AETCIt3HxrWlw0q9PN9iuz63RGh8FZvSnxLOSqXzIrEfnEzC7FKHyBDACn7cl65MpMOy3k3j/J803Vo+hB4Hyh0xeP3AyZ1u1wlh8Yx5m9SrYZQd/rcgsvjFV+RZFye/Au+REx+qV7h/0W+rxw== Received: from BYAPR02CA0065.namprd02.prod.outlook.com (2603:10b6:a03:54::42) by DS0PR12MB8296.namprd12.prod.outlook.com (2603:10b6:8:f7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23; Fri, 12 Jul 2024 10:50:00 +0000 Received: from SJ1PEPF000023D6.namprd21.prod.outlook.com (2603:10b6:a03:54:cafe::c5) by BYAPR02CA0065.outlook.office365.com (2603:10b6:a03:54::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:49:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023D6.mail.protection.outlook.com (10.167.244.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Fri, 12 Jul 2024 10:49:59 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:49:49 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:49:47 -0700 From: Xueming Li To: David Marchand CC: Ferruh Yigit , Ali Alnubani , dpdk stable Subject: patch 'app/testpmd: fix outer IP checksum offload' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:29 +0800 Message-ID: <20240712104528.308638-44-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D6:EE_|DS0PR12MB8296:EE_ X-MS-Office365-Filtering-Correlation-Id: d4d47c17-5e06-4010-9204-08dca260607d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nevSXuZbFGZ0FVvCQv2780E6O55aZr2Srj0AwzgKDbIlBJcWz8DeFdEApiQn?= =?us-ascii?Q?s8zM1lfNMd/ANCf0Ef4p1wkof3SpDwEiOQRF95bLilzl4lWCOzbpmDxYvg5F?= =?us-ascii?Q?NMttfsKE2TJy4YqMsZr6gSR0WsgmbbpMOMMjN0Kc3rid6jk/FNSvvbPwtvlG?= =?us-ascii?Q?yOHLmxeZ7vLjYSBIYXUXNEnCTTQHPsREDZz7nEiXfymR7q13432iDODaIXBS?= =?us-ascii?Q?y4vfjS77iFDg4YC+gbdiOH649d7luZHHAihtFpHcwu/7LbCCT8lcuuuZBaUu?= =?us-ascii?Q?EGKsqeBYUvvA+wHcphF53I5Ptat4WV6I0vC8ZenynN1XV5y8OOlq9mG6vWU+?= =?us-ascii?Q?sG7jlgzIEC2dJZfKyd8gIcOhGJ47oz7U9yXjPcQ7o6CmruZYkgT/w3uZcwdJ?= =?us-ascii?Q?RejmtPUjtqcrPcDWvxfR3K5urE36DtZ7RTBDXmTcm95Of17fALir3oXtKSAP?= =?us-ascii?Q?9lQ+KLNX4kP2w6K/Wtn7O6RUNJRcWJ8idaWICEtwr5bTY/ymNPQPUTtP0LtB?= =?us-ascii?Q?xNROKgpzSZlGZnCkpCXVmPcEDwZgga+kS5tOMYQyA8oycbmMfejnY6YiwXP8?= =?us-ascii?Q?YL/DebpUHKBODmTATehSw84Qs2SlW2nBrjnwUYqgCV9T9wfpSU+Hi0N0yphV?= =?us-ascii?Q?DmVWWvkpTbEuYufk56MIYEl4/8oAnox7BMufmLSlGDpWaqFg49pefpNYdAfL?= =?us-ascii?Q?V5+I5dn9C5xRUcywvrOUBepBY7V/1aDUBrFY9+9l2e8EvoHFIQPupcQoIt9d?= =?us-ascii?Q?ACCGzRA0Q0bJgyXBRDQ7mRsaHAe5Zkb5Teny45ycdCM3011xWA10aV+S9TtF?= =?us-ascii?Q?n14LSYTXvgxk9+hqpghbIN/ySaWvf2GADll+ks3hexGoVz5KreRkFq2X0HK1?= =?us-ascii?Q?Xlv0Q/fJcgX3+r7QbigkZ4qC5ZFugubp7N9lu6RdoB744SEaOC6lCa4sInsy?= =?us-ascii?Q?YXgquAcOvHvUfivpw7fGpKA/q/2KBUxWzIgmNBesopiJRJroGllhaBVJyiLr?= =?us-ascii?Q?MIvvS5pu4hf+J5EyEyxVZn/UHuj2jqFWa+dhxxPy2SxXNEaipYkWMDz7I8VF?= =?us-ascii?Q?CzqSu+wKxag5umFRw8FfSqyg4aptF4H/WLHA1L54Cx/S6DLfuTXSGdAFFbS1?= =?us-ascii?Q?srB//qcd9TMldMu2c3XIPk4M/j/Pm0MT4+VBkLVkJ2ic32wPf8rKtFT7tQ1z?= =?us-ascii?Q?wESZiQKwT4T8KS1p6lR+ldcUGEwB1dievVBHa0J0K0roFl972N1kGkYQqYtK?= =?us-ascii?Q?jw1OHvkqCSZf6GkC1bsFZe2+N9szl0UlhFrCCzUltNJ8wWmfaObHQPnfOQA9?= =?us-ascii?Q?XAhX3MaWsmAlASgUxo4pR6EX1fmXAYWTKpIwCowbjQffIP3E4bv7qfDOwE4d?= =?us-ascii?Q?FbKK2QF73p15KlS7SNShNPQhGcL/4vNlrLQXHRwAqHvTZMM3o2STV5ngKKUF?= =?us-ascii?Q?pjfW+1A5bTN7jQVoItq79MaZQSGZjqDy?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:49:59.8857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4d47c17-5e06-4010-9204-08dca260607d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D6.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8296 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=108a1722d5781c2c5f7ef0ff42251981d96a9ed8 Thanks. Xueming Li --- >From 108a1722d5781c2c5f7ef0ff42251981d96a9ed8 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 18 Apr 2024 10:20:17 +0200 Subject: [PATCH] app/testpmd: fix outer IP checksum offload Cc: Xueming Li [ upstream commit b9d859d8a671ec4516face2eba24434b955a9ac1 ] Resetting the outer IP checksum to 0 is not something mandated by the mbuf API and is done by rte_eth_tx_prepare(), or per driver if needed. Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Signed-off-by: David Marchand Acked-by: Ferruh Yigit Tested-by: Ali Alnubani --- app/test-pmd/csumonly.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 6711dda42e..f5125c2788 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -583,15 +583,17 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info, uint64_t ol_flags = 0; if (info->outer_ethertype == _htons(RTE_ETHER_TYPE_IPV4)) { - ipv4_hdr->hdr_checksum = 0; ol_flags |= RTE_MBUF_F_TX_OUTER_IPV4; - if (tx_offloads & RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM) + if (tx_offloads & RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM) { ol_flags |= RTE_MBUF_F_TX_OUTER_IP_CKSUM; - else + } else { + ipv4_hdr->hdr_checksum = 0; ipv4_hdr->hdr_checksum = rte_ipv4_cksum(ipv4_hdr); - } else + } + } else { ol_flags |= RTE_MBUF_F_TX_OUTER_IPV6; + } if (info->outer_l4_proto != IPPROTO_UDP) return ol_flags; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:16.064922892 +0800 +++ 0043-app-testpmd-fix-outer-IP-checksum-offload.patch 2024-07-12 18:40:14.026594237 +0800 @@ -1 +1 @@ -From b9d859d8a671ec4516face2eba24434b955a9ac1 Mon Sep 17 00:00:00 2001 +From 108a1722d5781c2c5f7ef0ff42251981d96a9ed8 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b9d859d8a671ec4516face2eba24434b955a9ac1 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org