From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0AB845610 for ; Fri, 12 Jul 2024 12:50:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA9E942EA3; Fri, 12 Jul 2024 12:50:39 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2068.outbound.protection.outlook.com [40.107.236.68]) by mails.dpdk.org (Postfix) with ESMTP id 92B3040261 for ; Fri, 12 Jul 2024 12:50:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qQzeliY+lFNCICKYOPvBSHz+YxKeeKZYVyq97wU+iPoGmmOYFC8kPiKNmHKnlRQVXESn0hGNcLQXHYKGWCIG9koFpUs1p0Mp8HnnEVo+W8nvICwxjRTxRSk/8Kqz0dorrILObHb9mI+Lj2LhUm5r8s3fhEpfYhwHGxK8jiCfs9CLi3813fmop8DRkusfgBkmf3Rr3vAerMMPpxQ+aIIR3B1cvRrW9ZGwTmV9zQCYGPt+MwZG+Bl/7cn8gvFNmB49G76qe6SzRRWRQ2iTvwjNrrg1umFx+T3hxloHFEm66++Qz++v/VXe/ZIUJm10oF5nvTxbXFQuj5NufBtmHiQYpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aPWUOBP1n8uU/1P4T2rNTBqB4SHtUHe5JY2x7LWRygw=; b=J4GaNh7m1oRJF4SwjjkkRuWfFqb/ItRwbP9zU6oZgzXEbImg3dU0ecevvYRjropRZYe0/b14XjrzQz3YZoiI7FRC2Rkm0CjDSVQnxCsbFqJvYpuqnrmTfQvBvyY2tNb5DVyKKyInEgee7TzgmKWl/CvOaogXgPMoT58mR3BBceaC3O7wguU9qNIUoWcearD1fFgmdYVxtrG+lwwPVAfS2teJvgfla2ikJG8Bm5bN2gapCIDrVUHl9vlOT7cjEAQH/1pOFZdj8FrLaZgzdvx/9VVOkEt6ESyxEmuGhpzmC1s06Q7FMGM5q0lY2cPWk8ga00WCC0mepWyGgKnB2EkeAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aPWUOBP1n8uU/1P4T2rNTBqB4SHtUHe5JY2x7LWRygw=; b=RV/8UO1+JL4xUEPqmxeddCc+gWgwjBMcvGYaKTGM4DadLCDUbXfgqqJcMyRIXzlHcnumOpDX130TAe74Ps8poYZg5lcEVtpkZZhtW63mZbAVkS+BlZwMBUnHKzO/KCbuPQ2t09ocYf/+5bTZMFlx66ty5XRB0XTPdCzwQhf11iSPRhybLPzAO9L6dOV2/QCd3Gwg9wQYYDD3oTv0BBt9h1fu4UzhRuUj1RvUUw68igAxqF2malzpS6rckys8GylqoOGyg5naMZGOrMN8gFdBKyEnAYS1+O76TtMi5LnSj6hEh3o7DfbR6Z2nfT/8ribVSu31mP/XxYSlZhkaNe758g== Received: from BYAPR11CA0082.namprd11.prod.outlook.com (2603:10b6:a03:f4::23) by BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Fri, 12 Jul 2024 10:50:35 +0000 Received: from SJ1PEPF000023D5.namprd21.prod.outlook.com (2603:10b6:a03:f4:cafe::76) by BYAPR11CA0082.outlook.office365.com (2603:10b6:a03:f4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22 via Frontend Transport; Fri, 12 Jul 2024 10:50:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023D5.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Fri, 12 Jul 2024 10:50:35 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:50:26 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:50:24 -0700 From: Xueming Li To: David Marchand CC: Ali Alnubani , dpdk stable Subject: patch 'net/iavf: remove outer UDP checksum offload for X710 VF' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:32 +0800 Message-ID: <20240712104528.308638-47-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D5:EE_|BL1PR12MB5732:EE_ X-MS-Office365-Filtering-Correlation-Id: 173c043d-7bc6-49ad-ab47-08dca26075c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rBs8zF6tYnuLEX64ZcrELA16TkfyCdl6/OhqBHH+Q3AtoKdQRyw79jRPTtKY?= =?us-ascii?Q?A7doAlzy5BC9ALvN3ZJdK0ibbHjzTMlRhSyyp5iLnWG3t7/2BvpGZeeUQq6s?= =?us-ascii?Q?9lFHJa9SIGc41fYD1dADfnpehBY51TeVCWeLxwPOMRBd+cfaGd0GzAVfD04J?= =?us-ascii?Q?wpH63RONoNfwjYlohjcAZ2dCi2g75kfQSRuN73aX7IPZsh9mU0Gixl8HfF+P?= =?us-ascii?Q?4agCrsa+YPBDnhpdn1yKDbFGUj7sFG2GiO4Ij7zTmNT/Tr5PxirenYoWQVb4?= =?us-ascii?Q?yIE2AMET0IiUQ/mL54LnHKBHtrnwiAWs9SUbNKKAIdD2ZCVALxtO6q8Q927K?= =?us-ascii?Q?3RLYwca/8oI9EouIlMQE+19LNHBb9dzb7gHW0KBnYtqqIKshky1UMfM/9Aes?= =?us-ascii?Q?vV/7qmxey9qS1NA9FIBaWPFnfF4kgJnjW36c0L2lRh1IcFSv4bZKBhfKTb8f?= =?us-ascii?Q?ncS2vb0zFxmrygFEwwMoLKiyozKsOMGAyHt1YXqwK3JDCS3ySI0FAUYAUgO2?= =?us-ascii?Q?elFVRHtBYn3Bxkm5Ybjz0a0vojPWK3pDb1hAi/ek3eo0QN6Z91Y/MGr5fQ+C?= =?us-ascii?Q?7F7zn2qzr+1YgVv1PAIUncr5yvu0IeCrvoxfoM6ntOprZVykZP8R4LGijq5N?= =?us-ascii?Q?igsTbdmL+JkAYJizL5EoKzsoFvWiA+bl6lB/VlXvxt2Cu8qUpWTF5nhZezOA?= =?us-ascii?Q?2dOtVhwnFUEEAAAstfNyMSe//MoHwg6TM9tpcYAFoiEAwChV7/xMEgGjR9tf?= =?us-ascii?Q?MgqVjFMKq34RE/Xeoe6xqk/pQDhzioKTOuHpLdRyMghK0Gbeo2sYMniqQApv?= =?us-ascii?Q?syhs53f69QBQvCQapn9EAyPuKE0k6/Pc1cCEsZpJ5EMN5QKNtRvmzacRfkUz?= =?us-ascii?Q?oChJaT0XTWB5GCCsfx0QzSVHJ7cy0UgwdTzbEW6+siwevz/GmE2ctT3/8RPe?= =?us-ascii?Q?pcbnXCl5tKDcz/omlsJ/ZBhyAEm0RHtYEARfAkKS0XYT9je6gPIzGIB/dIYj?= =?us-ascii?Q?YmObQGy2bpq3BUALIoKkpyPOmLmzzUaFohDipcJj/YYaQC7skgG49ApRF0Sr?= =?us-ascii?Q?XTF6/LKZmNnLzOD9Wvip0hktzsZzdTlCaGym+TuwG9T6tzmZylr6ajNYXwE/?= =?us-ascii?Q?vP7jqSH6pUmEWbcsT3V3hDjsCuz301vBJ36QWopKIUzMNYlNyP+ZhE07M/Ub?= =?us-ascii?Q?jnejVlNCaRG6175yrOTWTdJFOlic8sKuGI1OyT4iW2d1PoM83UayYufLq7jT?= =?us-ascii?Q?vS7h0zGs6CxSvbSEms0yG5mKpJz37MOjUmHs+Kf+slADQwI/+ComUuhcmK87?= =?us-ascii?Q?p3qaS/VkVJ7UoFsJWxSf8oV1Zy7PyTV7GWtAD8OUJ+6JHAd6211XcaP4G2bH?= =?us-ascii?Q?00wuP8fwYnDXIXAykfe2USbB33V7KqHSI2OXDsaWZXPRfnMirOHdG/19Uzff?= =?us-ascii?Q?SlqhZ6eYEnOG7ZhyU/D4yh/03Cy8khPI?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:50:35.5576 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 173c043d-7bc6-49ad-ab47-08dca26075c0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D5.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5732 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=039efb0ebef041f2a9c4f082101d8534fde570d6 Thanks. Xueming Li --- >From 039efb0ebef041f2a9c4f082101d8534fde570d6 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 18 Apr 2024 10:20:20 +0200 Subject: [PATCH] net/iavf: remove outer UDP checksum offload for X710 VF Cc: Xueming Li [ upstream commit 032ba1580bc36f31e431cf8d14dd3dec0079fa9c ] According to the X710 datasheet, X710 devices do not support outer checksum offload. """ 8.4.4.2 Transmit L3 and L4 Integrity Offload Tunneling UDP headers and GRE header are not offloaded while the X710/XXV710/XL710 leaves their checksum field as is. If a checksum is required, software should provide it as well as the inner checksum value(s) that are required for the outer checksum. """ Fix Tx offload capabilities depending on the VF type. Bugzilla ID: 1406 Fixes: f7c8c36fdeb7 ("net/iavf: enable inner and outer Tx checksum offload") Signed-off-by: David Marchand Tested-by: Ali Alnubani --- doc/guides/nics/features/iavf.ini | 2 +- drivers/net/iavf/iavf_ethdev.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini index c59115ae15..ce9860e963 100644 --- a/doc/guides/nics/features/iavf.ini +++ b/doc/guides/nics/features/iavf.ini @@ -33,7 +33,7 @@ L3 checksum offload = Y L4 checksum offload = Y Timestamp offload = Y Inner L3 checksum = Y -Inner L4 checksum = Y +Inner L4 checksum = P Packet type parsing = Y Rx descriptor status = Y Tx descriptor status = Y diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index c26612c4a1..2d85b947f6 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1163,7 +1163,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) RTE_ETH_TX_OFFLOAD_TCP_CKSUM | RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | @@ -1172,6 +1171,10 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) RTE_ETH_TX_OFFLOAD_MULTI_SEGS | RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE; + /* X710 does not support outer udp checksum */ + if (adapter->hw.mac.type != IAVF_MAC_XL710) + dev_info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; + if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_CRC) dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:16.203197075 +0800 +++ 0046-net-iavf-remove-outer-UDP-checksum-offload-for-X710-.patch 2024-07-12 18:40:14.066594232 +0800 @@ -1 +1 @@ -From 032ba1580bc36f31e431cf8d14dd3dec0079fa9c Mon Sep 17 00:00:00 2001 +From 039efb0ebef041f2a9c4f082101d8534fde570d6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 032ba1580bc36f31e431cf8d14dd3dec0079fa9c ] @@ -22 +24,0 @@ -Cc: stable@dpdk.org @@ -45 +47 @@ -index 245b3cd854..bbf915097e 100644 +index c26612c4a1..2d85b947f6 100644 @@ -48 +50 @@ -@@ -1174,7 +1174,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) +@@ -1163,7 +1163,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) @@ -56 +58 @@ -@@ -1183,6 +1182,10 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) +@@ -1172,6 +1171,10 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)