From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 365B945610 for ; Fri, 12 Jul 2024 12:51:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DCDB42F0A; Fri, 12 Jul 2024 12:51:47 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2083.outbound.protection.outlook.com [40.107.223.83]) by mails.dpdk.org (Postfix) with ESMTP id 1C6E940261 for ; Fri, 12 Jul 2024 12:51:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qlE1R4CWW4rkAhKTo41pWAWbyI6cSunU7TJ3DqVLruXFxCk63s6YztqScnuOSg/M4qcAqYITcx73FbUr9s5vDYDFu41cyxpcg5Qqyx88RWgoSPHcTHonV2+HS9Ad/KlIsQckoBFvjA/3DYvilJDmyUZaQFzhe+b4dFc0ikR1vA35Gi4Cfpk4JKkYvH7cjbjXH4slFeAe3pu7EG5sHhbCriW/HpljCPUnMTp6BNluBEskmMJt9XyX9zF//GkbtGKy8nBkRdV3ncXayWzFN/FGGOVBDGAm4FCMIWdWG4KGyUerSGk9q86JPt4p/FJqYr09KuJgbIZea6tqOayxKUZ/zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n8+HTcToqrjaJU1yEtu+IPYdZhhVYvMoMaxaaLqkOr4=; b=Bb4vfikDQoe8iD4PwZeVQNeYKmIKoQkv0o+atftsLsHanKLLfmcY1VzaxEeE0qm+Ogx0qp3ZtnNq12iLg2UnnijFaP2dQ43e6IvAlm0GZSyPKbpfnVi8WvwgmTsOiLeOF5ln3tTbv2DRh1Oe92h2EkfVfen4LEa6sT7cCd1jnTPlT5PzwDoJjAjfDNf44wNYBLhgkWc93DfNcX2Y3fb6m7Fhar9hHwYr2fwZWs6AYGm+UQ4yQl8MzuhiDV/TJ0l2pctMM/KSsnRTN6KbcaWlIK5J2gklrEsHZFs463q5qz55GHbVDoXx2Yf5hJa/0szthoor8rT+Bfe1MFQ9TYxMrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n8+HTcToqrjaJU1yEtu+IPYdZhhVYvMoMaxaaLqkOr4=; b=Zp4qdXvb3NXxxDONblghavNxgE6UQ6b6eXa5MZFlxmCBlAU/j+Kq9QdTQLfdpB5u1nhKKDnM5maq0c88BCXOur7OiQPX4zcmRTz7Qc3DX05TYbInh2Zd1oPoIFA51173KTafyaERPadSgLd2/FTwWxOprR2cL0aRcw1LWT9rbkFfitwqR0R5nB5gegQFT7LUdMz8uCXlQQZX1QqU3ZbGoXnA8TFHykkQgMPZpUDuqBHjs2eUTqGT0OFZ39e8BPMPwqgXOQ2ZAyUkZIGZbZ6KvQth6ko9c3hK/K9ifnM807/g/G8S5Ms4J9+IsJ25PdlZLLaft0UGwlR2jownSJiE+Q== Received: from BYAPR04CA0004.namprd04.prod.outlook.com (2603:10b6:a03:40::17) by IA1PR12MB6329.namprd12.prod.outlook.com (2603:10b6:208:3e5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23; Fri, 12 Jul 2024 10:51:43 +0000 Received: from SJ5PEPF000001D4.namprd05.prod.outlook.com (2603:10b6:a03:40:cafe::68) by BYAPR04CA0004.outlook.office365.com (2603:10b6:a03:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:51:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001D4.mail.protection.outlook.com (10.167.242.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 10:51:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:51:28 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:51:26 -0700 From: Xueming Li To: Hernan Vargas CC: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc: fix memory barrier' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:43 +0800 Message-ID: <20240712104528.308638-58-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D4:EE_|IA1PR12MB6329:EE_ X-MS-Office365-Filtering-Correlation-Id: b53e4b69-96af-4bd3-6fd0-08dca2609df6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AS53Oa8lzDUYUfayBIg8Q56JES4EiPsmf48vNBgOD5jINgbhih5sXWGCVjP2?= =?us-ascii?Q?GfSwOKBzEehHo5LvvH+FjMAgUWG9Zg0I7FLP8yCED1CQCr6OunqBuq9jSF+Q?= =?us-ascii?Q?QLQd6ppazM11SKa8UVqcR9Zv50GyWcJRydRrBv77uvDbRUF8oq1idjVJMXJ7?= =?us-ascii?Q?KEgiUFpCgKIX/UYO4jLtwN1u0hmF5pArjvXqQDE3wjUGuL5puu0A16W5l4i6?= =?us-ascii?Q?Ah8qMYKNbBe7qsX5bHmHDd10TMoBjRlI0R4TOorlQ75+Ya3RkNiLF0LNCSnp?= =?us-ascii?Q?RFwz7M4OMY4qjKOELQboW1gDwAfE8WYy4uVIfzvG0PcMMUjzHJU4RgtOflfM?= =?us-ascii?Q?z8mEpt0mKy3fheWnCBm1x09s4OjBGAQ1x6cKC42wWsrMJc2I9PvYabmEP8VT?= =?us-ascii?Q?FIsAMfcJL/awEY4jSmHnfkWN9FwUrAc3jDuqNpW8LWUf3Nd5bsyRMgpdw79j?= =?us-ascii?Q?V38pZtktPgQ04fioDevMdMfoiMoD/QL102Su5ozvypnDwvKDwatFPXaIt0+z?= =?us-ascii?Q?KC7X4/0epVpErx7yr78IoBa+NnOhN+sNiPqnVFsnYQQh/qZOlhhnbRwrwTtw?= =?us-ascii?Q?M6/515wnDuNTJe7UWhFf/pl/hdF/svlYeyq9/8pYWRhzTkoCG/qIroBjoDHj?= =?us-ascii?Q?E7qVoTsP9runSf6kT4EAfmROxdpG3vk1FSLO8nPElL/DADv2Hd0Oxeh7eBbl?= =?us-ascii?Q?YOR+NAwi8PLfaCm339UPHE8WW+/vag/vkZKno9FzWwjEGgEgf9EvCj5GjEYo?= =?us-ascii?Q?I+mB7lYCvluidfsRgyCwJ0h1ZLgSTCg9e5btAnaZFlYJWxjWX8DzRQm67EOZ?= =?us-ascii?Q?o7jsATPeodzs0EYStCmYNJj+jqvPTdtStsw1IuE/xqYWNJpSORsw300bddXB?= =?us-ascii?Q?8xRwxC8QwoDsB8q5kc5qs7QS3+O+11DfD6N+8WF+cXeJcmmRwoeX+Kwy8HgA?= =?us-ascii?Q?jlU7sPxEvBTo3qjWVuHX1W64dq+BYV3J7IOsATG9yXOqqgvxc9DqiGa+5Tfp?= =?us-ascii?Q?609jQbQNH/KZaiVSm7G15PzChiwNaokV8R6uT2AbhBvoWvfhIBx9CECgYBhk?= =?us-ascii?Q?LvkvBkSurzzbEC6BHPZzOud7o+OWJIY3QUYGMKcZHt/yfNnpMtNitman7Oyo?= =?us-ascii?Q?NFoJ85B1Y8KELhV+ZYylBCD4pM5pQnAkzUBd8ZC/idOP5YJf6axXIAyoslKN?= =?us-ascii?Q?cxGTOfJzCocf2ZJF9b6lAiFKi9lkBrnRbzmf+KbfUA6YFHOs2XSzti75STDd?= =?us-ascii?Q?LGr6wFZ25ZZROzcV4xynbtlTOYNASnN+hMG1ZvNhOamd59N7PDkCQ7tVxAsD?= =?us-ascii?Q?n4UeS3W9wVdaQ2id8W68tL0UyXiMLQfPL0NUHG8Vk5PSLlqxCWoR0G0/28gG?= =?us-ascii?Q?zry/0PRujtb+2ikvMcstcs9ZvBDWTLEc+ZFewRSfQXO1hQb5of33BCnJxTdD?= =?us-ascii?Q?e3aejPbLV5tvEh5P2lPMAmR5Y0vSS04y?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:51:42.9720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b53e4b69-96af-4bd3-6fd0-08dca2609df6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6329 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=0ab5bf3a37e66ef3a049a53c27865282a39c8d3c Thanks. Xueming Li --- >From 0ab5bf3a37e66ef3a049a53c27865282a39c8d3c Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 2 May 2024 13:45:44 -0700 Subject: [PATCH] baseband/acc: fix memory barrier Cc: Xueming Li [ upstream commit 0a200a3a29017f6b01a481776a571a75e03a32ce ] Moving memory barrier so that dequeue thread can be in sync with enqueue thread. Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h index bda2ad2f7a..6752c256d2 100644 --- a/drivers/baseband/acc/acc_common.h +++ b/drivers/baseband/acc/acc_common.h @@ -1110,6 +1110,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, req_elem_addr, (void *)q->mmio_reg_enqueue); + q->aq_enqueued++; + q->sw_ring_head += enq_batch_size; + rte_wmb(); /* Start time measurement for enqueue function offload. */ @@ -1120,8 +1123,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, queue_stats->acc_offload_cycles += rte_rdtsc_precise() - start_time; - q->aq_enqueued++; - q->sw_ring_head += enq_batch_size; n -= enq_batch_size; } while (n); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:16.798500604 +0800 +++ 0057-baseband-acc-fix-memory-barrier.patch 2024-07-12 18:40:14.116594226 +0800 @@ -1 +1 @@ -From 0a200a3a29017f6b01a481776a571a75e03a32ce Mon Sep 17 00:00:00 2001 +From 0ab5bf3a37e66ef3a049a53c27865282a39c8d3c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0a200a3a29017f6b01a481776a571a75e03a32ce ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index fddeb0737b..e249f37e38 100644 +index bda2ad2f7a..6752c256d2 100644 @@ -22 +24 @@ -@@ -1112,6 +1112,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, +@@ -1110,6 +1110,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, @@ -32 +34 @@ -@@ -1122,8 +1125,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n, +@@ -1120,8 +1123,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,