From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16B6A45610 for ; Fri, 12 Jul 2024 12:52:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1083B402E5; Fri, 12 Jul 2024 12:52:15 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2060.outbound.protection.outlook.com [40.107.100.60]) by mails.dpdk.org (Postfix) with ESMTP id 3AEA340261 for ; Fri, 12 Jul 2024 12:52:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wOBh3n3Go7DkklptnkYBviqh4biP4MRWIvucjBnhPx6MObgKR1HBxWCEnzq2g4+xW5eeI1yLfLg6BdQI15UQJmj2+cdWRL6x7OZWo53DzNi1iBzKTaLZdFuzCjRnrgz0I4qPwGXjX3FUUcEsO2mezLVBgXH9SscWv7du362FiKuejnNTS0LMKcSsk0tQ+Z7ac0cBqLA/qKd0xp/IsdCJQzdy9jRKBa9Kn2DUUdeS94TQ42npDN9asDKEfzqwllsLwGHB2yT7e9s+65aD19F0QIASCHfdIgQiDEeAThBz0tZ0Gz+jGArSN4YRv6XMOjUjK5gdXcrwPAJRQZo1kJ0lGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nYwWnTvxYpEhjJCxtctaIuXWZDRqGHS9OqkwP9DLVNA=; b=xMZQ9KhJheWe7bj3j0FCtUAb1ffT0ubx1hy96YcOBebr/gorIeIEKBY01n1BJ5R7BJDr4BC05XY8M+ehfj243V1MAHWxbnD3J1mZncGBCQx7iXrHurJpSm9KYeFrFPH8+XC0nWEJr2Jd4OTzUyAknrGYoh4FCqF6Fpd8V8JEmz3xl3L09L6qquQhQ/C51DySzGw+43/b+yB5QN625tKznfgRUWOJqJQ8JJdA7CuYCUN8R/kj5wmUbPYVtPRXDGZrlqbcOvcKh7hbAGMI8CUP4K/FysL4c5PShijmJey4zYdx4Sl3jHrSJd+Fjn7uSynwg2blWwQ/QMl/b3tDqXmvAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nYwWnTvxYpEhjJCxtctaIuXWZDRqGHS9OqkwP9DLVNA=; b=Da/iR+booOzqoCzLeMZgUDUCze1Fyio7SXT6fU4aNwqpOZOCG3iqP9seFOSiXD7Qvb9dDhqdghSa2d3bNN+Tkx8O7djtUbBdiHhWeQqGrKj79ZCWeJRLjGYvt2mOwzVhaodCIbYtR98CAqg/nJGvtxwV4EG/YgBSgjL7PN5ERGftmD5aV4+mFGS5JJ4hc0KR9kT/u9s/6Us1Gim3Kx0quH0/4mVf6p4GgDk24BODiEZXK8JcQRzxi3DJToWBGEi/LcHUS4Jdn3HUxCP0P+gw7lW0YBiEv93FzLA+CSOjkulQ9NFH3KPtKtaORbuGKyhKHyv63qjGF2aLtX0NteYEzA== Received: from SJ0PR03CA0231.namprd03.prod.outlook.com (2603:10b6:a03:39f::26) by CH3PR12MB8305.namprd12.prod.outlook.com (2603:10b6:610:12e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.36; Fri, 12 Jul 2024 10:52:10 +0000 Received: from SJ5PEPF000001D0.namprd05.prod.outlook.com (2603:10b6:a03:39f:cafe::61) by SJ0PR03CA0231.outlook.office365.com (2603:10b6:a03:39f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 10:52:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001D0.mail.protection.outlook.com (10.167.242.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 10:52:10 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:52:00 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 03:51:57 -0700 From: Xueming Li To: Stephen Hemminger CC: Jun Wang , Bruce Richardson , dpdk stable Subject: patch 'net/ixgbe: do not update link status in secondary process' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 18:44:49 +0800 Message-ID: <20240712104528.308638-64-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712104528.308638-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D0:EE_|CH3PR12MB8305:EE_ X-MS-Office365-Filtering-Correlation-Id: 6811d947-8cfb-4740-7cf5-08dca260ae2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BTilaMMCqrZQTUBFQ+38N2SDvrBrykeqpOtqxw0fpOT54j5JamYdAmwomo7M?= =?us-ascii?Q?G00z2nvTLHw5gk3rHXojccHLU1XPO/WhCiaSON4dF+tlu/aBBPYr2eXQ9JtM?= =?us-ascii?Q?VJ9BQOT+5gonIKnYqD/pkNq1eWLehR3PvGBjIx9iDN8Db8Ci+KaAjvsm6aA8?= =?us-ascii?Q?d6jgDD8rwFvr8SCYT1T9Y+CQDw8+8x19U1s6mjAnr7uwXTbNUmlqMfNdR6SO?= =?us-ascii?Q?7rw2WvJB9alDquO8B6IEO0yhrTOfVQcOsTA2bXjFNA8w2eNP5hWjyi1D+wkN?= =?us-ascii?Q?0uD0iKMNap6XoxzjeNUnzMF1Ztp5lgoDVNK0etInHXVVUaD+LuzJW68ngX8U?= =?us-ascii?Q?uEEwVbCRaf5X99FrwGgUn6JxMzGTTX6eIgSlKncYdTdNYep/R1vfOZKNjazP?= =?us-ascii?Q?yMhXlDO1ruFxiY+MZ5qPCOglALPot6CxNBV89fhiXDb0lPgWn9cNozBzXk45?= =?us-ascii?Q?d+wjn+cWp3OJqrdXg/kQNZjlXu2mHq4/4Xyh7MBfvIEyLuC0ixqv7zf3EIEx?= =?us-ascii?Q?AZXkp+u4WcKVLLji852ymHh4MiWf3slkMcXzRXXuIJMg2DdF/LNRXy4dsuOH?= =?us-ascii?Q?8DKf2ndCPaSBXdByfTcNJsnBJJj5kXGP+9V/N75uskcD5xKotKyB7NCoNHx8?= =?us-ascii?Q?Yrj5GGDr67ZEGMWxXdpwKwbQjRtFM2AOqkxouKmKISDkuve6McBdBN3DuvXX?= =?us-ascii?Q?oUQ6+Pcd8vDD0ZEvG/ipqhg5Xoujwxx46/YpOylCSpcgj1pC7pql8+5PHVJm?= =?us-ascii?Q?H10ECllyImB/w2xWFMHbBRPLMxAeyjQOVwybO2tDLeT5Ccrh6GU9TKEicXRh?= =?us-ascii?Q?zctRKYoMtOr5cxWEmH4vZdFtfG+GKSgLSN8Lmxv1XdykeRfAv0Z0V9Yxk2Z2?= =?us-ascii?Q?iT/84jihf0vzlvDoj/3Ibaq+HI0/BsiteWvvUrbJyAXrfHYIVWSF28Az8QMY?= =?us-ascii?Q?65lIunXrIpZO6GbU33SNXZSu/TrmxRuqC9neN0TIgtS2QfXsXYl1aDcY60Sd?= =?us-ascii?Q?XA8Do9WnL8j75nZeGmVti2h8r0TgIhfD2etD5cgBnGL1h3O//zznWZ9Gz2cs?= =?us-ascii?Q?BM058YgBqJIdtxO6MKdQv+C6Y0awCrDc6+iB6Yuk/HIu+ZIMqbzAKKQlq7p4?= =?us-ascii?Q?6PT8T9PXYaMIudaYPaP3LPGMPKTft6l6gfsfLRSNhZB8HLGeTtv92dvAXRtD?= =?us-ascii?Q?FFCdpa6xGohm/6wGWzpBXI1sdV8Rlr3Pw7O0im+/dbTlG/MayGSxwE5WrcVd?= =?us-ascii?Q?uGPZ34x6/5l1hHMiwZVOh9BMWZarBPoqS5yBdFiIyH+a/b8th9CgudS4ta0a?= =?us-ascii?Q?oMjtJHJ7/D3OxSY0hLaqGbsPqBiobLen3VWzDXOy4vqh/dHMU4E5S4OQNqz5?= =?us-ascii?Q?L5BRLXQYs/dGm4wJmsM+gCMtT4lr/y5x7nHQPZv6+s3Zj37q2lZckG9QQErn?= =?us-ascii?Q?wRsbJkI8ZaOlbjJOlQnfG0bU/w0U6NTL?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 10:52:10.2166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6811d947-8cfb-4740-7cf5-08dca260ae2c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8305 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=6f3188b1fccc5840cbc8152f5ed5922b1f6a78a6 Thanks. Xueming Li --- >From 6f3188b1fccc5840cbc8152f5ed5922b1f6a78a6 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 20 Mar 2024 10:33:04 -0700 Subject: [PATCH] net/ixgbe: do not update link status in secondary process Cc: Xueming Li [ upstream commit 5ffd40b85febd2a80b88b4cfbf4e1dd7e5f059c5 ] The code to update link status is not safe in secondary process. If called from secondary it will crash, example from dumpcap: ixgbe_dev_link_update_share() ixgbe_dev_link_update() rte_eth_link_get() Fixes: af75078fece3 ("first public release") Reported-by: Jun Wang Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index a32d3a6d7c..a54920042b 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4289,6 +4289,9 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, int wait = 1; u32 esdp_reg; + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return -1; + memset(&link, 0, sizeof(link)); link.link_status = RTE_ETH_LINK_DOWN; link.link_speed = RTE_ETH_SPEED_NUM_NONE; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:17.022448777 +0800 +++ 0063-net-ixgbe-do-not-update-link-status-in-secondary-pro.patch 2024-07-12 18:40:14.146594222 +0800 @@ -1 +1 @@ -From 5ffd40b85febd2a80b88b4cfbf4e1dd7e5f059c5 Mon Sep 17 00:00:00 2001 +From 6f3188b1fccc5840cbc8152f5ed5922b1f6a78a6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 5ffd40b85febd2a80b88b4cfbf4e1dd7e5f059c5 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index bbdc996f31..a6916da0c5 100644 +index a32d3a6d7c..a54920042b 100644 @@ -26 +28 @@ -@@ -4293,6 +4293,9 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, +@@ -4289,6 +4289,9 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,