From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AC8045610 for ; Fri, 12 Jul 2024 13:04:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33941402E5; Fri, 12 Jul 2024 13:04:09 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2045.outbound.protection.outlook.com [40.107.236.45]) by mails.dpdk.org (Postfix) with ESMTP id DC41840261 for ; Fri, 12 Jul 2024 13:04:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qrz/yWKdS9V85UO4V4HIuA7F2n2J9IkwZ+2EDqvgYiDTZsStpdzYjoTpNaKsyvW1Yqu8BaEsO1BpOSW/o4givuY494bOgqMC6b465JLWUSNMQmvdYwDZeiQH9mdmaKwfDO6leTrqLmjzqbGKqfBMitrZITyQVg8vMdikT3qZWdvC2IWiBExS4Yd3ie5pD2diJrmpGz7s6Qvd+0xOZZvLpiTwyyBENAoFASGd9fpZpXLnp1RcEPxeJSEFp+tHmrDfd5AFGGF2/OrkZxpgNDSvYeTmjvGFPRnCw53Sm8sp548Q4cwJrvJKBiUzOxqmsanMqKaiZ1pxWfAvwAsOb33Olg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VsRVqFmS0phvwEWuBhIQHtuFG/XrkyoGYmWbqd6o8iY=; b=gC4jI0jKiIh7tQdLS/T6ZFvME7Bdy07IviV8fm53bgcn809+SPRNPqYlRoydzXQGJmaHhmKwYOrVOyhU6FcAWqE7V1L/h9rtbqAeCQ49IJfaMTYej1us96JVT7OZLRkgSc0L18g5m3LKGZ2a2O7WqFRgTYIaAMbLu5q16O6oGumN8Yt1J0ALstmyv1YGOYWPi5O7dI6uk6CSv+/cq4HePCP00/GTA8FDMClo8wYkzCnjKPaXgYT0nCdSWxTEf0Juz3z4XN/bIRWA63ux5Abit3yF/hDPHoOCDJ7qRt4eksr8CbA1GzVGEIphy0f8gNcrtMWXC+jbRIAtWLGewDnmFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VsRVqFmS0phvwEWuBhIQHtuFG/XrkyoGYmWbqd6o8iY=; b=dX4sIszxP5ENAdsxGo69mJxQTT9rhoW/FoTf/D9RjiaSF8IetciiWOsHZAZWRRC3IcMJVBvuIUXe5Sdyy/uBG3o3ygr4viodlnaGNLd4mwK9C2kXE7tnGOQXCOJWxRmhiMmSLAYws/T2DhPPQ1doCRbCpSYWKCry8Ecf/KAHu7p/a6Lb8yto9vEYWgCbt1DBLEjo/tD2PEDpy5k3A2ep/VGmtONZ2VFaGXT3+GeBWIR72aMFPobI2N2tot5yZNGqeD39pLQEGf/Ym8Nqjn1qJlmvYXj9L13cDJ094pTcjtAnHM+GAiX/ZMXxywpk+ghFzc5+v1IE9TL0oYue+vz0qw== Received: from MN2PR19CA0008.namprd19.prod.outlook.com (2603:10b6:208:178::21) by PH7PR12MB5949.namprd12.prod.outlook.com (2603:10b6:510:1d8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Fri, 12 Jul 2024 11:04:03 +0000 Received: from BL02EPF0001A0FE.namprd03.prod.outlook.com (2603:10b6:208:178:cafe::5) by MN2PR19CA0008.outlook.office365.com (2603:10b6:208:178::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.23 via Frontend Transport; Fri, 12 Jul 2024 11:04:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF0001A0FE.mail.protection.outlook.com (10.167.242.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Fri, 12 Jul 2024 11:04:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 04:03:46 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 12 Jul 2024 04:03:44 -0700 From: Xueming Li To: David Marchand CC: Christian Ehrhardt , Bruce Richardson , dpdk stable Subject: patch 'telemetry: lower log level on socket error' has been queued to stable release 23.11.2 Date: Fri, 12 Jul 2024 19:01:50 +0800 Message-ID: <20240712110153.309690-20-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240712110153.309690-1-xuemingl@nvidia.com> References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712110153.309690-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FE:EE_|PH7PR12MB5949:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e27063f-d260-4434-a268-08dca2625717 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ey/k6wzLqQERecAF+bF1hGZ8Qq5mqxdgiyMBdsJQT13kq9HU0TR+yQsMqkmr?= =?us-ascii?Q?pml/xscaWiMVj8h0IkjEJ4O99Dw6b+jTl9PH5ozp6HZcl8nLF+FHdzOFt+f/?= =?us-ascii?Q?cXpykI4mWu/9Btv6F54/dBujH1DNQmeN1mAr2JtoZE/xBv1Ti1aY7+3uaoDc?= =?us-ascii?Q?gjYeqdTA5JC596bj/BONaa5pPF9OPCxaxDs9EkPTXec4v0TI2pe6OYC+pQZe?= =?us-ascii?Q?FWqZEpcZT8j6HBxH/GRiSLzRdNmJe8IRql+qSxEPf+DSYzswSryt5MApPgMb?= =?us-ascii?Q?w0KrPwmq6xdTlC3reuFKmLWEMtMFqEH9DSirj9hjkAv2wpxuE+uDNxSblsGI?= =?us-ascii?Q?T+eb0tBtB/x+pAeWKGc/uD03V9pKCDbE0ZBNRzsBSWpTrhwYtXupgdRzEf3q?= =?us-ascii?Q?/d9b95MVZfKL5VL8hFPaadyEOcyOzhC5KDqttcebkFhIcQPHNH20WU1YlYk8?= =?us-ascii?Q?17acZH+1cyoZ4w/svpIGBuxi0WSMq9mqbVPu2yzhoLI0vGqTbw28R390pb6T?= =?us-ascii?Q?90/upPuvJEsUPqjny9Q/vgg3PwjIXf0bUxUOcgFiIo999/MDlgAtWcB94t0C?= =?us-ascii?Q?uFB4gbH5dd9kdyVLLug5FPE9G8RUnA1Igb813Pud7ysEzgtWzTpFHRo81Bts?= =?us-ascii?Q?o/KqZ5xPQSvNnJAZuTT4Svli42hGJAUzx7ltldyWo75FP5dNAi4VPLy0Z7+n?= =?us-ascii?Q?asJdQiuZb3liT3dFiBCYMTVOiQCB2SxcyMbGwT5ra4MIQnYPir03lZWj98FY?= =?us-ascii?Q?I6N/HEAdgF35O7KzbFCzat6H26kkFMIz4cCacfQyhozDQSw0hV/O0Vk8sCZn?= =?us-ascii?Q?+0SdXRvq8M1imh+MueY30mVfIjSjPzJYTYURdmQAm0ebTe5Mfwwspl3cr8qC?= =?us-ascii?Q?hLbK8qRaxrO8aTlFwWAAvHV5qoJQwPeUB8Rl4jciTw2dLo8YEiSxW9oqYidC?= =?us-ascii?Q?LlYXeaLQgmchH9VOXHoNiGTYdurMGytDIBHY0/hrqx8FxDWJygGDG1F9Z1Jy?= =?us-ascii?Q?HUfNYDW08igEBNrVSkWakF6zPyd+KYr5kWSSkdcTm8xWM0YFGagaSz8ZNfMO?= =?us-ascii?Q?EkocVEAL6RaWBTfTsXPkyW+i5xYz4E0rY8I8G+GexeDqerRVifwwzVsfYFlU?= =?us-ascii?Q?tVJwvvWlxkE/URMB8avViFywctzdjp51S9nzlY/HsK7264F5kCMakCPNypnr?= =?us-ascii?Q?S+Z2wxdiyqpiaKgOBOesj7m3wT26P+2wsWQ2X98N0QayQNnA7TKeRCyVTDIy?= =?us-ascii?Q?QxF0Fldx3ArFrths8Mb7aaM8JxK464mGglyzJaLCNiJ/L4/CR8wbxTaMcK+0?= =?us-ascii?Q?E4qt0lmbALNxY3jrSRS/WM4Z1E76NZ7Mz8QTQ9CE8TqO40GY0ghSfeWQjXol?= =?us-ascii?Q?MVnMSmJ+w7yNqxbGtMGaB8hAn6wCGMU4OLSgNo1xDlERpNNVWZ9sGETLOPs0?= =?us-ascii?Q?tchXjVrS9A90BaWUwXd14mX/yatgyqli?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 11:04:02.9397 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e27063f-d260-4434-a268-08dca2625717 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5949 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=51ea612fcbaf60502388f2c4719e383f0314ad13 Thanks. Xueming Li --- >From 51ea612fcbaf60502388f2c4719e383f0314ad13 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 6 Jun 2024 14:26:54 +0200 Subject: [PATCH] telemetry: lower log level on socket error Cc: Xueming Li [ upstream commit 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 ] When starting two DPDK programs using the same DPDK prefix (like for example OVS and testpmd, both running as primary processes in --in-memory mode), the first DPDK process of the two spews some error log when the second starts: TELEMETRY: Socket write base info to client failed This is because telemetry init involves trying to connect on existing sockets to check if it can take over an existing socket file. On the other hand, this error log provides no helpful information. Lower this log to debug level. Fixes: e14bb5f10509 ("telemetry: fix connected clients count") Reported-by: Christian Ehrhardt Signed-off-by: David Marchand Acked-by: Bruce Richardson --- lib/telemetry/telemetry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index 88d6410980..551bc92e9d 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/telemetry/telemetry.c @@ -381,7 +381,7 @@ client_handler(void *sock_id) "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}", telemetry_version, getpid(), MAX_OUTPUT_LEN); if (write(s, info_str, strlen(info_str)) < 0) { - TMTY_LOG(ERR, "Socket write base info to client failed\n"); + TMTY_LOG(DEBUG, "Socket write base info to client failed"); goto exit; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-12 18:40:18.520753397 +0800 +++ 0099-telemetry-lower-log-level-on-socket-error.patch 2024-07-12 18:40:14.356594197 +0800 @@ -1 +1 @@ -From 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 Mon Sep 17 00:00:00 2001 +From 51ea612fcbaf60502388f2c4719e383f0314ad13 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 ] @@ -20 +22,0 @@ -Cc: stable@dpdk.org @@ -30 +32 @@ -index 1663bd8c68..509fae76ec 100644 +index 88d6410980..551bc92e9d 100644 @@ -33 +35 @@ -@@ -382,7 +382,7 @@ client_handler(void *sock_id) +@@ -381,7 +381,7 @@ client_handler(void *sock_id) @@ -37,2 +39,2 @@ -- TMTY_LOG_LINE(ERR, "Socket write base info to client failed"); -+ TMTY_LOG_LINE(DEBUG, "Socket write base info to client failed"); +- TMTY_LOG(ERR, "Socket write base info to client failed\n"); ++ TMTY_LOG(DEBUG, "Socket write base info to client failed");