* [PATCH v1] test/crypto: fix asymmetric capability test
@ 2024-07-15 13:37 Gowrishankar Muthukrishnan
2024-07-16 5:25 ` Anoob Joseph
2024-07-18 15:55 ` Akhil Goyal
0 siblings, 2 replies; 3+ messages in thread
From: Gowrishankar Muthukrishnan @ 2024-07-15 13:37 UTC (permalink / raw)
To: dev, Akhil Goyal, Fan Zhang, Shally Verma, Ashish Gupta,
Umesh Kartha, Pablo de Lara, Sunila Sahu
Cc: Anoob Joseph, Gowrishankar Muthukrishnan, stable
Fix asymmetric capability test for below:
* Skip test if asymmetric crypto feature is not supported by device.
* Assert return value of RTE function to get asymmetric capability.
Coverity issue: 373365
Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests")
Cc: stable@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
app/test/test_cryptodev_asym.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 3802cf8022..1d88832146 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -626,7 +626,7 @@ test_capability(void)
RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO)) {
RTE_LOG(INFO, USER1,
"Device doesn't support asymmetric. Test Skipped\n");
- return TEST_SUCCESS;
+ return TEST_SKIPPED;
}
/* print xform capability */
@@ -641,6 +641,7 @@ test_capability(void)
capa = rte_cryptodev_asym_capability_get(dev_id,
(const struct
rte_cryptodev_asym_capability_idx *) &idx);
+ TEST_ASSERT_NOT_NULL(capa, "Failed to get asymmetric capability");
print_asym_capa(capa);
}
}
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1] test/crypto: fix asymmetric capability test
2024-07-15 13:37 [PATCH v1] test/crypto: fix asymmetric capability test Gowrishankar Muthukrishnan
@ 2024-07-16 5:25 ` Anoob Joseph
2024-07-18 15:55 ` Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Anoob Joseph @ 2024-07-16 5:25 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan, dev, Akhil Goyal, Fan Zhang,
Shally Verma, Ashish Gupta, Umesh Kartha, Pablo de Lara,
Sunila Sahu
Cc: Gowrishankar Muthukrishnan, stable
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
> Subject: [PATCH v1] test/crypto: fix asymmetric capability test
>
> Fix asymmetric capability test for below:
> * Skip test if asymmetric crypto feature is not supported by device.
> * Assert return value of RTE function to get asymmetric capability.
>
> Coverity issue: 373365
> Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 14635 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1] test/crypto: fix asymmetric capability test
2024-07-15 13:37 [PATCH v1] test/crypto: fix asymmetric capability test Gowrishankar Muthukrishnan
2024-07-16 5:25 ` Anoob Joseph
@ 2024-07-18 15:55 ` Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2024-07-18 15:55 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan, dev, Fan Zhang, Shally Verma,
Ashish Gupta, Umesh Kartha, Pablo de Lara, Sunila Sahu
Cc: Anoob Joseph, Gowrishankar Muthukrishnan, stable
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
> Subject: [PATCH v1] test/crypto: fix asymmetric capability test
>
> Fix asymmetric capability test for below:
> * Skip test if asymmetric crypto feature is not supported by device.
> * Assert return value of RTE function to get asymmetric capability.
>
> Coverity issue: 373365
> Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Applied to dpdk-next-crypto
Thanks.
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 14571 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-18 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-15 13:37 [PATCH v1] test/crypto: fix asymmetric capability test Gowrishankar Muthukrishnan
2024-07-16 5:25 ` Anoob Joseph
2024-07-18 15:55 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).