From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A9FC455AD for ; Mon, 15 Jul 2024 17:29:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26C6540BA0; Mon, 15 Jul 2024 17:29:09 +0200 (CEST) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mails.dpdk.org (Postfix) with ESMTP id 2D7BB40DCD for ; Mon, 15 Jul 2024 17:29:08 +0200 (CEST) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-367a9ab4d81so2692172f8f.1 for ; Mon, 15 Jul 2024 08:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721057348; x=1721662148; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=amFszj9V+niUfp1KDDXV9oFknrZXMoGmP4g2Aqyvqx8=; b=k6kVsjOtP8TyOgTkc/KF0/hv9zVokQ4dmw3sO8SKWCMyKxZCG9OznoScLLH2LeDPj3 iwH/Xxs4xTrwiNBvhvs661nb4CR5MTg1xmehzbmTyqiqz5MISf0MI4JbFjlSUPJAcJFa CveaM86IvBi6a5gzj7swMi/YaIB3eqR+crB0OaDW8miCfyp/oDXLrzzcFjLYCinAgNde wQq01g9oHt0n1Rg5RjpN+Uog582lvKkN86/KTU4j7EBhBcrGPNwiikZOhz4ju2tGGIc0 WC9hdpIjkFJsmxhVNoewNi5FApz9QakxlT/w7POSTcV8uSROFmZxT8nfal7at5+GMGBX Ugyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721057348; x=1721662148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=amFszj9V+niUfp1KDDXV9oFknrZXMoGmP4g2Aqyvqx8=; b=pSQs6Un85q3VlEXOdOR9h3twqra5kzBRjzNeaOO1NOBYtZTwKeihShoV2yVbX2FTdY Ptlm4hr8MjYAsOwY2CtlZKCtxAjAV1nBAecS3WpdL1XorcgOY2nuxmnymBQOA3mLeFyr 6l3cnL3Kdbxx3SQ8LMgOaNL0In11eNY2nyrPsG8y9og7g/3XErDI8lBHt22gXE3l+esV i2+D/1f2rRkJHq3sZMmiKVV70Qdls38J/aItX0wZp9YKvt+yBl2k8tSpt1MWsQN/s3jQ G5Zf2bMPCqlVhR/pzhhskp8VYvEw2+AHZzi0LkzQmvCj/9D8JbHkhYbJlNM9ls01/ga+ 6bAQ== X-Forwarded-Encrypted: i=1; AJvYcCWj9q9KcBScUxMEk0d0mqrODiXQ/piLaSRgqUtMWWY+Jel+PNghFi6QqUl1Ceo7xqBtb28y5qHORK4A9ZGer/k= X-Gm-Message-State: AOJu0YzyzP8/+0fu8fXdWsud3O9/5CDuumulS3cDbv66uywcvvPls05D 1HxFBFoqrJuCFqZMpoFRfZd/BaWZKpkE5I6tnPm9QhdtUQueqWQ5yKWrWzXD X-Google-Smtp-Source: AGHT+IE7Se4Dn2ZoanjWWy9iubCP/7mnoKlCK1ao6r87GxMC809RoDal6GhCwMOi+S8bQzs4W6JLJw== X-Received: by 2002:adf:ff8f:0:b0:367:909b:8281 with SMTP id ffacd0b85a97d-368240caf85mr41026f8f.59.1721057347756; Mon, 15 Jul 2024 08:29:07 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680db038f4sm6607337f8f.94.2024.07.15.08.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 08:29:07 -0700 (PDT) From: luca.boccassi@gmail.com To: Rohit Raj Cc: Vanshika Shukla , dpdk stable Subject: patch 'bus/dpaa: remove redundant file descriptor check' has been queued to stable release 22.11.6 Date: Mon, 15 Jul 2024 16:26:17 +0100 Message-Id: <20240715152704.2229503-39-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240715152704.2229503-1-luca.boccassi@gmail.com> References: <20240624235907.885628-81-luca.boccassi@gmail.com> <20240715152704.2229503-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/17/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b7594f8f156098c3e00f7f005f44758f770542f2 Thanks. Luca Boccassi --- >From b7594f8f156098c3e00f7f005f44758f770542f2 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Wed, 10 Jul 2024 14:25:31 +0530 Subject: [PATCH] bus/dpaa: remove redundant file descriptor check [ upstream commit 0ca2093f6b3608467bebe9caf27ce98671fb3381 ] This patch removes the redundant file descriptor check. Coverity issue: 425715 Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/process.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/process.c b/drivers/bus/dpaa/base/qbman/process.c index 3504ec97db..3e4622f606 100644 --- a/drivers/bus/dpaa/base/qbman/process.c +++ b/drivers/bus/dpaa/base/qbman/process.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) * * Copyright 2011-2016 Freescale Semiconductor Inc. - * Copyright 2017,2020 NXP + * Copyright 2017,2020,2022,2024 NXP * */ #include @@ -27,15 +27,16 @@ static int check_fd(void) { int ret; - if (fd >= 0) - return 0; ret = pthread_mutex_lock(&fd_init_lock); assert(!ret); + /* check again with the lock held */ if (fd < 0) fd = open(PROCESS_PATH, O_RDWR); + ret = pthread_mutex_unlock(&fd_init_lock); assert(!ret); + return (fd >= 0) ? 0 : -ENODEV; } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-15 16:19:36.635580126 +0100 +++ 0039-bus-dpaa-remove-redundant-file-descriptor-check.patch 2024-07-15 16:19:34.532205695 +0100 @@ -1 +1 @@ -From 0ca2093f6b3608467bebe9caf27ce98671fb3381 Mon Sep 17 00:00:00 2001 +From b7594f8f156098c3e00f7f005f44758f770542f2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0ca2093f6b3608467bebe9caf27ce98671fb3381 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 59e0d641ce..2d805c5bd9 100644 +index 3504ec97db..3e4622f606 100644 @@ -31 +32 @@ -@@ -28,15 +28,16 @@ static int check_fd(void) +@@ -27,15 +27,16 @@ static int check_fd(void)