From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C3DA455AD for ; Mon, 15 Jul 2024 17:31:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6775640E20; Mon, 15 Jul 2024 17:31:33 +0200 (CEST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id E474740A71 for ; Mon, 15 Jul 2024 17:31:31 +0200 (CEST) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4272738eb9eso32711165e9.3 for ; Mon, 15 Jul 2024 08:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721057491; x=1721662291; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FMefru4xsK2cUg+sxyk63hWGRbfK0zNnul/M8RhJ5TE=; b=R06Dp38CN4YtDHcOUPizoWVD0umwVH7zufdQdVZnle+EBybr0QZK0QZbgesLre9Dm8 PQp9HZK4XEldkHGriVnW5srD9qaTf0FX8bZ3AQJdzjbJOi55CfQ6f9BPYEqyEnUqe3ug JiT3JS2kKQxTyMJduR+t7MxmNWv7XMIonutIRKN6Go5t/kNrtGVAjsU5t3mj+Onjch7p XTfkl3QmVtpgh/4k3PEZSGbJyBb+zpLImOqFamqrtzlUerrvnbkb/kBx7FsNwZhpYKv6 FgjG4SvJsycftH32/XhpToTyihZYAjFQnFeA6DH34ao5giOUy3N/BXEA46y3QUM8EvsN GXnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721057491; x=1721662291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FMefru4xsK2cUg+sxyk63hWGRbfK0zNnul/M8RhJ5TE=; b=Od55pn57SEt6g9d658FVMeGn46nxCTSwZUx5ukk42jAiPl26r4ygqOisKOeLwzs0w5 vRXCCxWL24MS+ygot497msaHvJkOa1UBt2wHfrYYxjoMIPDB3Famri+C24dxzboJ3je+ 3d4xzK4rSEj37PabsuipvtO4gN3Rm6Dk91TS+8cdtpKAC2k5rZVSuvNq49tW5VZzQqmL RfA1WidxTPnsVqie6ZHS/w2xyvikucLng/yXxfhINoeh52ISLjWm4+Wmi/nzfu05I9Ts GnSLGMhe7h3RaucIRa40tpe/Y2sTPLPtl7quCoem3U/fwcnfTnO9DBvKRMvdXDNLgc8I a9yQ== X-Gm-Message-State: AOJu0Yzv/USi46t5XZraZty+hv7yb/+VoFJrcHDxgYlznE6J5bD2uEFr CeLbjpCPtJKFpZGquDrgMTo9kFdoq8f7O+caJkgh+EnA5K2K2srD9zvfGRRGUSI= X-Google-Smtp-Source: AGHT+IGfUR66v9EcL6PTZOkTGBXxdNqZPLRDdzNOZaVsxxV7Yyy6V6i9ingXDLy/AUZ7Ht7Spf7upQ== X-Received: by 2002:a05:600c:754:b0:426:5b3a:96c with SMTP id 5b1f17b1804b1-426707f8122mr122524275e9.28.1721057491525; Mon, 15 Jul 2024 08:31:31 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a63449fcsm90398195e9.29.2024.07.15.08.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 08:31:31 -0700 (PDT) From: luca.boccassi@gmail.com To: Shai Brandes Cc: dpdk stable Subject: patch 'net/ena: fix checksum handling' has been queued to stable release 22.11.6 Date: Mon, 15 Jul 2024 16:27:00 +0100 Message-Id: <20240715152704.2229503-82-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240715152704.2229503-1-luca.boccassi@gmail.com> References: <20240624235907.885628-81-luca.boccassi@gmail.com> <20240715152704.2229503-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/17/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/18b7942cef2ec0c26c7999550d72f4558e456cd3 Thanks. Luca Boccassi --- >From 18b7942cef2ec0c26c7999550d72f4558e456cd3 Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 2 Jul 2024 17:46:24 +0300 Subject: [PATCH] net/ena: fix checksum handling [ upstream commit f66055c7564050e55c7eab147d039bf01048829a ] This change fixes an issue where a non tcp/udp packet can be indicated to have an invalid csum. If the device erroneously tries to verify the csum on a non tcp/udp packet it will result in false indication that there is a csum error. This change make the driver ignore the indication for csum error on such packets. Fixes: 84daba9962b5 ("net/ena: add extra Rx checksum related xstats") Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 881e2ecdaf..e640bbae3d 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -590,7 +590,8 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, packet_type |= RTE_PTYPE_L3_IPV6; } - if (!ena_rx_ctx->l4_csum_checked || ena_rx_ctx->frag) { + if (!ena_rx_ctx->l4_csum_checked || ena_rx_ctx->frag || + !(packet_type & (RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP))) { ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; } else { if (unlikely(ena_rx_ctx->l4_csum_err)) { -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-15 16:19:38.656312875 +0100 +++ 0082-net-ena-fix-checksum-handling.patch 2024-07-15 16:19:34.732209965 +0100 @@ -1 +1 @@ -From f66055c7564050e55c7eab147d039bf01048829a Mon Sep 17 00:00:00 2001 +From 18b7942cef2ec0c26c7999550d72f4558e456cd3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f66055c7564050e55c7eab147d039bf01048829a ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 67a1d86f9a..a18c94df28 100644 +index 881e2ecdaf..e640bbae3d 100644 @@ -24 +25 @@ -@@ -669,7 +669,8 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, +@@ -590,7 +590,8 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,