[PATCH v1] crypto/aesni_mb: fix typo in error message

[PATCH v1] crypto/aesni_mb: fix typo in error message

[Joel Kavanagh]

This patch fixes a typo in the log message for error allocation.
The typo incorrectly spelled 'allocating' as 'allocationg' in the
log message for error allocation.

Additionally, this commit updates the .mailmap file to ensure proper
attribution and mapping of contributor email addresses.

Fixes: f9dfb59 ("crypto/ipsec_mb: support remaining SGL")
Cc: stable@dpdk.org

Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
---
 .mailmap                               | 1 +
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index f1e64286a1..5b6e30d76c 100644
--- a/.mailmap
+++ b/.mailmap
@@ -681,6 +681,7 @@ Jin Yu <jin.yu@intel.com>
 Jiri Slaby <jslaby@suse.cz>
 Job Abraham <job.abraham@intel.com>
 Jochen Behrens <jochen.behrens@broadcom.com> <jbehrens@vmware.com>
+Joel Kavanagh <joel.kavanagh@intel.com>
 Joey Xing <joey.xing@jaguarmicro.com>
 Johan Faltstrom <johan.faltstrom@netinsight.net>
 Johan Källström <johan.kallstrom@ericsson.com>
diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index d74946c180..ef4228bd38 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -1534,7 +1534,7 @@ aesni_mb_digest_appended_in_src(struct rte_crypto_op *op, IMB_JOB *job,
  *
  * @return
  * - 0 on success, the IMB_JOB will be filled
- * - -1 if invalid session or errors allocationg SGL linear buffer,
+ * - -1 if invalid session or errors allocating SGL linear buffer,
  *   IMB_JOB will not be filled
  */
 static inline int
-- 
2.34.1

RE: [PATCH v1] crypto/aesni_mb: fix typo in error message

[Dooley, Brian]

Hi Joel,

> -----Original Message-----
> From: Joel Kavanagh <joel.kavanagh@intel.com>
> Sent: Thursday, July 11, 2024 2:15 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Ji, Kai <kai.ji@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Fan Zhang
> <fanzhang.oss@gmail.com>; Ciara Power <ciara.power@intel.com>
> Cc: dev@dpdk.org; gakhil@marvell.com; stable@dpdk.org; Kavanagh, Joel
> <joel.kavanagh@intel.com>
> Subject: [PATCH v1] crypto/aesni_mb: fix typo in error message
> 
> This patch fixes a typo in the log message for error allocation.
> The typo incorrectly spelled 'allocating' as 'allocationg' in the log message for
> error allocation.
> 
> Additionally, this commit updates the .mailmap file to ensure proper
> attribution and mapping of contributor email addresses.
> 
> Fixes: f9dfb59 ("crypto/ipsec_mb: support remaining SGL")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
> ---
>  .mailmap                               | 1 +
>  drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/.mailmap b/.mailmap
> index f1e64286a1..5b6e30d76c 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -681,6 +681,7 @@ Jin Yu <jin.yu@intel.com>  Jiri Slaby <jslaby@suse.cz>
> Job Abraham <job.abraham@intel.com>  Jochen Behrens
> <jochen.behrens@broadcom.com> <jbehrens@vmware.com>
> +Joel Kavanagh <joel.kavanagh@intel.com>
>  Joey Xing <joey.xing@jaguarmicro.com>
>  Johan Faltstrom <johan.faltstrom@netinsight.net>  Johan Källström
> <johan.kallstrom@ericsson.com> diff --git
> a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
> b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
> index d74946c180..ef4228bd38 100644
> --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
> +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
> @@ -1534,7 +1534,7 @@ aesni_mb_digest_appended_in_src(struct
> rte_crypto_op *op, IMB_JOB *job,
>   *
>   * @return
>   * - 0 on success, the IMB_JOB will be filled
> - * - -1 if invalid session or errors allocationg SGL linear buffer,
> + * - -1 if invalid session or errors allocating SGL linear buffer,
>   *   IMB_JOB will not be filled
>   */
>  static inline int
> --
> 2.34.1

Acked-by: Brian Dooley <brian.dooley@intel.com>

[PATCH v2 0/4] Fix spelling mistakes

[Joel Kavanagh]

Fix up crypto spelling mistakes.

v2: Added more typo fixes to patchset

Joel Kavanagh (4):
  crypto/aesni_mb: fix typo in error message
  app/test: fix typo in error message allocation
  crypto/qat: fix typo in log message
  doc: fix typo in l2fwd-crypto guide

 .mailmap                                       | 1 +
 app/test/test_cryptodev.c                      | 6 +++---
 doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +-
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c         | 2 +-
 drivers/crypto/qat/qat_sym.c                   | 2 +-
 5 files changed, 7 insertions(+), 6 deletions(-)

-- 
2.34.1

[PATCH v2 1/4] crypto/aesni_mb: fix typo in error message

[Joel Kavanagh]

This patch fixes a typo in the log message for error allocation.
The typo incorrectly spelled 'allocating' as 'allocationg' in the
log message for error allocation.

Fixes: f9dfb59edbcc ("crypto/ipsec_mb: support remaining SGL")
Cc: stable@dpdk.org

Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
Acked-by: Brian Dooley <brian.dooley@intel.com>
---
v2: Added more typo fixes to patchset
---
 .mailmap                               | 1 +
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 9d0e1380cf..6822c54376 100644
--- a/.mailmap
+++ b/.mailmap
@@ -678,6 +678,7 @@ Jin Yu <jin.yu@intel.com>
 Jiri Slaby <jslaby@suse.cz>
 Job Abraham <job.abraham@intel.com>
 Jochen Behrens <jochen.behrens@broadcom.com> <jbehrens@vmware.com>
+Joel Kavanagh <joel.kavanagh@intel.com>
 Joey Xing <joey.xing@jaguarmicro.com>
 Johan Faltstrom <johan.faltstrom@netinsight.net>
 Johan Källström <johan.kallstrom@ericsson.com>
diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
index d74946c180..ef4228bd38 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -1534,7 +1534,7 @@ aesni_mb_digest_appended_in_src(struct rte_crypto_op *op, IMB_JOB *job,
  *
  * @return
  * - 0 on success, the IMB_JOB will be filled
- * - -1 if invalid session or errors allocationg SGL linear buffer,
+ * - -1 if invalid session or errors allocating SGL linear buffer,
  *   IMB_JOB will not be filled
  */
 static inline int
-- 
2.34.1

[PATCH v2 2/4] app/test: fix typo in error message allocation

[Joel Kavanagh]

This patch fixes a typo in the `test_cryptodev.c` file where "out-op" was
incorrectly used instead of "out-of-place" on three separate occassions.

Fixes: f3dbf94be60c ("app/test: check SGL on QAT")
Fixes: 43220096d66a ("test/crypto: add PDCP cases for scatter gather")
Cc: stable@dpdk.org

Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
---
 app/test/test_cryptodev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 6042db36a4..c846b26ed1 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -9428,7 +9428,7 @@ static int test_pdcp_proto(int i, int oop, enum rte_crypto_cipher_operation opc,
 	/* Out of place support */
 	if (oop) {
 		/*
-		 * For out-op-place we need to alloc another mbuf
+		 * For out-of-place we need to alloc another mbuf
 		 */
 		ut_params->obuf = rte_pktmbuf_alloc(ts_params->mbuf_pool);
 		rte_pktmbuf_append(ut_params->obuf, output_vec_len);
@@ -9637,7 +9637,7 @@ test_pdcp_proto_SGL(int i, int oop,
 	/* Out of place support */
 	if (oop) {
 		/*
-		 * For out-op-place we need to alloc another mbuf
+		 * For out-of-place we need to alloc another mbuf
 		 */
 		ut_params->obuf = rte_pktmbuf_alloc(ts_params->mbuf_pool);
 		rte_pktmbuf_append(ut_params->obuf, frag_size_oop);
@@ -16831,7 +16831,7 @@ test_authenticated_encryption_SGL(const struct aead_test_data *tdata,
 	}
 
 	/*
-	 * For out-op-place we need to alloc another mbuf
+	 * For out-of-place we need to alloc another mbuf
 	 */
 	if (oop) {
 		ut_params->obuf = rte_pktmbuf_alloc(ts_params->mbuf_pool);
-- 
2.34.1

[PATCH v2 3/4] crypto/qat: fix typo in log message

[Joel Kavanagh]

This patch fixes a typo in the log message for rte_security support.
The typo incorrectly spelled 'enabled' as 'ensabled' in the
log message indicating that rte_security support is enabled.

Fixes: fb3b9f492205 ("crypto/qat: rework burst data path")
Cc: stable@dpdk.org

Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
---
 drivers/crypto/qat/qat_sym.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index b41d1b1def..d979ae6489 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -291,7 +291,7 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev)
 		}
 
 		cryptodev->feature_flags |= RTE_CRYPTODEV_FF_SECURITY;
-		QAT_LOG(INFO, "Device %s rte_security support ensabled", name);
+		QAT_LOG(INFO, "Device %s rte_security support enabled", name);
 	} else {
 		QAT_LOG(INFO, "Device %s rte_security support disabled", name);
 	}
-- 
2.34.1

[PATCH v2 4/4] doc: fix typo in l2fwd-crypto guide

[Joel Kavanagh]

This patch fixes a typo in the l2fwd-crypto documentation where
the l2fwd-crypt was changed to l2fwd-crypto.

Fixes: 7cacb0565539 ("doc: add generic build instructions for sample apps")
Cc: stable@dpdk.org

Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
---
 doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst b/doc/guides/sample_app_ug/l2_forward_crypto.rst
index ce49eab96f..7ff304d05c 100644
--- a/doc/guides/sample_app_ug/l2_forward_crypto.rst
+++ b/doc/guides/sample_app_ug/l2_forward_crypto.rst
@@ -30,7 +30,7 @@ Compiling the Application
 
 To compile the sample application see :doc:`compiling`.
 
-The application is located in the ``l2fwd-crypt`` sub-directory.
+The application is located in the ``l2fwd-crypto`` sub-directory.
 
 Running the Application
 -----------------------
-- 
2.34.1

RE: [EXTERNAL] [PATCH v2 1/4] crypto/aesni_mb: fix typo in error message

[Akhil Goyal]

> Subject: [EXTERNAL] [PATCH v2 1/4] crypto/aesni_mb: fix typo in error message
> 
> This patch fixes a typo in the log message for error allocation.
> The typo incorrectly spelled 'allocating' as 'allocationg' in the
> log message for error allocation.
> 
> Fixes: f9dfb59edbcc ("crypto/ipsec_mb: support remaining SGL")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Joel Kavanagh <joel.kavanagh@intel.com>
> Acked-by: Brian Dooley <brian.dooley@intel.com>
Series Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto

Thanks for the fixes.