From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 213474569C for ; Wed, 24 Jul 2024 13:34:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C9EE433D2; Wed, 24 Jul 2024 13:34:37 +0200 (CEST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mails.dpdk.org (Postfix) with ESMTP id 37CDC43394 for ; Wed, 24 Jul 2024 13:34:35 +0200 (CEST) Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2eeb1051360so67317421fa.0 for ; Wed, 24 Jul 2024 04:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721820875; x=1722425675; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8E9gzhVwDl6+IUzzq5fXSRcQlvyXS31s1UXHiCl9IVI=; b=DKnRlS9Ijr/hCXBdUgzJ8xqI9Qu9Lvs5J5iY0Iw6LYH2cz7pd6ihfNPz97sTkizbei JPLGlk4Lp1WPzmh9RQZDySuIbOmGtCT3en9pHKQ89l25avddU97HS8uImxkY1xCobBAe SkWhyi68ml1ZuSgEaEl1F+yeqlYzxtfkd0qKlDuaHBug7K54LnPEW9JiwX+926iT6pon QaOqaOWx01exTs16puxD2LJEDDXN30uZdAciiPbWfAQmVUhYwr+HhjFAY8VgEWa2CIGy 3tVpDQId2noOGOD2AgHXyueDrv15Jb/YV/onrKneoB2WgaAbzMbWwqlpZ8OiBBJUWyHE K7Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721820875; x=1722425675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8E9gzhVwDl6+IUzzq5fXSRcQlvyXS31s1UXHiCl9IVI=; b=R+D33Lg2eH9m34EcsFXmyR7hMr1kXi0xAuWQjKIshfK4oom4WrOdAVJrZLyDO7UGxO Yl0TrgRyieT/FPAULmsheaSBZXGb+ui+XTs1ljCbT9Yc6E5pzo3E5CXEmL1zftFuwPoV 85VjvIsAFOvaH0fK06IY0Tt1DaSt3lHAK4uLJAi1D+9V6xbX+h29gu0UoNPS4kbh76Ux zpzTNgFBDvJX2SJVi1krz1AS7P9FiehBLOiyOgzMmgRwRtXl9+3S6Im/8FYuJJwxFJuR shQm9vtdA6rCHl58/Xv5PCBHMBsFL8Bvl796eHAT5n6nWfnGNcijpew2Ly5rRogtda+N r/AA== X-Forwarded-Encrypted: i=1; AJvYcCUKGDTY+lg3xiCyQ1NH7tJbROqARQtgDlc1OJ0PXW8nu64KOQ44YXbab6ZZ0UZ7FYM6Q/7phurz6nKolnZOO3g= X-Gm-Message-State: AOJu0YxD1j7RkrTnRsCOCsvXvWXrL9XF3RIK3Ko9rPWAyDkkJktfVoV2 rbrBBeHWtQ2nbalCfytoz9sguAR5Jb2OkpwtFE3OU7mMnq61GLhUfVL9jy74 X-Google-Smtp-Source: AGHT+IGWV5EngQr72vz/SBytr/Lddxd23UPudRariFwz3EXyompPr15P59TYogj+Xy3P+sWdSyw2zw== X-Received: by 2002:a2e:8912:0:b0:2ef:24e8:fd83 with SMTP id 38308e7fff4ca-2f032544908mr13510131fa.38.1721820874539; Wed, 24 Jul 2024 04:34:34 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427f9413547sm26019075e9.44.2024.07.24.04.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 04:34:34 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Raslan Darawsheh , Ali Alnubani , dpdk stable Subject: patch 'app/testpmd: fix build on signed comparison' has been queued to stable release 22.11.6 Date: Wed, 24 Jul 2024 12:33:03 +0100 Message-Id: <20240724113318.616754-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240724113318.616754-1-luca.boccassi@gmail.com> References: <20240715152704.2229503-86-luca.boccassi@gmail.com> <20240724113318.616754-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/99b0e4a22c4dd9cd718dc23e2c583bf4b2a21b3e Thanks. Luca Boccassi --- >From 99b0e4a22c4dd9cd718dc23e2c583bf4b2a21b3e Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 22 Jul 2024 03:52:29 -0700 Subject: [PATCH] app/testpmd: fix build on signed comparison [ upstream commit 1f47f469aac68bc88be24e530b4267d03537de12 ] Build error: .../app/test-pmd/config.c: In function 'icmp_echo_config_setup': .../app/test-pmd/config.c:5159:30: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) ^ All 'nb_txq', 'nb_fwd_ports' & 'nb_fwd_lcores' are unsigned variables, but the warning is related to the integer promotion rules of C: 'nb_txq' -> uint16_t, promoted to 'int' 'nb_fwd_ports' -> uint16_t, promoted to 'int' (nb_txq * nb_fwd_ports) -> result 'int' nb_fwd_lcores -> 'uint32_t' Ends up comparing 'int' vs 'uint32_t'. Fixing by adding the casting back which was initially part of the patch. Fixes: 2bf44dd14fa5 ("app/testpmd: fix lcore ID restriction") Reported-by: Raslan Darawsheh Signed-off-by: Ferruh Yigit Tested-by: Ali Alnubani --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1a6d791129..4ff0e72115 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -4618,7 +4618,7 @@ icmp_echo_config_setup(void) lcoreid_t lc_id; uint16_t sm_id; - if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) + if ((lcoreid_t)(nb_txq * nb_fwd_ports) < nb_fwd_lcores) cur_fwd_config.nb_fwd_lcores = (lcoreid_t) (nb_txq * nb_fwd_ports); else -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-24 12:29:22.694533464 +0100 +++ 0025-app-testpmd-fix-build-on-signed-comparison.patch 2024-07-24 12:29:20.795026614 +0100 @@ -1 +1 @@ -From 1f47f469aac68bc88be24e530b4267d03537de12 Mon Sep 17 00:00:00 2001 +From 99b0e4a22c4dd9cd718dc23e2c583bf4b2a21b3e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1f47f469aac68bc88be24e530b4267d03537de12 ] + @@ -24 +25,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 66c3a68c1d..6f0beafa27 100644 +index 1a6d791129..4ff0e72115 100644 @@ -37 +38 @@ -@@ -5156,7 +5156,7 @@ icmp_echo_config_setup(void) +@@ -4618,7 +4618,7 @@ icmp_echo_config_setup(void)