From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0273F457A1 for ; Mon, 12 Aug 2024 14:52:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0A40402C3; Mon, 12 Aug 2024 14:52:01 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2080.outbound.protection.outlook.com [40.107.220.80]) by mails.dpdk.org (Postfix) with ESMTP id 1B3524029C for ; Mon, 12 Aug 2024 14:52:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uNNW5L4J4X8qIav6wtbCrODeWsSyJ9doH+ghRFBoNq4DzYlrebbljQPKHm5GZNv1ALl26PEIOFHscxqKHdQpMuibESexuz8EmGzi9RkEM917mj8Tyuw0Hkg9cH42SIWemSjzP1TMKfK3bSEUADBneoo610EtfJ4WBX/5GS854kr6EUrQAZqw+SvboKTsJeZbLMqesPQ4Fh154IbBJQzZcbKZzTfTtMY1S3mWA+n6s2+5McIyYml4/ELs4vISS7WNS93zM8PmT9Z8KHkiHS9woDgClWrc+WckLCdD57nF4eIof5xRTzcasTQOi1D3T6i8ekUVcGUvMxhYQxdbs8fsiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHZk/vUrzScXXMPJUeDNo/IYU7H9hBrXhijJfuyz4us=; b=wJHa1/16e4YynDes/gPWWHQIfd0FNpoHAJ8w2ryfPLJQdedd7zAEKBUVRQXazrUl8nQ5L8U230sx5A9voulm/2LFlhxtbMmViavifNNQhPCiSFdJGnEGWGgFPvTwIPdbLr7C+Q3v4NM9oqAtsvXzCmIXS+UkFB8DbH/uAl4yrRgz/IJOZq7MWKPMnVVwrU3PCaWlZIK5HzmgErwUEesgaMpM1KE2eWaZeeMzIlouJpYPrlLlILwnlJZC5fPHAp4IItae9tnXBVKNkdYGFbf7TNwnhZvDV4QyU1SfmczlJuHQi/Qx0Wp/FICxnef6SqMWmZTTsFVOg/KBKG9bO1i6nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHZk/vUrzScXXMPJUeDNo/IYU7H9hBrXhijJfuyz4us=; b=AflPk1TCESL+OS4qfVizwo9VS2SIgXZqmXBePUGbOzmLdR2lHr1zsaFOEBAwz8pwIHTO9X0bvfSMFgBDM38aPhIPxnzlfYGSUQkgk7eG9UZtoQA5WZfPv62lGfZKwOpJuQu2ju+PJU0a0odU7RP4Cfx/FG6SfhVadlr9WmbcFFlRMP7oIaPnayRbQBsIadngGqNspykVR4Ohm5qQ62YotJqQ3zrHuD8+odqY3Lera7RLpMv8rWSqVsC/AgwNWLO+9FIiY8cadXvd7as6Wey6a1kI0ze4y0eplp3GcW6DCGTauTLpFhpbU10OI/0Lzt8z70NUu6eB5+1IYoblvB4UFA== Received: from MN2PR20CA0059.namprd20.prod.outlook.com (2603:10b6:208:235::28) by PH0PR12MB8051.namprd12.prod.outlook.com (2603:10b6:510:26d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:51:56 +0000 Received: from BL02EPF0001A108.namprd05.prod.outlook.com (2603:10b6:208:235:cafe::49) by MN2PR20CA0059.outlook.office365.com (2603:10b6:208:235::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:51:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF0001A108.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 12:51:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:51:37 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:51:35 -0700 From: Xueming Li To: Jingjing Wu CC: , Zhirun Yan , dpdk stable Subject: patch 'graph: fix mcore dispatch walk' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:06 +0800 Message-ID: <20240812125035.389667-10-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A108:EE_|PH0PR12MB8051:EE_ X-MS-Office365-Filtering-Correlation-Id: 68cd657b-ecbb-4a39-760e-08dcbacd8bbb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wLTM0U4Ts9Uot24SP0Ub/CdXRvkE/uqdjmO2wxSMcXnUQfubQB1wcdSBCfI6?= =?us-ascii?Q?GNTxGx7kw8HHf1aae3NvQAJb2/csIoy/LZBGu6Q/LchbPKnN1CbVT9KO7/pB?= =?us-ascii?Q?Dvokvf6PItgH6AqZDqB3M8Z9DP+cJcvODcLnDTk9bxrIQOGUSqYFfig1amwH?= =?us-ascii?Q?a+2zBW+IAutmbBTZL6Eb/+8cUEkHqDAjsJNEFal9IMauV8pLlPwx6TJHyzRc?= =?us-ascii?Q?BssCKpt7yRpTjUN+B3Jtq2s7xRmXbBpC/UO6+n545DeaFSiz3GOylejG1vgT?= =?us-ascii?Q?CxEUkj8zmHLFTEGqyXRY7/B/i9lh1AAxkHaY9k66OOyuq/Bf6g2PS9ntKden?= =?us-ascii?Q?1DGyXHueRu31Vkp6kJQp8KryTpy2ylQjhYem+xPdFhqcCcLxnrJELsxjH+eD?= =?us-ascii?Q?nIMZ73ia4R0WptRgukM6AfOq1j4SHiufPprHv6XRM/a11Gvzw0lHsk6U/3WH?= =?us-ascii?Q?/503fmwcQPd3DrS90Lt/+M/yCGNZyT5kdhxdJiKwXG3ZA/FUa3x7mlila8sC?= =?us-ascii?Q?FAgQSHWNAV3lAl73KdkXNXmYVdQu87pu3a2NBtRPtFvj9WFuUKCf9BFrWGOf?= =?us-ascii?Q?VBTQDGrX8uiZ3nG40oN/I9Fcs9x4VNqq1DC373+dkyUVtKAGp3u0Sttxn4Qu?= =?us-ascii?Q?+BfYHgf0I4K/JprEixxe1KUyUZGJBMePHwcZyorftpaIrGKpwfjJCrGmNLyh?= =?us-ascii?Q?BPLQWnyah7Defk23OMrnpBwaQaCMjknm0iBEggwl1NpSZqhHXI5Lj/0Xe4+Q?= =?us-ascii?Q?34heyu1oKuInTbYu5ptuHo9J7UL8hV+xPB/EB8gCtfqGOogtEzhtHSgq59On?= =?us-ascii?Q?97yG8mPIEaxS9yag9eoV4BTptzl7oMiEHQgKm0eMn87v4KNVN82iCevvE6Yw?= =?us-ascii?Q?thDCuqr4mEFtxCEgIygL+gy/4xgWbQ0P53lM4EgzP3M6JsR/swuSCCuOfrq/?= =?us-ascii?Q?zUQaOafijJ/FwbaAuzIMyDT57Eykn5+4W/w8pceSqz4z33VQ6X3xWm3r5OmC?= =?us-ascii?Q?xMGMRaW787/nxaUoHra9PDGMa/61lPXO0kKJ0qa0hxKJyPGc3cWzSMPa8VCE?= =?us-ascii?Q?TnVqDYnmmB9cVYE9u0wBwJbLJZwUVTaZ1hHsfHh5ck7JBKdQdnEeu5IX7p5c?= =?us-ascii?Q?LdFdcBqGOJe6YuI8sfx99C6ED+XCVC7dkGRHLNq/dORxHI7R7RESmM9kethk?= =?us-ascii?Q?AXx6Vc1Qb+95CSo8WgMcevmCwLG3Isr3I2BBkFypu+nhGcmYzzByMHMm6oBn?= =?us-ascii?Q?ZoD5oePvTo2x9PReKaHfJFrQrSL9PQcDI78swN0pi7ublhIYoXW4RGu6rzMk?= =?us-ascii?Q?DB/1FXC35ImduUvIlt1rkhciElHrtwETtX14OTzWxlBgISIsdhHcHE5iE0Ja?= =?us-ascii?Q?8FxLgTM0SeblLQOFIq70MdCt5tCfQczUo8Wg5yiE+vaRlXxAKMnPjcGGbxyK?= =?us-ascii?Q?N2EP0WFHNGWhgMAzEVwcJ65w4Am+eKH/?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:51:55.3117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68cd657b-ecbb-4a39-760e-08dcbacd8bbb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A108.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8051 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c13a819a446733582988f12bda50d35b02f15b62 Thanks. Xueming Li --- >From c13a819a446733582988f12bda50d35b02f15b62 Mon Sep 17 00:00:00 2001 From: Jingjing Wu Date: Fri, 22 Mar 2024 15:46:37 +0000 Subject: [PATCH] graph: fix mcore dispatch walk Cc: Xueming Li [ upstream commit 19c34a3caee965e60f25fb4de6553607b894ba72 ] Head move happens before the core id check, which will cause the last source node be executed even core id is not correct. This patch changes head check to less than 1 instead of 0 to fix this issue. Fixes: 35dfd9b9fd85 ("graph: introduce graph walk by cross-core dispatch") Signed-off-by: Jingjing Wu Acked-by: Zhirun Yan --- lib/graph/rte_graph_model_mcore_dispatch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h b/lib/graph/rte_graph_model_mcore_dispatch.h index 75ec388cad..732b89297f 100644 --- a/lib/graph/rte_graph_model_mcore_dispatch.h +++ b/lib/graph/rte_graph_model_mcore_dispatch.h @@ -100,7 +100,7 @@ rte_graph_walk_mcore_dispatch(struct rte_graph *graph) node = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]); /* skip the src nodes which not bind with current worker */ - if ((int32_t)head < 0 && node->dispatch.lcore_id != graph->dispatch.lcore_id) + if ((int32_t)head < 1 && node->dispatch.lcore_id != graph->dispatch.lcore_id) continue; /* Schedule the node until all task/objs are done */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:02.921460657 +0800 +++ 0009-graph-fix-mcore-dispatch-walk.patch 2024-08-12 20:44:01.895069255 +0800 @@ -1 +1 @@ -From 19c34a3caee965e60f25fb4de6553607b894ba72 Mon Sep 17 00:00:00 2001 +From c13a819a446733582988f12bda50d35b02f15b62 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 19c34a3caee965e60f25fb4de6553607b894ba72 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org