From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D43F457A1 for ; Mon, 12 Aug 2024 15:01:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06914406B7; Mon, 12 Aug 2024 15:01:51 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2069.outbound.protection.outlook.com [40.107.236.69]) by mails.dpdk.org (Postfix) with ESMTP id 9A2DD402C3 for ; Mon, 12 Aug 2024 15:01:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yoR4EWXITraLPUZgGQRcpmQ2sHTuOgivxpeeIW+YRGxFMyGZf6+PH0BcfP5AtCMeNcYnN+/x16l357qWZmXPwJxjRrOtWUVEmKcNIipdwKyL71aK+tck6OeR7gGnMrFyZ1Vn+28eoLXdkKInyYFidsd1JU18TzisyXih3eVHScdqoG4NIaYbz5dSNM6An+I4A965c5dJI9W4XW35PIEe95ha+xg4e0hau9hQk/mpf8O9evj5TMhzVOMsqPT4F2MOLhHIbZ6q+g5XdA4VCvvglZDdf/JLn/IZe8c3J3IBln3dwVNVjeS7FYzLNkUDYgqxx2cq3P+FktAXNw5fzB4NTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wmS24mUHgdSSjMZ7t4lRsknYUdg7MxwJi6HVSACQvf0=; b=vt5huzaWswxpv96WBtZzgdSoMVvWSk+LEAqI+xlnsNRBmcIF1iQdGtO5q91xAmhv/202ATv3o1n8OSeMTHR9+s39AHI48+tslrmn0Sz4aOlHRvcBiUBfgYcDPtuY4KrNjotXguPmsCtsgZMrbrz3GOGoqweeW07GKwFJIN5/E3r+Ace12yORErLvF6rnPrvAbjGuxsdf2vFA+Mh4gKSCqzeuCQtW/gewi+ilEsWSsdOU5CE8PXgQuuiDNSAMqJ8SmkSGylHfGM/zqa3dLhhdMY4p0A2qz0M0o7ouTOLSQLH8tvzTsNul8gk9b5rCMsihXtit0gfv53HN+IvTpW962Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wmS24mUHgdSSjMZ7t4lRsknYUdg7MxwJi6HVSACQvf0=; b=j56hO2Z8kilXfnCyUzQ+7iDRuALb+zqo9zXxYZr1AibGWCYaHcEIWglEJhEbkoM+fSSEnyBwwDM2kB7nnetoPHiIOdEuH6Cs5xJQZQ7CQAt3z9EY+3boHESzO8lMXFg2hkO5lFxuegHMK9Savg8etXeqG28pZCV6aU7gtblwBV+xgvBSpzktxhmjlco2+K2/pngEG3eUfHTE0mis4T6R/4Yxr1b9qU53T92kH3QJ54hNqgn2w30GB7SlI1XyXKtuAIRCSxFTZW6zqvYqT0grOC8p2O2HKgvvwzDiKQHqpsE8ZtjRyfjvHYRXd1BvAqctFBIszwN5LLu+q0sJRL2Krg== Received: from BYAPR07CA0104.namprd07.prod.outlook.com (2603:10b6:a03:12b::45) by CH3PR12MB7546.namprd12.prod.outlook.com (2603:10b6:610:149::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Mon, 12 Aug 2024 13:01:44 +0000 Received: from CO1PEPF000042A7.namprd03.prod.outlook.com (2603:10b6:a03:12b:cafe::2) by BYAPR07CA0104.outlook.office365.com (2603:10b6:a03:12b::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 13:01:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042A7.mail.protection.outlook.com (10.167.243.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 13:01:43 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:01:18 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:01:16 -0700 From: Xueming Li To: Gowrishankar Muthukrishnan CC: , Anoob Joseph , dpdk stable Subject: patch 'test/crypto: fix modex comparison' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:49 +0800 Message-ID: <20240812125035.389667-113-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A7:EE_|CH3PR12MB7546:EE_ X-MS-Office365-Filtering-Correlation-Id: ef8550c8-7239-4df1-2e4f-08dcbaceea37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6MYqa+6T8QyjoW0ZvE3hV274PEqij547vbsHVk5KQXh0RXf5lzvCoZXD/13+?= =?us-ascii?Q?CoGO5xOGAs5qzIg0dw56P3LaNcz4fPdXayuLwkDeARAAfNOvDwnJnJHdjyp/?= =?us-ascii?Q?qo0Di79e9HlYYp8z+37JCCE7pCMq0Tdw9ukR0EvTCoKryRVX4cqIihXUkOd9?= =?us-ascii?Q?iQ/YDVK+JHI1GJVQTQKOw+m69opEz1cvD0FG4iRcRRVDms6JqUKgT67rZDpi?= =?us-ascii?Q?MogqURsmPPD/GGtXBLqHveICD7mKSfS6VQMOIuhCZcQS1gfXCD0BLmxykFpt?= =?us-ascii?Q?TClIcEECqA6SC/3BAQT1UfT2oT+IpzQTunLgu+4f6yG6Lz1TJMKyRICn0pjv?= =?us-ascii?Q?rZ75yQRWwjLi6EPxRe3g/EQDmLJxE2Vh79R+EZw3au0wpoRdoHbofPRkPoL7?= =?us-ascii?Q?3r0G/ebezKJyHbhr2xBRAA3ujetWa6oSQipAHNyJzM09cV4K+ELEQpBO2G5u?= =?us-ascii?Q?zBFvtn3iO5yThmLCVHYQvV4Xw2J5woCzXt+mY0cRcjOpaw8l3Rtki3D7fGIz?= =?us-ascii?Q?I69GZc5Aof9A29KdlkndHtcsojHgUTeOpMQ3lgJgl6cJAKWUNIw68IASe6Kn?= =?us-ascii?Q?fxAJ9BsNiWlDRA4QL19YKcNrSoT/ZgfQ8R9ugNKXTsEd+BFBBptyZbh9SNi7?= =?us-ascii?Q?c4TPcVqK5BxtKKJ4uiq+RnwOLlUTFm6qQrwJSypJcW6W/K5+2iEuNA7H6ivs?= =?us-ascii?Q?MGBxzYsSijbbhr5iVkbcJKJG38gK2eAx0PsMs1I84OoTqP4U8ARQ0os96cyY?= =?us-ascii?Q?iwIwaFHM5ONtsrUKupflxqGRadQjy+oVYWPsclPx461Q6To5RIjKBei5iRXv?= =?us-ascii?Q?y68Hy9R0iyK3iJHy1W5OOao9kv3YQp5fNJVH3BLmhqPWYKAv+FMfQi0ihqVt?= =?us-ascii?Q?6WKI1DF+ED1UYIq4TafM4thVIIEgEsiKUNEXRVwTybHnoiP1LReXBScxdUNs?= =?us-ascii?Q?D2oyhSj/xu1X23ajDGWSgp8TvC+aJx7LpCTK07j4heqNbNvMeRIkABwkW/tv?= =?us-ascii?Q?LEAck9JGSOImyeGLFYwyIr34jEUk/ZKucAtLXXTtqQDC4HRDsBkRGb6uHcWp?= =?us-ascii?Q?GOHeR1vPgosTyAMFzQHgfZXgu4nsPIqODrmJM1cpk5tH7Pw5z6/rx5BSIiTH?= =?us-ascii?Q?d4jV1hVpYr18HlRqnbXKP9hjKnT5T01+oj7dRYjyupIjwWTMg+ZCZrf13jRL?= =?us-ascii?Q?eyExhUrnSQjTbf1Y5ADgKyCyk8H7eXpZPsIrfh6kkYNlSANXcoCUwoETyh2n?= =?us-ascii?Q?5OujvAkL5bhmhSePU+Y9OlGLAsV8Fph4WS2sw00Cagg3aaAl/oMK0yC+Bt2V?= =?us-ascii?Q?+xRflhdZlCJGdmD1ALgevizBulOntAR6RTp/a5Q4TfDr91o6bLkGu7G6L0x2?= =?us-ascii?Q?MAxIR36EdoZ1/kQWq9L49yLaiqlEAam8AikEmnrfxjwR95U1A7CYh0ml0OAk?= =?us-ascii?Q?20iMbov3F2B+bOxXA5CWvSGYTjhLxY9K?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:01:43.3407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef8550c8-7239-4df1-2e4f-08dcbaceea37 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7546 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=b2acb5218f3a79b0fd68593c08ceb308c199e94b Thanks. Xueming Li --- >From b2acb5218f3a79b0fd68593c08ceb308c199e94b Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Mon, 15 Jul 2024 19:08:33 +0530 Subject: [PATCH] test/crypto: fix modex comparison Cc: Xueming Li [ upstream commit cc42abd111e09672edb51e786baa7e49263c5c0a ] Fix comparison function used by modex test to check from first non-zero value itself. Coverity issue: 430125 Fixes: 2162d32c1c3b ("test/crypto: validate modex from first non-zero") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph --- app/test/test_cryptodev_asym.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index a6bb1e03f3..3b57a0249b 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app/test/test_cryptodev_asym.c @@ -3197,21 +3197,26 @@ static int send_one(void) } static int -modular_cmpeq(const uint8_t *a, const uint8_t *b, size_t len) +modular_cmpeq(const uint8_t *a, size_t a_len, const uint8_t *b, size_t b_len) { - const uint8_t *new_a = a, *new_b = b; + const uint8_t *new_a, *new_b; size_t i, j; /* Strip leading NUL bytes */ - for (i = 0; i < len; i++) + for (i = 0; i < a_len; i++) if (a[i] != 0) - new_a = &a[i]; + break; - for (j = 0; j < len; j++) + for (j = 0; j < b_len; j++) if (b[j] != 0) - new_b = &b[i]; + break; + + if (a_len - i != b_len - j) + return 1; - if (i != j || memcmp(new_a, new_b, len - i)) + new_a = &a[i]; + new_b = &b[j]; + if (memcmp(new_a, new_b, a_len - i)) return 1; return 0; @@ -3251,7 +3256,7 @@ modular_exponentiation(const void *test_data) TEST_ASSERT_SUCCESS(send_one(), "Failed to process crypto op"); - TEST_ASSERT_SUCCESS(modular_cmpeq(vector->reminder.data, + TEST_ASSERT_SUCCESS(modular_cmpeq(vector->reminder.data, vector->reminder.len, self->result_op->asym->modex.result.data, self->result_op->asym->modex.result.length), "operation verification failed\n"); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:06.086771915 +0800 +++ 0112-test-crypto-fix-modex-comparison.patch 2024-08-12 20:44:02.445069363 +0800 @@ -1 +1 @@ -From cc42abd111e09672edb51e786baa7e49263c5c0a Mon Sep 17 00:00:00 2001 +From b2acb5218f3a79b0fd68593c08ceb308c199e94b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit cc42abd111e09672edb51e786baa7e49263c5c0a ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 1d88832146..f0b5d38543 100644 +index a6bb1e03f3..3b57a0249b 100644