From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8611C457A1 for ; Mon, 12 Aug 2024 15:02:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8250940666; Mon, 12 Aug 2024 15:02:51 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2058.outbound.protection.outlook.com [40.107.92.58]) by mails.dpdk.org (Postfix) with ESMTP id 50D7C402C3 for ; Mon, 12 Aug 2024 15:02:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bhQ4iSSl9HBowLOy6asQj9RvjsawElPWR01gyWHC7hxDLYKWIT/pGFJ8bOMJ/NWu5VVzd7bkU4HHzLQv6p/CIapFYail62NdM3M+a8Vd1wLud2xgJaE0WTXXc0xw8a6M7D+bJCjbdkVxr7DYgyO3Q7hvyTvorADwcDXSNJRMzMOar+VFGUrQnhe2nM8keCjT6DTHKZOAjfnUxypB9p1LMzaz2ve9sSWbKewo9bqB+aWYBNT3YyCTD+TSbqXrSSEFzJHZOJjYKyPUK5ViqXJLsdzIl1pasrq60N2BO0L4o/DMPZgudI3duJ0aI+hDELFrLpk8XZJo1AuGVfUX7TS/WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dVxRba5NpTKTczqYKkur59VB74cM7do1L1hBry4D2ng=; b=aO3b5NaKYXKQ8RlQ5cyFe7SBiaAC2Edz+78Pi6jIOly2sSfMCumhzMbxZFfVDA2EVTpWY6otW/HD/RW+fOHRUOO7U81K5ZhqwuglSsqBCjU7uWAJ3NhgbGq8xPz7bv1sTgW9zG1VvXi2GrACXi9GL1589pE8MVNbyDRLkyCIc6u+oVLAyrFAzpQ7Z7iGo14SrIB0A6PreOkdtitwCEOmFIvywBlt7iGhFyaWO+01XffBcyvp3GPyQteIBFb66ZgXGZjjbvnFVGvb6rxYkjCj7Nqc6JSxT5kzpSgYR87uOdGXjUMSTl8qGBZlAdG4fc8GCx+7N7vRLxv9wB4RIIWTfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dVxRba5NpTKTczqYKkur59VB74cM7do1L1hBry4D2ng=; b=aKFMuCqaI3nyngRKTl1F0iKfafK0Iu0mPQvzKpjiTCh1yl/nZxy0tn2Ls0vy1Ddbz4Jd8b9r+qY9EI3rqVHoVZ9T2zO1O/N/10SN2XHVttW9cKoJMIfTmGzOLdk0Vh+mGQ5RDbScu002P64SDr8aqhwpNh3CJ3ouZfxlTdu2TG7x5zvTNo8bbgeRt/bGkH0QGzEWyXSPXxITyzdeB+7mpIaQuUWWsjQbJlay6N8WInrZB2v2rtGWMuvkdsawW96OUjdtrpIAwTj/MxCb0IRJQUcEIz1UjJqqUMfhzUeFMVOqtLDr5durpj77RfR+2snOKuFXOXEw8Bh1m3eco0hoXQ== Received: from SJ0PR13CA0148.namprd13.prod.outlook.com (2603:10b6:a03:2c6::33) by IA0PR12MB8864.namprd12.prod.outlook.com (2603:10b6:208:485::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Mon, 12 Aug 2024 13:01:50 +0000 Received: from CO1PEPF000042A8.namprd03.prod.outlook.com (2603:10b6:a03:2c6:cafe::57) by SJ0PR13CA0148.outlook.office365.com (2603:10b6:a03:2c6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 13:01:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042A8.mail.protection.outlook.com (10.167.243.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 13:01:48 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:01:22 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:01:20 -0700 From: Xueming Li To: Ankur Dwivedi CC: , dpdk stable Subject: patch 'common/cnxk: fix integer overflow' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:51 +0800 Message-ID: <20240812125035.389667-115-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A8:EE_|IA0PR12MB8864:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c6693c1-4190-4cc6-679e-08dcbaceed2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IPj/4IOVskthV0IrOFPEaOWFOfdbfEWlPx+yZ3iYwfqz80byOn3bX5idURiE?= =?us-ascii?Q?Ablw20ZecWF2jVbbS4LZBcrl9UvyzM04WNAAx164W4QB9wll3j4bgAXMLOmm?= =?us-ascii?Q?pGwSHHeczmUWO9W9qNi9S9vL39j/8mu9+4pkA9nEVgAoPkse+6EXYm43Wk7h?= =?us-ascii?Q?JOcYKdlGcEkeEVsMSdMFhKVC2GceU5dvvc8s2G/7RngaKUzkY0UcFnIV8Ecl?= =?us-ascii?Q?OrXZh5C111RnGvj7I66QNG87YGzojkJU3c/XCr3yNsFsu1/J+Jsr8d8PZa+q?= =?us-ascii?Q?GG13iXSS29qSCKob+0CO3AihpWQPWahyQtzwnc+Li0iE7eHZt/lRiG6gWGtB?= =?us-ascii?Q?NRhfwmv1B8jEbeEmuQjIeU+dAHF8FdIxkxNCxsVAQ05KvKg3tELHmYfrtdGW?= =?us-ascii?Q?SRMG/r388PGj10xEDWdlAeK1vpHxVQ3UYwidlJWQRVGQhWG06I89i44O/1UX?= =?us-ascii?Q?zB9mnlx84Sp3bkzpJd9aiTS1Tpo81dU55PHCk6vfCRqDw9B759ZX5QGOxy4W?= =?us-ascii?Q?PWxnHjvWYqfV9p3qWCMGFyFOGJl8Ua5JTgGPoWCI9r4add4C4zMtg0QCELFZ?= =?us-ascii?Q?+QCGRllAlZ84vfemvdRUf5n7kqr6n5zXAduEgC03j1kDok2fixg5+cJ/mjHC?= =?us-ascii?Q?v7bKZtrpECJr+TEulfp4gU4nEm7ApHQpn996R56EDuA0GlR+ChIQncSONvab?= =?us-ascii?Q?jxVIXUFjsKlIH2CYNZ1KyStpFs2uQ3Q8NUotwKBTF/b+SBu32BgerF7YH3sA?= =?us-ascii?Q?uLzKNdFrH/vFwpjNusACLnFRKtJsDgyqrf0L0wBU0uIJVKBcDLhREjo9xVEx?= =?us-ascii?Q?tEN7Wn8ro2HFs94iBWeiLsSkOJhe7MzCOZxcKg5pmb/vw5ZWP/d675wRYwuR?= =?us-ascii?Q?lOVB+j/iIkDrmYzIly34YOTCMYw+EV6ot3ULDXDMaWazzJakrkpHeb+aoMCj?= =?us-ascii?Q?CopN/Kmigo6sUP1B28YQMu/acVoQtnAqXNDsMC/C6OqqhmXctpGsJRSJiyHw?= =?us-ascii?Q?IUsq/d0iImwBN+d4mOjeyG4hLwVHJ20sGcAvKxc3O+Nnudkt6qINp6wePit5?= =?us-ascii?Q?O7bKANP0AJGr85tZuvuQDCRmhd0j4J3MnMNW7ntjIxz6ms8WewOUNgqdscaF?= =?us-ascii?Q?txFy2Em9EezGXweIxWjgLzjp4VZRwkAq8pLH/QnafS2e1X/zS9PUdxgf4YbM?= =?us-ascii?Q?59QL5F1sPrDdanCNmofNRE/N0yalyQRfCMUhlhljXuISasVNip7jEmJ0GjVO?= =?us-ascii?Q?H1QWHZApmtLQ3RxzVu8/tb8a7dMF8LQj91uvZNah9bstBKh80aVoOnaNDooD?= =?us-ascii?Q?qdkiUhLKqDi1jyfLIxQvOvgU4hKys51U7Iq4hJf+N9hyPwJjRKO/fz91zdbR?= =?us-ascii?Q?8VdmmLBIUhBimwKDuw2VtnJsMQTvBcza+W0vIhaBgkwR10wbV11snccnnT8z?= =?us-ascii?Q?Atx/mu/Hj1u8BVMF4UMB948ZjHMHTOa+?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:01:48.2654 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c6693c1-4190-4cc6-679e-08dcbaceed2b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8864 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=8f23521ad7ee5964b12554bf6f622e234fb73249 Thanks. Xueming Li --- >From 8f23521ad7ee5964b12554bf6f622e234fb73249 Mon Sep 17 00:00:00 2001 From: Ankur Dwivedi Date: Thu, 18 Jul 2024 12:04:37 +0530 Subject: [PATCH] common/cnxk: fix integer overflow Cc: Xueming Li [ upstream commit 118ba4e3f2a39e6fc10075c680310f4cdabc1bd7 ] The expression flow_age->aging_poll_freq * NPC_AGE_WAIT_TIMEOUT_US is evaluated using 32 bit arithmetic. An integer overflow may occur when the value is too large to fit in 32 bits. This patch resolves this by casting flow_age->aging_poll_freq to 64 bit. Coverity issue: 428156 Fixes: a4878294318e ("common/cnxk: fix flow aging on application exit") Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_npc_aging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/roc_npc_aging.c index 1e85033e2a..258c15e341 100644 --- a/drivers/common/cnxk/roc_npc_aging.c +++ b/drivers/common/cnxk/roc_npc_aging.c @@ -145,7 +145,7 @@ npc_age_wait_until(struct roc_npc_flow_age *flow_age) plt_delay_us(sleep); timeout += sleep; } while (!flow_age->aged_flows_get_thread_exit && - (timeout < (flow_age->aging_poll_freq * NPC_AGE_WAIT_TIMEOUT_US))); + (timeout < ((uint64_t)flow_age->aging_poll_freq * NPC_AGE_WAIT_TIMEOUT_US))); } uint32_t -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:06.135061611 +0800 +++ 0114-common-cnxk-fix-integer-overflow.patch 2024-08-12 20:44:02.445069363 +0800 @@ -1 +1 @@ -From 118ba4e3f2a39e6fc10075c680310f4cdabc1bd7 Mon Sep 17 00:00:00 2001 +From 8f23521ad7ee5964b12554bf6f622e234fb73249 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 118ba4e3f2a39e6fc10075c680310f4cdabc1bd7 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org