From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1A6F457A1 for ; Mon, 12 Aug 2024 15:03:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCB24406FF; Mon, 12 Aug 2024 15:03:01 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2069.outbound.protection.outlook.com [40.107.244.69]) by mails.dpdk.org (Postfix) with ESMTP id CBAA6402C3 for ; Mon, 12 Aug 2024 15:02:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XEGLQ99Qg1lWLyrDMzZISO6Oe2R/ZHS3A4Ur4zaIQAKyo3yjXHsTeO5z10uTmHM3xmK8d8Yb8VjBWn1G3bvAVJ+5CB7koveyFt3/VtgYOTp/VwgSakclV0Y63W/8BtlqvCoKOzyZGGZoaQC9e2dYPGUWBwd9DDlr1lm0XqAJi1YGmIO3Kwog1vNYxLLwJITX8iu4CFfSecfr4QVgD0PeWrMLdbGoN3SGf/YccCPJXcTTQODLukpyQyB+hZsm94P0/63vagXgf4XTlQClX0hEgpolh0JFu0fmX4383oSlnwNVQfrtFsc9qoAIOcAtegooWnHXf27zZTZxLF5lkzIWtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0u0g+5/fF5MrxZDQrhtXK6XwoPKzTq5ope5j8BdaNoU=; b=GXUSmxhhrqAaLOUlqAKeZzcKKHTljXl9kGVJ/7sz7c25PnhTpYJ/X3X3iVT0HnDYzz7lAUq5eDD505vN4ktCbU97C8xQCssfRo6XsTusbly8OiQlw6os47HhFEynV/Y4/j06u75q1aQLIHlqhI0on0Sp5wN2jchMieSx2aTF0jlC7PKTFok6gcUQu88I/DbPEo1L8dz0ZE2F9Ge6+Lb9SrcfOTXLoC44c0j5A+lWX2KrSR+CltCdnJKZa09DsBf47KRZJ2U+HixNBB92O5fYD0QzImeYF+/suf3eQ3q3+3KrdiwxjGs8SXizNvY7r5wmLtqcYw399k6q07srl0DYXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0u0g+5/fF5MrxZDQrhtXK6XwoPKzTq5ope5j8BdaNoU=; b=tdps2h9yQddY/6rgTcguCW2FI4IZ+tF3eD/j7xcp8b/rQgf2idiiWQsbd1OXuOtF2p9Rx3tqFMfKUi3Zl5UEcYP0veqEKqqbr9vIPmIJHabPYKAG9qoiaK3EK9fkpS82TKsDSpbbpxdS+0mAfSGkj1JtOBFN43mQPqoCe/sH7NTHlA5ZZR3NENn2N1pDxDGh13HvNqzVFI6z190RUaAUVqQq3BZHBnLDXJ4sjn+SK5TzliZY+NDiNaM5wehRyBtHVw8bqUe8Iz/9xilV+QBiEK3N7WbzUUs+k3LcdukEze6pFDIRvtcvwhpiWVUJ1vejsmKESyrAncSD1v6TZAkLCg== Received: from SN6PR04CA0088.namprd04.prod.outlook.com (2603:10b6:805:f2::29) by PH7PR12MB6954.namprd12.prod.outlook.com (2603:10b6:510:1b7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 13:02:56 +0000 Received: from SN1PEPF00026369.namprd02.prod.outlook.com (2603:10b6:805:f2:cafe::da) by SN6PR04CA0088.outlook.office365.com (2603:10b6:805:f2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 13:02:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF00026369.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 13:02:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:02:39 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:02:37 -0700 From: Xueming Li To: Bing Zhao CC: , Viacheslav Ovsiienko , "dpdk stable" Subject: patch 'net/mlx5: fix uplink port probing in bonding mode' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:50:03 +0800 Message-ID: <20240812125035.389667-127-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00026369:EE_|PH7PR12MB6954:EE_ X-MS-Office365-Filtering-Correlation-Id: 422c3c6f-e59e-4c90-e954-08dcbacf155a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BZ8gncSZG/YIfebCP9puC29vH3Rp1FdelaF1cWlPKusAOwfMlRtfzvG5Poup?= =?us-ascii?Q?eMPjvMuaqLqBg68ggcFQ7uMWJToU4Aotw60tEt7Uoi+fg2QHscD2TW/juFF8?= =?us-ascii?Q?mUll99W20g7TH6uTRZIy8pmTkGr2FTnnvUuvI7e/7WdAbVvD/Adn6JmDW1Um?= =?us-ascii?Q?zqgiZzTGuWANUxmvlm5sSxbouEOanEWLkprZPyJRAS2VQMkOSwjakS68yppL?= =?us-ascii?Q?sBYvtUEsVMSCAHt4rKhv3G5GAbqp6z3Sqlj1EXey8eUupf9OofgyYTSpMW6N?= =?us-ascii?Q?t6jaBjPUxQVtorcyf/hf07+D1pXSRlRvVpRz5NLYB6+U6CexklRWws9BkLX8?= =?us-ascii?Q?uDBTttyMw5j33HccgPAgVtBy3hkAafne+bCmZO0QiG6T15OJLepkDotFemVm?= =?us-ascii?Q?yIAscz8xCyVOW1gO8L1SgXE2nEQZhmEUGksnczL9EuprGfofaLOS/cGYubiV?= =?us-ascii?Q?ZSpIITuzCd+QFAJny6A86+v96aFWc2n/74SY4dil3HUMxsJMOaD+MOe2o0D7?= =?us-ascii?Q?czF6NE8n2ASCiXuPHFsYLXEYt7RiSKLUYI5aEqFa3otrXNT2yn6IaJeuYd7H?= =?us-ascii?Q?GRvUu4meN3GhO7Y+TF/IIrCSju92wVn0zD7uHyoO5EkezFu9K/Aob5DKolig?= =?us-ascii?Q?vyCD0CSjNihNOkM+ckscUW2OORqlOrEnQSIIG8TZNFJmGJi6xDAw+uddyk7n?= =?us-ascii?Q?mfYu3zaQCgTnbFJE0P7krJJ1L+UqxmbzO+FaU6r471S/begdzYznvEJRYySp?= =?us-ascii?Q?VvbuzwtAzjeH8uJgfEkffPXjqoMmSzbVGYlYFW+mrVHnVWKx3fBnpQYPvBAD?= =?us-ascii?Q?a4kFvrsfiPY8eGTkusSh2bDW3ik3F6GFWw6/fXPY8hPEGa5w0NrEN6jA6oAC?= =?us-ascii?Q?G4+XEY0moNAWAErEqAQcn8k+LSdigL3LlxkQ24nc+Lh0Nw+7n29blxjS4Hvp?= =?us-ascii?Q?RgvilnEzQ7IsKDDVJW875tIngQPz76+XhSnJQ5ztJxWoL7y2qpSqdFzEy0bN?= =?us-ascii?Q?UtSo6vEXtez8fBGxn7AaNyhqpoDMW/qkUrrjtPP1FNuTY49m4TyuTKvqOM1S?= =?us-ascii?Q?gKjni8SPoAJs1GAeKwaxgcor7BMhg+k7GCWrx2UIFz5mOUa6bJKJ+MiFvR3b?= =?us-ascii?Q?NvPnf/2g0YeglaVmV1G1vX6X0dZqzbPrLmESwPfKDQj6B2irGztrYfREknr2?= =?us-ascii?Q?Rm6NoNHoYOC3LMwyaGbBqGKb55ZTOssWzNbp09jQkUuwcdjFKhdEipirVeJH?= =?us-ascii?Q?YuR9G+HNUAS9ajwSY/MPUXZRj95fPHYuV47stJbqOoJMo1Q+0BRChUq5bpYh?= =?us-ascii?Q?Ns0UyAHac8XBWMrYSTRLMl0E6jfP32XB9SEsZbU90Dcomg4c790s592GBoWo?= =?us-ascii?Q?77Lz5SzmXhtxcLnn9tsnoF4aK9MiMKNRLJQSkjJYvTZ2RQOS4zvxqMKBd9PV?= =?us-ascii?Q?Ypo5uYRKhxKZ8ndndyDpDrZNep0zMFvg?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:02:55.7793 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 422c3c6f-e59e-4c90-e954-08dcbacf155a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00026369.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6954 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=1988c32194f9c1caad80970882960b3eda418fcf Thanks. Xueming Li --- >From 1988c32194f9c1caad80970882960b3eda418fcf Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 17 Jul 2024 19:35:41 +0300 Subject: [PATCH] net/mlx5: fix uplink port probing in bonding mode Cc: Xueming Li [ upstream commit 39d4ec8f36192b9dafbad4994cbe37f7674c7190 ] In the HW-LAG bonding mode, the representor port can be from both slave PFs. When probing a representor (REP), the UPLINK (proxy) port always needs to be probed firstly before any REP port. In the current implementation, when probing a device with the following format: -a 0000:XX:00.0,dv_flow_en=N,representor=pf1vfy Since the REP belongs to the 2nd PF in the bonding, the UPLINK would not be added into the probing ports list. 1. In dv_flow_en=1 mode, the REP itself can be probed. But it didn't obey the rules and the behaviors were inconsistent. a. When probing the REP from 1st PFs, the UPLINK was also probed. b. When detaching the UPLINK, all REPs were detached. 2. In dv_flow_en=2 mode, since some resources can only be allocated / created on the proxy port, the probing would get a failure. By removing the unneeded check of the bonding PF device index, the UPLINK will always try to be probed with any format. Fixes: 2e569a370395 ("net/mlx5: add VF LAG mode bonding device recognition") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 2cf609873a..2241e84341 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -2437,8 +2437,7 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev, list[ns].info.master = 0; list[ns].info.representor = 0; } - if (list[ns].info.port_name == bd) - ns++; + ns++; break; case MLX5_PHYS_PORT_NAME_TYPE_PFHPF: /* Fallthrough */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:06.485998083 +0800 +++ 0126-net-mlx5-fix-uplink-port-probing-in-bonding-mode.patch 2024-08-12 20:44:02.505069375 +0800 @@ -1 +1 @@ -From 39d4ec8f36192b9dafbad4994cbe37f7674c7190 Mon Sep 17 00:00:00 2001 +From 1988c32194f9c1caad80970882960b3eda418fcf Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 39d4ec8f36192b9dafbad4994cbe37f7674c7190 ] @@ -29 +31,0 @@ -Cc: stable@dpdk.org @@ -38 +40 @@ -index 5e950e9be1..11336c430b 100644 +index 2cf609873a..2241e84341 100644 @@ -41 +43 @@ -@@ -2473,8 +2473,7 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev, +@@ -2437,8 +2437,7 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev,