From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 146B3457A1 for ; Mon, 12 Aug 2024 15:03:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DE9F40A82; Mon, 12 Aug 2024 15:03:02 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2070.outbound.protection.outlook.com [40.107.95.70]) by mails.dpdk.org (Postfix) with ESMTP id D0A4E40666 for ; Mon, 12 Aug 2024 15:02:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dx1xep9WRwy0rhx184EpBp36yHD/50kvmTjs1j2Y5V+c0/jPepjWx7h8JNRjbYGCQqVvT0hUuk1mBP4v61pnKopDwlvg55J5u5sKxpoD+6sVfycGY9v6Bt4Rz3uLJycIiUnNN5p+5HHSw8FHGCFAtiUGYdIY2f4U0KJmySa0qEfwtMmKJEuvsPgS3T7FfrfRHCL6clKLHTGUj8HInJdED/2fpPQMF2gSJGsfVjtpqWIN0Tnp217u99/hFCaBBWhP42wNI2kn5CHazwfsvPg9zdMxwsG0ksBdytVhPCB3L00IniaKfza+E4Mt8gZe321VXKEmQQ86EwCIhWGFyNMFrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vwe005bltowPIkiDw3bYQolpX2YaLdkcCXsUfy6/9JI=; b=OclmEEb5bPHRSdkmcLbQquOpv4H+J4QOzWuqiiQ4h4E454YCyRc1LSqGlOrKalnjp8P7WnpvFbAApp9xHQ6Y/MiqgPwZJLqsxmqI8tLRWvaSeBMG2V61iubAdOTl6b8s5RglrUIl+VZicqJdF9PfSAEFU+UXmpngY1FEc6KrWKka2mw4KMlW6cmlddWD4a61FrPEJL6GqlCFNjS18JCzzQybXVzLyyHo6gcNB1oC56txgDXIOTjHmzOca4/WG0GvVtXymlNNqiI3yhvqb9HGRvICQrPrIXGr0uEz1lQPQ4SoNo0FSK0vqv258YY94VzM8MZ55J/45sy9WiNwRcjwBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vwe005bltowPIkiDw3bYQolpX2YaLdkcCXsUfy6/9JI=; b=fsM90usV+g2PEPIl67C+knT8KWY8OqLVpJvRhMkrmB9phIJtJkxKLqQa8zL3n89LH3pcypdazTBtt1nKmwaJAyOP7AfElpC7iRiHuNiYQdi7lL78f8tT6hlENtBtykXRtq0+sIUvZ8FZszaDEI+7vqGU8fg5dohZvNaXvRuwNSSWH6NGO66MMjPWM/9MpPHLaxx1SD/wXjTix1LSDbrHFvlv/MswBiSxE2jr0pi86yYTH3A9WVB9MOcxSPTZXnmi2uvLoT8srZgwYG0gWYiBSeYw2z4pntA6ojAcpMeWwF7FacrDf8MZCJDtgoLQvX6ykWtbR5ZOTdVpum2Ao6GQDQ== Received: from SA9P223CA0007.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::12) by MW3PR12MB4380.namprd12.prod.outlook.com (2603:10b6:303:5a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Mon, 12 Aug 2024 13:02:57 +0000 Received: from SN1PEPF0002636A.namprd02.prod.outlook.com (2603:10b6:806:26:cafe::4e) by SA9P223CA0007.outlook.office365.com (2603:10b6:806:26::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20 via Frontend Transport; Mon, 12 Aug 2024 13:02:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002636A.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 13:02:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:02:41 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:02:39 -0700 From: Xueming Li To: Bing Zhao CC: , Viacheslav Ovsiienko , "dpdk stable" Subject: patch 'common/mlx5: remove unneeded field when modify RQ table' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:50:04 +0800 Message-ID: <20240812125035.389667-128-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636A:EE_|MW3PR12MB4380:EE_ X-MS-Office365-Filtering-Correlation-Id: 73a501e2-4280-40b4-d803-08dcbacf161e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bP+4dfCku+kwR23XJLFoqlBFLn3cUIwWWk1lZQZLeWDDgoGCAvxUP3bzomo6?= =?us-ascii?Q?PdxHc0auG8Gidt1iecXczB60jrKlCLs5kPUzaExwE9yzLob2IdtfNpkvlauk?= =?us-ascii?Q?2J31l8BtiVyulM4nwWIYV+me+YmCv5NdkBDWoiBFHFmL+faw+c45lHFHgV2j?= =?us-ascii?Q?2PYEurW05/N9ovPY42Hzb1VMzx/byFYFd/H+MocGZCYzBkLXwbw1KDYFYJX5?= =?us-ascii?Q?u3rgXeXPU2GeuTUDUl97pc5zA/nXNRePHll6wY/iPAZ8RdvIJGsJtNlrO5/a?= =?us-ascii?Q?Tg9yZ5YgjAw0ZSARcun4BVDWt5r0h12yQmwLXgM8eG76Gvk/+MOGD1y2osvR?= =?us-ascii?Q?O8MexEMXkUy2ez0lA+4vNyQizXerQKYNHHFZW/ooMvcXmhVUCXnUMzTjJQKh?= =?us-ascii?Q?HXOjHD//Xks42a5XsFVme1G1MeAJKClTXTqVHDRbjhLR2APsfafRYhNJvw/X?= =?us-ascii?Q?8svsJwaVF84SekPmeSksOmyj1IwS1OEQJ/XGxGi91zUikHT8jpNHA8iQwitz?= =?us-ascii?Q?DXvmxzMDk0dgTdEtLId3+fU/GbMUSa9khV+g5wcqaOHpxFuH/a08+DGxGr5F?= =?us-ascii?Q?kUq+fs7dtXWTcES74Ww5we9gAduQr/65XaSStt8WKXquiZT6vQh/xerQY5P+?= =?us-ascii?Q?VLtbjiQXFWWa7FKaRdIdQOQmuYc/CP9T9y/c7NOsKLa87Co5WehKYc/NxT8O?= =?us-ascii?Q?mbR58MujUhvVuViYW4bHefPX2C5Mf5d8N/YL5EUi/ShrGraBSskQNIr2NGo2?= =?us-ascii?Q?aNPMIePOMJpdpf70SLC4AtID67OVGuOYilAi4U/V/Gc/+vLx3YDj0OS8Ohep?= =?us-ascii?Q?rbQ5Ya88FFitelBwZvlz1JSsmPk6P9UECJ6z1d306DCbZ9UZmK6Ix5yEQo5A?= =?us-ascii?Q?472w4E72nkbZgTJRt9qtCRBVB7OdpixgiwypGGTFVrHO8t1yGultf3nKS56+?= =?us-ascii?Q?IYyRoCvC/DSobHjuv45euoDfO99Tvof/UfUaMUx27olmHO974m171ZiU2uvV?= =?us-ascii?Q?TCaaAECKzQcXHSC8PtbUuinuih7PX+AqS9Pdk1cjPq9tIs/+Scb8c6fc2odn?= =?us-ascii?Q?KHGruP6mc+N5bxcqLowKpZLhrTy/x7uFnwUCBZw5A+DX7aldHavyQ0ywrFoM?= =?us-ascii?Q?qdZXokyDLGaaOL+9gVHkgFKz0QTVk+//HBkxsOpJ6nVt/aJWSAhR4NtGuSqC?= =?us-ascii?Q?B2Ti4KE1YqJ7F3mHtITkZ4CX55ctFMW+sNiOvug5OkjxvhT3xxKfGt1iCzIL?= =?us-ascii?Q?6x6Jj+wSU96tPsp1+XUB5x59JKLDtC2yzsI/d0iHZeTpYKBx2gqs8cXLTtbt?= =?us-ascii?Q?xfM7/wC9CuQEqGh+lZbTkKFF6fznZzQkchsJ01r/r8tsr2kCqjTpHyZjqeW3?= =?us-ascii?Q?I5U3CmC5FRNjaLavv+486cwWVscp2QJ/Z00sb5pZn8skG6IdvFn4AMXQisn6?= =?us-ascii?Q?fJr6r/1cYXO3m77UnUuAc+lIx6kYOsPs?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:02:57.0322 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73a501e2-4280-40b4-d803-08dcbacf161e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4380 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=3b60ef3db6dd122ec86a400c31fe19911fb4aec2 Thanks. Xueming Li --- >From 3b60ef3db6dd122ec86a400c31fe19911fb4aec2 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 17 Jul 2024 19:37:19 +0300 Subject: [PATCH] common/mlx5: remove unneeded field when modify RQ table Cc: Xueming Li [ upstream commit 463e5abe09362f1d20d0ec99b5969549d51167d6 ] The attribute "rqt_max_size" of the RQT(RQ table) context is only needed by when creating a new one. When modifying an old one, there is no need to set this attribute. The firmware usually ignored this unneeded field. When enabling some extra check, an error will be returned to prevent the code from continuing to run. In the meanwhile, this field will always be set to the maximal one fetched from the capability without any change. Removing the value set and leave it to 0 will help to solve the potential failure. Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 52b07367b7..630ab96a8f 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -1872,7 +1872,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, MLX5_SET64(modify_rqt_in, in, modify_bitmask, 0x1); rqt_ctx = MLX5_ADDR_OF(modify_rqt_in, in, rqt_context); MLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type); - MLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size); MLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size); for (i = 0; i < rqt_attr->rqt_actual_size; i++) MLX5_SET(rqtc, rqt_ctx, rq_num[i], rqt_attr->rq_list[i]); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:06.513353581 +0800 +++ 0127-common-mlx5-remove-unneeded-field-when-modify-RQ-tab.patch 2024-08-12 20:44:02.505069375 +0800 @@ -1 +1 @@ -From 463e5abe09362f1d20d0ec99b5969549d51167d6 Mon Sep 17 00:00:00 2001 +From 3b60ef3db6dd122ec86a400c31fe19911fb4aec2 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 463e5abe09362f1d20d0ec99b5969549d51167d6 ] @@ -19 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +30 @@ -index 8e12ac50de..9710dcedd3 100644 +index 52b07367b7..630ab96a8f 100644 @@ -31 +33 @@ -@@ -1914,7 +1914,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, +@@ -1872,7 +1872,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt,