From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FA92457A1 for ; Mon, 12 Aug 2024 15:03:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0852F4065A; Mon, 12 Aug 2024 15:03:35 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 952ED402C3 for ; Mon, 12 Aug 2024 15:03:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=weTjXA34h+svMguc/NaiJNz163DxFNAGSKfS/yFHIEPeCcNP9rgBf6fBDlzp+Cve20fgo7s7MRbXEbdVBIt5Ctxlh4Bh85W1xOjM4Uap4k4fCXHD0UfSYseVq/k0KeOt9ptScLOyYxe2/SFnKxH3f3eBszx/VooY4pC0kGv5KjIXh+BBGcQcRgvnyWDbDDQ3ucPX9bB0y3tiBjHkk6lWKuHDrFCFUyjmQCYzFixx3BbHVU7gBUhlS5GsNB9X2/RVosCthe3Ok6K6UVI1d1BX1m3yBU3k/uWwQWVuOB9raB84MK4Nm2nbKiWpQCuFDjSPSTBBz2KEWzzgFYnjICO/YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jf4CvF/SnDwUbBe7HQBaCC9gwVaNz+2qYA+7tJDVFtA=; b=hOxNrQ7eO+R8/64CD0STrlSSLGMBMzxKisHjydwFjZ6S1elZdAPa1sad+yDTYs3p7kuJc4ZdRwEtTT3lLmGl8nfutppzMUsNMqfHjtOmMOTFkRt9m/6uN4wroUv3KkZGXjclGKupEFCBLF0PCwTGf6zW86ZduX6AyouasWKspAoi2ujZvGYTyyfByO4Lz6X9PmkShhz6YEj+zKHdMga2lryu1PQ1Zp0AGq9NecuAhiMbpxgiIC7SHCKKOrvhdSFBxs5V2uzWOreNfZhiFxicNBPsJmYD9AOimxf+7B9OSPpfGWhbdJzYsqVVxl+0x0TLDBipVJE92Nc1hQZYRmlZ+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jf4CvF/SnDwUbBe7HQBaCC9gwVaNz+2qYA+7tJDVFtA=; b=ZXHoUYB+woct7TvgqfSSvUdqKQYZoO3NKIE+AAYgYaEPsc4Vo55gujBenCD6gUyu4wavQBWfpiUQ62T1n644aca5GyZ9LA8h+C5bOEkf4pF4bGKv71FU4qbkZ2o8fOF/u9F27bxdpE2/nxKguX8ii/g3SBL8/8V0HNr7qE/M+YMQtknRjPaDMKrnUC/ELGdSI5fNUXtNYRKmNmrGVlB3w/MPk5ANbLGgQxmsbPAy3j8Uqd8KZkpjTe0IWE52hXmZxAjjn6O3RFMRxPpJD9HCDUeswq3pbCC0Nf45sOcsDNnxrY/GN+eQOE4H2pGGHhYMj7otEXJOj0c5NniLZTKVvw== Received: from BY3PR04CA0020.namprd04.prod.outlook.com (2603:10b6:a03:217::25) by IA0PR12MB8932.namprd12.prod.outlook.com (2603:10b6:208:492::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 13:03:30 +0000 Received: from SJ5PEPF00000205.namprd05.prod.outlook.com (2603:10b6:a03:217:cafe::b7) by BY3PR04CA0020.outlook.office365.com (2603:10b6:a03:217::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 13:03:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF00000205.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 13:03:30 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:03:09 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:03:07 -0700 From: Xueming Li To: Stephen Hemminger CC: , Long Li , Wei Hu , dpdk stable Subject: patch 'net/netvsc: use ethdev API to set VF MTU' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:50:09 +0800 Message-ID: <20240812125035.389667-133-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000205:EE_|IA0PR12MB8932:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bec2dad-4012-4e9a-ef99-08dcbacf29b2 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?f5u+7KNZ887aXviTUTo/whyb92YBeROPE/mt7RcEtccN374VXMdLWilDGbMG?= =?us-ascii?Q?vG4FPsRi+ZzCvg6xO+kDMbANPlSPjOK9K1h/F/rXQ/7BZFYgHqwlWlQIl2pL?= =?us-ascii?Q?+JxE+XbbkMiKOxrhWGxZgHCC8ujMHXE+9zMHCXlsTCvUZT5TkbvD8cBSTkMP?= =?us-ascii?Q?bE8Qun7FTMExqEu/rUJwLzQ8GzW+YrgoG0hLwmVxD0S12xk4+7kjsRUH4scF?= =?us-ascii?Q?v1nVzQsjO58/LtnNK7qAimWTp/Vw/vgCWMzgzBkhNMPK3uOZ0wCJ3k/els+q?= =?us-ascii?Q?ZTM9nqrkdaXOcpeQNaFkiYS9SLjxhc8dGX54liFJuCLjQWMR4wUem69HltGO?= =?us-ascii?Q?M3SwGgt8UbLq0dS20T1VdAXbtJnOFUFfHQ4Fg8BghunSkXt84Y4HTNVjd7Dv?= =?us-ascii?Q?ZCyhpDweagw+GeS8SChG1EARjd/oPQN1QbpHe2KAGwOige8gQR0IZ+SN8cSn?= =?us-ascii?Q?sLCai1o3Rj1tZTptXq9uRrYDL6x5RyXmJBaatbZb7Z8N2IAr2yh7AZ5rpUx+?= =?us-ascii?Q?fqgraqRFi1MHuNablb+73o1oNKMKPtYRXWC1mV9SU6PqoPzBZLOmu0zW7MZp?= =?us-ascii?Q?F4l+2vDtsi35oBBOsn5W6q4BMq2CTv9jnD/5hqps65yR+OcgEGvPFjNe7K6G?= =?us-ascii?Q?/xGpmjXdIfz0yZc7lIL/N4BXvmdP19a2OxI2Ks3ERia9G2FHiRQW5fQ/JvJE?= =?us-ascii?Q?9tR4qzkCyiuUGkIEpMqZROAAcipBOVDFf5NB5/Wurv9nkoztte8x+0o8YOWp?= =?us-ascii?Q?cN0LLH70laJFgPOjU0wCoM87GU2tiZyUPIgk09IyumTdV0rieG9OaCnwumxk?= =?us-ascii?Q?s8xeQklldWKHXHzjSdz2gwN3z9hP4ahZvVeFSxZZQ5vpMHMjgqVihMShrLui?= =?us-ascii?Q?rF41yUHusWPgrPJzAayBI3+nNoANTAzHpRMJ/AyqyQ7AbQvnF4l5oPEYK8l3?= =?us-ascii?Q?WuZpjb6/1DgqGpxzwuyBAOw7u4x2xiC+b847hIazHvtTEUCdEA3591/ugAmp?= =?us-ascii?Q?FzpwVPskBBb1g0kC7Ddxy04uJYuG5xV6XhlQH9E2+1KKI/kI+5dQpYwfSpZu?= =?us-ascii?Q?aDT5Epa+pu9QNVT+5XYgR52UCpL86jJ1bgXsndgmOpnPVVTf+L2K2vuX40Y+?= =?us-ascii?Q?In9BNmaDJPeGdoinhBz9eH07rqdKl3ZfdGPJf5wZubWiV+52ua31ivGT15lG?= =?us-ascii?Q?SpzOEYMmb3ptjpAIbo9q66qlLPHkaQl/9JtCQ+acguSjqqpv8X07EWofSoxl?= =?us-ascii?Q?k8ZW6yXAmQOzshM3vbual27PwaBK0uY6W7/G6GyqUCzTKjbZYrM8ott1rRrn?= =?us-ascii?Q?gW2tHZHGvE4qoMV+cNxcleGIt/xFro+GnMcODUblkJZo/xoawvmxsC0DjPoz?= =?us-ascii?Q?ZJCB5OBAwxOXKmoGAqe/PoVldsm4x2k/jYK4VmW8IUbuyCZFQd8hSPBIMATa?= =?us-ascii?Q?bdA06iJPc457ymLqjpMEqd9RNaU0vAu1?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:03:30.0044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bec2dad-4012-4e9a-ef99-08dcbacf29b2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000205.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8932 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=fbd7ac3b83d6fa7c0edc88008985d021b6014a35 Thanks. Xueming Li --- >From fbd7ac3b83d6fa7c0edc88008985d021b6014a35 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 18 Jul 2024 12:35:16 -0700 Subject: [PATCH] net/netvsc: use ethdev API to set VF MTU Cc: Xueming Li [ upstream commit e57f8c38dc99b32a747b0aa4a0442a167e52d085 ] The current code uses unnecessary locking to set VF MTU, resulting in deadlock on hot add/remove path. Fix this by using rte_eth_dev_set_mtu() to set VF MTU. Fixes: 45c83603087e ("net/netvsc: support MTU set") Signed-off-by: Stephen Hemminger Signed-off-by: Long Li Reviewed-by: Wei Hu --- drivers/net/netvsc/hn_vf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c index 90cb6f6923..a4e958419d 100644 --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c @@ -264,7 +264,7 @@ int hn_vf_add(struct rte_eth_dev *dev, struct hn_data *hv) goto exit; } - ret = hn_vf_mtu_set(dev, dev->data->mtu); + ret = rte_eth_dev_set_mtu(port, dev->data->mtu); if (ret) { PMD_DRV_LOG(ERR, "Failed to set VF MTU"); goto exit; @@ -794,7 +794,7 @@ int hn_vf_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) rte_rwlock_read_lock(&hv->vf_lock); vf_dev = hn_get_vf_dev(hv); if (hv->vf_ctx.vf_vsc_switched && vf_dev) - ret = vf_dev->dev_ops->mtu_set(vf_dev, mtu); + ret = rte_eth_dev_set_mtu(vf_dev->data->port_id, mtu); rte_rwlock_read_unlock(&hv->vf_lock); return ret; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:06.707220366 +0800 +++ 0132-net-netvsc-use-ethdev-API-to-set-VF-MTU.patch 2024-08-12 20:44:02.535069381 +0800 @@ -1 +1 @@ -From e57f8c38dc99b32a747b0aa4a0442a167e52d085 Mon Sep 17 00:00:00 2001 +From fbd7ac3b83d6fa7c0edc88008985d021b6014a35 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e57f8c38dc99b32a747b0aa4a0442a167e52d085 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 6b3d0eb0c8..b664beaa5d 100644 +index 90cb6f6923..a4e958419d 100644 @@ -33 +35 @@ -@@ -796,7 +796,7 @@ int hn_vf_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) +@@ -794,7 +794,7 @@ int hn_vf_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)