From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C661457A1 for ; Mon, 12 Aug 2024 15:03:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 982B54065A; Mon, 12 Aug 2024 15:03:57 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2063.outbound.protection.outlook.com [40.107.220.63]) by mails.dpdk.org (Postfix) with ESMTP id 97D11402C3 for ; Mon, 12 Aug 2024 15:03:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WNJeVpV/HwK8mwz6nhB++Yw/W0tpIry6CoTeOjPDhWD9SFBvUKxOtSlb5Pe04/eFrGuPyqHkEloEBw8ya6wDzeRsgcPuQNunuS9tDAqnFQxXUxSE2ZNZ/6lgsWHrlqeSlOhz60babZz+unlV6gRvoWUierXjTVD2bf/DcWUuor8YU4DJXWPF7uEEw3/zIxH5UUzlYz9mp3k3eLysvkeav3GlGs8FefmHhvJZn1Coa5AQn2a519ADcy1tdh5NvuygDV1wur6ccrZf9N2YCj3/dD5Rf17etxFocdUJA039NX5yVgTbFjRFRw0abnmn/1yV7t3eqpcLWDymSvI/x0ZPjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZSuMy1uS4lznguPVbolBpAcNh+B62B+s8W9bEt5F+T4=; b=Yz2g/69TrAHy2FbCvJpI3ogSkXYitF9JlZQUFFBrk0UDU77Ux0y8pdcoZVKXBVi4S7D4PwevZuLiD66M8O1WBwZkLXhdPnhyefJWzWwKNWTCpDxJq8Mdy9WipKH5GqTYS1VTrZN4ozzpuYZAp9/1LuREk0V7Vib3ruweMHQOtxMSW2fnTcVpKoUOEMB3xHRRg8YlJ0fJAI6vm5sX8yMxDQtn3tbbe6V2tKvoiEPVcyNaf06XuKb7JOGJMa+og3stUHiVnqdhdqjWhZLJo9UNKq5ohudaI00TK/Oe04mC2aqVyvykOMUrKgDk4XojBCTRTx0pa+JFojylr4rEbM0vCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZSuMy1uS4lznguPVbolBpAcNh+B62B+s8W9bEt5F+T4=; b=ot21o5RYfhxGtlkXGmE05yCTndBPz3xIvOmSqaCh6asXKmfD38py2mqQhPQmxsfQUZztfKNwq3mxZJvnij3JwRis5N619Md337iYzDD3vKNxXFe95oURgK6ORdLRjBpBtbG/oX0Vkn+z+7xlJq7Xhgp0Hs/TnQEFNJv9BUzzsMmne1K4xP+6xNYE+Ze+qgIzTsTSiAM4j6YH1TwFIvD6GnOSIukLFW2pH27dovekTlWgJdOXg9gBq7Sg/NHHX3LrnliVPsKKKbih7/jFAGkl5km3bnC+RiXXN9gFpgF6UHE1tNbAq5+AVzdDtwyuVEc+8S3CC5N4iT6bL7VLPgPYgg== Received: from MW4PR04CA0365.namprd04.prod.outlook.com (2603:10b6:303:81::10) by IA1PR12MB6353.namprd12.prod.outlook.com (2603:10b6:208:3e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 13:03:52 +0000 Received: from SJ5PEPF00000208.namprd05.prod.outlook.com (2603:10b6:303:81:cafe::4d) by MW4PR04CA0365.outlook.office365.com (2603:10b6:303:81::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 13:03:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF00000208.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 13:03:52 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:03:36 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 06:03:33 -0700 From: Xueming Li To: Ferruh Yigit CC: , Raslan Darawsheh , Ali Alnubani , dpdk stable Subject: patch 'app/testpmd: fix build on signed comparison' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:50:13 +0800 Message-ID: <20240812125035.389667-137-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000208:EE_|IA1PR12MB6353:EE_ X-MS-Office365-Filtering-Correlation-Id: 80434156-e908-43ca-90d3-08dcbacf3729 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yHMkwgRfqGMX3QKQx+CWw/gKkeiL9cAJam/giuuuqqqJ+zh9+Zy9QFopbfvj?= =?us-ascii?Q?WCs7WJMGrGPAz1jMVo7O50/w0JJnYb+oYswCd5751u0P87aqwqwa5P0GXho4?= =?us-ascii?Q?MYeYntsl2Lsp696axM5Mo88/CtGgS/SA+CrvZLsra2cekirXCT5JuTJtsQkh?= =?us-ascii?Q?m/jShXZCVly2QaxPHblpJBqBnN+X7BYcSbTfuwsu/ip8hKHiOiWYLONKQRnR?= =?us-ascii?Q?g0lHJq+mHj1hJ/ENH49w4GNv3mcZOP9iIzGXrVgFHSbRJIM2AjwY1msbh7vW?= =?us-ascii?Q?gWklkoJJ/ZMsliGBxnbYI8gLnx+DL96LU07i30oT/63BivWHzGd2CcD0OhnB?= =?us-ascii?Q?QfppbAcDna8KZpxLC2N5vdiAMEV9L6mwl9sBgT12R+L7i5PvyFg2Vgu6XAnm?= =?us-ascii?Q?+xPT0YVkLSRbWeRWZ+R9GlZkbI9lRPUMXVzabS7Sh1Aa20Y/6X25FFi1yFvp?= =?us-ascii?Q?DYOAuZCXVrGZWh+sli0lYrU7iWHqBNLRSct8LeGDR0J6ifVoZyOwbbG/GJ0s?= =?us-ascii?Q?rBjzFaER6g5ZRVcEmKqZ3CCizrNfiU0/8R5dVjp2o2t9/ssfAeQN2V1+sByC?= =?us-ascii?Q?3rA/r121h66ai8JEwBRJybndRFDpA6ANqnGzuridwNpXZT1Bg8gDCzLMM8f1?= =?us-ascii?Q?hp/bca9Q+fUCGuNq17WsuZyZwAI+BPdogWmLyqAOvoRUC1EYPPYShjzwz408?= =?us-ascii?Q?qjlAU/WhJ0GmDhzcNWhGNRf1X+HmpYEoF6YsaPZSt/4JLm5mz1DKZne4yRu6?= =?us-ascii?Q?BYUnuAdTcaKMjOMITZHojqWGA6kCq4yI5ckwWQ26m6e8II3gtwapU8gJpWVA?= =?us-ascii?Q?6rwZ06A8iU/iHKYAm1YrW0zGtjkK/x0biw+4cRtKwGDYa3iw6C3azbcOPia4?= =?us-ascii?Q?eO18A/+37XDH6At1yo3WiBnKmAPEpRKFHKyZTVbmRLmQQ5aVLq8pudNWu23S?= =?us-ascii?Q?N4+hMRCE8mbrzFUkvIRGjMFl7oE2v4p7rZ+eQ0ohFaYIZOfAu9q7K3PrgJqO?= =?us-ascii?Q?/YNGjCQgwzG7Ga74Q2B0j+TF8c9KF7oSk9g56DKfM6n6LFgw2kT8j9GLbQgg?= =?us-ascii?Q?PYEZfeWQm+vFOH0IBVbXnn5C+om0fgClx0ndfmef8sg5DtM0U4vOvQetvN4L?= =?us-ascii?Q?NBZxEttXmvJsKsKNXW9BtNYTU8e8Lse/eLfHQHRnwmOCViRD9Dd4qFZ7BFPW?= =?us-ascii?Q?ASWgN6xYh2YfO3a4Nobb6fRlLAcThRxxCtr8eiWkSP9zFEmqP7KdEkkf8Qk0?= =?us-ascii?Q?VDgXovmwmScbG8+XR8aWa7MSN8gTGL+Ec1UwlVHFuFTq0Tqq0y4XxbyS2vba?= =?us-ascii?Q?nc9nz2DMMd48vuzeCd/p8zsWWuJ/0316hSuuqO1qE8C3IIB9nG0OyYO1PUc2?= =?us-ascii?Q?pdyMovf+gkNwmZJeNbIeYslH0q/FAqd2ZSsuZMtPBcizBqxw6gmqDWCcXp9J?= =?us-ascii?Q?sRdf3eSYCP/cQiEO1AINYSBusddWTeAw?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:03:52.5141 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80434156-e908-43ca-90d3-08dcbacf3729 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6353 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ca12727f09f74f8524e346d3e9c9c472e6b4dd10 Thanks. Xueming Li --- >From ca12727f09f74f8524e346d3e9c9c472e6b4dd10 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 22 Jul 2024 03:52:29 -0700 Subject: [PATCH] app/testpmd: fix build on signed comparison Cc: Xueming Li [ upstream commit 1f47f469aac68bc88be24e530b4267d03537de12 ] Build error: .../app/test-pmd/config.c: In function 'icmp_echo_config_setup': .../app/test-pmd/config.c:5159:30: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) ^ All 'nb_txq', 'nb_fwd_ports' & 'nb_fwd_lcores' are unsigned variables, but the warning is related to the integer promotion rules of C: 'nb_txq' -> uint16_t, promoted to 'int' 'nb_fwd_ports' -> uint16_t, promoted to 'int' (nb_txq * nb_fwd_ports) -> result 'int' nb_fwd_lcores -> 'uint32_t' Ends up comparing 'int' vs 'uint32_t'. Fixing by adding the casting back which was initially part of the patch. Fixes: 2bf44dd14fa5 ("app/testpmd: fix lcore ID restriction") Reported-by: Raslan Darawsheh Signed-off-by: Ferruh Yigit Tested-by: Ali Alnubani --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a09aa3bb85..40e4e83fb8 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -4980,7 +4980,7 @@ icmp_echo_config_setup(void) lcoreid_t lc_id; uint16_t sm_id; - if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) + if ((lcoreid_t)(nb_txq * nb_fwd_ports) < nb_fwd_lcores) cur_fwd_config.nb_fwd_lcores = (lcoreid_t) (nb_txq * nb_fwd_ports); else -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:06.811800757 +0800 +++ 0136-app-testpmd-fix-build-on-signed-comparison.patch 2024-08-12 20:44:02.545069383 +0800 @@ -1 +1 @@ -From 1f47f469aac68bc88be24e530b4267d03537de12 Mon Sep 17 00:00:00 2001 +From ca12727f09f74f8524e346d3e9c9c472e6b4dd10 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 1f47f469aac68bc88be24e530b4267d03537de12 ] @@ -24 +26,0 @@ -Cc: stable@dpdk.org @@ -34 +36 @@ -index 66c3a68c1d..6f0beafa27 100644 +index a09aa3bb85..40e4e83fb8 100644 @@ -37 +39 @@ -@@ -5156,7 +5156,7 @@ icmp_echo_config_setup(void) +@@ -4980,7 +4980,7 @@ icmp_echo_config_setup(void)