From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1D05457A1 for ; Mon, 12 Aug 2024 14:52:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB3CC40665; Mon, 12 Aug 2024 14:52:24 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by mails.dpdk.org (Postfix) with ESMTP id E08CF402C3 for ; Mon, 12 Aug 2024 14:52:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sy2vdnKaSnN8ebsusBPIvNAUv7PYTm2KlaeyVY8LEdWXg6DmPM0ss3FOvHEorIrrUE2HxS1xQP7XdmixKDE4yq9KR5vXZ8pBN3hDE1dsh8wVK28cp4y2TcRGvMJ01m3E//UZVM/ffe4xbLcGEqJF2e58nvJz70a6sCF+LUyahbpu1Q6F3AHeX0jdbiYAQuqZNjGD/5rhRtKDVjvA4jeWC9Q7HNmutwMKnMrMeQdhjgtsfDE9pnDVtlBHC+0okbYAz9BcAM+r60reHzKhfjFBi2y2GW7KrO7gVO6lSG+cI4m623alCQCn9FusDwEfFIcyhkKf35fvq4vDS440sdul9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cq+ep0XeciVRh9dLRxZROU1+Asp5NOb37iW3O5OKbsg=; b=t5AQ5gCizuZF3/DsNHY6IzriKZozOonb8nmgxcmr55IFRn7dG03rLS08hqtOMXWsLaxPfO4gI1ZDfnmk0/fBW9M2QfWe8upc56sEzWkkrUKaDZZ/ASAkiq2AOhM0shliSzie+u9KbBfMeVgz4DvzXxINqjm0iZjKdwhJZSTzNlUCoBKzLiWW2jzYl2SSvB96GacyGKcTjBScAsaO9NfMQGJIT5nZ5N7EKdl4gbSXm5ouYgi3lCMqSYcThPSATdFPznllGJXcX2kkGj4LST4RUtQmTLw6/4ytVVcaTSpECEJVJ0VDw8FqMHhkUC7rBzty/UKTzkvQW7M+aW1iWF9JjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cq+ep0XeciVRh9dLRxZROU1+Asp5NOb37iW3O5OKbsg=; b=dkZRs+6haykbE6B3Bo8QZ/JN/i7FrUqKCWbNbCWRXR1iOIZA25jzk00RcXcgNCTlpu6YIWBp1CWJh5GPOz/LK3pRlNR1cyFNdCrcpZ3HzykGjzFV13wobdHm5W3gZEHoXAl49PYoU8KEXsN/FSRLHjnJgxa6LSjyWHvODbx4CqKPevMX8DCnU2ihEj+vKSAAKkavbfhltPVGgo6gJyDOQ6j7thfdaLKvsz7yAMMTFKJI/nbHtBBSNuq5qq2MRPl1l+ffbtQfOD+iwS40WDelqhyJ/zDt1Pq8lVAXFBqT5r7QAb/apW80QF4RIgLDVPdo6cgQCBD5/6qQkVnTDaqCOg== Received: from DS7PR03CA0310.namprd03.prod.outlook.com (2603:10b6:8:2b::9) by IA1PR12MB6651.namprd12.prod.outlook.com (2603:10b6:208:3a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:52:19 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:8:2b:cafe::43) by DS7PR03CA0310.outlook.office365.com (2603:10b6:8:2b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.33 via Frontend Transport; Mon, 12 Aug 2024 12:52:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:52:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:05 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:03 -0700 From: Xueming Li To: Zhichao Zeng CC: , Song Jiale , dpdk stable Subject: patch 'telemetry: fix connection parameter parsing' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:10 +0800 Message-ID: <20240812125035.389667-14-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|IA1PR12MB6651:EE_ X-MS-Office365-Filtering-Correlation-Id: c2ff1252-fe0f-4c9b-26e1-08dcbacd9a0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Oxe5/PDfZo21S2kqSSKVLU+tCg8v+Ao1uZUXdIQmzQDUMxPG5oyn1ZToivMj?= =?us-ascii?Q?eoN2aYU/1oyPJXrn+aOU38wyVgKNMPqOkoq8fjSpjsgtvtJPAXaWUuSQ/pX+?= =?us-ascii?Q?elVKq2b+b6L1nxw6E3SATtIE6H7hsT+YjhQUmh8YILatmFcFhAbpIBkXhah5?= =?us-ascii?Q?fltbna7gY//LoFyTv2zEawtIOIWzc/azGlU+NZ4WGsxjS8oBc6drhDyZRMS6?= =?us-ascii?Q?D98Z/MtnXCw7pr7r+d+1eneLx1rItfslNkOGcOPo2uhfGZFWxUdz1ZWCewF9?= =?us-ascii?Q?9GPaUtDu9hQPsZW14yWPoxb2ajSMMQdFRf6Sv3fe2OTpdLCVIQJtqguaSLkT?= =?us-ascii?Q?KjZ1f8cna8pchvUjm1bmAG1A0++pUPFeiT+lCmM/jPHGLOwlctWy0XLcmLGe?= =?us-ascii?Q?W+4JNPGA7y1croSZoE5/WOha0Y/s140Xh7iYEraH0Se8UIbqgacZ6SDksr4K?= =?us-ascii?Q?SsWP7O5mtt11cfZNevyyjcdrxFqRrIJJTUKj3de8AxfQe14VmarCsHDlt/hR?= =?us-ascii?Q?O0HFT0ALQ+Z5uaApNvyp0orFCEZvFwX4d5DwugFuH9ZCxhTFobTAz6UZWmaY?= =?us-ascii?Q?OYqLRMecd/qDMeQhvt3PTFoKEgqKjwgzoA/hhxmGszq8+CsjuYOCKb+cIKsD?= =?us-ascii?Q?sndKsaqnRgX/hU7BxydPJPT/LPr41XEX4h6h3+OCCsD84gFaGlbATBmrs34n?= =?us-ascii?Q?kMEBG/3ZFDEuY+3TJPUTU29a7Qx6IhukyK1posy0o8yKp83+0m3SOAwQC+hi?= =?us-ascii?Q?t+y0Vc5POCij6xSpLz7F+nfUvMkeAgN0HoEa+uXkKXVi8zZXu3Is0ihpRkc3?= =?us-ascii?Q?Bqnb4d6IZVdU54fLA45P6T7H3HO1+nwX7JvssA+HNjB9sZooePPvHwhg84kg?= =?us-ascii?Q?W7WRFmP+shTaLUBf/PSvDVZBgfWpKpdJoHT8lvTqbXcEOfEi7vO+xOJFmF6N?= =?us-ascii?Q?HFv+RHr7VqZn13szsxSqpxujS0SlG22NVsHmOArSjAHBmkb/3Boc8PepLQzV?= =?us-ascii?Q?pDCa+kHHix4k739ZeikHvTb94Kegr/vfYuPrtxtg31UF9GEAuvFEF3e8j4j5?= =?us-ascii?Q?Zkiu4BQ1RmGnT7aAyWWPebWFyF4TVQA403lK4dwLI5GBuqABYUsRj8fHqzNW?= =?us-ascii?Q?rFLf7OCBb+dZwJzlRvoetvhG0Koafu/Eskn1Xl7eoPLbwX8ogIX7rySvE5/5?= =?us-ascii?Q?TFO+KAtb+hFpy56Pdm2S5HKDRw3+Nhfl1VYW/MUakjlfXLP3ujpm0nzNwcUq?= =?us-ascii?Q?f3LLl5S/8Geo/4WFopDE7NOHqB6EBs3RtKcGjVbj40MsmnLQePMw4CMD5UGy?= =?us-ascii?Q?4ZQouX8dXI+9xdf+Tln0N6GQ5bSz7JmXljC9i1O84qJUlElb/Y7OAHRcdCbr?= =?us-ascii?Q?1d+sLouJVMlv0WSbL3FS9sSrJLNwsli72Pr3cfEt5p5HM474t5y4z2FEphZZ?= =?us-ascii?Q?o9M9WQxgt5xdCItTZDCBKQqGNkGJvSSM?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:52:19.3689 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c2ff1252-fe0f-4c9b-26e1-08dcbacd9a0b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6651 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=f798848548c19b7f7ad896d76c66d7ab678f75b4 Thanks. Xueming Li --- >From f798848548c19b7f7ad896d76c66d7ab678f75b4 Mon Sep 17 00:00:00 2001 From: Zhichao Zeng Date: Fri, 21 Jun 2024 10:40:37 +0800 Subject: [PATCH] telemetry: fix connection parameter parsing Cc: Xueming Li [ upstream commit efdf81829076198189ba6ccbb2e5c50270f56992 ] For calling memcpy when the source and destination addresses are the same, there is a small probability that there will be a copy error issue in some environments, resulting in a failure to connect. This patch uses memmove instead of memcpy to avoid this issue. Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Signed-off-by: Zhichao Zeng Tested-by: Song Jiale --- lib/telemetry/telemetry_legacy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetry_legacy.c b/lib/telemetry/telemetry_legacy.c index 4c1d1c353a..578230732c 100644 --- a/lib/telemetry/telemetry_legacy.c +++ b/lib/telemetry/telemetry_legacy.c @@ -94,7 +94,7 @@ register_client(const char *cmd __rte_unused, const char *params, } #ifndef RTE_EXEC_ENV_WINDOWS strlcpy(data, strchr(params, ':'), sizeof(data)); - memcpy(data, &data[strlen(":\"")], strlen(data)); + memmove(data, &data[strlen(":\"")], strlen(data)); if (!strchr(data, '\"')) { fprintf(stderr, "Invalid client data\n"); return -1; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:03.032890458 +0800 +++ 0013-telemetry-fix-connection-parameter-parsing.patch 2024-08-12 20:44:01.905069257 +0800 @@ -1 +1 @@ -From efdf81829076198189ba6ccbb2e5c50270f56992 Mon Sep 17 00:00:00 2001 +From f798848548c19b7f7ad896d76c66d7ab678f75b4 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit efdf81829076198189ba6ccbb2e5c50270f56992 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org