From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65422457A1 for ; Mon, 12 Aug 2024 14:52:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FC96402C3; Mon, 12 Aug 2024 14:52:47 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) by mails.dpdk.org (Postfix) with ESMTP id 266E44029C for ; Mon, 12 Aug 2024 14:52:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gn2cWhgHVdIytfIu4YJg3d9By9ap93sBYzX6CfUEOENyWMjtjI37aleYE/XT/1HxnS7yLQI7uViAiF/iFw7R2+dMcinLiHMpV6pyYQyKm5HXxZ1+HNyEzm+QG6bWEFpufjcK2kkU7+dg6tZXGlNgb6fAP0TdP8qzdbLUxF4oRd4rSvx9bsuQxqmEOm9NbN2MP+UEnlVv9NIA/elTH5LnEG0A6gAW3pm4CaAeWKiG6GW/iAmsFfdq4BURaL+Aics0O1t9sWsfdpPQmEPmHaj4VXk1sHFE7SR2y8JTZMfvqaKg1RZIsW8OPRj0WwFzYm7vfH8oxIDoAGXb9InpJiamfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6335bR9PgivHiLwiW5lO1K3gPDOYDl4Pllrl/68k1+g=; b=L1Wg8NZocLKZjD+yreydpQ9k04edgUt8ZLRFa0N8MSmLl7W6JVYv/oFzVwppFQD2MHKInVyVX2CNx9TTKgxaCYNoGE+MskKV1wTS53vW5VHSpeBq+c+lanXPMNH3/mLQD04O1L1FlOwtLWQ88NDb/tcsSN3qolqRJdx+jwdyPlFqGN1v5JthfuUYqIHSb1dolO8VT0kfBk7PkidXSk5/8qorrMDjUj4GWDbCVEZtqyVfcMRpyzJLxd+FotfjkfS/wuTpfmg3Bji5AENXTK1nzmeRNaIKzOtXoHpa0yXFqt5cS7wOHKBD2cCP0O7SOYDYnb8yizRsEn4cMuVeeopluw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6335bR9PgivHiLwiW5lO1K3gPDOYDl4Pllrl/68k1+g=; b=DjfI/FEPa1Am0tG8eF0WqCAiwATDgcjfpKUmCfZbsOSJzTSgmbjoDeb/vrNp6Y67DtGWul0OIZg2wCY1s+e+piVkiCtt3fcFTU9mimE5/diQWsf/1jkg7rlHvflhAixyAQ7WM36M7lpk1AvlRy5NxAnrubafF/+4bnCjPyAP6EPXXWKPMt7z3eMa+d35DKPaYI39eCp0GTi+kjJlK/uMS2LdYSdISKXk17yHU94xheV/VqiwsNXo4DhpEu9gcv3dtcMk5QKKQd52HuoGbHd1+2tPb83z/qXzW9oMyPvJvS5DlwJmfyXFjs0exasmAkGiRhYzHd4aOMAg8X2MFlPb4g== Received: from SN4PR0501CA0003.namprd05.prod.outlook.com (2603:10b6:803:40::16) by DM4PR12MB5987.namprd12.prod.outlook.com (2603:10b6:8:6a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Mon, 12 Aug 2024 12:52:42 +0000 Received: from SA2PEPF00003F61.namprd04.prod.outlook.com (2603:10b6:803:40:cafe::f1) by SN4PR0501CA0003.outlook.office365.com (2603:10b6:803:40::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.15 via Frontend Transport; Mon, 12 Aug 2024 12:52:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F61.mail.protection.outlook.com (10.167.248.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 12:52:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:31 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:30 -0700 From: Xueming Li To: Gowrishankar Muthukrishnan CC: , Akhil Goyal , dpdk stable Subject: patch 'app/crypto-perf: remove redundant local variable' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:15 +0800 Message-ID: <20240812125035.389667-19-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F61:EE_|DM4PR12MB5987:EE_ X-MS-Office365-Filtering-Correlation-Id: 05f2931f-9dea-4b48-6f10-08dcbacda793 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/nb6bTxXFXE2hmwmcD5Oc4HwVLPS45CsZuwUgOB1UUqB2mUyxCFKqtovbKmz?= =?us-ascii?Q?9h7k+qDCI4HfaW2RktDYIIkHkEdDzbL8fzl028axNpwo5cRPE45f7LEE1leS?= =?us-ascii?Q?FvxbDganEmjt2rveJ5WC5usIM5UdghM8T9v2/SM+RMGCIOuxiBlpv24/H3/H?= =?us-ascii?Q?7uvv7a9O+GPV2ADGa25s/1KxYwKAySFL6p2yoIN9e/eKoqJqbExI6QAMXsVm?= =?us-ascii?Q?Q/DMdvIBeLPp2PvqGYi7MFoHlN6HmFusLaiO9hdZU2bxSxqRWU2xxU3oqLiV?= =?us-ascii?Q?U/osQfpIM5HQ20knP2hjMIBIjtEZ2vtSkH1TphP0fw0mLn3SDtrAw0G2EIcj?= =?us-ascii?Q?A1bFlYWXj4JRpkOyExkXKM7ODLHhNE7eT002pUB7tsg0kXBDm7bK/0BktDTy?= =?us-ascii?Q?cF23eLU9aH5GEHDQ/VK9uhtbOU4J7Hj7RUOElxJ+7yDrEDQO3IcXLyAdp+hH?= =?us-ascii?Q?JnGq2a5Fe01/XBaFm3DESbekI/KUwTzPAo3BlJtoP7Ra3HrBoyAZw812qouZ?= =?us-ascii?Q?z0Ha+a3X3zgKHlrW8sHhP46VeEV/TLJaSpHtx5LrUA/6ioK3w+dcihtWs1Wd?= =?us-ascii?Q?lrg9uD2rAL8Olk2/md5rjcl4izKLhZRmxBIg8SlIeXcLv4hh3OQB59FV8UIv?= =?us-ascii?Q?ILKnunRgkL8QVRniKKtKjFWokIrvNB15mwnkq1Ft5uA82DlT6cS1MFWcpJXb?= =?us-ascii?Q?bPOTkzciiVRPXovX5EER0v6DNhOWjXGGU7t8wqyTUddchLstUzcA7KDIzv1n?= =?us-ascii?Q?FCNB3i/uW1rnUwRbEp4eOmALTf4q3QQgKj7zVJGbsD7Rr+qMkyBacTda3xpc?= =?us-ascii?Q?kbFQpwYpPGXVge5Xh9AYdWmifDwiz2rchEQN33Eaq6bgrmFshz10OI+KTFLj?= =?us-ascii?Q?HFr6vRTZ76hTlHZeX/u0fEA+tTWywDOfxvwl+r/4rXZjUEThHy18CZE+Itnm?= =?us-ascii?Q?Wrye0FzaAXIh88FgdzAVuAxzau/Iy/ulEZHfOi7El7f3Nw8HUkqPSE7WsGGE?= =?us-ascii?Q?4D68qhZTUTwy2g8wgeu114JSL6cliSfaE2nTGS7A2ZxRoIYXTEHsJMLU7y4K?= =?us-ascii?Q?jkQpn2Rh7391+pn+YwC5ObO+YvwNDIZjP0MGkim8zR39BSHOh1NivkZ+uZrP?= =?us-ascii?Q?YmRg/tjAcoA1NWWz+S4ouat2esQW+gfRILGA2Se4gefQpKCVeNnm874n4wTx?= =?us-ascii?Q?tUNDgr9Uyx3fRft9IqnqzkOxMwxyaysaCBAQAIm2u4TiGo0lhe6MyhDO6a92?= =?us-ascii?Q?yrWzp84CjgO3+DXk2qT3I1ea/g3AKOacK4frwEXYfuFK2EpmI2I/Cz6OH41O?= =?us-ascii?Q?wOyFUuLyukepUwl8O4cQmTCv2YQThIl5BHIhcL0O4yawZpuQGbgX8JWjA4RM?= =?us-ascii?Q?t4IrJN5RDNNobiP7+vJSsU3q1h2HWVDVNgg5dKZGIQ99k30o6BZKv3uWuuIU?= =?us-ascii?Q?kBf/vtlLcU+qMhjlloVMvDoXik8lmcV7?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:52:42.0724 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05f2931f-9dea-4b48-6f10-08dcbacda793 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F61.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5987 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=74697625672acd8b1fa108e9e29302348908eef1 Thanks. Xueming Li --- >From 74697625672acd8b1fa108e9e29302348908eef1 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Wed, 26 Jun 2024 14:17:41 +0530 Subject: [PATCH] app/crypto-perf: remove redundant local variable Cc: Xueming Li [ upstream commit 766cac609427cc8ef0f6680a73c4dcd3ac4e2a0d ] Remove redundant local variable used for asym session. Fixes: a29bb2489886 ("cryptodev: hide asymmetric session structure") Fixes: 2973dbf93b44 ("security: hide session structure") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_ops.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c index 84945d1313..0e79133310 100644 --- a/app/test-crypto-perf/cperf_ops.c +++ b/app/test-crypto-perf/cperf_ops.c @@ -21,7 +21,6 @@ cperf_set_ops_asym(struct rte_crypto_op **ops, uint64_t *tsc_start __rte_unused) { uint16_t i; - void *asym_sess = (void *)sess; for (i = 0; i < nb_ops; i++) { struct rte_crypto_asym_op *asym_op = ops[i]->asym; @@ -31,7 +30,7 @@ cperf_set_ops_asym(struct rte_crypto_op **ops, asym_op->modex.base.length = options->modex_data->base.len; asym_op->modex.result.data = options->modex_data->result.data; asym_op->modex.result.length = options->modex_data->result.len; - rte_crypto_op_attach_asym_session(ops[i], asym_sess); + rte_crypto_op_attach_asym_session(ops[i], sess); } } @@ -64,7 +63,6 @@ cperf_set_ops_security(struct rte_crypto_op **ops, for (i = 0; i < nb_ops; i++) { struct rte_crypto_sym_op *sym_op = ops[i]->sym; - void *sec_sess = (void *)sess; uint32_t buf_sz; uint32_t *per_pkt_hfn = rte_crypto_op_ctod_offset(ops[i], @@ -72,7 +70,7 @@ cperf_set_ops_security(struct rte_crypto_op **ops, *per_pkt_hfn = options->pdcp_ses_hfn_en ? 0 : PDCP_DEFAULT_HFN; ops[i]->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED; - rte_security_attach_session(ops[i], sec_sess); + rte_security_attach_session(ops[i], sess); sym_op->m_src = (struct rte_mbuf *)((uint8_t *)ops[i] + src_buf_offset); @@ -129,7 +127,6 @@ cperf_set_ops_security_ipsec(struct rte_crypto_op **ops, uint16_t iv_offset __rte_unused, uint32_t *imix_idx, uint64_t *tsc_start) { - void *sec_sess = sess; const uint32_t test_buffer_size = options->test_buffer_size; const uint32_t headroom_sz = options->headroom_sz; const uint32_t segment_sz = options->segment_sz; @@ -143,7 +140,7 @@ cperf_set_ops_security_ipsec(struct rte_crypto_op **ops, struct rte_mbuf *m = sym_op->m_src; ops[i]->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED; - rte_security_attach_session(ops[i], sec_sess); + rte_security_attach_session(ops[i], sess); sym_op->m_src = (struct rte_mbuf *)((uint8_t *)ops[i] + src_buf_offset); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:03.205405144 +0800 +++ 0018-app-crypto-perf-remove-redundant-local-variable.patch 2024-08-12 20:44:01.915069259 +0800 @@ -1 +1 @@ -From 766cac609427cc8ef0f6680a73c4dcd3ac4e2a0d Mon Sep 17 00:00:00 2001 +From 74697625672acd8b1fa108e9e29302348908eef1 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 766cac609427cc8ef0f6680a73c4dcd3ac4e2a0d ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 4ca001b721..a802281a71 100644 +index 84945d1313..0e79133310 100644 @@ -39 +41 @@ -@@ -62,7 +61,6 @@ cperf_set_ops_security(struct rte_crypto_op **ops, +@@ -64,7 +63,6 @@ cperf_set_ops_security(struct rte_crypto_op **ops, @@ -47 +49 @@ -@@ -70,7 +68,7 @@ cperf_set_ops_security(struct rte_crypto_op **ops, +@@ -72,7 +70,7 @@ cperf_set_ops_security(struct rte_crypto_op **ops, @@ -56 +58 @@ -@@ -127,7 +125,6 @@ cperf_set_ops_security_ipsec(struct rte_crypto_op **ops, +@@ -129,7 +127,6 @@ cperf_set_ops_security_ipsec(struct rte_crypto_op **ops, @@ -62,4 +64,4 @@ - uint64_t tsc_start_temp, tsc_end_temp; - uint16_t i = 0; -@@ -140,7 +137,7 @@ cperf_set_ops_security_ipsec(struct rte_crypto_op **ops, - uint32_t offset = test_buffer_size; + const uint32_t headroom_sz = options->headroom_sz; + const uint32_t segment_sz = options->segment_sz; +@@ -143,7 +140,7 @@ cperf_set_ops_security_ipsec(struct rte_crypto_op **ops, + struct rte_mbuf *m = sym_op->m_src; @@ -70,2 +72,2 @@ - sym_op->m_src = (struct rte_mbuf *)((uint8_t *)ops[i] + src_buf_offset); - sym_op->m_src->pkt_len = test_buffer_size; + sym_op->m_src = (struct rte_mbuf *)((uint8_t *)ops[i] + + src_buf_offset);