From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B9B4457A1 for ; Mon, 12 Aug 2024 14:53:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42EE5402C3; Mon, 12 Aug 2024 14:53:08 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2044.outbound.protection.outlook.com [40.107.94.44]) by mails.dpdk.org (Postfix) with ESMTP id EEA364029C for ; Mon, 12 Aug 2024 14:53:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MaOSzJo66z2fe3tw+oLkfiorSgarU4/GHqUKfjV88n1rp4CFsEj93NKZuJByt+ZOrcQO27sIHuFsnqjNHqZih4NMguEo7dzfbJAnycv3b0mCB6ncvO/6GIxeHT0fr6UdIrWMjviNiTDyBE5oNoEawXJGrAEwvF3D5WMiTxcxZ7eA+5ntgF2sziknAApm7KcsZ5Mv+NnpBXrkphlp2ORY/1k451LTQh9CWWlZZYhhFoci54qpwKc/Ja0fYQM662qMPInjBETSUh6vsXIohDaNateJp2p9VOc/CvTk99ylWPn71TWuHF/6fqdeyP3W3SJiYOjWsMFzIhj0vh1F45gTXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6lrPLDjLa2oOn0D2tBtisxxTwAwQUUPpzdMz8v/Dj8Q=; b=AsJKooaNugjoy5eNuqY3Tx3AjBu5aS89PoysoaoKU36+DmS3Nnf9BQjm8pBwUnDjCMXGR9JhFETMWDYKcsTtuKcMG2g4LNqzMivBtGPnTanijQmsG4Cz3IflQWRswBElulNariqdLrImkkVB+mlXvsN9qGAPXg+Ws+ZIDRBycU9ttdqFPL54wLWfmIMr6SAoHGEtjrRmQLwU6OQZeIdq0x9o+9tFLnW+xValA3sUiHYAnR8vjIFOWvrhET9ZTLtrZbpnoVTmoshmxqlJV3X8gxPVccL/E1vQNo3FaG075/eiuqc53O0tL3CVAfxEYQkxaUxLm6IKxetHId6rkS0vNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lrPLDjLa2oOn0D2tBtisxxTwAwQUUPpzdMz8v/Dj8Q=; b=jHgwHZO+wSVwRhDTaq1gg78fK/kaEihF9muyeX0gp97mMhZOLH1mdBcYsDux5Nb1s78+AaOBOmuDjjPL2LYASxxHYMBgCklxOJsfPusQ/N3FBP34hormveDZzrX9uLHOffaAeoiP1ih6SM4zw+DCgLsS6ebvRugsj4hdWRfLJzO2frD4w7R8i99eD4Pqt8zr3LcO+GA3KFV2Y8oEG2O5jzS4pgECGvCOKJYym41pILKTqnpjkkLmTrxYKWDpyhtOt8XInbj75r/fsSrw0N4QSztxLWEP8S2ukFoubUddFIrl3x9eXOAgKo3mKyZACOuFf5JLy+INtTXAtuvB4nWHiQ== Received: from SA9P223CA0010.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::15) by SN7PR12MB8129.namprd12.prod.outlook.com (2603:10b6:806:323::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Mon, 12 Aug 2024 12:53:03 +0000 Received: from SA2PEPF00003F64.namprd04.prod.outlook.com (2603:10b6:806:26:cafe::2b) by SA9P223CA0010.outlook.office365.com (2603:10b6:806:26::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:53:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F64.mail.protection.outlook.com (10.167.248.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 12:53:03 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:53 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:51 -0700 From: Xueming Li To: Gowrishankar Muthukrishnan CC: , dpdk stable Subject: patch 'test/crypto: validate modex from first non-zero' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:17 +0800 Message-ID: <20240812125035.389667-21-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F64:EE_|SN7PR12MB8129:EE_ X-MS-Office365-Filtering-Correlation-Id: f9ac7920-0a99-4550-4c66-08dcbacdb448 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YCdb/SCq/1v8FDbMfVXcv/HW5S+/hAlGrNEVZKld4+cY+hqpEbXwlbDVXxV0?= =?us-ascii?Q?k/tkJQ4Q1eMu8KVSDtRasaju2lpErh/7fbN35e/GWXBWeQQjIyy6HYJH7Sq9?= =?us-ascii?Q?dPoezy5B/E2u583F9U+VAxzIJxZnsEkvlMG+NJPoSN2WJO3Mqhmgg3jLVCn1?= =?us-ascii?Q?nuPIB9qy2lMfPOCRi8C+4Zp+PsSzo6c8aNdbKXrNqB/iFmL0PA5COzU1kuqw?= =?us-ascii?Q?z8y8UJeNaIi1YyeU/28Z+dQ7OIx+1VAL9wup4u4J0mu/QdDkh/xcew7pxAMN?= =?us-ascii?Q?Jj+weo8svqWS0tj/2XOI7NoNbtuLODEdJie2Usw/wNCs66DxNacbBJQzoUC4?= =?us-ascii?Q?FflUj9yEGQwOjmHbyUcW2ew5jNQph2dLrbV0xnkU/buf6WeUjFFtnItgoZp7?= =?us-ascii?Q?aDIksk1ko8KicSfF9np2bDP3tXFB4A/wnKJGvKvMTVE5cQ5IrXt3mBrkFYPK?= =?us-ascii?Q?UxENNLZ9d+YGORNQRSRIxoFjYiA+8IQJpk3CszIQIPnZqTIVyLDvtlykJ9bp?= =?us-ascii?Q?hVRTY1wwwwMVwuHztmzEBSGxVqoUQTxQMNy4u5g9vgWX4imNQnD+DFQPU5O5?= =?us-ascii?Q?+YXoUqNWcw1Gw6VzSfwGUbdNpZI/ZUgmKuGYOQkZh0WdKnPrCa/qP0GXrb0/?= =?us-ascii?Q?1K3CMbb8D/tExoEH1+n81sfPoBt/BBd49rLgoEAesMEfD+PkhsX6+wRUV9fm?= =?us-ascii?Q?NN4v/Nl36ixozKiPNszIJuFmr3y9IozyaynVARuUhMWDQjrGPFQ/fbDw7W/Z?= =?us-ascii?Q?JwC38Em/wsXFLG92U7uH6t3TfXN8MC9H1CpjONqwjH0H6bkWIyoGfM2wbQ3A?= =?us-ascii?Q?HGdTzkEV+DDqFnLjS4QlWxSdeuy9HEAbyQupWkOb8blUfVVuFlGJDPS0qbta?= =?us-ascii?Q?+l9/Pkxz0tGX4HsF4JbBITrX4SKfoAJOKI0RSeDyS33rfAvx02lfpbcPrr2x?= =?us-ascii?Q?+x4d6H0XS7gO1We9tXNBjtKj2YBfXe8Gt6g0zHZsIwUXRrQEK1s/IrSaNHcV?= =?us-ascii?Q?iZDZUj61QyL+ZGFuVbUIat5nrn/MCPO66Pr1QiyvAxUJ2VDoIYxxZYboPBBW?= =?us-ascii?Q?zLQgvuEE0LSxdNkefz+Zx7iyvF/k73FAr1sjuGxH1IRe3JulUHUU5LRFzRel?= =?us-ascii?Q?d0XMbKR8SMR8/8g6Kj0zeQnJ5u/IV//cYxBAxD9mOE+TGW/bkctfwtA5Wc9D?= =?us-ascii?Q?pdrppFCNBIkFsHyhpmJ8NkFnaz0X+CK52qlwaYnnNy+fpMq5HQHVSpBf2+0/?= =?us-ascii?Q?qy/nozxUk5fQ/fUIN77Z+v/5q3MfoTmrWmSXv3W0HiYBiZMWESGhcNaRZ4N2?= =?us-ascii?Q?aS+IkQee+A3iNPTdCmQTbKoTVRo1BNgdM7BJawkiZLuwljEHZk9lm1WhHebf?= =?us-ascii?Q?B9p8rP95ynIRzHNmbInQCaWgG3SKpRLjtm2dhxXsQQhgvilEOJ9bYdFX0ZLf?= =?us-ascii?Q?kXQ3dx/yONdYDCDsrAutGB5fpaGMXzUu?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:53:03.4060 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9ac7920-0a99-4550-4c66-08dcbacdb448 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F64.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8129 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=7978b75d1babcaae9b6c9633b6915dfaba2c6138 Thanks. Xueming Li --- >From 7978b75d1babcaae9b6c9633b6915dfaba2c6138 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Wed, 26 Jun 2024 15:33:40 +0530 Subject: [PATCH] test/crypto: validate modex from first non-zero Cc: Xueming Li [ upstream commit 2162d32c1c3b3495b6f0b053e6e9c61092b5704a ] At present, there is no specification of whether modex op output can carry leading zeroes without changing the value. OpenSSL strips leading zeroes, but other hardware need not be. Hence, when output is compared against expected result, validation could start from first non-zero. Fixes: 1ffefe00f184 ("test/crypto: add modexp and modinv functions") Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 2c745a7f7c..fec53f87db 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app/test/test_cryptodev_asym.c @@ -3200,6 +3200,27 @@ static int send_one(void) return TEST_SUCCESS; } +static int +modular_cmpeq(const uint8_t *a, const uint8_t *b, size_t len) +{ + const uint8_t *new_a = a, *new_b = b; + size_t i, j; + + /* Strip leading NUL bytes */ + for (i = 0; i < len; i++) + if (a[i] != 0) + new_a = &a[i]; + + for (j = 0; j < len; j++) + if (b[j] != 0) + new_b = &b[i]; + + if (i != j || memcmp(new_a, new_b, len - i)) + return 1; + + return 0; +} + static int modular_exponentiation(const void *test_data) { @@ -3234,9 +3255,9 @@ modular_exponentiation(const void *test_data) TEST_ASSERT_SUCCESS(send_one(), "Failed to process crypto op"); - TEST_ASSERT_BUFFERS_ARE_EQUAL(vector->reminder.data, + TEST_ASSERT_SUCCESS(modular_cmpeq(vector->reminder.data, self->result_op->asym->modex.result.data, - self->result_op->asym->modex.result.length, + self->result_op->asym->modex.result.length), "operation verification failed\n"); return TEST_SUCCESS; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:03.254848141 +0800 +++ 0020-test-crypto-validate-modex-from-first-non-zero.patch 2024-08-12 20:44:01.925069261 +0800 @@ -1 +1 @@ -From 2162d32c1c3b3495b6f0b053e6e9c61092b5704a Mon Sep 17 00:00:00 2001 +From 7978b75d1babcaae9b6c9633b6915dfaba2c6138 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 2162d32c1c3b3495b6f0b053e6e9c61092b5704a ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org